Re: RFR: 8336753: Don't run serviceability/sa/ClhsdbDumpheap.java with -Xcomp [v2]

2024-07-19 Thread Daniel Lundén
On Fri, 19 Jul 2024 10:42:00 GMT, Tobias Hartmann wrote: >> Can/should I include the bug number in some other way (perhaps directly in >> the comment)? I'm thinking if someone reads the comment in the future and >> would like more details. > > I don't think that's necessary, one can always

Re: RFR: 8336753: Don't run serviceability/sa/ClhsdbDumpheap.java with -Xcomp [v2]

2024-07-19 Thread Tobias Hartmann
On Fri, 19 Jul 2024 09:50:43 GMT, Daniel Lundén wrote: >> test/hotspot/jtreg/serviceability/sa/ClhsdbDumpheap.java line 40: >> >>> 38: /** >>> 39: * @test >>> 40: * @bug 8240989 8336753 >> >> I don't think that change makes sense because the test is not a regression >> test for JDK-8336753.

Re: RFR: 8336753: Don't run serviceability/sa/ClhsdbDumpheap.java with -Xcomp [v2]

2024-07-19 Thread Daniel Lundén
On Fri, 19 Jul 2024 09:45:19 GMT, Tobias Hartmann wrote: >> Daniel Lundén has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Add comment and bug number > > test/hotspot/jtreg/serviceability/sa/ClhsdbDumpheap.java line 40: > >> 38: /** >>

Re: RFR: 8336753: Don't run serviceability/sa/ClhsdbDumpheap.java with -Xcomp [v2]

2024-07-19 Thread Tobias Hartmann
On Fri, 19 Jul 2024 09:31:01 GMT, Daniel Lundén wrote: >> We are seeing quite a few timeouts for >> `serviceability/sa/ClhsdbDumpheap.java` running with -Xcomp in testing, >> possibly related to >> [JDK-8324241](https://bugs.openjdk.org/browse/JDK-8324241). We should >> disable running

Re: RFR: 8336753: Don't run serviceability/sa/ClhsdbDumpheap.java with -Xcomp [v2]

2024-07-19 Thread Daniel Lundén
> We are seeing quite a few timeouts for > `serviceability/sa/ClhsdbDumpheap.java` running with -Xcomp in testing, > possibly related to > [JDK-8324241](https://bugs.openjdk.org/browse/JDK-8324241). We should disable > running `ClhsdbDumpheap.java` with -Xcomp, at least for now. > > ###