Re: RFR: 8337031: Improvements to CompilationMemoryStatistic

2024-07-30 Thread Ashutosh Mehra
On Wed, 24 Jul 2024 10:45:05 GMT, Thomas Stuefe wrote: >> Some minor improvements to CompilationMemoryStatistic. More details are in >> [JDK-8337031](https://bugs.openjdk.org/browse/JDK-8337031) >> >> Testing: >> test/hotspot/jtreg/compiler/print/CompileCommandPrintMemStat.java >> >> test/

Re: RFR: 8337031: Improvements to CompilationMemoryStatistic [v3]

2024-07-30 Thread Vladimir Kozlov
On Tue, 30 Jul 2024 15:02:51 GMT, Ashutosh Mehra wrote: >> Some minor improvements to CompilationMemoryStatistic. More details are in >> [JDK-8337031](https://bugs.openjdk.org/browse/JDK-8337031) >> >> Testing: >> test/hotspot/jtreg/compiler/print/CompileCommandPrintMemStat.java >> >> test

Re: RFR: 8337031: Improvements to CompilationMemoryStatistic [v3]

2024-07-30 Thread Vladimir Kozlov
On Tue, 30 Jul 2024 15:02:51 GMT, Ashutosh Mehra wrote: >> Some minor improvements to CompilationMemoryStatistic. More details are in >> [JDK-8337031](https://bugs.openjdk.org/browse/JDK-8337031) >> >> Testing: >> test/hotspot/jtreg/compiler/print/CompileCommandPrintMemStat.java >> >> test

Re: RFR: 8337031: Improvements to CompilationMemoryStatistic

2024-07-30 Thread Ashutosh Mehra
On Wed, 24 Jul 2024 10:45:05 GMT, Thomas Stuefe wrote: >> Some minor improvements to CompilationMemoryStatistic. More details are in >> [JDK-8337031](https://bugs.openjdk.org/browse/JDK-8337031) >> >> Testing: >> test/hotspot/jtreg/compiler/print/CompileCommandPrintMemStat.java >> >> test/

Re: RFR: 8337031: Improvements to CompilationMemoryStatistic [v3]

2024-07-30 Thread Ashutosh Mehra
> Some minor improvements to CompilationMemoryStatistic. More details are in > [JDK-8337031](https://bugs.openjdk.org/browse/JDK-8337031) > > Testing: > test/hotspot/jtreg/compiler/print/CompileCommandPrintMemStat.java > > test/hotspot/jtreg/serviceability/dcmd/compiler/CompilerMemoryStatist

Re: RFR: 8337031: Improvements to CompilationMemoryStatistic [v2]

2024-07-30 Thread Ashutosh Mehra
On Tue, 30 Jul 2024 05:18:17 GMT, Thomas Stuefe wrote: >> Ashutosh Mehra has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Address review comments by Thomas S. >> >> Signed-off-by: Ashutosh Mehra > > src/hotspot/share/compiler/compil

Re: RFR: 8337031: Improvements to CompilationMemoryStatistic [v2]

2024-07-29 Thread Thomas Stuefe
On Mon, 29 Jul 2024 14:49:48 GMT, Ashutosh Mehra wrote: >> Some minor improvements to CompilationMemoryStatistic. More details are in >> [JDK-8337031](https://bugs.openjdk.org/browse/JDK-8337031) >> >> Testing: >> test/hotspot/jtreg/compiler/print/CompileCommandPrintMemStat.java >> >> test

Re: RFR: 8337031: Improvements to CompilationMemoryStatistic [v2]

2024-07-29 Thread Ashutosh Mehra
On Sat, 27 Jul 2024 05:44:14 GMT, Thomas Stuefe wrote: >> What do you mean by x macro? Do you have an example that shows the use of x >> macro? > > You use them already in your patch. > > E.g. > > > #define XX(name, whatever, desc) st->print_cr(" " LEGEND_KEY_FMT ": " #name > #desc > DO_AR

Re: RFR: 8337031: Improvements to CompilationMemoryStatistic

2024-07-29 Thread Ashutosh Mehra
On Wed, 24 Jul 2024 10:45:05 GMT, Thomas Stuefe wrote: >> Some minor improvements to CompilationMemoryStatistic. More details are in >> [JDK-8337031](https://bugs.openjdk.org/browse/JDK-8337031) >> >> Testing: >> test/hotspot/jtreg/compiler/print/CompileCommandPrintMemStat.java >> >> test/

Re: RFR: 8337031: Improvements to CompilationMemoryStatistic [v2]

2024-07-29 Thread Ashutosh Mehra
> Some minor improvements to CompilationMemoryStatistic. More details are in > [JDK-8337031](https://bugs.openjdk.org/browse/JDK-8337031) > > Testing: > test/hotspot/jtreg/compiler/print/CompileCommandPrintMemStat.java > > test/hotspot/jtreg/serviceability/dcmd/compiler/CompilerMemoryStatist

Re: RFR: 8337031: Improvements to CompilationMemoryStatistic

2024-07-26 Thread Thomas Stuefe
On Fri, 26 Jul 2024 18:21:05 GMT, Ashutosh Mehra wrote: >> src/hotspot/share/compiler/compilationMemoryStatistic.cpp line 242: >> >>> 240: for (int tag = 0; tag < Arena::tag_count(); tag++) { >>> 241: st->print_cr(" " LEGEND_KEY_FMT ": %s", Arena::tag_name[tag], >>> Arena::tag_desc[t

Re: RFR: 8337031: Improvements to CompilationMemoryStatistic

2024-07-26 Thread Thomas Stuefe
On Fri, 26 Jul 2024 18:18:45 GMT, Ashutosh Mehra wrote: >> src/hotspot/share/compiler/compilationMemoryStatistic.cpp line 204: >> >>> 202: size_t _total; >>> 203: // usage per arena tag when total peaked >>> 204: size_t _tags_size_at_peak[Arena::tag_count()]; >> >> Can you please make sur

Re: RFR: 8337031: Improvements to CompilationMemoryStatistic

2024-07-26 Thread Ashutosh Mehra
On Fri, 26 Jul 2024 06:08:03 GMT, Thomas Stuefe wrote: >> Some minor improvements to CompilationMemoryStatistic. More details are in >> [JDK-8337031](https://bugs.openjdk.org/browse/JDK-8337031) >> >> Testing: >> test/hotspot/jtreg/compiler/print/CompileCommandPrintMemStat.java >> >> test/

Re: RFR: 8337031: Improvements to CompilationMemoryStatistic

2024-07-25 Thread Thomas Stuefe
On Tue, 23 Jul 2024 21:46:50 GMT, Ashutosh Mehra wrote: > Some minor improvements to CompilationMemoryStatistic. More details are in > [JDK-8337031](https://bugs.openjdk.org/browse/JDK-8337031) > > Testing: > test/hotspot/jtreg/compiler/print/CompileCommandPrintMemStat.java > > test/hotspo

Re: RFR: 8337031: Improvements to CompilationMemoryStatistic

2024-07-24 Thread Thomas Stuefe
On Tue, 23 Jul 2024 21:46:50 GMT, Ashutosh Mehra wrote: > Some minor improvements to CompilationMemoryStatistic. More details are in > [JDK-8337031](https://bugs.openjdk.org/browse/JDK-8337031) > > Testing: > test/hotspot/jtreg/compiler/print/CompileCommandPrintMemStat.java > > test/hotspo

Re: RFR: 8337031: Improvements to CompilationMemoryStatistic

2024-07-23 Thread Ashutosh Mehra
On Tue, 23 Jul 2024 21:46:50 GMT, Ashutosh Mehra wrote: > Some minor improvements to CompilationMemoryStatistic. More details are in > [JDK-8337031](https://bugs.openjdk.org/browse/JDK-8337031) > > Testing: > test/hotspot/jtreg/compiler/print/CompileCommandPrintMemStat.java > > test/hotspo

RFR: 8337031: Improvements to CompilationMemoryStatistic

2024-07-23 Thread Ashutosh Mehra
Some minor improvements to CompilationMemoryStatistic. More details are in [JDK-8337031](https://bugs.openjdk.org/browse/JDK-8337031) Testing: test/hotspot/jtreg/compiler/print/CompileCommandPrintMemStat.java test/hotspot/jtreg/serviceability/dcmd/compiler/CompilerMemoryStatisticTest.java -