RFR: JDK-8317635: Improve GetClassFields test to verify correctness of field order

2023-10-10 Thread Alex Menkov
All test cases in getclfld007 had 1 (or 0) field in test classes/interfaces. The change adds several fields in one of the test classes to verify order of the returned fields (as described by GetClassFields spec). Additionally added "printdump" argument to the test agent to make the test more verb

Re: RFR: JDK-8317635: Improve GetClassFields test to verify correctness of field order

2023-10-11 Thread Chris Plummer
On Wed, 11 Oct 2023 00:39:23 GMT, Alex Menkov wrote: > All test cases in getclfld007 had 1 (or 0) field in test classes/interfaces. > The change adds several fields in one of the test classes to verify order of > the returned fields (as described by GetClassFields spec). > Additionally added "pr

Re: RFR: JDK-8317635: Improve GetClassFields test to verify correctness of field order

2023-10-12 Thread Alex Menkov
On Thu, 12 Oct 2023 01:37:01 GMT, Chris Plummer wrote: >> All test cases in getclfld007 had 1 (or 0) field in test classes/interfaces. >> The change adds several fields in one of the test classes to verify order of >> the returned fields (as described by GetClassFields spec). >> Additionally add

Re: RFR: JDK-8317635: Improve GetClassFields test to verify correctness of field order [v2]

2023-10-17 Thread Alex Menkov
> All test cases in getclfld007 had 1 (or 0) field in test classes/interfaces. > The change adds several fields in one of the test classes to verify order of > the returned fields (as described by GetClassFields spec). > Additionally added "printdump" argument to the test agent to make the test >

Re: RFR: JDK-8317635: Improve GetClassFields test to verify correctness of field order [v2]

2023-10-17 Thread Alex Menkov
On Thu, 12 Oct 2023 20:23:10 GMT, Alex Menkov wrote: >> test/hotspot/jtreg/vmTestbase/nsk/jvmti/GetClassFields/getclfld007/TestDescription.java >> line 36: >> >>> 34: * The test checks if the function returns the expected list of >>> fields: >>> 35: * - the list contains only dir

Re: RFR: JDK-8317635: Improve GetClassFields test to verify correctness of field order [v2]

2023-10-18 Thread Chris Plummer
On Wed, 18 Oct 2023 01:40:18 GMT, Alex Menkov wrote: >> All test cases in getclfld007 had 1 (or 0) field in test classes/interfaces. >> The change adds several fields in one of the test classes to verify order of >> the returned fields (as described by GetClassFields spec: "in the order they >>

Re: RFR: JDK-8317635: Improve GetClassFields test to verify correctness of field order [v2]

2023-10-18 Thread Serguei Spitsyn
On Wed, 18 Oct 2023 01:40:18 GMT, Alex Menkov wrote: >> All test cases in getclfld007 had 1 (or 0) field in test classes/interfaces. >> The change adds several fields in one of the test classes to verify order of >> the returned fields (as described by GetClassFields spec: "in the order they >>

Re: RFR: JDK-8317635: Improve GetClassFields test to verify correctness of field order [v2]

2023-10-18 Thread Serguei Spitsyn
On Wed, 18 Oct 2023 01:40:18 GMT, Alex Menkov wrote: >> All test cases in getclfld007 had 1 (or 0) field in test classes/interfaces. >> The change adds several fields in one of the test classes to verify order of >> the returned fields (as described by GetClassFields spec: "in the order they >>

Re: RFR: JDK-8317635: Improve GetClassFields test to verify correctness of field order [v2]

2023-10-18 Thread Serguei Spitsyn
On Wed, 18 Oct 2023 01:40:18 GMT, Alex Menkov wrote: >> All test cases in getclfld007 had 1 (or 0) field in test classes/interfaces. >> The change adds several fields in one of the test classes to verify order of >> the returned fields (as described by GetClassFields spec: "in the order they >>

Re: RFR: JDK-8317635: Improve GetClassFields test to verify correctness of field order [v2]

2023-10-18 Thread Serguei Spitsyn
On Wed, 18 Oct 2023 01:40:18 GMT, Alex Menkov wrote: >> All test cases in getclfld007 had 1 (or 0) field in test classes/interfaces. >> The change adds several fields in one of the test classes to verify order of >> the returned fields (as described by GetClassFields spec: "in the order they >>

Re: RFR: JDK-8317635: Improve GetClassFields test to verify correctness of field order [v3]

2023-10-18 Thread Alex Menkov
> All test cases in getclfld007 had 1 (or 0) field in test classes/interfaces. > The change adds several fields in one of the test classes to verify order of > the returned fields (as described by GetClassFields spec: "in the order they > occur in the class file"). > Field order in the class file

Re: RFR: JDK-8317635: Improve GetClassFields test to verify correctness of field order [v3]

2023-10-18 Thread Serguei Spitsyn
On Thu, 19 Oct 2023 02:19:35 GMT, Alex Menkov wrote: >> All test cases in getclfld007 had 1 (or 0) field in test classes/interfaces. >> The change adds several fields in one of the test classes to verify order of >> the returned fields (as described by GetClassFields spec: "in the order they >>