Re: RFR: JDK-8318636: Add jcmd to print annotated process memory map [v9]

2023-11-13 Thread Thomas Stuefe
On Thu, 9 Nov 2023 07:03:34 GMT, David Holmes wrote: >>> > As this adds a JCmd, doesn't this need both a CSR and a manual entry? >>> >>> * CSR: not sure; there are precedences for going with CSR and without >>> CSR. Since we get awfully close to JDK22 freeze, I would prefer for a CSR >>> n

Re: RFR: JDK-8318636: Add jcmd to print annotated process memory map [v9]

2023-11-09 Thread Thomas Stuefe
On Thu, 9 Nov 2023 07:03:34 GMT, David Holmes wrote: >>> > As this adds a JCmd, doesn't this need both a CSR and a manual entry? >>> >>> * CSR: not sure; there are precedences for going with CSR and without >>> CSR. Since we get awfully close to JDK22 freeze, I would prefer for a CSR >>> n

Re: RFR: JDK-8318636: Add jcmd to print annotated process memory map [v9]

2023-11-09 Thread Thomas Stuefe
On Thu, 9 Nov 2023 07:27:37 GMT, David Holmes wrote: >> Thomas Stuefe has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix another windows error > > src/hotspot/share/services/diagnosticCommand.cpp line 1193: > >> 1191: output()->pri

Re: RFR: JDK-8318636: Add jcmd to print annotated process memory map [v9]

2023-11-08 Thread David Holmes
On Thu, 9 Nov 2023 07:26:46 GMT, David Holmes wrote: >> Thomas Stuefe has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix another windows error > > src/hotspot/share/services/diagnosticCommand.cpp line 1159: > >> 1157: } >> 1158: >> 11

Re: RFR: JDK-8318636: Add jcmd to print annotated process memory map [v9]

2023-11-08 Thread David Holmes
On Thu, 2 Nov 2023 17:42:29 GMT, Thomas Stuefe wrote: >> Analysts and supporters often use /proc/xx/maps to make sense of the memory >> footprint of a process. >> >> Interpreting the memory map correctly can help when used as a complement to >> other tools (e.g. NMT). There even exist tools ou

Re: RFR: JDK-8318636: Add jcmd to print annotated process memory map [v9]

2023-11-08 Thread Thomas Stuefe
On Thu, 9 Nov 2023 07:03:34 GMT, David Holmes wrote: > > > > As this adds a JCmd, doesn't this need both a CSR and a manual entry? > > > > > > > > > ``` > > > * CSR: not sure; there are precedences for going with CSR and without > > > CSR. Since we get awfully close to JDK22 freeze, I would pr

Re: RFR: JDK-8318636: Add jcmd to print annotated process memory map [v9]

2023-11-08 Thread David Holmes
On Wed, 8 Nov 2023 11:40:35 GMT, Johan Sjölen wrote: > > > As this adds a JCmd, doesn't this need both a CSR and a manual entry? > > > > > > ``` > > * CSR: not sure; there are precedences for going with CSR and without CSR. > > Since we get awfully close to JDK22 freeze, I would prefer for a C

Re: RFR: JDK-8318636: Add jcmd to print annotated process memory map [v9]

2023-11-08 Thread Johan Sjölen
On Wed, 8 Nov 2023 11:24:43 GMT, Thomas Stuefe wrote: > > As this adds a JCmd, doesn't this need both a CSR and a manual entry? > > * CSR: not sure; there are precedences for going with CSR and without > CSR. Since we get awfully close to JDK22 freeze, I would prefer for a CSR not > to be

Re: RFR: JDK-8318636: Add jcmd to print annotated process memory map [v9]

2023-11-08 Thread Thomas Stuefe
On Wed, 8 Nov 2023 09:51:12 GMT, Johan Sjölen wrote: > As this adds a JCmd, doesn't this need both a CSR and a manual entry? - CSR: not sure; there are precedences for going with CSR and without CSR. Since we get awfully close to JDK22 freeze, I would prefer for a CSR not to be needed. Also wo

Re: RFR: JDK-8318636: Add jcmd to print annotated process memory map [v9]

2023-11-08 Thread Johan Sjölen
On Thu, 2 Nov 2023 17:42:29 GMT, Thomas Stuefe wrote: >> Analysts and supporters often use /proc/xx/maps to make sense of the memory >> footprint of a process. >> >> Interpreting the memory map correctly can help when used as a complement to >> other tools (e.g. NMT). There even exist tools ou

Re: RFR: JDK-8318636: Add jcmd to print annotated process memory map [v9]

2023-11-03 Thread Thomas Stuefe
On Thu, 2 Nov 2023 17:42:29 GMT, Thomas Stuefe wrote: >> Analysts and supporters often use /proc/xx/maps to make sense of the memory >> footprint of a process. >> >> Interpreting the memory map correctly can help when used as a complement to >> other tools (e.g. NMT). There even exist tools ou

Re: RFR: JDK-8318636: Add jcmd to print annotated process memory map [v9]

2023-11-02 Thread Thomas Stuefe
> Analysts and supporters often use /proc/xx/maps to make sense of the memory > footprint of a process. > > Interpreting the memory map correctly can help when used as a complement to > other tools (e.g. NMT). There even exist tools out there that attempt to > annotate the process memory map wi