On Wed, 28 Jun 2023 16:15:39 GMT, Ioi Lam wrote:
>> Coleen Phillimore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Use pointer_delta_as_int for the name that uses pointer_delta, fix
>> negative case to just do checked_cast.
>
> src/h
On Wed, 28 Jun 2023 13:17:21 GMT, Coleen Phillimore wrote:
>> This is another version of PR https://github.com/openjdk/jdk/pull/14659 but
>> I've added a pointer delta function in globalDefinitions.hpp to use for
>> these pointer diff calculations that return int everywhere. If the name is
>>
> This is another version of PR https://github.com/openjdk/jdk/pull/14659 but
> I've added a pointer delta function in globalDefinitions.hpp to use for these
> pointer diff calculations that return int everywhere. If the name is
> agreeable, I'll fix the other cases of this like this. It's bet
On Wed, 28 Jun 2023 13:17:21 GMT, Coleen Phillimore wrote:
>> This is another version of PR https://github.com/openjdk/jdk/pull/14659 but
>> I've added a pointer delta function in globalDefinitions.hpp to use for
>> these pointer diff calculations that return int everywhere. If the name is
>>
On Wed, 28 Jun 2023 13:17:21 GMT, Coleen Phillimore wrote:
>> This is another version of PR https://github.com/openjdk/jdk/pull/14659 but
>> I've added a pointer delta function in globalDefinitions.hpp to use for
>> these pointer diff calculations that return int everywhere. If the name is
>>
> This is another version of PR https://github.com/openjdk/jdk/pull/14659 but
> I've added a pointer delta function in globalDefinitions.hpp to use for these
> pointer diff calculations that return int everywhere. If the name is
> agreeable, I'll fix the other cases of this like this. It's bet
On Wed, 28 Jun 2023 07:52:35 GMT, Stefan Karlsson wrote:
>> Taking out that cast does work, so I've fixed that.
>
>> pointer_delta has different semantics
>
> Right. That was "recently" added to pointer_delta with JDK-8260046. It begs
> the question why felt the need to add it there but feel th
On Tue, 27 Jun 2023 15:11:34 GMT, Coleen Phillimore wrote:
>> Hm. Maybe this would be ok. Our original idea was to make it T* not T until
>> this cast. I don't know how many other cases there are that I haven't
>> gotten to yet. But it would eliminate a cast, so that's good (unless these
>>
On Tue, 27 Jun 2023 20:48:27 GMT, Coleen Phillimore wrote:
>> This is another version of PR https://github.com/openjdk/jdk/pull/14659 but
>> I've added a pointer delta function in globalDefinitions.hpp to use for
>> these pointer diff calculations that return int everywhere. If the name is
>>
> This is another version of PR https://github.com/openjdk/jdk/pull/14659 but
> I've added a pointer delta function in globalDefinitions.hpp to use for these
> pointer diff calculations that return int everywhere. If the name is
> agreeable, I'll fix the other cases of this like this. It's bet
On Tue, 27 Jun 2023 14:54:03 GMT, Coleen Phillimore wrote:
>> src/hotspot/share/code/codeBlob.inline.hpp line 36:
>>
>>> 34: inline const ImmutableOopMap* CodeBlob::oop_map_for_slot(int slot,
>>> address return_address) const {
>>> 35: assert(_oop_maps != nullptr, "nope");
>>> 36: return _o
> This is another version of PR https://github.com/openjdk/jdk/pull/14659 but
> I've added a pointer delta function in globalDefinitions.hpp to use for these
> pointer diff calculations that return int everywhere. If the name is
> agreeable, I'll fix the other cases of this like this. It's bet
On Tue, 27 Jun 2023 12:59:59 GMT, Stefan Karlsson wrote:
>> This is another version of PR https://github.com/openjdk/jdk/pull/14659 but
>> I've added a pointer delta function in globalDefinitions.hpp to use for
>> these pointer diff calculations that return int everywhere. If the name is
>> a
On Tue, 27 Jun 2023 12:41:50 GMT, Coleen Phillimore wrote:
> This is another version of PR https://github.com/openjdk/jdk/pull/14659 but
> I've added a pointer delta function in globalDefinitions.hpp to use for these
> pointer diff calculations that return int everywhere. If the name is
> agr
On Mon, 26 Jun 2023 17:47:25 GMT, Coleen Phillimore wrote:
> More casts for size of address differences in same code space,
> checked_casts<> and type changes to fix -Wconversion warnings. See CR for
> details.
> Tested with tier1-4.
After some offline conversation with Ioi, we thought of a b
On Mon, 26 Jun 2023 20:19:47 GMT, Frederic Parain wrote:
>> More casts for size of address differences in same code space,
>> checked_casts<> and type changes to fix -Wconversion warnings. See CR for
>> details.
>> Tested with tier1-4.
>
> src/hotspot/cpu/aarch64/continuationFreezeThaw_aarch64
On Mon, 26 Jun 2023 17:47:25 GMT, Coleen Phillimore wrote:
> More casts for size of address differences in same code space,
> checked_casts<> and type changes to fix -Wconversion warnings. See CR for
> details.
> Tested with tier1-4.
Changes requested by fparain (Reviewer).
src/hotspot/cpu/a
17 matches
Mail list logo
