Re: RFR: 8318682: SA decoding of scalar replaced objects is broken [v4]

2024-01-17 Thread Chris Plummer
On Tue, 16 Jan 2024 22:47:04 GMT, Chris Plummer wrote: >> Tom Rodriguez has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Update >> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/code/NMethod.java >> >>Co-authored-by:

Re: RFR: 8318682: SA decoding of scalar replaced objects is broken [v4]

2024-01-17 Thread Tom Rodriguez
On Tue, 16 Jan 2024 22:36:55 GMT, Chris Plummer wrote: >> Tom Rodriguez has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Update >> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/code/NMethod.java >> >>Co-authored-by:

Re: RFR: 8318682: SA decoding of scalar replaced objects is broken [v4]

2024-01-16 Thread Chris Plummer
On Mon, 15 Jan 2024 16:03:03 GMT, Tom Rodriguez wrote: >> The changes for JDK-8287061 didn't update the SA decoding logic and there >> are other places where the decoding has gotten out of sync with HotSpot. >> Some of them can't be tested because they are part of JVMCI but I've added a >>

Re: RFR: 8318682: SA decoding of scalar replaced objects is broken [v4]

2024-01-15 Thread Tom Rodriguez
> The changes for JDK-8287061 didn't update the SA decoding logic and there are > other places where the decoding has gotten out of sync with HotSpot. Some of > them can't be tested because they are part of JVMCI but I've added a directed > test for the JDK-8287061 code and a more brute force