Re: [sheepdog] [PATCH] sheep: use correct error code in rebae_vdi()

2014-02-05 Thread Hitoshi Mitake
At Mon, 3 Feb 2014 10:05:49 +0900, Hitoshi Mitake wrote: > > Signed-off-by: Hitoshi Mitake > --- > sheep/vdi.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) ping? Thanks, Hitoshi > > diff --git a/sheep/vdi.c b/sheep/vdi.c > index 3414b05..a50d3df 100644 > --- a/sheep/vdi.c > ++

Re: [sheepdog] [PATCH] util: remove unused functions

2014-02-05 Thread Hitoshi Mitake
At Thu, 6 Feb 2014 01:34:18 +0800, Liu Yuan wrote: > > If we need it future, we can bring them back on demand from git repo. No need > to keep it in the source file. > > Signed-off-by: Liu Yuan > --- > include/util.h | 4 --- > lib/util.c | 83 > --

Re: [sheepdog] [PATCH] sheep: fix vdi clone operation

2014-02-05 Thread Hitoshi Mitake
At Wed, 5 Feb 2014 21:17:28 +0800, Liu Yuan wrote: > > - pass correct array size > - return FULL_VDI instead of wrong NO_BASE_VDI > > Signed-off-by: Liu Yuan > --- > sheep/vdi.c | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) Looks good to me. Reviewed-by: Hitoshi Mitake

Re: [sheepdog] [PATCH] .gitignore: add dog/sheepdog script and backup files

2014-02-05 Thread Hitoshi Mitake
At Wed, 5 Feb 2014 19:36:58 +0900, Ryusuke Konishi wrote: > > Get rid of the following untracked files from the output of "git > status" command: > > $ git status > # On branch install > # Untracked files: > # (use "git add ..." to include in what will be committed) > # > # include

Re: [sheepdog] [PATCH stable-0.7] zookeeper: fix build failure in sheep/cluster/zookeeper.c

2014-02-05 Thread Hitoshi Mitake
At Tue, 4 Feb 2014 22:19:58 +0900, Ryusuke Konishi wrote: > > The commit 8b4a72f310f0e8a14d99187fc97066e1017759b3 "lib: rename > wrappers of pthread_rwlock" mistakenly inserted rb_destroy() in > zk_tree_destroy() function and broke build of zookeeper. > > This fixes the issue. > > Signed-off-by

[sheepdog] FYI: build error of lib/logger.c on CentOS6

2014-02-05 Thread Ryusuke Konishi
Hi Lists, Matsuo-san found compilation of the current master branch fails with the following error: Making all in lib make[1]: Entering directory `/home/ryusuke/git/sdds/download/sheepdog/lib' CC logger.o logger.c: In function 'gdb_cmd': logger.c:746: error: 'ARG_MAX' undeclared (first use

[sheepdog] [PATCH] util: remove unused functions

2014-02-05 Thread Liu Yuan
If we need it future, we can bring them back on demand from git repo. No need to keep it in the source file. Signed-off-by: Liu Yuan --- include/util.h | 4 --- lib/util.c | 83 -- 2 files changed, 87 deletions(-) diff --git a/include

[sheepdog] [PATCH] sheep: fix vdi clone operation

2014-02-05 Thread Liu Yuan
- pass correct array size - return FULL_VDI instead of wrong NO_BASE_VDI Signed-off-by: Liu Yuan --- sheep/vdi.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/sheep/vdi.c b/sheep/vdi.c index 080bc82..1ae31ca 100644 --- a/sheep/vdi.c +++ b/sheep/vdi.c @@ -315,9

[sheepdog] [PATCH] .gitignore: add dog/sheepdog script and backup files

2014-02-05 Thread Ryusuke Konishi
Get rid of the following untracked files from the output of "git status" command: $ git status # On branch install # Untracked files: # (use "git add ..." to include in what will be committed) # # include/config.h.in~ # script/dog # script/sheepdog Signed-off-by: Ryusu