Re: [sheepdog] [PATCH v3 0/2] block: deprecate the sheepdog driver

Am 02.10.2020 um 13:32 hat Daniel P. Berrangé geschrieben: > 2 years back I proposed dropping the sheepdog mailing list from the > MAINTAINERS file, but somehow the patch never got picked up: > > https://lists.gnu.org/archive/html/qemu-block/2018-03/msg01048.html > > So here I am with the

Re: [sheepdog] [PATCH v1 1/1] sheepdog driver patch: fixs the problem of qemu process become crashed when the sheepdog gateway break the IO and then recover

Am 01.10.2020 um 04:21 hat mingwei geschrieben: > this patch fixs the problem of qemu process become crashed when the sheepdog > gateway break the IO for a few seconds and then recover. > > problem reproduce: > 1.start a fio process in qemu to produce IOs to sheepdog gateway, whatever IO > type

Re: [sheepdog] [PATCH] block/sheepdog: Replace magic val by NANOSECONDS_PER_SECOND definition

Am 21.09.2020 um 13:01 hat Philippe Mathieu-Daudé geschrieben: > Use self-explicit NANOSECONDS_PER_SECOND definition instead > of magic value. > > Signed-off-by: Philippe Mathieu-Daudé Thanks, applied to the block branch. Kevin -- sheepdog mailing list sheepdog@lists.wpkg.org

Re: [sheepdog] [PATCH 2/2] block: trickle down the fallback image creation function use to the block drivers

Am 26.03.2020 um 14:20 hat Eric Blake geschrieben: > > +++ b/block/file-posix.c > > @@ -3513,6 +3513,8 @@ static BlockDriver bdrv_host_device = { > > .bdrv_reopen_prepare = raw_reopen_prepare, > > .bdrv_reopen_commit = raw_reopen_commit, > > .bdrv_reopen_abort =

Re: [sheepdog] [PATCH v3 1/4] block: Add trivial backing_fmt support to qcow, sheepdog, vmdk

Am 09.03.2020 um 16:44 hat Daniel P. Berrangé geschrieben: > We could support "-F ..." and validate any non-raw formats, while raising a > runtime error in the case of "-F raw", as only the "raw" backing format has > the probing security risk. > > Users who need to use qcow, with a backing file,

Re: [sheepdog] [PATCH v3 1/4] block: Add trivial backing_fmt support to qcow, sheepdog, vmdk

Am 09.03.2020 um 16:32 hat Eric Blake geschrieben: > On 3/9/20 10:21 AM, Kevin Wolf wrote: > > Am 06.03.2020 um 23:51 hat Eric Blake geschrieben: > > > For qcow2 and qed, we want to encourage the use of -F always, as these > > > formats can suffer from data corruption o

Re: [sheepdog] [PATCH v3 1/4] block: Add trivial backing_fmt support to qcow, sheepdog, vmdk

Am 06.03.2020 um 23:51 hat Eric Blake geschrieben: > For qcow2 and qed, we want to encourage the use of -F always, as these > formats can suffer from data corruption or security holes if backing > format is probed. But for other formats, the backing format cannot be > recorded. Making the user

Re: [sheepdog] [RFC v5 000/126] error: auto propagated local_err

Am 20.11.2019 um 13:59 hat Eric Blake geschrieben: > On 11/20/19 3:50 AM, Vladimir Sementsov-Ogievskiy wrote: > > Okay... > > > > I think that: > > > > 1. A lot of efforts (not only my, I think reviewing is already exceeded > > generation efforts) > > are made, it would be sad to lose them.

Re: [sheepdog] [PATCH] sheepdog: Remove unnecessary NULL check in sd_prealloc()

Am 18.05.2018 um 20:17 hat Peter Maydell geschrieben: > In commit 8b9ad56e9cbfd852a, we removed the code that could result > in our getting to sd_prealloc()'s out_with_err_set label with a > NULL blk pointer. That makes the NULL check in the error-handling > path unnecessary, and Coverity gripes

Re: [sheepdog] [PATCH 0/7] block: Preallocated truncation for gluster and sheepdog

Am 13.02.2018 um 14:03 hat Max Reitz geschrieben: > As far as I can see, these are the only protocols beside file-posix that > support preallocated creation. In contrast to file-posix, however, they > have not supported preallocated truncation so far. This series brings > their truncation code

Re: [sheepdog] [Qemu-devel] [PATCH] sheepdog: Set error when connection fails

Am 20.04.2017 um 17:30 hat Daniel P. Berrange geschrieben: > On Thu, Apr 20, 2017 at 12:00:03PM +0800, Fam Zheng wrote: > > Signed-off-by: Fam Zheng > > --- > > block/sheepdog.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/block/sheepdog.c b/block/sheepdog.c >

Re: [sheepdog] [Qemu-devel] internal snapshots with sheepdog

Am 18.09.2015 um 11:03 hat Vasiliy Tolstov geschrieben: > 2015-09-18 12:02 GMT+03:00 Kevin Wolf <kw...@redhat.com>: > > Doesn't sheepdog already support storing snapshots in the same image? > > I thought it would just work; at least, there's some code there for it. > >

Re: [sheepdog] [PATCH] sheepdog: Fix misleading error messages in sd_snapshot_create()

Am 12.02.2015 um 14:49 hat Markus Armbruster geschrieben: If do_sd_create() fails, it first reports the error returned, then reports a another one with strerror(errno). errno is meaningless at that point. Report just one error combining the valid information from both messages.

Re: [sheepdog] [PATCH v5] sheepdog: selectable object size support

Am 15.02.2015 um 15:17 hat Hitoshi Mitake geschrieben: At Fri, 13 Feb 2015 18:20:53 +0900, Teruaki Ishizaki wrote: Previously, qemu block driver of sheepdog used hard-coded VDI object size. This patch enables users to handle VDI object size. When you start qemu, you don't need to

Re: [sheepdog] [Qemu-devel] [PATCH] sheepdog: fix confused return values

Am 13.02.2015 um 04:45 hat Liu Yuan geschrieben: From: Liu Yuan liuy...@cmss.chinamobile.com These functions mix up -1 and -errno in return values and would might cause trouble error handling in the call chain. This patch let them return -errno and add some comments. Reported-by: Markus

Re: [sheepdog] [PATCH v3] sheepdog: selectable object size support

Am 26.01.2015 um 10:52 hat Teruaki Ishizaki geschrieben: Hi, Kevin Thanks for your review! (2015/01/23 22:53), Kevin Wolf wrote: Am 23.01.2015 um 09:24 hat Teruaki Ishizaki geschrieben: Previously, qemu block driver of sheepdog used hard-coded VDI object size. This patch enables users

Re: [sheepdog] [PATCH v3] sheepdog: selectable object size support

Am 23.01.2015 um 09:24 hat Teruaki Ishizaki geschrieben: Previously, qemu block driver of sheepdog used hard-coded VDI object size. This patch enables users to handle block_size_shift value for calculating VDI object size. When you start qemu, you don't need to specify additional command

Re: [sheepdog] [PATCH] sheepdog: check if '-o redundancy' is passed from user

Am 08.12.2013 um 17:11 hat Liu Yuan geschrieben: This fix a segfault (that is caused by b3af018f3) of following command: $ qemu-img convert some_img sheepdog:some_img Cc: qemu-de...@nongnu.org Cc: Kevin Wolf kw...@redhat.com Cc: Stefan Hajnoczi stefa...@redhat.com Signed-off-by: Liu Yuan

Re: [sheepdog] [PATCH v2 0/2] sheepdog: make use of copy_policy

Am 25.10.2013 um 20:03 hat MORITA Kazutaka geschrieben: At Wed, 23 Oct 2013 16:51:50 +0800, Liu Yuan wrote: v2: - merge the reserved bits This patch set makes use of copy_policy in struct SheepdogInode in order to support recently introduced erasure coding volume in sheepdog.

Re: [sheepdog] [Qemu-devel] [PATCH v5] sheepdog: add discard/trim support for sheepdog

Am 16.04.2013 um 10:18 hat Stefan Hajnoczi geschrieben: On Tue, Apr 16, 2013 at 12:15:04AM +0800, Liu Yuan wrote: @@ -727,6 +730,20 @@ static void coroutine_fn aio_read_response(void *opaque) rsp.result = SD_RES_SUCCESS; } break; +case

Re: [sheepdog] [Qemu-devel] [PATCH v4] sheepdog: do not blindly memset all read buffers

Am 10.07.2012 20:06, schrieb MORITA Kazutaka: At Tue, 10 Jul 2012 16:12:27 +0200, Christoph Hellwig wrote: Only buffers that map to unallocated blocks need to be zeroed. Signed-off-by: Christoph Hellwig h...@lst.de --- block/sheepdog.c | 37 ++--- 1

Re: [Sheepdog] [Qemu-devel] [PATCH] sheepdog: use coroutines

Am 23.08.2011 19:14, schrieb MORITA Kazutaka: At Tue, 23 Aug 2011 14:29:50 +0200, Kevin Wolf wrote: Am 12.08.2011 14:33, schrieb MORITA Kazutaka: This makes the sheepdog block driver support bdrv_co_readv/writev instead of bdrv_aio_readv/writev. With this patch, Sheepdog network I/O

Re: [Sheepdog] [Qemu-devel] [PATCH] sheepdog: use coroutines

Am 12.08.2011 14:33, schrieb MORITA Kazutaka: This makes the sheepdog block driver support bdrv_co_readv/writev instead of bdrv_aio_readv/writev. With this patch, Sheepdog network I/O becomes fully asynchronous. The block driver yields back when send/recv returns EAGAIN, and is resumed

Re: [Sheepdog] [Qemu-devel] [PATCH] sheepdog: add data preallocation support

Am 05.07.2011 20:21, schrieb MORITA Kazutaka: + +max_idx = (vdi_size + SD_DATA_OBJ_SIZE - 1) / SD_DATA_OBJ_SIZE; + +for (idx = 0; idx max_idx; idx++) { +uint64_t oid; +oid = vid_to_data_oid(vid, idx); + +if (inode-data_vdi_id[idx]) { +ret =

Re: [Sheepdog] [PATCH] sheepdog: add data preallocation support

Am 21.05.2011 14:35, schrieb MORITA Kazutaka: This introduces a qemu-img create option for sheepdog which allows the data to be preallocated (note that sheepdog always preallocates metadata). This is necessary to use Sheepdog volumes as a backend storage for iSCSI target. More information is

Re: [Sheepdog] [Qemu-devel] [RFC PATCH 0/2] Sheepdog: distributed storage system for QEMU

Am 14.05.2010 11:54, schrieb MORITA Kazutaka: There is another problem to make the sheepdog driver be a protocol; how to deal with protocol specific create_options? For example, sheepdog supports cloning images as a format driver: $ qemu-img create -f sheepdog dst -b sheepdog:src But if

Re: [Sheepdog] [RFC PATCH v2 2/3] block: call the snapshot handlers of the protocol drivers

Am 14.05.2010 11:51, schrieb MORITA Kazutaka: When snapshot handlers of the format driver is not defined, it is better to call the ones of the protocol driver. This enables us to implement snapshot support in the protocol driver. Signed-off-by: MORITA Kazutaka morita.kazut...@lab.ntt.co.jp