[sheepdog] FYI: build error of lib/logger.c on CentOS6

__undef_ARG_MAX # undef ARG_MAX # undef __undef_ARG_MAX #endif Regards, Ryusuke Konishi -- sheepdog mailing list sheepdog@lists.wpkg.org http://lists.wpkg.org/mailman/listinfo/sheepdog

[sheepdog] [PATCH stable-0.7] zookeeper: fix build failure in sheep/cluster/zookeeper.c

The commit 8b4a72f310f0e8a14d99187fc97066e1017759b3 lib: rename wrappers of pthread_rwlock mistakenly inserted rb_destroy() in zk_tree_destroy() function and broke build of zookeeper. This fixes the issue. Signed-off-by: Ryusuke Konishi konishi.ryus...@lab.ntt.co.jp Cc: Hitoshi Mitake

[sheepdog] [PATCH] bs_sheepdog.c: fix io errors during writing to a snapshot

() with a pthread reader/writer lock, and also fixes the race condition between create_branch() and sd_io() with the lock. Signed-off-by: Ryusuke Konishi konishi.ryus...@lab.ntt.co.jp Cc: Hitoshi Mitake mitake.hito...@lab.ntt.co.jp --- usr/bs_sheepdog.c | 22 +- 1 file changed

[sheepdog] [PATCH] bs_sheepdog.c: add missing initialization of request header

The create_branch function of the sheepdog driver sends a partially uninitialized request to sheepdog. This fixes the defect. Signed-off-by: Ryusuke Konishi konishi.ryus...@lab.ntt.co.jp Cc: Hitoshi Mitake mitake.hito...@lab.ntt.co.jp --- usr/bs_sheepdog.c |1 + 1 file changed, 1 insertion

[sheepdog] [PATCH] bs_sheepdog.c: add missing initialization of read data length

) ==1885==by 0x412776: mtask_handler (mgmt.c:494) ==1885==by 0x4106A8: event_loop (tgtd.c:411) ==1885==by 0x410D64: main (tgtd.c:583) Signed-off-by: Ryusuke Konishi konishi.ryus...@lab.ntt.co.jp Cc: Hitoshi Mitake mitake.hito...@lab.ntt.co.jp --- usr/bs_sheepdog.c |6 -- 1

[sheepdog] [PATCH] sheep: fix memory leak at create_client()

The current create_client function does not free client_info structure when getpeername() failed. This fixes the leak bug. Signed-off-by: Ryusuke Konishi konishi.ryus...@lab.ntt.co.jp --- sheep/request.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/sheep/request.c b

[sheepdog] [PATCH] sheep: fix memory leaks at start_deletion()

The start_deletion function does not free the deletion_work structure nor the buffer (dw-buf) that it locally allocated when it deletes inode of the VDI or dw-count was equal to zero. This fixes these leak bugs. Signed-off-by: Ryusuke Konishi konishi.ryus...@lab.ntt.co.jp --- sheep/vdi.c | 10

[sheepdog] [PATCH] bs_sheepdog.c: fix a descriptor leak in connect_to_sdog_tcp()

When connect_to_sdoc_tcp function failed to connect a socket due to an error other than EINTR, it doesn't free the socket file descriptor. This fixes the leak bug. Signed-off-by: Ryusuke Konishi konishi.ryus...@lab.ntt.co.jp --- usr/bs_sheepdog.c |1 + 1 file changed, 1 insertion(+) diff

Re: [sheepdog] [PATCH] sheep: add an option for selecting the output directory of sheep.log

branch. So, How about separating this change to two patches? - The first patch simply adds log directory option, and then backport it for stable users. - The second patch refactors the log option as above for future releases. Regards, Ryusuke Konishi -- sheepdog mailing list sheepdog

[sheepdog] [PATCH] bs_sheepdog.c: ensure that vdi names and tag names are null-terminated

of a null byte causes potential buffer overrun issue with the sheep daemon even though we are trying to fix this sort of dangerous implementation. This patch ensures that tag names and vdi names set to the request buffer are both null terminated and fixes these issues. Signed-off-by: Ryusuke

[sheepdog] [PATCH] sheep: fix improper strncmp usage in fill_vdi_info_range()

the size argument strlen(inode-name) with sizeof(inode-name). Signed-off-by: Ryusuke Konishi konishi.ryus...@lab.ntt.co.jp --- sheep/vdi.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sheep/vdi.c b/sheep/vdi.c index 60bc52d..c8751ed 100644 --- a/sheep/vdi.c +++ b/sheep

[sheepdog] Question on the string format of vdiname and tag in LOCK_VDI/GET_VDI_INFO

+ SD_MAX_VDI_TAG_LEN]; memset(buf, 0, sizeof(buf)); strncpy(buf, filename, SD_MAX_VDI_LEN); strncpy(buf + SD_MAX_VDI_LEN, tag, SD_MAX_VDI_TAG_LEN); Is there any guideline for this sort of string data for sheepdog ? Regards, Ryusuke Konishi -- sheepdog mailing list sheepdog

[sheepdog] [PATCH] bs_sheepdog.c: fix memory leak issues in sd_open()

restores filename argument temporarily broken for parsing VDI options when unknown protocol was specified or tcp port number was malformed. Signed-off-by: Ryusuke Konishi konishi.ryus...@lab.ntt.co.jp --- usr/bs_sheepdog.c |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git

[sheepdog] [PATCH] bs_sheepdog.c: fix pthread rwlock leak in sd_io()

The current sd_io function exits without unlocking pthread rwlock in the error path. This fixes the leak bug. Signed-off-by: Ryusuke Konishi konishi.ryus...@lab.ntt.co.jp --- usr/bs_sheepdog.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/usr/bs_sheepdog.c b/usr

[sheepdog] [PATCH] dog: fix return value of vdi_backup()

of the normal path of vdi_backup(). Signed-off-by: Ryusuke Konishi konishi.ryus...@lab.ntt.co.jp --- dog/vdi.c |1 + 1 file changed, 1 insertion(+) diff --git a/dog/vdi.c b/dog/vdi.c index d829077..d9a9a0f 100644 --- a/dog/vdi.c +++ b/dog/vdi.c @@ -1878,6 +1878,7 @@ static int vdi_backup(int argc, char