From: levin li
Signed-off-by: levin li
---
sheep/recovery.c |1 -
1 file changed, 1 deletion(-)
diff --git a/sheep/recovery.c b/sheep/recovery.c
index 59ac9d6..0033c6b 100644
--- a/sheep/recovery.c
+++ b/sheep/recovery.c
@@ -346,7 +346,6 @@ static void notify_recovery_completion_work(stru
On 08/28/2012 04:14 PM, levin li wrote:
> - hdr.flags = SD_FLAG_CMD_WRITE;
> hdr.data_length = sizeof(sys->this_node);
Why not? We do write &sys->this_node as data to transfer.
Thanks,
Yuan
--
sheepdog mailing list
sheepdog@lists.wpkg.org
http://lists.wpkg.org/mailman/listinfo/sheepdog
On 08/28/2012 04:38 PM, Liu Yuan wrote:
> On 08/28/2012 04:14 PM, levin li wrote:
>> -hdr.flags = SD_FLAG_CMD_WRITE;
>> hdr.data_length = sizeof(sys->this_node);
>
> Why not? We do write &sys->this_node as data to transfer.
>
> Thanks,
> Yuan
>
For cluster requests we send data through
On 08/28/2012 04:14 PM, levin li wrote:
> From: levin li
>
>
> Signed-off-by: levin li
> ---
> sheep/recovery.c |1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/sheep/recovery.c b/sheep/recovery.c
> index 59ac9d6..0033c6b 100644
> --- a/sheep/recovery.c
> +++ b/sheep/recovery.c
> @@
At Tue, 28 Aug 2012 16:43:50 +0800,
levin li wrote:
>
> On 08/28/2012 04:38 PM, Liu Yuan wrote:
> > On 08/28/2012 04:14 PM, levin li wrote:
> >> - hdr.flags = SD_FLAG_CMD_WRITE;
> >>hdr.data_length = sizeof(sys->this_node);
> >
> > Why not? We do write &sys->this_node as data to transfer.
>
On 08/28/2012 05:41 PM, MORITA Kazutaka wrote:
> At Tue, 28 Aug 2012 16:43:50 +0800,
> levin li wrote:
>>
>> On 08/28/2012 04:38 PM, Liu Yuan wrote:
>>> On 08/28/2012 04:14 PM, levin li wrote:
- hdr.flags = SD_FLAG_CMD_WRITE;
hdr.data_length = sizeof(sys->this_node);
>>>
>>> Why not?
On 08/28/2012 05:41 PM, MORITA Kazutaka wrote:
> At Tue, 28 Aug 2012 16:43:50 +0800,
> levin li wrote:
>>
>> On 08/28/2012 04:38 PM, Liu Yuan wrote:
>>> On 08/28/2012 04:14 PM, levin li wrote:
- hdr.flags = SD_FLAG_CMD_WRITE;
hdr.data_length = sizeof(sys->this_node);
>>>
>>> Why not?
At Tue, 28 Aug 2012 18:35:46 +0800,
Liu Yuan wrote:
>
> On 08/28/2012 05:41 PM, MORITA Kazutaka wrote:
> > At Tue, 28 Aug 2012 16:43:50 +0800,
> > levin li wrote:
> >>
> >> On 08/28/2012 04:38 PM, Liu Yuan wrote:
> >>> On 08/28/2012 04:14 PM, levin li wrote:
> -hdr.flags = SD_FLAG_CMD
On 08/28/2012 07:56 PM, MORITA Kazutaka wrote:
> When sheep receives a requests without SD_FLAG_CMD_WRITE, begin_rx()
> doesn't set req->data, so in such case prepare_cluster_msg() shouldn't
> set the invalid data to msg->data, no? I believe multicasting invalid
> data makes it difficult for us to
At Tue, 28 Aug 2012 20:53:59 +0800,
Liu Yuan wrote:
>
> On 08/28/2012 07:56 PM, MORITA Kazutaka wrote:
> > When sheep receives a requests without SD_FLAG_CMD_WRITE, begin_rx()
> > doesn't set req->data, so in such case prepare_cluster_msg() shouldn't
> > set the invalid data to msg->data, no? I b
On 08/28/2012 10:02 PM, MORITA Kazutaka wrote:
> sing SD_FLAG_DATA_IN/OUT is also okay to me, but it's also different
> issue from this patch. The problem of this patch is using a different
> rule against local requests, and it is confusing. At least with the
> current design, we should add SD_FL
11 matches
Mail list logo
