Re: [sheepdog] [PATCH v2] sheep/recovery: multi-threading recovery process

2014-02-03 Thread MORITA Kazutaka
At Tue, 28 Jan 2014 18:01:42 +0800, Liu Yuan wrote: > > @@ -861,6 +885,7 @@ static void recover_object_main(struct work *work) > > finish_recovery(rinfo); > out: > + rinfo->running_threads_nr--; > free_recovery_obj_work(row); > } This can cause a segfault because rinfo may be

Re: [sheepdog] [PATCH v2] sheep/recovery: multi-threading recovery process

2014-01-30 Thread Hitoshi Mitake
At Thu, 30 Jan 2014 13:51:02 +0800, Liu Yuan wrote: > > On Thu, Jan 30, 2014 at 02:42:56PM +0900, Hitoshi Mitake wrote: > > At Thu, 30 Jan 2014 10:44:06 +0800, > > Liu Yuan wrote: > > > > > > On Thu, Jan 30, 2014 at 11:33:27AM +0900, Hitoshi Mitake wrote: > > > > At Thu, 30 Jan 2014 10:17:16 +080

Re: [sheepdog] [PATCH v2] sheep/recovery: multi-threading recovery process

2014-01-29 Thread Liu Yuan
On Thu, Jan 30, 2014 at 02:42:56PM +0900, Hitoshi Mitake wrote: > At Thu, 30 Jan 2014 10:44:06 +0800, > Liu Yuan wrote: > > > > On Thu, Jan 30, 2014 at 11:33:27AM +0900, Hitoshi Mitake wrote: > > > At Thu, 30 Jan 2014 10:17:16 +0800, > > > Liu Yuan wrote: > > > > > > > > On Wed, Jan 29, 2014 at 0

Re: [sheepdog] [PATCH v2] sheep/recovery: multi-threading recovery process

2014-01-29 Thread Hitoshi Mitake
At Thu, 30 Jan 2014 10:44:06 +0800, Liu Yuan wrote: > > On Thu, Jan 30, 2014 at 11:33:27AM +0900, Hitoshi Mitake wrote: > > At Thu, 30 Jan 2014 10:17:16 +0800, > > Liu Yuan wrote: > > > > > > On Wed, Jan 29, 2014 at 05:19:09PM +0900, Hitoshi Mitake wrote: > > > > At Wed, 29 Jan 2014 16:14:56 +080

Re: [sheepdog] [PATCH v2] sheep/recovery: multi-threading recovery process

2014-01-29 Thread Liu Yuan
On Thu, Jan 30, 2014 at 11:33:27AM +0900, Hitoshi Mitake wrote: > At Thu, 30 Jan 2014 10:17:16 +0800, > Liu Yuan wrote: > > > > On Wed, Jan 29, 2014 at 05:19:09PM +0900, Hitoshi Mitake wrote: > > > At Wed, 29 Jan 2014 16:14:56 +0800, > > > Liu Yuan wrote: > > > > > > > > On Wed, Jan 29, 2014 at 0

Re: [sheepdog] [PATCH v2] sheep/recovery: multi-threading recovery process

2014-01-29 Thread Liu Yuan
On Thu, Jan 30, 2014 at 11:33:27AM +0900, Hitoshi Mitake wrote: > At Thu, 30 Jan 2014 10:17:16 +0800, > Liu Yuan wrote: > > > > On Wed, Jan 29, 2014 at 05:19:09PM +0900, Hitoshi Mitake wrote: > > > At Wed, 29 Jan 2014 16:14:56 +0800, > > > Liu Yuan wrote: > > > > > > > > On Wed, Jan 29, 2014 at 0

Re: [sheepdog] [PATCH v2] sheep/recovery: multi-threading recovery process

2014-01-29 Thread Hitoshi Mitake
At Thu, 30 Jan 2014 10:17:16 +0800, Liu Yuan wrote: > > On Wed, Jan 29, 2014 at 05:19:09PM +0900, Hitoshi Mitake wrote: > > At Wed, 29 Jan 2014 16:14:56 +0800, > > Liu Yuan wrote: > > > > > > On Wed, Jan 29, 2014 at 05:01:52PM +0900, Hitoshi Mitake wrote: > > > > At Wed, 29 Jan 2014 15:53:57 +080

Re: [sheepdog] [PATCH v2] sheep/recovery: multi-threading recovery process

2014-01-29 Thread Liu Yuan
On Wed, Jan 29, 2014 at 05:19:09PM +0900, Hitoshi Mitake wrote: > At Wed, 29 Jan 2014 16:14:56 +0800, > Liu Yuan wrote: > > > > On Wed, Jan 29, 2014 at 05:01:52PM +0900, Hitoshi Mitake wrote: > > > At Wed, 29 Jan 2014 15:53:57 +0800, > > > Liu Yuan wrote: > > > > > > > > On Wed, Jan 29, 2014 at 0

Re: [sheepdog] [PATCH v2] sheep/recovery: multi-threading recovery process

2014-01-29 Thread Liu Yuan
On Thu, Jan 30, 2014 at 10:11:43AM +0900, Hitoshi Mitake wrote: > At Thu, 30 Jan 2014 02:53:27 +0800, > Liu Yuan wrote: > > > > On Wed, Jan 29, 2014 at 06:04:15PM +0900, Hitoshi Mitake wrote: > > > At Wed, 29 Jan 2014 17:38:34 +0900, > > > Hitoshi Mitake wrote: > > > > > > > > At Wed, 29 Jan 2014

Re: [sheepdog] [PATCH v2] sheep/recovery: multi-threading recovery process

2014-01-29 Thread Hitoshi Mitake
At Thu, 30 Jan 2014 02:53:27 +0800, Liu Yuan wrote: > > On Wed, Jan 29, 2014 at 06:04:15PM +0900, Hitoshi Mitake wrote: > > At Wed, 29 Jan 2014 17:38:34 +0900, > > Hitoshi Mitake wrote: > > > > > > At Wed, 29 Jan 2014 16:29:03 +0800, > > > Liu Yuan wrote: > > > > > > > > On Wed, Jan 29, 2014 at

Re: [sheepdog] [PATCH v2] sheep/recovery: multi-threading recovery process

2014-01-29 Thread Liu Yuan
On Wed, Jan 29, 2014 at 06:04:15PM +0900, Hitoshi Mitake wrote: > At Wed, 29 Jan 2014 17:38:34 +0900, > Hitoshi Mitake wrote: > > > > At Wed, 29 Jan 2014 16:29:03 +0800, > > Liu Yuan wrote: > > > > > > On Wed, Jan 29, 2014 at 05:19:09PM +0900, Hitoshi Mitake wrote: > > > > At Wed, 29 Jan 2014 16:

Re: [sheepdog] [PATCH v2] sheep/recovery: multi-threading recovery process

2014-01-29 Thread Liu Yuan
On Wed, Jan 29, 2014 at 05:38:34PM +0900, Hitoshi Mitake wrote: > At Wed, 29 Jan 2014 16:29:03 +0800, > Liu Yuan wrote: > > > > On Wed, Jan 29, 2014 at 05:19:09PM +0900, Hitoshi Mitake wrote: > > > At Wed, 29 Jan 2014 16:14:56 +0800, > > > Liu Yuan wrote: > > > > > > > > On Wed, Jan 29, 2014 at 0

Re: [sheepdog] [PATCH v2] sheep/recovery: multi-threading recovery process

2014-01-29 Thread Hitoshi Mitake
At Wed, 29 Jan 2014 17:38:34 +0900, Hitoshi Mitake wrote: > > At Wed, 29 Jan 2014 16:29:03 +0800, > Liu Yuan wrote: > > > > On Wed, Jan 29, 2014 at 05:19:09PM +0900, Hitoshi Mitake wrote: > > > At Wed, 29 Jan 2014 16:14:56 +0800, > > > Liu Yuan wrote: > > > > > > > > On Wed, Jan 29, 2014 at 05:0

Re: [sheepdog] [PATCH v2] sheep/recovery: multi-threading recovery process

2014-01-29 Thread Hitoshi Mitake
At Wed, 29 Jan 2014 16:29:03 +0800, Liu Yuan wrote: > > On Wed, Jan 29, 2014 at 05:19:09PM +0900, Hitoshi Mitake wrote: > > At Wed, 29 Jan 2014 16:14:56 +0800, > > Liu Yuan wrote: > > > > > > On Wed, Jan 29, 2014 at 05:01:52PM +0900, Hitoshi Mitake wrote: > > > > At Wed, 29 Jan 2014 15:53:57 +080

Re: [sheepdog] [PATCH v2] sheep/recovery: multi-threading recovery process

2014-01-29 Thread Liu Yuan
On Wed, Jan 29, 2014 at 05:19:09PM +0900, Hitoshi Mitake wrote: > At Wed, 29 Jan 2014 16:14:56 +0800, > Liu Yuan wrote: > > > > On Wed, Jan 29, 2014 at 05:01:52PM +0900, Hitoshi Mitake wrote: > > > At Wed, 29 Jan 2014 15:53:57 +0800, > > > Liu Yuan wrote: > > > > > > > > On Wed, Jan 29, 2014 at 0

Re: [sheepdog] [PATCH v2] sheep/recovery: multi-threading recovery process

2014-01-29 Thread Hitoshi Mitake
At Wed, 29 Jan 2014 16:14:56 +0800, Liu Yuan wrote: > > On Wed, Jan 29, 2014 at 05:01:52PM +0900, Hitoshi Mitake wrote: > > At Wed, 29 Jan 2014 15:53:57 +0800, > > Liu Yuan wrote: > > > > > > On Wed, Jan 29, 2014 at 03:32:34PM +0800, Liu Yuan wrote: > > > > On Wed, Jan 29, 2014 at 04:28:35PM +090

Re: [sheepdog] [PATCH v2] sheep/recovery: multi-threading recovery process

2014-01-29 Thread Liu Yuan
On Wed, Jan 29, 2014 at 05:01:52PM +0900, Hitoshi Mitake wrote: > At Wed, 29 Jan 2014 15:53:57 +0800, > Liu Yuan wrote: > > > > On Wed, Jan 29, 2014 at 03:32:34PM +0800, Liu Yuan wrote: > > > On Wed, Jan 29, 2014 at 04:28:35PM +0900, Hitoshi Mitake wrote: > > > > At Tue, 28 Jan 2014 18:01:42 +0800

Re: [sheepdog] [PATCH v2] sheep/recovery: multi-threading recovery process

2014-01-29 Thread Liu Yuan
On Wed, Jan 29, 2014 at 05:01:52PM +0900, Hitoshi Mitake wrote: > At Wed, 29 Jan 2014 15:53:57 +0800, > Liu Yuan wrote: > > > > On Wed, Jan 29, 2014 at 03:32:34PM +0800, Liu Yuan wrote: > > > On Wed, Jan 29, 2014 at 04:28:35PM +0900, Hitoshi Mitake wrote: > > > > At Tue, 28 Jan 2014 18:01:42 +0800

Re: [sheepdog] [PATCH v2] sheep/recovery: multi-threading recovery process

2014-01-29 Thread Hitoshi Mitake
At Wed, 29 Jan 2014 15:53:57 +0800, Liu Yuan wrote: > > On Wed, Jan 29, 2014 at 03:32:34PM +0800, Liu Yuan wrote: > > On Wed, Jan 29, 2014 at 04:28:35PM +0900, Hitoshi Mitake wrote: > > > At Tue, 28 Jan 2014 18:01:42 +0800, > > > Liu Yuan wrote: > > > > > > > > Rationale for multi-threaded recove

Re: [sheepdog] [PATCH v2] sheep/recovery: multi-threading recovery process

2014-01-28 Thread Liu Yuan
On Wed, Jan 29, 2014 at 03:32:34PM +0800, Liu Yuan wrote: > On Wed, Jan 29, 2014 at 04:28:35PM +0900, Hitoshi Mitake wrote: > > At Tue, 28 Jan 2014 18:01:42 +0800, > > Liu Yuan wrote: > > > > > > Rationale for multi-threaded recovery: > > > > > > 1. If one node is added, we find that all the VMs

Re: [sheepdog] [PATCH v2] sheep/recovery: multi-threading recovery process

2014-01-28 Thread Liu Yuan
On Wed, Jan 29, 2014 at 04:28:35PM +0900, Hitoshi Mitake wrote: > At Tue, 28 Jan 2014 18:01:42 +0800, > Liu Yuan wrote: > > > > Rationale for multi-threaded recovery: > > > > 1. If one node is added, we find that all the VMs on other nodes will get > >noticeably affected until 50% data is tra

Re: [sheepdog] [PATCH v2] sheep/recovery: multi-threading recovery process

2014-01-28 Thread Hitoshi Mitake
At Tue, 28 Jan 2014 18:01:42 +0800, Liu Yuan wrote: > > Rationale for multi-threaded recovery: > > 1. If one node is added, we find that all the VMs on other nodes will get >noticeably affected until 50% data is transferred to the new node. > > 2. For node failure, we might not have problems

[sheepdog] [PATCH v2] sheep/recovery: multi-threading recovery process

2014-01-28 Thread Liu Yuan
Rationale for multi-threaded recovery: 1. If one node is added, we find that all the VMs on other nodes will get noticeably affected until 50% data is transferred to the new node. 2. For node failure, we might not have problems of running VM but the recovery process boost will benefit IO op