Re: [sigrok-devel] Protocol decoder and dumps for 1-Wire

2012-07-03 Thread Uwe Hermann
Hi, On Tue, Jul 03, 2012 at 12:33:17AM +0200, Iztok Jeras wrote: > The 1-Wire protocol decoder should be almost ready now, this week I > will add some more dumps and test the decoder with them. The code is > ready for a first review, next issues remain: Thanks, merged for now with a few minor cha

Re: [sigrok-devel] [PATCH 2/4] sr: session: Keep a global pollfd array

2012-07-03 Thread Lars-Peter Clausen
On 07/04/2012 01:21 AM, Bert Vermeulen wrote: > On 07/01/2012 02:37 PM, Lars-Peter Clausen wrote: >> On 06/30/2012 08:54 PM, Lars-Peter Clausen wrote: >>> [...] >>> >>> - new_sources = g_try_realloc(sources, sizeof(struct source) * >>> (num_sources - 1)); >>> + new_pollfds = g_try_realloc(so

Re: [sigrok-devel] [PATCH 2/4] sr: session: Keep a global pollfd array

2012-07-03 Thread Bert Vermeulen
On 07/01/2012 02:37 PM, Lars-Peter Clausen wrote: > On 06/30/2012 08:54 PM, Lars-Peter Clausen wrote: >> [...] >> >> -new_sources = g_try_realloc(sources, sizeof(struct source) * >> (num_sources - 1)); >> +new_pollfds = g_try_realloc(sources, sizeof(GPollFD) * num_sources); > > Ok, here

Re: [sigrok-devel] [PATCH] sr: demodevice: Reset sample limit when setting time limit and vice versa

2012-07-03 Thread Bert Vermeulen
On 07/03/2012 11:59 PM, Lars-Peter Clausen wrote: > Only one limit should be active at a time. Make sure that the sample > limit is disabled when a time limit is set and vice versa. This and your previous 3 fx2lafw patches all applied. Fixes that 500ms delay quite nicely, thanks! -- Bert Vermeu

[sigrok-devel] [PATCH] sr: demodevice: Reset sample limit when setting time limit and vice versa

2012-07-03 Thread Lars-Peter Clausen
Only one limit should be active at a time. Make sure that the sample limit is disabled when a time limit is set and vice versa. Signed-off-by: Lars-Peter Clausen --- libsigrok/hardware/demo/demo.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/libsigrok/hardware/demo/demo.c b/libsigrok

[sigrok-devel] [PATCH 2/3] sr: fx2lafw: Do not start a new acquisition if the old is still running

2012-07-03 Thread Lars-Peter Clausen
This may happen if the acquisition_start is called right after calling acquisition_stop and not all transfers have been freed or on repeated calls to acquisition_start. If it happens we'll enter an undefined state and all kind of strange behavior may occur, so error out in such a case. Signed-off-

[sigrok-devel] [PATCH 3/3] sr: fx2lafw: Fix potential leaks in acquisition_start error paths

2012-07-03 Thread Lars-Peter Clausen
Call abort_acquisition if starting sampling fails in acquisition_start, this will ensure that all already allocated resources are being freed again. Signed-off-by: Lars-Peter Clausen --- libsigrok/hardware/fx2lafw/fx2lafw.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a

[sigrok-devel] [PATCH 1/3] sr: fx2lafw: Abort pending transfers when sampling is stopped

2012-07-03 Thread Lars-Peter Clausen
The recent reworks of the fx2lafw made sure that the total buffer size is large enough hold 500ms of data. This was done to improve performance and stability. That the timeout value for a transfer was also increased to over 500ms, a side effect of this is that when sampling is stopped there will be