Re: [sigrok-devel] Peaktech DMM 3330 and LCR 2170, both work (with patches)

2016-11-02 Thread Uwe Hermann
Hi, On Thu, Oct 20, 2016 at 11:58:41AM +0200, Gerhard Sittig wrote: > Got the Peaktech 3330 DMM as well as the Peaktech 2170 LCR meter > to work with sigrok. The former needs a simple serial-dmm entry > (attached). The latter is 100% compatible with existing support > for a device, but the ES519

Re: [sigrok-devel] endianess conversion, where to put common helpers?

2016-11-02 Thread Gerhard Sittig
On Wed, Nov 02, 2016 at 22:32 +0100, Tilman Sauerbeck wrote: > > Gerhard Sittig [2016-11-02 20:39]: > > Hi, > > > When I looked at several places in the sigrok's subprojects' > > sources, I noticed the absence of common endianess conversion > > helpers. All affected call sites appear to open co

Re: [sigrok-devel] asix-sigma fixes: capture and timing issues, multi-device support

2016-11-02 Thread Uwe Hermann
Hi, On Wed, Oct 26, 2016 at 01:43:32PM +0200, jry wrote: > Please update ASIX SIGMA firmwares to latest versions: > https://gitlab.com/jrysig/sigrok-firmware/commits/asixfix Merged, thanks! The libsigrok ASIX SIGMA patches are being currently discussed on IRC, will be merged when finalized. Uw

Re: [sigrok-devel] endianess conversion, where to put common helpers?

2016-11-02 Thread Uwe Hermann
Hi, On Wed, Nov 02, 2016 at 09:29:32PM +0100, Gerhard Sittig wrote: > Still it might be worth to factor out the endianess handling. > Asix Sigma (WIP) is a current motivation. Other locations could > benefit from common logic. Not sure there's all that much that could be be feasibly factored out

Re: [sigrok-devel] endianess conversion, where to put common helpers?

2016-11-02 Thread Tilman Sauerbeck
Gerhard Sittig [2016-11-02 20:39]: Hi, > When I looked at several places in the sigrok's subprojects' > sources, I noticed the absence of common endianess conversion > helpers. All affected call sites appear to open code the > respective functions. In my (quite old) checkout, there are some end

Re: [sigrok-devel] endianess conversion, where to put common helpers?

2016-11-02 Thread Gerhard Sittig
On Wed, Nov 02, 2016 at 20:39 +0100, Gerhard Sittig wrote: > > Hi! > > When I looked at several places in the sigrok's subprojects' > sources, I noticed the absence of common endianess conversion > helpers. All affected call sites appear to open code the > respective functions. This was written

[sigrok-devel] endianess conversion, where to put common helpers?

2016-11-02 Thread Gerhard Sittig
Hi! When I looked at several places in the sigrok's subprojects' sources, I noticed the absence of common endianess conversion helpers. All affected call sites appear to open code the respective functions. Working on Asix Sigma support, jry@ currently is in need of conversion routines for 16bit

Re: [sigrok-devel] [PATCH 9100/9100] asix-sigma: assume libsigrok's "config.h" is not a sytem header

2016-11-02 Thread Gerhard Sittig
On Wed, Nov 02, 2016 at 19:16 +0100, Uwe Hermann wrote: > > Hi, > > On Sun, Oct 16, 2016 at 06:26:17PM +0200, Gerhard Sittig wrote: > > -#include > > +#include "config.h" > > I'd rather avoid changing this one without a good technical reason. > There was a change in the exact opposite direction

Re: [sigrok-devel] [PATCH 204/204] decoder loader: print error messages when decoders fail load time checks

2016-11-02 Thread Gerhard Sittig
On Wed, Nov 02, 2016 at 19:09 +0100, Uwe Hermann wrote: > > Hi, > > On Sun, Oct 16, 2016 at 06:25:29PM +0200, Gerhard Sittig wrote: > > Several checks get applied when loading externally provided protocol > > decoders. Print error messages when checks fail, so that developers can > > better reso

Re: [sigrok-devel] [PATCH 9100/9100] asix-sigma: assume libsigrok's "config.h" is not a sytem header

2016-11-02 Thread Uwe Hermann
Hi, On Sun, Oct 16, 2016 at 06:26:17PM +0200, Gerhard Sittig wrote: > -#include > +#include "config.h" I'd rather avoid changing this one without a good technical reason. There was a change in the exact opposite direction a while back, plus ensuring a certain include path order and such etc. etc

Re: [sigrok-devel] [PATCH 105/106] output: ASCII: add support for user configurable character set

2016-11-02 Thread Uwe Hermann
Hi, On Sun, Oct 16, 2016 at 06:25:23PM +0200, Gerhard Sittig wrote: > Signed-off-by: Gerhard Sittig Merged, thanks. > + if (ctx->charset) > + g_free((gpointer)ctx->charset); Dropped the "if" here, g_free() can cope with its argument being NULL. Uwe. -- http:

Re: [sigrok-devel] [PATCH 204/204] decoder loader: print error messages when decoders fail load time checks

2016-11-02 Thread Uwe Hermann
Hi, On Sun, Oct 16, 2016 at 06:25:29PM +0200, Gerhard Sittig wrote: > Several checks get applied when loading externally provided protocol > decoders. Print error messages when checks fail, so that developers can > better resolve issues. Merged with minimal changes, thanks! > + /* > +

Re: [sigrok-devel] [PATCH 200/204] repo mgmt: introduce git attributes for improved Python diffs

2016-11-02 Thread Uwe Hermann
Hi, On Sun, Oct 16, 2016 at 06:25:25PM +0200, Gerhard Sittig wrote: > In the absence of respective instructions, git will use a rather generic > approach to generate diffs and patches. Introduce a git attributes file > which results in improved output for Python sources (i.e. all protocol > decod

[sigrok-devel] [PATCH] rohde-schwarz-sme-0x: Initial device support

2016-11-02 Thread Vladislav Ivanov
Rohde&Schwarz SME-0x is a family of RF signal generators. This patch adds basic device feature support. Frequency and output power can be read and written. Parameter limits depend on the specific device model and installed options. Device list:         SME-02         SME-03         SME-03A