Revision: 7257
          http://skim-app.svn.sourceforge.net/skim-app/?rev=7257&view=rev
Author:   hofman
Date:     2011-06-03 00:24:55 +0000 (Fri, 03 Jun 2011)

Log Message:
-----------
rebuild typeselect search cache lazily

Modified Paths:
--------------
    trunk/SKTypeSelectHelper.m

Modified: trunk/SKTypeSelectHelper.m
===================================================================
--- trunk/SKTypeSelectHelper.m  2011-05-26 17:57:20 UTC (rev 7256)
+++ trunk/SKTypeSelectHelper.m  2011-06-03 00:24:55 UTC (rev 7257)
@@ -143,10 +143,7 @@
 #pragma mark API
 
 - (void)rebuildTypeSelectSearchCache {    
-    if (searchCache)
-        [searchCache release];
-    
-    searchCache = [[dataSource typeSelectHelperSelectionItems:self] retain];
+    SKDESTROY(searchCache);
 }
 
 - (BOOL)processKeyDownEvent:(NSEvent *)keyEvent {
@@ -264,7 +261,7 @@
 
 - (NSArray *)searchCache {
     if (searchCache == nil)
-        [self rebuildTypeSelectSearchCache];
+        searchCache = [[dataSource typeSelectHelperSelectionItems:self] 
retain];
     return searchCache;
 }
 


This was sent by the SourceForge.net collaborative development platform, the 
world's largest Open Source development site.

------------------------------------------------------------------------------
Simplify data backup and recovery for your virtual environment with vRanger.
Installation's a snap, and flexible recovery options mean your data is safe,
secure and there when you need it. Discover what all the cheering's about.
Get your free trial download today. 
http://p.sf.net/sfu/quest-dev2dev2 
_______________________________________________
Skim-app-commit mailing list
Skim-app-commit@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/skim-app-commit

Reply via email to