[ https://issues.apache.org/jira/browse/SLING-582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bertrand Delacretaz closed SLING-582. ------------------------------------- Resolution: Fixed Patch applied in revision 681061, please cross-check and close this issue if ok. Thanks very much for your contribution! > scripting/jst JsCodeGeneratorTest broken under Cygwin on Windows > ---------------------------------------------------------------- > > Key: SLING-582 > URL: https://issues.apache.org/jira/browse/SLING-582 > Project: Sling > Issue Type: Bug > Components: Testing > Environment: Maven version: 2.0.9 > Java version: 1.6.0_03 > OS name: "windows vista" version: "6.0" arch: "x86" Family: "windows" > Reporter: Craig L. Ching > Priority: Minor > Attachments: SLING-582.patch > > > This is probably not that important to too many people, but for me it is. I > use cygwin on Windows for development and CRLF issues are always a problem > here. So this is a fix to the JsCodeGeneratorTest that allows it to work on > Cygwin. > Basically, normal Windows uses CRLF for line-endings, but Cygwin uses just CR > if installed the way Cygwin recommends. There's a subtle problem where the > test generates code that has CRLF in it, but since the test's expected input > doesn't use CRLF, the test fails. There is already a helper that is supposed > to turn line-endings into '.', but, unfortunately it's broken as well. > Currently it simply turns '\n' into '.', but in the case of Windows this ends > up leaving the line-feeds in, which doesn't cause any problems, but the > intention of the code isn't met. So, not only is this a better > implementation that fixes a subtle issue, but it also makes it work on Cygwin. > Patch will be attached in my next post. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.