Re: [jira] Created: (SOLR-24) Add Highlighting to standard request handler

2006-06-23 Thread Mike Klaas
On 6/23/06, Chris Hostetter <[EMAIL PROTECTED]> wrote: Mike, I've only had a chance to skim your patch so far, but on the surface it looks very good to me. One little thing scares me a little bit... : 5. SolrPluginUtils.getParam() only uses the default parameter if it is null, not blank. ..

Re: [jira] Created: (SOLR-24) Add Highlighting to standard request handler

2006-06-23 Thread Chris Hostetter
Mike, I've only had a chance to skim your patch so far, but on the surface it looks very good to me. One little thing scares me a little bit... : 5. SolrPluginUtils.getParam() only uses the default parameter if it is null, not blank. ...in principal, I agree with the sentiment that "" should