[jira] Commented: (SOLR-1275) Add expungeDeletes to DirectUpdateHandler2

2009-09-14 Thread Jason Rutherglen (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12755339#action_12755339 ] Jason Rutherglen commented on SOLR-1275: The latest patch dated 2009-08-24 03:44 PM.

[jira] Commented: (SOLR-1275) Add expungeDeletes to DirectUpdateHandler2

2009-09-14 Thread Noble Paul (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12755322#action_12755322 ] Noble Paul commented on SOLR-1275: -- solrconfig-serialms.xml is not in the trunk. which test

[jira] Commented: (SOLR-1275) Add expungeDeletes to DirectUpdateHandler2

2009-09-14 Thread Jason Rutherglen (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12755234#action_12755234 ] Jason Rutherglen commented on SOLR-1275: The DirectUpdateHandlerTest fails as solrco

[jira] Commented: (SOLR-1275) Add expungeDeletes to DirectUpdateHandler2

2009-09-10 Thread Grant Ingersoll (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12753628#action_12753628 ] Grant Ingersoll commented on SOLR-1275: --- Tests pass for me, Noble, can this be resolve

[jira] Commented: (SOLR-1275) Add expungeDeletes to DirectUpdateHandler2

2009-09-09 Thread Noble Paul (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12753179#action_12753179 ] Noble Paul commented on SOLR-1275: -- the tests never failed in my box or in the nightly buil

[jira] Commented: (SOLR-1275) Add expungeDeletes to DirectUpdateHandler2

2009-09-09 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12753142#action_12753142 ] Mark Miller commented on SOLR-1275: --- bq. Hey, there aren't any benevolent dictators around

[jira] Commented: (SOLR-1275) Add expungeDeletes to DirectUpdateHandler2

2009-09-09 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12753132#action_12753132 ] Yonik Seeley commented on SOLR-1275: bq. Yonik may have a final word on this Hey, ther

[jira] Commented: (SOLR-1275) Add expungeDeletes to DirectUpdateHandler2

2009-09-08 Thread Noble Paul (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12752880#action_12752880 ] Noble Paul commented on SOLR-1275: -- here is some confusion on whether the testcase is right

[jira] Commented: (SOLR-1275) Add expungeDeletes to DirectUpdateHandler2

2009-09-08 Thread Grant Ingersoll (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12752696#action_12752696 ] Grant Ingersoll commented on SOLR-1275: --- What's the status on this one? > Add expunge

[jira] Commented: (SOLR-1275) Add expungeDeletes to DirectUpdateHandler2

2009-08-25 Thread Noble Paul (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12747788#action_12747788 ] Noble Paul commented on SOLR-1275: -- bq.Do we need to? We should be testing that the method

[jira] Commented: (SOLR-1275) Add expungeDeletes to DirectUpdateHandler2

2009-08-25 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12747446#action_12747446 ] Yonik Seeley commented on SOLR-1275: bq. if we don't test to insure the segments with de

[jira] Commented: (SOLR-1275) Add expungeDeletes to DirectUpdateHandler2

2009-08-21 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12745952#action_12745952 ] Yonik Seeley commented on SOLR-1275: bq. Calling SR.undelete would remove the deletes an

[jira] Commented: (SOLR-1275) Add expungeDeletes to DirectUpdateHandler2

2009-08-20 Thread Jason Rutherglen (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12745731#action_12745731 ] Jason Rutherglen commented on SOLR-1275: I'll check in a new patch that's faster (i.

[jira] Commented: (SOLR-1275) Add expungeDeletes to DirectUpdateHandler2

2009-08-20 Thread Jason Rutherglen (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12745717#action_12745717 ] Jason Rutherglen commented on SOLR-1275: > Isn't it much simpler Calling SR.undele

[jira] Commented: (SOLR-1275) Add expungeDeletes to DirectUpdateHandler2

2009-08-20 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12745695#action_12745695 ] Yonik Seeley commented on SOLR-1275: Isn't it much simpler to just check that the segmen

[jira] Commented: (SOLR-1275) Add expungeDeletes to DirectUpdateHandler2

2009-08-20 Thread Jason Rutherglen (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12745643#action_12745643 ] Jason Rutherglen commented on SOLR-1275: I like using XML, I was wondering why in Te

[jira] Commented: (SOLR-1275) Add expungeDeletes to DirectUpdateHandler2

2009-08-20 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12745468#action_12745468 ] Yonik Seeley commented on SOLR-1275: Hmmm, it's harder to see in diff format... the test

[jira] Commented: (SOLR-1275) Add expungeDeletes to DirectUpdateHandler2

2009-08-19 Thread Jason Rutherglen (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12745249#action_12745249 ] Jason Rutherglen commented on SOLR-1275: Because maxBufferedDocs=10, and the previou

[jira] Commented: (SOLR-1275) Add expungeDeletes to DirectUpdateHandler2

2009-08-19 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12745214#action_12745214 ] Yonik Seeley commented on SOLR-1275: The standard solrconfig.xml in the test directory h

[jira] Commented: (SOLR-1275) Add expungeDeletes to DirectUpdateHandler2

2009-08-19 Thread Noble Paul (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12745150#action_12745150 ] Noble Paul commented on SOLR-1275: -- The tests are passing ,but for the time being I wish to

[jira] Commented: (SOLR-1275) Add expungeDeletes to DirectUpdateHandler2

2009-08-19 Thread Noble Paul (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12745135#action_12745135 ] Noble Paul commented on SOLR-1275: -- committed r805888 The test passes now. > Add expungeD

[jira] Commented: (SOLR-1275) Add expungeDeletes to DirectUpdateHandler2

2009-08-19 Thread Noble Paul (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12745128#action_12745128 ] Noble Paul commented on SOLR-1275: -- the testcase fails > Add expungeDeletes to DirectUpdat

[jira] Commented: (SOLR-1275) Add expungeDeletes to DirectUpdateHandler2

2009-08-19 Thread Noble Paul (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12744951#action_12744951 ] Noble Paul commented on SOLR-1275: -- The patch looks fine to me . I plan to commit this shor

[jira] Commented: (SOLR-1275) Add expungeDeletes to DirectUpdateHandler2

2009-08-08 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12740994#action_12740994 ] Yonik Seeley commented on SOLR-1275: Apologies - my brain went the wrong way when I saw

[jira] Commented: (SOLR-1275) Add expungeDeletes to DirectUpdateHandler2

2009-08-08 Thread Jason Rutherglen (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12740992#action_12740992 ] Jason Rutherglen commented on SOLR-1275: Given the simplicity of the functionality I

[jira] Commented: (SOLR-1275) Add expungeDeletes to DirectUpdateHandler2

2009-08-05 Thread Jason Rutherglen (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12739744#action_12739744 ] Jason Rutherglen commented on SOLR-1275: Sure, I'll have time at some point to post

[jira] Commented: (SOLR-1275) Add expungeDeletes to DirectUpdateHandler2

2009-08-04 Thread Noble Paul (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12738942#action_12738942 ] Noble Paul commented on SOLR-1275: -- json, is there a way to test if expungeDeletes is indee

[jira] Commented: (SOLR-1275) Add expungeDeletes to DirectUpdateHandler2

2009-07-16 Thread Jason Rutherglen (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12732032#action_12732032 ] Jason Rutherglen commented on SOLR-1275: I can add some tests? (would like to get fa

[jira] Commented: (SOLR-1275) Add expungeDeletes to DirectUpdateHandler2

2009-07-16 Thread Otis Gospodnetic (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12731999#action_12731999 ] Otis Gospodnetic commented on SOLR-1275: Patch looks good to me (also not tested it)

[jira] Commented: (SOLR-1275) Add expungeDeletes to DirectUpdateHandler2

2009-07-14 Thread Noble Paul (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-1275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12731302#action_12731302 ] Noble Paul commented on SOLR-1275: -- So , this should be an extra option in the CommitUpdate