[
https://issues.apache.org/jira/browse/SOLR-1437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12762128#action_12762128
]
Fergus McMenemie commented on SOLR-1437:
OK, having a look at it right now.
DIH:
[
https://issues.apache.org/jira/browse/SOLR-1437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12762156#action_12762156
]
Fergus McMenemie commented on SOLR-1437:
Hmmm, the version I uploaded works. I think
[
https://issues.apache.org/jira/browse/SOLR-1437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12762158#action_12762158
]
Noble Paul commented on SOLR-1437:
--
the else return; was a bug . look at the mask_NPE patch
[
https://issues.apache.org/jira/browse/SOLR-1437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12762093#action_12762093
]
Noble Paul commented on SOLR-1437:
--
bq.PutNulls: I can see what it is doing but I still
[
https://issues.apache.org/jira/browse/SOLR-1437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12762094#action_12762094
]
Fergus McMenemie commented on SOLR-1437:
I am done!
DIH: Enhance XPathRecordReader
[
https://issues.apache.org/jira/browse/SOLR-1437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12761838#action_12761838
]
Fergus McMenemie commented on SOLR-1437:
OK!
* I have a better method of dealing
[
https://issues.apache.org/jira/browse/SOLR-1437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12761496#action_12761496
]
Fergus McMenemie commented on SOLR-1437:
I am doing more work on this to:
* improve
[
https://issues.apache.org/jira/browse/SOLR-1437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12761124#action_12761124
]
Fergus McMenemie commented on SOLR-1437:
I am quite pleased with it as far as it
[
https://issues.apache.org/jira/browse/SOLR-1437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12761153#action_12761153
]
Fergus McMenemie commented on SOLR-1437:
Re your concern. Correct, i was was also
[
https://issues.apache.org/jira/browse/SOLR-1437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12760895#action_12760895
]
Noble Paul commented on SOLR-1437:
--
Fergus can you give the patch updated to trunk?
DIH:
[
https://issues.apache.org/jira/browse/SOLR-1437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12760602#action_12760602
]
Fergus McMenemie commented on SOLR-1437:
Making good progress! The //expression and
[
https://issues.apache.org/jira/browse/SOLR-1437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12759211#action_12759211
]
Fergus McMenemie commented on SOLR-1437:
Still trying to understand all the ins and
[
https://issues.apache.org/jira/browse/SOLR-1437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12758652#action_12758652
]
Fergus McMenemie commented on SOLR-1437:
Noble,
Playing with the code... some
[
https://issues.apache.org/jira/browse/SOLR-1437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12758663#action_12758663
]
Noble Paul commented on SOLR-1437:
--
it is not an intentional.
DIH: Enhance
[
https://issues.apache.org/jira/browse/SOLR-1437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12758664#action_12758664
]
Noble Paul commented on SOLR-1437:
--
bq. inside parse() the valuesAddedinThisFrame HashSet
[
https://issues.apache.org/jira/browse/SOLR-1437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12758860#action_12758860
]
Fergus McMenemie commented on SOLR-1437:
Apologies! my testcase which uses the same
[
https://issues.apache.org/jira/browse/SOLR-1437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12757795#action_12757795
]
Lance Norskog commented on SOLR-1437:
-
Should we just steal the streaming XPath
[
https://issues.apache.org/jira/browse/SOLR-1437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12757823#action_12757823
]
Noble Paul commented on SOLR-1437:
--
DIH needs streaming of a records which contain a bunch
[
https://issues.apache.org/jira/browse/SOLR-1437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12757091#action_12757091
]
Noble Paul commented on SOLR-1437:
--
committed r816577
thanks Fergus
DIH: Enhance
[
https://issues.apache.org/jira/browse/SOLR-1437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12756450#action_12756450
]
Fergus McMenemie commented on SOLR-1437:
OK. Would it be bad if I recoded things
[
https://issues.apache.org/jira/browse/SOLR-1437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12756453#action_12756453
]
Noble Paul commented on SOLR-1437:
--
renaming done in trunk
let us be clear about what all
[
https://issues.apache.org/jira/browse/SOLR-1437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12756469#action_12756469
]
Fergus McMenemie commented on SOLR-1437:
Good points.
I am still make sure I
[
https://issues.apache.org/jira/browse/SOLR-1437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12756476#action_12756476
]
Noble Paul commented on SOLR-1437:
--
try not to make too many changes. If you have javadocs
[
https://issues.apache.org/jira/browse/SOLR-1437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12756477#action_12756477
]
Noble Paul commented on SOLR-1437:
--
bq. I was not going to allow wild-cards in the forEach
[
https://issues.apache.org/jira/browse/SOLR-1437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12756916#action_12756916
]
Noble Paul commented on SOLR-1437:
--
the patch looks fine.
* It is not created from the
[
https://issues.apache.org/jira/browse/SOLR-1437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12756051#action_12756051
]
Fergus McMenemie commented on SOLR-1437:
A pity we may not make the 1.4 release, but
[
https://issues.apache.org/jira/browse/SOLR-1437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12756358#action_12756358
]
Noble Paul commented on SOLR-1437:
--
for any normal event , parser.next(); should be called
27 matches
Mail list logo
