[jira] Commented: (SOLR-248) Capitalization Filter Factory

2007-05-24 Thread Ryan McKinley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12498492 ] Ryan McKinley commented on SOLR-248: 1) would it make sense for the keep option to refer to a file, using the

[jira] Commented: (SOLR-248) Capitalization Filter Factory

2007-05-24 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12498700 ] Yonik Seeley commented on SOLR-248: --- Hmmm, this feels slightly strange implementing at the indexing level. What are

[jira] Commented: (SOLR-248) Capitalization Filter Factory

2007-05-24 Thread Ryan McKinley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12498711 ] Ryan McKinley commented on SOLR-248: It is a little strange, but (in my case anyway) i think it makes sense...

[jira] Commented: (SOLR-248) Capitalization Filter Factory

2007-05-24 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12498717 ] Yonik Seeley commented on SOLR-248: --- Implemented at the indexing level, I can have different values for the stored

[jira] Commented: (SOLR-248) Capitalization Filter Factory

2007-05-24 Thread J.J. Larrea (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12498817 ] J.J. Larrea commented on SOLR-248: -- While I fully agree that faceting does raise some odd issues stemming from the

[jira] Commented: (SOLR-248) Capitalization Filter Factory

2007-05-24 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12498834 ] Yonik Seeley commented on SOLR-248: --- Why is so much of the logic in the Factory? I haven't looked at this specific

Re: [jira] Commented: (SOLR-248) Capitalization Filter Factory

2007-05-24 Thread Chris Hostetter
: I haven't looked at this specific code, but this is my preference in : general. multiple TokenFilters are created per-field instance on the : index side, and per-query-term on the search side, so it's better to : pull all the setup you can out of the Filter for performance reasons.

[jira] Commented: (SOLR-248) Capitalization Filter Factory

2007-05-24 Thread Ryan McKinley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12498841 ] Ryan McKinley commented on SOLR-248: Why is so much of the logic in the Factory? It seemed silly to copy the

[jira] Commented: (SOLR-248) Capitalization Filter Factory

2007-05-23 Thread Hoss Man (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12498488 ] Hoss Man commented on SOLR-248: --- 1) would it make sense for the keep option to refer to a file, using the same format