[jira] Commented: (SOLR-410) Audit the new ResponseBuilder class

2008-06-05 Thread Mike Klaas (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12602834#action_12602834 ] Mike Klaas commented on SOLR-410: - Ryan, can this be closed? Audit the new ResponseBuilder

[jira] Commented: (SOLR-410) Audit the new ResponseBuilder class

2007-11-12 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12541938 ] Yonik Seeley commented on SOLR-410: --- Ongoing review + changes also applies to search components in general

Re: [jira] Commented: (SOLR-410) Audit the new ResponseBuilder class

2007-11-12 Thread Ryan McKinley
Yonik Seeley commented on SOLR-410: --- Ongoing review + changes also applies to search components in general (SearchComponent class, etc). Yes, of course! What is your thought on resolving vs keeping open issues that need further review/changes? Keeping

Re: [jira] Commented: (SOLR-410) Audit the new ResponseBuilder class

2007-11-12 Thread Yonik Seeley
On Nov 12, 2007 3:34 PM, Ryan McKinley [EMAIL PROTECTED] wrote: What is your thought on resolving vs keeping open issues that need further review/changes? If we know that changes need to be made (as is the case here), I think it's OK to leave it open. Committing things before they are done