[ 
https://issues.apache.org/jira/browse/SOLR-256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617884#action_12617884
 ] 

shalinmangar edited comment on SOLR-256 at 7/29/08 11:01 AM:
----------------------------------------------------------------------

Incorporates Hoss's suggestions as per comment above.

Another change is that the UpdateHandler constructor adds itself to the 
infoRegistry. This leads to an NullPointerException in 
DirectUpdateHandler2#getStatistics because when JmxMonitoredMap tries to read 
the statistics, the instance variables of DUH2 haven't been initialized yet. 
The call to infoRegistry.put has now been moved to SolrCore constructor right 
after it creates the UpdateHandler.

I shall commit this shortly.

      was (Author: shalinmangar):
    Incorporates Hoss's suggestions as per comment above.

Another change is that the UpdateHandler constructor adds itself to the 
infoRegistry. This leads to an NullPointerException in 
DirectUpdateHandler2#getStatistics because when JmxMonitoredMap tries to read 
the statistics, the instance variables of DUH2 haven't been initialized yet.

I shall commit this shortly.
  
> Stats via JMX
> -------------
>
>                 Key: SOLR-256
>                 URL: https://issues.apache.org/jira/browse/SOLR-256
>             Project: Solr
>          Issue Type: New Feature
>          Components: search, update
>            Reporter: Sharad Agarwal
>            Assignee: Shalin Shekhar Mangar
>            Priority: Minor
>             Fix For: 1.3
>
>         Attachments: jmx.patch, jmx.patch, jmx.patch, jmx.patch, jmx.patch, 
> SOLR-256.patch, SOLR-256.patch, SOLR-256.patch, SOLR-256.patch, 
> SOLR-256.patch, SOLR-256.patch, SOLR-256.patch, SOLR-256.patch, 
> SOLR-256.patch, SOLR-256.patch
>
>
> This patch adds JMX capability to get statistics from all the SolrInfoMBean.
> The implementation is done such a way to minimize code changes. 
> In SolrInfoRegistry, I have overloaded Map's  put and remove methods to 
> register and unregister SolrInfoMBean in MBeanServer. 
> Later on, I am planning to use register and unregister methods in 
> SolrInfoRegistry and removing getRegistry() method (Hiding the map instance 
> to other classes)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to