Re: svn commit: r883522 - in /lucene/solr/trunk/src/java/org/apache/solr/search: ValueSourceParser.java function/ConstValueSource.java

2009-11-23 Thread Chris Hostetter
:final long constant; : + final double dv; : + final float fv; ..can't the "final long constant" be removed completely now? -Hoss

Re: svn commit: r883522 - in /lucene/solr/trunk/src/java/org/apache/solr/search: ValueSourceParser.java function/ConstValueSource.java

2009-11-23 Thread Yonik Seeley
On Mon, Nov 23, 2009 at 5:36 PM, Chris Hostetter wrote: > :    final long constant; > : +  final double dv; > : +  final float fv; > > ..can't the "final long constant" be removed completely now? Some functions could actually use it - say like ms(). More could in the future if/when we type our va

Re: svn commit: r883522 - in /lucene/solr/trunk/src/java/org/apache/solr/search: ValueSourceParser.java function/ConstValueSource.java

2009-11-23 Thread Chris Hostetter
: Some functions could actually use it - say like ms(). : More could in the future if/when we type our value sources to avoid : precision loss (i.e. sub(longfield1,longfield2) would work in long : space, not float space). my bad ... i tuned out the fact that both new variables had different type