Re: DIH abort doesn't close datasources

2011-06-16 Thread Shalin Shekhar Mangar
On Thu, Jun 16, 2011 at 3:46 PM, Frank Wesemann wrote: > Shalin, > thank you for the answer. > I indeed didn't look into clearCache(). > I thought it would just do that ( clear caches ). :) > Yeah, it is not the most aptly named method :) Thanks for reviewing the code though! -- Regards, Shali

Re: DIH abort doesn't close datasources

2011-06-16 Thread Frank Wesemann
Shalin, thank you for the answer. I indeed didn't look into clearCache(). I thought it would just do that ( clear caches ). :) Shalin Shekhar Mangar schrieb: The abort command just sets a atomic boolean flag which is checked frequently by the import threads to see if they should stop. If you loo

Re: DIH abort doesn't close datasources

2011-06-16 Thread Shalin Shekhar Mangar
On Wed, Jun 15, 2011 at 8:10 PM, Frank Wesemann wrote: > Hi, > I just came across this: > If I abort an import via /dataimport/?command=abort the connections to the > (in my case) database stay open. > Shouldn't DocBuilder#rollback() call something like cleanup() which in turn > tries to close Ent

DIH abort doesn't close datasources

2011-06-15 Thread Frank Wesemann
Hi, I just came across this: If I abort an import via /dataimport/?command=abort the connections to the (in my case) database stay open. Shouldn't DocBuilder#rollback() call something like cleanup() which in turn tries to close EntityProcessors, Datasources etc. instead of relying that finalize