Re: spellcheck: buildOnOptimize?

2008-09-30 Thread Jason Rennie
On Fri, Sep 26, 2008 at 9:33 AM, Shalin Shekhar Mangar < [EMAIL PROTECTED]> wrote: > Jason, can you please open a jira issue to add this feature? > Done. https://issues.apache.org/jira/browse/SOLR-795 Jason

Re: spellcheck: buildOnOptimize?

2008-09-26 Thread Shalin Shekhar Mangar
On Fri, Sep 26, 2008 at 9:27 AM, Chris Hostetter <[EMAIL PROTECTED]>wrote: > > couldn't the Listener's newSearcher() method just do something like > this... > > if (rebuildOnlyAfterOptimize && >! (newSearcher.getReader().isOptimized() && > ! oldSearcher.getReader().isOptimized()) { > re

Re: spellcheck: buildOnOptimize?

2008-09-26 Thread Grant Ingersoll
That seems reasonable. Another thing to think about, is maybe it is useful to provide some event metadata to the events that contain information about what triggered them. Something like a SolrEvent class such that postCommit looks like postCommit(SolrEvent evt) and public void newSearch

Re: spellcheck: buildOnOptimize?

2008-09-25 Thread Chris Hostetter
: postCommit/postOptimize callbacks happen after commit/optimize but before a : new searcher is opened. Therefore, it is not possible to re-build spellcheck : index on those events without opening a IndexReader directly on the solr FWIW: I believe it has to work that way because postCommit events

Re: spellcheck: buildOnOptimize?

2008-09-25 Thread Shalin Shekhar Mangar
On Fri, Sep 26, 2008 at 12:43 AM, Grant Ingersoll <[EMAIL PROTECTED]>wrote: > > On Sep 25, 2008, at 2:17 PM, Jason Rennie wrote: > > I see that there's an option to automatically rebuild the spelling index >> on >> a commit. That's a nice feature that we'll consider using, but we run >> commits

Re: spellcheck: buildOnOptimize?

2008-09-25 Thread Grant Ingersoll
On Sep 25, 2008, at 2:17 PM, Jason Rennie wrote: I see that there's an option to automatically rebuild the spelling index on a commit. That's a nice feature that we'll consider using, but we run commits every few thousand document updates, which would yield ~100 spelling index rebuilds a d

spellcheck: buildOnOptimize?

2008-09-25 Thread Jason Rennie
I see that there's an option to automatically rebuild the spelling index on a commit. That's a nice feature that we'll consider using, but we run commits every few thousand document updates, which would yield ~100 spelling index rebuilds a day. OTOH, we run an optimize about once/day which seems