Re: [9] Review Request: 8156169 Some sound tests rarely hangs because of incorrect synchronization

2016-05-17 Thread Phil Race
+1. The reason for the change to tracks.toArray() was not obvious from the code and I understood it only after reading your comment below. So perhaps you could add a short comment before you push. -phil. On 05/17/2016 07:30 AM, Sergey Bylokhov wrote: Hello, Audio Guru. Please review the fix f

Re: [9] Review Request: 8156169 Some sound tests rarely hangs because of incorrect synchronization

2016-05-17 Thread Alex Menkov
Hi Sergey, Most of the fix looks good to me, but I'm not sure change in Sequence.deleteTrack is correct. As far as I understand synchronized(track) are to make safe getTickLength method (otherwise we can get ArrayIndexOutOfBoundsException there) --alex On 17.05.2016 17:30, Sergey Bylokhov w

[9] Review Request: 8156169 Some sound tests rarely hangs because of incorrect synchronization

2016-05-17 Thread Sergey Bylokhov
Hello, Audio Guru. Please review the fix for jdk9. While working on some bugs reported by the mach5 project, I found that some of our tests are quite unstable, and the reason was in this(or similar) pattern: clip.start(); while(clip.isRunning()); The status of the clip is run or not