CVS commit: src/lib/libwrap

2019-01-13 Thread Robert Elz
Module Name:src Committed By: kre Date: Mon Jan 14 03:30:25 UTC 2019 Modified Files: src/lib/libwrap: expandm.c Log Message: Whitespace (indent with tabs, rather than spaces), and rearrange one line that needed wrapping so it no longer does, and is (IMO) clearer. WHile

CVS commit: src/lib/libwrap

2019-01-13 Thread Robert Elz
Module Name:src Committed By: kre Date: Mon Jan 14 03:30:25 UTC 2019 Modified Files: src/lib/libwrap: expandm.c Log Message: Whitespace (indent with tabs, rather than spaces), and rearrange one line that needed wrapping so it no longer does, and is (IMO) clearer. WHile

Re: CVS commit: src/etc

2019-01-13 Thread Robert Elz
Date:Mon, 14 Jan 2019 11:59:51 +1100 From:matthew green Message-ID: <10889.1547427...@splode.eterna.com.au> | i don't agree with this. | | if we were going to make things easy for naive users I didn't say "easy" for naive users, I said "most useful". That

Re: CVS commit: src/etc

2019-01-13 Thread Greg Troxel
matthew green writes: > (i wouldn't pick 'wheel' as this group -- i would invent a > new group either called 'net' or 'wpa', with no underscore > since they're designed to be assigned, unlike the groups > for specific programs security models.) Are you saying that you are ok with the following:

Re: CVS commit: src/etc

2019-01-13 Thread Jason Thorpe
> On Jan 13, 2019, at 5:08 PM, David Holland > wrote: > > Is there a way we could, for example, leverage the current hacks for > chowning console devices to grant access to wpa_supplicant? Some of this could be achieved with ttyaction(5), certainly. -- thorpej

Re: CVS commit: src/etc

2019-01-13 Thread David Holland
On Mon, Jan 14, 2019 at 09:42:54AM +1100, matthew green wrote: > it would be OK if this was _read-only_ access to network > configuration, but one should never be allowed to change the > it unless root. In the long run, it's quite helpful for laptops to be able to adjust the network

re: CVS commit: src/etc

2019-01-13 Thread matthew green
> | i don't want to allow [...] > > People, once again, a big meaningless discussion on what the > default configuration should be.We should work out what will > be most useful to most naive users, and make that be the default, > regardless of what any of us want. i don't agree with this.

Re: CVS commit: src/etc

2019-01-13 Thread Robert Elz
In my previous message, I forgot to also note that if modifying (if required) wpa_supplicant to create the socket with the ownership & permissions set in the rc.conf file is too hard (would create issues with importing new versions easily) then the same can be accomplished by putting the socket in

re: CVS commit: src/tests/kernel

2019-01-13 Thread matthew green
> Modified Files: > src/tests/kernel: t_timeleft.c > > Log Message: > add call error checks, requested by mrg@ thanks!

Re: CVS commit: src/etc

2019-01-13 Thread Robert Elz
Date:Mon, 14 Jan 2019 09:42:54 +1100 From:matthew green Message-ID: <11338.1547419...@splode.eterna.com.au> | > I suppose the real question is do we want to allow group access to | > [...] | i don't want to allow [...] People, once again, a big meaningless

CVS commit: src/tests/kernel

2019-01-13 Thread Christos Zoulas
Module Name:src Committed By: christos Date: Mon Jan 14 00:23:43 UTC 2019 Modified Files: src/tests/kernel: t_timeleft.c Log Message: add call error checks, requested by mrg@ To generate a diff of this commit: cvs rdiff -u -r1.3 -r1.4 src/tests/kernel/t_timeleft.c

CVS commit: src/tests/kernel

2019-01-13 Thread Christos Zoulas
Module Name:src Committed By: christos Date: Mon Jan 14 00:23:43 UTC 2019 Modified Files: src/tests/kernel: t_timeleft.c Log Message: add call error checks, requested by mrg@ To generate a diff of this commit: cvs rdiff -u -r1.3 -r1.4 src/tests/kernel/t_timeleft.c

CVS commit: [pgoyette-compat] src/doc

2019-01-13 Thread Paul Goyette
Module Name:src Committed By: pgoyette Date: Mon Jan 14 00:16:32 UTC 2019 Modified Files: src/doc [pgoyette-compat]: TODO.compat-module Log Message: Note the desire to return some callback functions to having a void type, rather than int (changing them was necessary to

CVS commit: [pgoyette-compat] src/doc

2019-01-13 Thread Paul Goyette
Module Name:src Committed By: pgoyette Date: Mon Jan 14 00:16:32 UTC 2019 Modified Files: src/doc [pgoyette-compat]: TODO.compat-module Log Message: Note the desire to return some callback functions to having a void type, rather than int (changing them was necessary to

CVS commit: src/sys/arch/sparc/conf

2019-01-13 Thread matthew green
Module Name:src Committed By: mrg Date: Mon Jan 14 00:13:18 UTC 2019 Modified Files: src/sys/arch/sparc/conf: GENERIC KRUPS Log Message: normalise comment for fileassoc(8). from PR#44873. To generate a diff of this commit: cvs rdiff -u -r1.262 -r1.263

CVS commit: src/sys/arch/sparc/conf

2019-01-13 Thread matthew green
Module Name:src Committed By: mrg Date: Mon Jan 14 00:13:18 UTC 2019 Modified Files: src/sys/arch/sparc/conf: GENERIC KRUPS Log Message: normalise comment for fileassoc(8). from PR#44873. To generate a diff of this commit: cvs rdiff -u -r1.262 -r1.263

re: CVS commit: src/tests/kernel

2019-01-13 Thread Christos Zoulas
On Jan 14, 9:29am, m...@eterna.com.au (matthew green) wrote: -- Subject: re: CVS commit: src/tests/kernel | "Christos Zoulas" writes: | > Module Name:src | > Committed By: christos | > Date: Sun Jan 13 15:36:57 UTC 2019 | > | > Modified Files: | >

CVS commit: [pgoyette-compat] src/doc

2019-01-13 Thread Paul Goyette
Module Name:src Committed By: pgoyette Date: Sun Jan 13 23:33:07 UTC 2019 Modified Files: src/doc [pgoyette-compat]: TODO.compat-module Log Message: Note that rtsock_50 is now functional, even though the implementation remains sub-optimal. To generate a diff of this

CVS commit: [pgoyette-compat] src/doc

2019-01-13 Thread Paul Goyette
Module Name:src Committed By: pgoyette Date: Sun Jan 13 23:33:07 UTC 2019 Modified Files: src/doc [pgoyette-compat]: TODO.compat-module Log Message: Note that rtsock_50 is now functional, even though the implementation remains sub-optimal. To generate a diff of this

CVS commit: [pgoyette-compat] src/sys

2019-01-13 Thread Paul Goyette
Module Name:src Committed By: pgoyette Date: Sun Jan 13 23:32:22 UTC 2019 Modified Files: src/sys/compat/common [pgoyette-compat]: rtsock_50.c src/sys/compat/net [pgoyette-compat]: if.h route.h src/sys/kern [pgoyette-compat]: compat_stub.c

CVS commit: [pgoyette-compat] src/sys

2019-01-13 Thread Paul Goyette
Module Name:src Committed By: pgoyette Date: Sun Jan 13 23:32:22 UTC 2019 Modified Files: src/sys/compat/common [pgoyette-compat]: rtsock_50.c src/sys/compat/net [pgoyette-compat]: if.h route.h src/sys/kern [pgoyette-compat]: compat_stub.c

re: CVS commit: src/etc

2019-01-13 Thread matthew green
Roy Marples writes: > On 13/01/2019 10:20, matthew green wrote: > > shouldn't one need to be root to modify network configuration? > > i shouldn't be able to tell wpa_supplicant to do something as > > non-root, in a default install. > > In a default install the only member of wheel is root and

re: CVS commit: src/tests/kernel

2019-01-13 Thread matthew green
"Christos Zoulas" writes: > Module Name: src > Committed By: christos > Date: Sun Jan 13 15:36:57 UTC 2019 > > Modified Files: > src/tests/kernel: t_timeleft.c > > Log Message: > Increase the timeout a bit, and make sure we join so that there is no > race. i notice both

CVS commit: src/sys/arch/sparc/sparc

2019-01-13 Thread matthew green
Module Name:src Committed By: mrg Date: Sun Jan 13 22:11:11 UTC 2019 Modified Files: src/sys/arch/sparc/sparc: pmap.c Log Message: switch sparc pmap lock to the scheme sparc64 uses: - local IPL_NONE mutex for general pmap locking operations, not kernel lock. - for

CVS commit: src/sys/arch/sparc/sparc

2019-01-13 Thread matthew green
Module Name:src Committed By: mrg Date: Sun Jan 13 22:11:11 UTC 2019 Modified Files: src/sys/arch/sparc/sparc: pmap.c Log Message: switch sparc pmap lock to the scheme sparc64 uses: - local IPL_NONE mutex for general pmap locking operations, not kernel lock. - for

CVS commit: src/external/mit/xorg/lib/xkeyboard-config

2019-01-13 Thread Soren Jacobsen
Module Name:src Committed By: snj Date: Sun Jan 13 19:21:27 UTC 2019 Modified Files: src/external/mit/xorg/lib/xkeyboard-config: xkeyboard-config.man Log Message: regen for 2.25 To generate a diff of this commit: cvs rdiff -u -r1.4 -r1.5 \

CVS commit: src/external/mit/xorg/lib/xkeyboard-config

2019-01-13 Thread Soren Jacobsen
Module Name:src Committed By: snj Date: Sun Jan 13 19:21:27 UTC 2019 Modified Files: src/external/mit/xorg/lib/xkeyboard-config: xkeyboard-config.man Log Message: regen for 2.25 To generate a diff of this commit: cvs rdiff -u -r1.4 -r1.5 \

CVS commit: src/games/fortune/datfiles

2019-01-13 Thread Jonathan A. Kollasch
Module Name:src Committed By: jakllsch Date: Sun Jan 13 17:55:03 UTC 2019 Modified Files: src/games/fortune/datfiles: fortunes Log Message: Incite the "Purple Cow" wrath of Gelett Burgess upon ourselves. To generate a diff of this commit: cvs rdiff -u -r1.76 -r1.77

CVS commit: src/games/fortune/datfiles

2019-01-13 Thread Jonathan A. Kollasch
Module Name:src Committed By: jakllsch Date: Sun Jan 13 17:55:03 UTC 2019 Modified Files: src/games/fortune/datfiles: fortunes Log Message: Incite the "Purple Cow" wrath of Gelett Burgess upon ourselves. To generate a diff of this commit: cvs rdiff -u -r1.76 -r1.77

CVS commit: src/usr.bin/xstr

2019-01-13 Thread Valeriy E. Ushakov
Module Name:src Committed By: uwe Date: Sun Jan 13 16:48:51 UTC 2019 Modified Files: src/usr.bin/xstr: xstr.1 Log Message: .Pp before .Bd is redundant. >From Edgar Pettijohn. To generate a diff of this commit: cvs rdiff -u -r1.19 -r1.20 src/usr.bin/xstr/xstr.1 Please

CVS commit: src/usr.bin/xstr

2019-01-13 Thread Valeriy E. Ushakov
Module Name:src Committed By: uwe Date: Sun Jan 13 16:48:51 UTC 2019 Modified Files: src/usr.bin/xstr: xstr.1 Log Message: .Pp before .Bd is redundant. >From Edgar Pettijohn. To generate a diff of this commit: cvs rdiff -u -r1.19 -r1.20 src/usr.bin/xstr/xstr.1 Please

Re: CVS commit: src/etc

2019-01-13 Thread Greg Troxel
Jason Thorpe writes: >> On Jan 13, 2019, at 5:21 AM, Greg Troxel wrote: >> >> Even if you have to be root, these changes are still hugely useful. >> "sudo wpa_cli" is not that hard, even if it seems like it should not be >> necessary. > > ...but made slightly more annoying seeing as how sudo

Re: CVS commit: src/etc

2019-01-13 Thread Jason Thorpe
> On Jan 13, 2019, at 5:21 AM, Greg Troxel wrote: > > Even if you have to be root, these changes are still hugely useful. > "sudo wpa_cli" is not that hard, even if it seems like it should not be > necessary. ...but made slightly more annoying seeing as how sudo is not part of the base OS.

CVS commit: src/tests/kernel

2019-01-13 Thread Christos Zoulas
Module Name:src Committed By: christos Date: Sun Jan 13 15:36:57 UTC 2019 Modified Files: src/tests/kernel: t_timeleft.c Log Message: Increase the timeout a bit, and make sure we join so that there is no race. To generate a diff of this commit: cvs rdiff -u -r1.2 -r1.3

CVS commit: src/tests/kernel

2019-01-13 Thread Christos Zoulas
Module Name:src Committed By: christos Date: Sun Jan 13 15:36:57 UTC 2019 Modified Files: src/tests/kernel: t_timeleft.c Log Message: Increase the timeout a bit, and make sure we join so that there is no race. To generate a diff of this commit: cvs rdiff -u -r1.2 -r1.3

CVS commit: src/tests/fs/vfs

2019-01-13 Thread Andreas Gustafsson
Module Name:src Committed By: gson Date: Sun Jan 13 14:35:00 UTC 2019 Modified Files: src/tests/fs/vfs: t_renamerace.c Log Message: Mark the fs/vfs/t_renamerace:udf_renamerace_dirs test case as an expected failure referencing PR kern/53865, and force failure to avoid

CVS commit: src/tests/fs/vfs

2019-01-13 Thread Andreas Gustafsson
Module Name:src Committed By: gson Date: Sun Jan 13 14:35:00 UTC 2019 Modified Files: src/tests/fs/vfs: t_renamerace.c Log Message: Mark the fs/vfs/t_renamerace:udf_renamerace_dirs test case as an expected failure referencing PR kern/53865, and force failure to avoid

Re: CVS commit: src/etc

2019-01-13 Thread Greg Troxel
Roy Marples writes: > On 13/01/2019 10:20, matthew green wrote: >> shouldn't one need to be root to modify network configuration? >> i shouldn't be able to tell wpa_supplicant to do something as >> non-root, in a default install. > > In a default install the only member of wheel is root and >

CVS commit: src/sys/arch/x86/include

2019-01-13 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sun Jan 13 12:19:09 UTC 2019 Modified Files: src/sys/arch/x86/include: specialreg.h Log Message: Forgot to commit file along with identcpu.c::rev1.86. To generate a diff of this commit: cvs rdiff -u -r1.136 -r1.137

CVS commit: src/sys/arch/x86/include

2019-01-13 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sun Jan 13 12:19:09 UTC 2019 Modified Files: src/sys/arch/x86/include: specialreg.h Log Message: Forgot to commit file along with identcpu.c::rev1.86. To generate a diff of this commit: cvs rdiff -u -r1.136 -r1.137

CVS commit: src/sys/arch/x86/x86

2019-01-13 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sun Jan 13 12:16:58 UTC 2019 Modified Files: src/sys/arch/x86/x86: identcpu.c Log Message: On certain AMD f10h CPUs (like mine), the BIOS does not enable WC+. It means that the guest pages that are WC+ become CD, and this degrades

CVS commit: src/sys/arch/x86/x86

2019-01-13 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sun Jan 13 12:16:58 UTC 2019 Modified Files: src/sys/arch/x86/x86: identcpu.c Log Message: On certain AMD f10h CPUs (like mine), the BIOS does not enable WC+. It means that the guest pages that are WC+ become CD, and this degrades

CVS commit: src/tests/lib/libc/sys

2019-01-13 Thread Andreas Gustafsson
Module Name:src Committed By: gson Date: Sun Jan 13 11:03:20 UTC 2019 Modified Files: src/tests/lib/libc/sys: t_ptrace_wait.c Log Message: Don't mark the traceme_vfork_crash_bus test case as an expected failure when it is executing as part of the

CVS commit: src/tests/lib/libc/sys

2019-01-13 Thread Andreas Gustafsson
Module Name:src Committed By: gson Date: Sun Jan 13 11:03:20 UTC 2019 Modified Files: src/tests/lib/libc/sys: t_ptrace_wait.c Log Message: Don't mark the traceme_vfork_crash_bus test case as an expected failure when it is executing as part of the

CVS commit: [pgoyette-compat] src/sys

2019-01-13 Thread Paul Goyette
Module Name:src Committed By: pgoyette Date: Sun Jan 13 10:49:51 UTC 2019 Modified Files: src/sys/arch/amd64/amd64 [pgoyette-compat]: netbsd32_machdep.c src/sys/arch/mips/mips [pgoyette-compat]: netbsd32_machdep.c src/sys/arch/sparc/fpu [pgoyette-compat]:

CVS commit: [pgoyette-compat] src/sys

2019-01-13 Thread Paul Goyette
Module Name:src Committed By: pgoyette Date: Sun Jan 13 10:49:51 UTC 2019 Modified Files: src/sys/arch/amd64/amd64 [pgoyette-compat]: netbsd32_machdep.c src/sys/arch/mips/mips [pgoyette-compat]: netbsd32_machdep.c src/sys/arch/sparc/fpu [pgoyette-compat]:

CVS commit: src/lib/libnvmm

2019-01-13 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sun Jan 13 10:43:23 UTC 2019 Modified Files: src/lib/libnvmm: libnvmm_x86.c Log Message: Handle more corner cases, clean up a little, and add a set of instructions in Group1. To generate a diff of this commit: cvs rdiff -u -r1.14

CVS commit: src/lib/libnvmm

2019-01-13 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sun Jan 13 10:43:23 UTC 2019 Modified Files: src/lib/libnvmm: libnvmm_x86.c Log Message: Handle more corner cases, clean up a little, and add a set of instructions in Group1. To generate a diff of this commit: cvs rdiff -u -r1.14

re: CVS commit: src/etc

2019-01-13 Thread matthew green
shouldn't one need to be root to modify network configuration? i shouldn't be able to tell wpa_supplicant to do something as non-root, in a default install. .mrg.

CVS commit: src/sys/dev/nvmm/x86

2019-01-13 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sun Jan 13 10:07:50 UTC 2019 Modified Files: src/sys/dev/nvmm/x86: nvmm_x86_svm.c Log Message: Reset DR7 before loading DR0-3, to prevent a fault if the host process has dbregs enabled. To generate a diff of this commit: cvs

CVS commit: src/sys/dev/nvmm/x86

2019-01-13 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sun Jan 13 10:07:50 UTC 2019 Modified Files: src/sys/dev/nvmm/x86: nvmm_x86_svm.c Log Message: Reset DR7 before loading DR0-3, to prevent a fault if the host process has dbregs enabled. To generate a diff of this commit: cvs

CVS commit: src/sys/arch/x86

2019-01-13 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sun Jan 13 10:01:07 UTC 2019 Modified Files: src/sys/arch/x86/include: dbregs.h src/sys/arch/x86/x86: dbregs.c Log Message: Error out if the higher 32 bits of DR6 and DR7 are set. MOV DR would fault otherwise. To generate

CVS commit: src/sys/arch/x86

2019-01-13 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sun Jan 13 10:01:07 UTC 2019 Modified Files: src/sys/arch/x86/include: dbregs.h src/sys/arch/x86/x86: dbregs.c Log Message: Error out if the higher 32 bits of DR6 and DR7 are set. MOV DR would fault otherwise. To generate

Re: CVS commit: src/etc

2019-01-13 Thread Roy Marples
Not really, it just sets the group explicitly rather than implicitly. Without it the socket group is derived from the directory it's created in, which is group wheel to start with. Now it could be argued that creating the socket in the first place allows members of the wheel group to configure