CVS commit: src/sys

2020-07-31 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sat Aug 1 06:50:43 UTC 2020 Modified Files: src/sys/external/bsd/ipf/netinet: ip_nat.c src/sys/net: if_bridge.c Log Message: Remove #ifdef BRIDGE_IPF, compile in the code by default. Sent to tech-net@. To generate a diff

CVS commit: src/sys/arch/aarch64/include

2020-07-31 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sat Aug 1 06:35:00 UTC 2020 Modified Files: src/sys/arch/aarch64/include: asan.h Log Message: Use large pages for the KASAN shadow, same as amd64, discussed with ryo@. To generate a diff of this commit: cvs rdiff -u -r1.8 -r1.9 s

CVS commit: src/usr.bin/make

2020-07-31 Thread Roland Illig
Module Name:src Committed By: rillig Date: Sat Aug 1 06:35:00 UTC 2020 Modified Files: src/usr.bin/make: var.c Log Message: make(1): remove unnecessary snprintf from Var_ExportVars String literals can be concatenated at compile time. Furthermore, MAKE_EXPORTED can now c

CVS commit: src/sys/arch/mips/mips

2020-07-31 Thread Nick Hudson
Module Name:src Committed By: skrll Date: Sat Aug 1 05:45:30 UTC 2020 Modified Files: src/sys/arch/mips/mips: spl.S Log Message: Trailing whitespace To generate a diff of this commit: cvs rdiff -u -r1.17 -r1.18 src/sys/arch/mips/mips/spl.S Please note that diffs are no

CVS commit: src/share/misc

2020-07-31 Thread Luke Mewburn
Module Name:src Committed By: lukem Date: Sat Aug 1 02:45:36 UTC 2020 Modified Files: src/share/misc: style Log Message: style: prefer braces for single statement control statements Prefer to use { braces } around single statements after control statements, instead of di

CVS commit: src/sys/dev

2020-07-31 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sat Aug 1 02:15:49 UTC 2020 Modified Files: src/sys/dev: cgd.c Log Message: Fix whitespace. To generate a diff of this commit: cvs rdiff -u -r1.138 -r1.139 src/sys/dev/cgd.c Please note that diffs are not public domain; the

CVS commit: src/sys/dev

2020-07-31 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sat Aug 1 02:15:17 UTC 2020 Modified Files: src/sys/dev: cgd.c Log Message: Run cgd(4) crypto threads with the FPU/SIMD units pre-enabled. Improves cgd throughput on systems with vectorized crypto by ~20%. To generate a dif

CVS commit: src

2020-07-31 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sat Aug 1 02:14:43 UTC 2020 Modified Files: src/share/man/man9: workqueue.9 src/sys/kern: subr_workqueue.c src/sys/sys: workqueue.h Log Message: New workqueue flag WQ_FPU. Arranges kthread_fpu_enter/exit aroun

CVS commit: src/sys/arch/x86/x86

2020-07-31 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sat Aug 1 02:13:34 UTC 2020 Modified Files: src/sys/arch/x86/x86: fpu.c Log Message: Add kthread_fpu_enter/exit support to x86. To generate a diff of this commit: cvs rdiff -u -r1.72 -r1.73 src/sys/arch/x86/x86/fpu.c Please

CVS commit: src/sys/arch/arm/vfp

2020-07-31 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sat Aug 1 02:13:04 UTC 2020 Modified Files: src/sys/arch/arm/vfp: vfp_init.c Log Message: Add kthread_fpu_enter/exit support to arm. To generate a diff of this commit: cvs rdiff -u -r1.70 -r1.71 src/sys/arch/arm/vfp/vfp_init

CVS commit: src/sys/arch/aarch64/aarch64

2020-07-31 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sat Aug 1 02:06:59 UTC 2020 Modified Files: src/sys/arch/aarch64/aarch64: fpu.c trap.c Log Message: Add kthread_fpu_enter/exit support to aarch64. To generate a diff of this commit: cvs rdiff -u -r1.7 -r1.8 src/sys/arch/aarc

CVS commit: src/sys/kern

2020-07-31 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sat Aug 1 02:05:45 UTC 2020 Modified Files: src/sys/kern: subr_pcu.c Log Message: Teach pcu(9) about LW_SYSTEM_FPU -- kthreads with fpu enabled. To generate a diff of this commit: cvs rdiff -u -r1.22 -r1.23 src/sys/kern/subr

CVS commit: src

2020-07-31 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sat Aug 1 02:04:55 UTC 2020 Modified Files: src/share/man/man9: kthread.9 src/sys/kern: kern_kthread.c kern_stub.c src/sys/sys: kthread.h lwp.h Log Message: New functions kthread_fpu_enter/exit. The MI definit

CVS commit: xsrc/external/mit/xorg-server/dist/hw/sun

2020-07-31 Thread Izumi Tsutsui
Module Name:xsrc Committed By: tsutsui Date: Sat Aug 1 01:49:58 UTC 2020 Modified Files: xsrc/external/mit/xorg-server/dist/hw/sun: sunKbd.c Log Message: Use "empty" for rmlvo model and layout to avoid lingering default settings. Now all modifier keys (CTRL, SHIFT, and N

CVS commit: src/usr.bin/config

2020-07-31 Thread Valeriy E. Ushakov
Module Name:src Committed By: uwe Date: Sat Aug 1 00:35:36 UTC 2020 Modified Files: src/usr.bin/config: config.samples.5 Log Message: Minor formatting tweaks. To generate a diff of this commit: cvs rdiff -u -r1.6 -r1.7 src/usr.bin/config/config.samples.5 Please note th

CVS commit: src/usr.bin/config

2020-07-31 Thread Valeriy E. Ushakov
Module Name:src Committed By: uwe Date: Fri Jul 31 23:55:57 UTC 2020 Modified Files: src/usr.bin/config: config.5 Log Message: Swtich from -ohang to -tag lists. -ohang lists are hard to read b/c long config directives are almost impossible to tell from the following text.

CVS commit: src/usr.bin/config

2020-07-31 Thread Valeriy E. Ushakov
Module Name:src Committed By: uwe Date: Fri Jul 31 23:44:04 UTC 2020 Modified Files: src/usr.bin/config: config.5 Log Message: Missed formatting fixes for "no makeoptions". To generate a diff of this commit: cvs rdiff -u -r1.42 -r1.43 src/usr.bin/config/config.5 Please

CVS commit: src/usr.bin/config

2020-07-31 Thread Valeriy E. Ushakov
Module Name:src Committed By: uwe Date: Fri Jul 31 23:42:21 UTC 2020 Modified Files: src/usr.bin/config: config.5 Log Message: The tale of two makeoptions. There are two forms that were both documented in the selections section, but the form with the condition (and only t

CVS commit: src/usr.bin/config

2020-07-31 Thread Valeriy E. Ushakov
Module Name:src Committed By: uwe Date: Fri Jul 31 23:30:23 UTC 2020 Modified Files: src/usr.bin/config: config.5 Log Message: Formatting improvements. To generate a diff of this commit: cvs rdiff -u -r1.40 -r1.41 src/usr.bin/config/config.5 Please note that diffs are n

CVS commit: src/usr.bin/make/unit-tests

2020-07-31 Thread Roland Illig
Module Name:src Committed By: rillig Date: Fri Jul 31 22:07:28 UTC 2020 Modified Files: src/usr.bin/make/unit-tests: Makefile Log Message: make(1): automate adding or removing test files To generate a diff of this commit: cvs rdiff -u -r1.77 -r1.78 src/usr.bin/make/unit-

CVS commit: src/usr.bin/config

2020-07-31 Thread Valeriy E. Ushakov
Module Name:src Committed By: uwe Date: Fri Jul 31 21:25:34 UTC 2020 Modified Files: src/usr.bin/config: config.5 Log Message: Minor tweak to list formatting. Where necessary, use .Bl -ohang -compact and explicit .Pp to be able to group multiple config directives (separat

CVS commit: src/usr.bin/make

2020-07-31 Thread Roland Illig
Module Name:src Committed By: rillig Date: Fri Jul 31 20:57:39 UTC 2020 Modified Files: src/usr.bin/make: dir.c Log Message: make(1): document another instance of undefined behavior The UNCONST macro is really terrible. This segmentation fault can be forced by setting _P

CVS commit: src/share/wscons/fonts

2020-07-31 Thread Frederic Cambus
Module Name:src Committed By: fcambus Date: Fri Jul 31 20:46:53 UTC 2020 Modified Files: src/share/wscons/fonts: spleen-16x32.fnt.uue spleen-32x64.fnt.uue spleen-8x16.fnt.uue Log Message: Update Spleen wscons fonts to version 1.8.2, bringing the following impro

CVS commit: src/sys/dev/wsfont

2020-07-31 Thread Frederic Cambus
Module Name:src Committed By: fcambus Date: Fri Jul 31 20:39:50 UTC 2020 Modified Files: src/sys/dev/wsfont: spleen16x32.h spleen32x64.h spleen8x16.h Log Message: Update Spleen kernel fonts to version 1.8.2, bringing the following improvements: - Fix size of the lower cas

CVS commit: src/sys/dev/raidframe

2020-07-31 Thread Christos Zoulas
Module Name:src Committed By: christos Date: Fri Jul 31 20:35:34 UTC 2020 Modified Files: src/sys/dev/raidframe: rf_netbsdkintf.c Log Message: no need for continue To generate a diff of this commit: cvs rdiff -u -r1.387 -r1.388 src/sys/dev/raidframe/rf_netbsdkintf.c Ple

CVS commit: src/sys/dev/raidframe

2020-07-31 Thread Christos Zoulas
Module Name:src Committed By: christos Date: Fri Jul 31 20:34:38 UTC 2020 Modified Files: src/sys/dev/raidframe: rf_netbsdkintf.c Log Message: - don't overwrite existing error. - return the error not 0 if failing. To generate a diff of this commit: cvs rdiff -u -r1.386 -

CVS commit: src/usr.bin/make

2020-07-31 Thread Simon J. Gerraty
Module Name:src Committed By: sjg Date: Fri Jul 31 20:22:10 UTC 2020 Modified Files: src/usr.bin/make: main.c make.1 make.h parse.c Log Message: Add -dL for LINT When parsing variable assignments other than := and if value contains '$' attempt Var_Subst the same as for :=

CVS commit: src/usr.bin/make/unit-tests

2020-07-31 Thread Roland Illig
Module Name:src Committed By: rillig Date: Fri Jul 31 20:16:21 UTC 2020 Modified Files: src/usr.bin/make/unit-tests: dir.exp dir.mk Log Message: make(1): add a test for deeply nested brace dependency To generate a diff of this commit: cvs rdiff -u -r1.4 -r1.5 src/usr.bin

CVS commit: src/usr.bin/make/unit-tests

2020-07-31 Thread Roland Illig
Module Name:src Committed By: rillig Date: Fri Jul 31 20:08:08 UTC 2020 Modified Files: src/usr.bin/make/unit-tests: dir.exp dir.mk Log Message: make(1): add more tests for expanding curly braces in dependencies To generate a diff of this commit: cvs rdiff -u -r1.3 -r1.4

CVS commit: src/sys/arch/mips/mips

2020-07-31 Thread Nick Hudson
Module Name:src Committed By: skrll Date: Fri Jul 31 20:04:18 UTC 2020 Modified Files: src/sys/arch/mips/mips: locore.S Log Message: Whitespace / comment alignment To generate a diff of this commit: cvs rdiff -u -r1.224 -r1.225 src/sys/arch/mips/mips/locore.S Please not

CVS commit: src/sys/arch/mips/mips

2020-07-31 Thread Nick Hudson
Module Name:src Committed By: skrll Date: Fri Jul 31 20:03:20 UTC 2020 Modified Files: src/sys/arch/mips/mips: locore.S Log Message: Trailing whitespace To generate a diff of this commit: cvs rdiff -u -r1.223 -r1.224 src/sys/arch/mips/mips/locore.S Please note that diff

CVS commit: src/usr.bin/make

2020-07-31 Thread Roland Illig
Module Name:src Committed By: rillig Date: Fri Jul 31 20:02:44 UTC 2020 Modified Files: src/usr.bin/make: dir.c src/usr.bin/make/unit-tests: dir.exp dir.mk Log Message: make(1): fix regression and add test for empty brace expansion This had been broken in r1.80 of

CVS commit: src/usr.bin/config

2020-07-31 Thread Valeriy E. Ushakov
Module Name:src Committed By: uwe Date: Fri Jul 31 20:01:42 UTC 2020 Modified Files: src/usr.bin/config: config.5 Log Message: Formatting improvements. Only comb through the first few pages (OBJECTS AND NAMES) for now. Use .Em for emphasis, not .Ar (both look the same in

CVS commit: src/usr.bin/make

2020-07-31 Thread Roland Illig
Module Name:src Committed By: rillig Date: Fri Jul 31 19:50:44 UTC 2020 Modified Files: src/usr.bin/make: dir.c Log Message: make(1): refactor DirExpandCurly Separating the low-level parts into small functions reduces the need for summarizing comments between the code lin

CVS commit: xsrc/external/mit

2020-07-31 Thread Maya Rashish
Module Name:xsrc Committed By: maya Date: Fri Jul 31 19:35:22 UTC 2020 Modified Files: xsrc/external/mit/xorg-server.old/dist/dix: pixmap.c xsrc/external/mit/xorg-server/dist/dix: pixmap.c Log Message: Backport the only patch from xorg-server 1.20.9 as I can't find

CVS commit: xsrc/external/mit/libX11/dist

2020-07-31 Thread Maya Rashish
Module Name:xsrc Committed By: maya Date: Fri Jul 31 19:29:52 UTC 2020 Modified Files: xsrc/external/mit/libX11/dist/m4: libtool.m4 xsrc/external/mit/libX11/dist/nls/en_US.UTF-8: Compose.pre xsrc/external/mit/libX11/dist/src: Font.c FontNames.c XlibInt.c Lo

CVS commit: src/sys/dev/raidframe

2020-07-31 Thread Christos Zoulas
Module Name:src Committed By: christos Date: Fri Jul 31 19:30:09 UTC 2020 Modified Files: src/sys/dev/raidframe: rf_netbsdkintf.c Log Message: Factor out the component cache flushing code; add retries. To generate a diff of this commit: cvs rdiff -u -r1.385 -r1.386 src/s

CVS import: xsrc/external/mit/libX11/dist

2020-07-31 Thread Maya Rashish
Module Name:xsrc Committed By: maya Date: Fri Jul 31 19:20:23 UTC 2020 Update of /cvsroot/xsrc/external/mit/libX11/dist In directory ivanova.netbsd.org:/tmp/cvs-serv5152 Log Message: initial import of libX11-1.6.10 Status: Vendor Tag: xorg Release Tags: libX11-1-6-10

CVS commit: src/usr.bin/make

2020-07-31 Thread Roland Illig
Module Name:src Committed By: rillig Date: Fri Jul 31 19:06:33 UTC 2020 Modified Files: src/usr.bin/make: dir.c src/usr.bin/make/unit-tests: dir.exp Log Message: make(1): fix parsing of nested braces in dependency lines Before, make could not parse {{thi,fou}r,fif

CVS commit: src/usr.bin/make

2020-07-31 Thread Roland Illig
Module Name:src Committed By: rillig Date: Fri Jul 31 17:41:35 UTC 2020 Modified Files: src/usr.bin/make: dir.c Log Message: make(1): trying to understand how DirExpandCurly works To generate a diff of this commit: cvs rdiff -u -r1.77 -r1.78 src/usr.bin/make/dir.c Pleas

CVS commit: src/usr.bin/make

2020-07-31 Thread Roland Illig
Module Name:src Committed By: rillig Date: Fri Jul 31 16:59:35 UTC 2020 Modified Files: src/usr.bin/make: dir.c Log Message: make(1): prefer memcpy over strncpy in DirExpandCurly strncpy has unnecessary overhead when the source memory is already guaranteed to contain no '

CVS commit: src/doc

2020-07-31 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Fri Jul 31 16:59:04 UTC 2020 Modified Files: src/doc: TODO.smpnet Log Message: BRIDGE_IPF is MP-safe, discussed with ozaki-r@ To generate a diff of this commit: cvs rdiff -u -r1.37 -r1.38 src/doc/TODO.smpnet Please note that diff

CVS commit: src

2020-07-31 Thread Roland Illig
Module Name:src Committed By: rillig Date: Fri Jul 31 16:42:51 UTC 2020 Modified Files: src/distrib/sets/lists/tests: mi src/usr.bin/make/unit-tests: Makefile Added Files: src/usr.bin/make/unit-tests: dir.exp dir.mk Log Message: make(1): add test for braces

CVS commit: src/usr.bin/make

2020-07-31 Thread Roland Illig
Module Name:src Committed By: rillig Date: Fri Jul 31 16:26:16 UTC 2020 Modified Files: src/usr.bin/make: arch.c Log Message: make(1): use snprintf instead of strncpy strncpy is not suited for string processing, despite its name. Even though the previous code used the co

CVS commit: src/usr.bin/make/unit-tests

2020-07-31 Thread Roland Illig
Module Name:src Committed By: rillig Date: Fri Jul 31 15:16:05 UTC 2020 Modified Files: src/usr.bin/make/unit-tests: moderrs.mk Log Message: make(1): remove outdated comment from unit test It had indeed been undefined behavior and was fixed in var.c r1.359 today in the mo

CVS commit: src/usr.bin/make

2020-07-31 Thread Roland Illig
Module Name:src Committed By: rillig Date: Fri Jul 31 14:59:53 UTC 2020 Modified Files: src/usr.bin/make: var.c Log Message: make(1): mark unmodified part of ApplyModifiersState as constant To generate a diff of this commit: cvs rdiff -u -r1.367 -r1.368 src/usr.bin/make/

CVS commit: src/usr.bin/make

2020-07-31 Thread Roland Illig
Module Name:src Committed By: rillig Date: Fri Jul 31 14:54:03 UTC 2020 Modified Files: src/usr.bin/make: var.c Log Message: make(1): reduce number of parameters to ApplyModifiers This saves a call to strlen and some arithmetic operations. To generate a diff of this com

CVS commit: src/usr.bin/make/unit-tests

2020-07-31 Thread Roland Illig
Module Name:src Committed By: rillig Date: Fri Jul 31 14:36:58 UTC 2020 Modified Files: src/usr.bin/make/unit-tests: modmisc.exp modmisc.mk Log Message: make(1): add test for chaining the :S modifier without colon To generate a diff of this commit: cvs rdiff -u -r1.32 -r

CVS commit: src/usr.bin/make

2020-07-31 Thread Roland Illig
Module Name:src Committed By: rillig Date: Fri Jul 31 14:26:22 UTC 2020 Modified Files: src/usr.bin/make: var.c Log Message: make(1): clean up Var_Parse If *freePtr is not NULL, it only makes sense to free that pointer and not a semmingly unrelated variable. To generate

CVS commit: src/usr.bin/make

2020-07-31 Thread Roland Illig
Module Name:src Committed By: rillig Date: Fri Jul 31 14:11:21 UTC 2020 Modified Files: src/usr.bin/make: var.c Log Message: make(1): remove some redundant parentheses To generate a diff of this commit: cvs rdiff -u -r1.364 -r1.365 src/usr.bin/make/var.c Please note tha

CVS commit: src/usr.bin/make

2020-07-31 Thread Roland Illig
Module Name:src Committed By: rillig Date: Fri Jul 31 14:07:21 UTC 2020 Modified Files: src/usr.bin/make: var.c Log Message: make(1): omit unnecessary memory writes in :tu and :tl modifiers To generate a diff of this commit: cvs rdiff -u -r1.363 -r1.364 src/usr.bin/make/

CVS commit: src/usr.bin/make

2020-07-31 Thread Roland Illig
Module Name:src Committed By: rillig Date: Fri Jul 31 13:56:19 UTC 2020 Modified Files: src/usr.bin/make: var.c Log Message: make(1): fix undefined behavior when parsing incomplete :t modifier mod[2] must only ever be accessed if mod[1] != '\0'. To generate a diff of th

CVS commit: src/usr.bin/make/unit-tests

2020-07-31 Thread Roland Illig
Module Name:src Committed By: rillig Date: Fri Jul 31 13:49:25 UTC 2020 Modified Files: src/usr.bin/make/unit-tests: moderrs.exp moderrs.mk Log Message: make(1): add test for parsing an incomplete :t modifier This looks a lot like undefined behavior, just like in :S and :

CVS commit: src/usr.bin/make

2020-07-31 Thread Roland Illig
Module Name:src Committed By: rillig Date: Fri Jul 31 13:43:44 UTC 2020 Modified Files: src/usr.bin/make: var.c Log Message: make(1): reduce scope of local variables in ApplyModifier_Subst To generate a diff of this commit: cvs rdiff -u -r1.361 -r1.362 src/usr.bin/make/v

CVS commit: src/usr.bin/make

2020-07-31 Thread Roland Illig
Module Name:src Committed By: rillig Date: Fri Jul 31 13:39:15 UTC 2020 Modified Files: src/usr.bin/make: var.c Log Message: make(1): reduce scope of local variables in ApplyModifier_Regex To generate a diff of this commit: cvs rdiff -u -r1.360 -r1.361 src/usr.bin/make/v

CVS commit: src/usr.bin/make

2020-07-31 Thread Roland Illig
Module Name:src Committed By: rillig Date: Fri Jul 31 13:30:09 UTC 2020 Modified Files: src/usr.bin/make: var.c src/usr.bin/make/unit-tests: moderrs.exp moderrs.mk Log Message: make(1): fix undefined behavior when parsing malformed :C modifier Same as in the :S mo

CVS commit: src/sys/dev/pci

2020-07-31 Thread Shoichi YAMAGUCHI
Module Name:src Committed By: yamaguchi Date: Fri Jul 31 09:34:34 UTC 2020 Modified Files: src/sys/dev/pci: if_ixl.c Log Message: Use if_initialize() and if_register() To generate a diff of this commit: cvs rdiff -u -r1.70 -r1.71 src/sys/dev/pci/if_ixl.c Please note tha

CVS commit: src/sys/dev/pci

2020-07-31 Thread Shoichi YAMAGUCHI
Module Name:src Committed By: yamaguchi Date: Fri Jul 31 09:25:42 UTC 2020 Modified Files: src/sys/dev/pci: if_ixl.c Log Message: Added sysctl nodes for the number of descriptors in ixl(4) To generate a diff of this commit: cvs rdiff -u -r1.69 -r1.70 src/sys/dev/pci/if_i

CVS commit: src/sys/dev/pci

2020-07-31 Thread Shoichi YAMAGUCHI
Module Name:src Committed By: yamaguchi Date: Fri Jul 31 09:07:17 UTC 2020 Modified Files: src/sys/dev/pci: if_ixl.c Log Message: Added sysctl nodes for ixl(4) Interrupt throttling(ITR) To generate a diff of this commit: cvs rdiff -u -r1.68 -r1.69 src/sys/dev/pci/if_ixl.

CVS commit: src/sys/arch/mips/include

2020-07-31 Thread Simon Burge
Module Name:src Committed By: simonb Date: Fri Jul 31 08:54:09 UTC 2020 Modified Files: src/sys/arch/mips/include: locore.h Log Message: Fix a tyop. Thankfully this #define was unused. To generate a diff of this commit: cvs rdiff -u -r1.112 -r1.113 src/sys/arch/mips/inc

CVS commit: src/sys/arch/mips/mips

2020-07-31 Thread Simon Burge
Module Name:src Committed By: simonb Date: Fri Jul 31 08:06:33 UTC 2020 Modified Files: src/sys/arch/mips/mips: mips_machdep.c Log Message: Fix TLB count probe on MIPS32R2+/MIPS64R2+ for CPUs that have a Config4 register with a Config4[MMUExtDef] value. To generate a dif

CVS commit: src/usr.bin/make

2020-07-31 Thread Roland Illig
Module Name:src Committed By: rillig Date: Fri Jul 31 07:29:21 UTC 2020 Modified Files: src/usr.bin/make: Makefile var.c src/usr.bin/make/unit-tests: moderrs.exp Log Message: make(1): fix undefined behavior in malformed :S modifier The unit tests failed on Ubuntu,