CVS commit: src/sys/dev/usb

2020-03-31 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Tue Mar 31 16:34:25 UTC 2020 Modified Files: src/sys/dev/usb: vhci.c vhci.h Log Message: Publish the request/response structures too. To generate a diff of this commit: cvs rdiff -u -r1.15 -r1.16 src/sys/dev/usb/vhci.c cvs rdiff -

CVS commit: src

2020-03-31 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Tue Mar 31 16:28:29 UTC 2020 Modified Files: src/distrib/sets/lists/comp: mi src/sys/dev/usb: Makefile vhci.c Added Files: src/sys/dev/usb: vhci.h Log Message: Put the ioctl definitions in a header, and install it.

CVS commit: src/sys/dev/usb

2020-03-31 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Tue Mar 31 16:17:32 UTC 2020 Modified Files: src/sys/dev/usb: vhci.c Log Message: Allow short transfers. We introduce a third packet, in the U->H list, that contains a vhci_response_t, which indicates the size. To generate a diff

CVS commit: src/sys/dev/usb

2020-03-29 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sun Mar 29 09:46:14 UTC 2020 Modified Files: src/sys/dev/usb: vhci.c Log Message: store the request buffer in the vxfer instead of the packet, clearer To generate a diff of this commit: cvs rdiff -u -r1.12 -r1.13 src/sys/dev/usb/v

CVS commit: src/sys/dev/usb

2020-03-24 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Tue Mar 24 17:20:55 UTC 2020 Modified Files: src/sys/dev/usb: vhci.c Log Message: Remove the argument from USB_{ATTACH,DETACH}, for consistency. To generate a diff of this commit: cvs rdiff -u -r1.11 -r1.12 src/sys/dev/usb/vhci.c

CVS commit: src/sys/dev/usb

2020-03-24 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Tue Mar 24 07:12:16 UTC 2020 Modified Files: src/sys/dev/usb: if_umb.c Log Message: Fix type confusion. Found by kASan when doing a normal attach+detach over vHCI. To generate a diff of this commit: cvs rdiff -u -r1.18 -r1.19 src/

CVS commit: src/sys/dev/usb

2020-03-24 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Tue Mar 24 07:11:07 UTC 2020 Modified Files: src/sys/dev/usb: vhci.c Log Message: Use a vhci_request_t, will be required for future changes. To generate a diff of this commit: cvs rdiff -u -r1.10 -r1.11 src/sys/dev/usb/vhci.c Ple

CVS commit: src/sys/dev/usb

2020-03-22 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sun Mar 22 17:15:16 UTC 2020 Modified Files: src/sys/dev/usb: vhci.c Log Message: Add internal support for multiple endpoints. To generate a diff of this commit: cvs rdiff -u -r1.9 -r1.10 src/sys/dev/usb/vhci.c Please note that d

CVS commit: src/sys/dev/usb

2020-03-22 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sun Mar 22 15:14:03 UTC 2020 Modified Files: src/sys/dev/usb: vhci.c Log Message: clarify and explain To generate a diff of this commit: cvs rdiff -u -r1.8 -r1.9 src/sys/dev/usb/vhci.c Please note that diffs are not public domain

CVS commit: src/sys/arch

2020-03-17 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Tue Mar 17 17:18:49 UTC 2020 Modified Files: src/sys/arch/amd64/include: cpu.h param.h pcb.h types.h src/sys/arch/x86/x86: vm_machdep.c Log Message: Add a redzone between the pcb and the stack. Sent to port-amd64@. To gene

CVS commit: src/sys/arch/x86/x86

2020-03-13 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sat Mar 14 05:19:50 UTC 2020 Modified Files: src/sys/arch/x86/x86: pmap.c Log Message: On amd64, mark the whole tree as NX. No real functional change, just to prevent possible future surprises, and to make it a little harder to map

CVS commit: src/sys/arch/x86/include

2020-03-13 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sat Mar 14 04:55:15 UTC 2020 Modified Files: src/sys/arch/x86/include: pte.h trap.h Log Message: style To generate a diff of this commit: cvs rdiff -u -r1.3 -r1.4 src/sys/arch/x86/include/pte.h cvs rdiff -u -r1.2 -r1.3 src/sys/arc

CVS commit: src/sys/dev/bluetooth

2020-03-13 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sat Mar 14 04:49:33 UTC 2020 Modified Files: src/sys/dev/bluetooth: btkbd.c Log Message: fix memory leaks To generate a diff of this commit: cvs rdiff -u -r1.18 -r1.19 src/sys/dev/bluetooth/btkbd.c Please note that diffs are not

CVS commit: src/sys/compat/netbsd32

2020-03-13 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sat Mar 14 04:39:15 UTC 2020 Modified Files: src/sys/compat/netbsd32: netbsd32_ioctl.c Log Message: wrong size passed to copyout To generate a diff of this commit: cvs rdiff -u -r1.109 -r1.110 src/sys/compat/netbsd32/netbsd32_ioct

CVS commit: src/sys/netbt

2020-02-29 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sat Feb 29 11:40:06 UTC 2020 Modified Files: src/sys/netbt: l2cap_signal.c rfcomm_session.c Log Message: pass the address of the field, instead of relying on it being the first field of the structure/union, no functional change, dis

CVS commit: src/sys/ufs/ufs

2020-02-26 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Wed Feb 26 18:00:12 UTC 2020 Modified Files: src/sys/ufs/ufs: ufs_vnops.c Log Message: Zero out the padding in 'd_namlen', to prevent info leaks. Same logic as ufs_makedirentry(). Found by kMSan: the unzeroed bytes of the pool_cach

CVS commit: src/sys/arch/x86/x86

2020-02-22 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sat Feb 22 20:12:40 UTC 2020 Modified Files: src/sys/arch/x86/x86: x86_tlb.c Log Message: add relaxed atomics, ok ad@ riastradh@ To generate a diff of this commit: cvs rdiff -u -r1.15 -r1.16 src/sys/arch/x86/x86/x86_tlb.c Please

CVS commit: src/sys/kern

2020-02-22 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sat Feb 22 20:08:39 UTC 2020 Modified Files: src/sys/kern: subr_msan.c Log Message: Be less strict: when copyinstr() returns ENAMETOOLONG, it does initialize the buffer, so mark it as such. To generate a diff of this commit: cvs r

CVS commit: src/sys/compat/common

2020-02-22 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sat Feb 22 09:42:20 UTC 2020 Modified Files: src/sys/compat/common: uipc_syscalls_40.c Log Message: pass the address of the field, instead of relying on it being the first field of the structure, no functional change To generate a

CVS commit: src/sys/net

2020-02-22 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sat Feb 22 09:30:42 UTC 2020 Modified Files: src/sys/net: rtsock_shared.c Log Message: pass the address of the field, instead of relying on it being the first field of the structure, no functional change To generate a diff of this

CVS commit: src/sys/kern

2020-02-22 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sat Feb 22 09:24:05 UTC 2020 Modified Files: src/sys/kern: sys_ptrace_common.c Log Message: pass the address of the field, instead of relying on it being the first field of the structure, no functional change, ok kamil To generate

CVS commit: src/sys/kern

2020-02-22 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sat Feb 22 08:58:39 UTC 2020 Modified Files: src/sys/kern: vfs_syscalls.c Log Message: Inline the block in the parent block, for clarity, and also to prevent a false positive with kMSan. Here, LLVM reorders the conditions and check

CVS commit: src/sys/kern

2020-02-22 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sat Feb 22 08:39:33 UTC 2020 Modified Files: src/sys/kern: uipc_socket.c Log Message: Zero out 'tv', to prevent uninitialized bytes in its padding from leaking to userland. Found by kMSan. Reported-by: syzbot+8134380511a82c8f5...@s

CVS commit: src/sys/arch/x86/x86

2020-02-21 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Fri Feb 21 18:34:37 UTC 2020 Modified Files: src/sys/arch/x86/x86: pmap.c Log Message: In pmap_changeprot_local(), drop the dirty bit along with the write bit. To generate a diff of this commit: cvs rdiff -u -r1.356 -r1.357 src/sy

CVS commit: src/sys/arch/x86/x86

2020-02-21 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Fri Feb 21 18:31:56 UTC 2020 Modified Files: src/sys/arch/x86/x86: pmap.c Log Message: Add comments. To generate a diff of this commit: cvs rdiff -u -r1.355 -r1.356 src/sys/arch/x86/x86/pmap.c Please note that diffs are not publi

CVS commit: src/sys/dev/usb

2020-02-16 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sun Feb 16 09:53:55 UTC 2020 Modified Files: src/sys/dev/usb: usbdi_util.c Log Message: Improve the check, to prevent more surprises. To generate a diff of this commit: cvs rdiff -u -r1.80 -r1.81 src/sys/dev/usb/usbdi_util.c Plea

CVS commit: src/sys/dev/usb

2020-02-16 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sun Feb 16 09:40:35 UTC 2020 Modified Files: src/sys/dev/usb: usbdi.c usbdi.h usbdi_util.c usbdi_util.h Log Message: Move usb_desc_* into usbdi_util.c, no functional change. To generate a diff of this commit: cvs rdiff -u -r1.192

CVS commit: src/sys/arch/amd64/stand/prekern

2020-02-15 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sat Feb 15 10:41:25 UTC 2020 Modified Files: src/sys/arch/amd64/stand/prekern: mm.c Log Message: Explain more. To generate a diff of this commit: cvs rdiff -u -r1.24 -r1.25 src/sys/arch/amd64/stand/prekern/mm.c Please note that d

CVS commit: src

2020-02-09 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sun Feb 9 12:19:01 UTC 2020 Modified Files: src/lib/libnvmm: libnvmm.3 src/share/man/man4: nvmm.4 Log Message: Reference nvmmctl(8). To generate a diff of this commit: cvs rdiff -u -r1.25 -r1.26 src/lib/libnvmm/libnvmm.3

CVS commit: src/sys

2020-02-08 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sat Feb 8 09:05:08 UTC 2020 Modified Files: src/sys/kern: subr_asan.c src/sys/sys: asan.h Log Message: Sync the codes with reality: partial replaced by mid, and use-after-ret added. To generate a diff of this commit: cvs

CVS commit: src/sys/dev/usb

2020-02-08 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sat Feb 8 08:47:27 UTC 2020 Modified Files: src/sys/dev/usb: usb_subr.c usbdi_util.c usbdi_util.h usbdivar.h Log Message: Move three functions into usbdi_util.c, where they belong. No functional change. To generate a diff of this

CVS commit: src/sys/dev/usb

2020-02-08 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sat Feb 8 08:18:06 UTC 2020 Modified Files: src/sys/dev/usb: usbdi_util.c usbdi_util.h Log Message: Reorder usbdi_util.{c,h}, for clarity. No functional change. To generate a diff of this commit: cvs rdiff -u -r1.76 -r1.77 src/sy

CVS commit: src/sys/dev/usb

2020-02-07 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sat Feb 8 07:57:16 UTC 2020 Modified Files: src/sys/dev/usb: usbdi.c Log Message: Dedup usb_desc_iter_next with usb_desc_iter_peek. To generate a diff of this commit: cvs rdiff -u -r1.188 -r1.189 src/sys/dev/usb/usbdi.c Please n

CVS commit: src/sys/dev/usb

2020-02-07 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sat Feb 8 07:53:24 UTC 2020 Modified Files: src/sys/dev/usb: u3g.c uhmodem.c usbdi.c usbdi_util.c usbdi_util.h Log Message: Introduce usbd_clear_endpoint_feature(), and dedup. To generate a diff of this commit: cvs rdiff -u -r1.3

CVS commit: src/sys/dev/usb

2020-02-07 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sat Feb 8 07:38:17 UTC 2020 Modified Files: src/sys/dev/usb: usbdi.c usbdi.h uvideo.c Log Message: Move uvideo's parsers into usbdi.c, to make them global. Rename usb_desc_iter_peek_next -> usb_desc_iter_peek for consistency. To

CVS commit: src/sys/dev/pci

2020-02-07 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sat Feb 8 07:24:46 UTC 2020 Modified Files: src/sys/dev/pci: if_alc.c if_alcreg.h Log Message: constify To generate a diff of this commit: cvs rdiff -u -r1.48 -r1.49 src/sys/dev/pci/if_alc.c cvs rdiff -u -r1.8 -r1.9 src/sys/dev/p

CVS commit: src/sys/dev/pci

2020-02-07 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sat Feb 8 07:20:41 UTC 2020 Modified Files: src/sys/dev/pci: if_jme.c Log Message: localify To generate a diff of this commit: cvs rdiff -u -r1.48 -r1.49 src/sys/dev/pci/if_jme.c Please note that diffs are not public domain; the

CVS commit: src/sys/dev/pci

2020-02-07 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sat Feb 8 07:19:09 UTC 2020 Modified Files: src/sys/dev/pci: if_aq.c Log Message: constify To generate a diff of this commit: cvs rdiff -u -r1.7 -r1.8 src/sys/dev/pci/if_aq.c Please note that diffs are not public domain; they ar

CVS commit: src

2020-02-07 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sat Feb 8 07:07:07 UTC 2020 Modified Files: src/share/man/man4: options.4 src/share/mk: bsd.sys.mk src/sys/arch/amd64/conf: ALL GENERIC src/sys/arch/amd64/include: param.h src/sys/conf: files ssp.mk

CVS commit: src/sys/arch/aarch64

2020-01-31 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Fri Jan 31 09:23:58 UTC 2020 Modified Files: src/sys/arch/aarch64/aarch64: trap.c src/sys/arch/aarch64/include: armreg.h pte.h Log Message: BTI definitions. To generate a diff of this commit: cvs rdiff -u -r1.24 -r1.25 src

CVS commit: src/sys/arch/aarch64/aarch64

2020-01-31 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Fri Jan 31 09:08:57 UTC 2020 Modified Files: src/sys/arch/aarch64/aarch64: netbsd32_machdep.c Log Message: D means E here (aarch32), so don't check it. A-I-F are checked below already, so drop the whole line. To generate a diff of

CVS commit: src/sys/compat

2020-01-31 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Fri Jan 31 09:01:23 UTC 2020 Modified Files: src/sys/compat/common: vfs_syscalls_30.c src/sys/compat/netbsd32: netbsd32_compat_30.c netbsd32_fs.c Log Message: Fix copyout overflows in fhstat, found by the LGTM bot. Not a big

CVS commit: src/sys/arch/x86/x86

2020-01-31 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Fri Jan 31 08:55:38 UTC 2020 Modified Files: src/sys/arch/x86/x86: dbregs.c fpu.c spectre.c svs.c Log Message: 'oldlwp' is never NULL now, so remove the NULL checks. To generate a diff of this commit: cvs rdiff -u -r1.14 -r1.15 sr

CVS commit: src/sys/kern

2020-01-31 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Fri Jan 31 08:26:11 UTC 2020 Modified Files: src/sys/kern: subr_msan.c Log Message: Be more informative. To generate a diff of this commit: cvs rdiff -u -r1.6 -r1.7 src/sys/kern/subr_msan.c Please note that diffs are not public d

CVS commit: src/sys/arch

2020-01-31 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Fri Jan 31 08:21:11 UTC 2020 Modified Files: src/sys/arch/amd64/amd64: machdep.c src/sys/arch/i386/i386: machdep.c mtrr_k6.c src/sys/arch/x86/include: mtrr.h src/sys/arch/x86/x86: mtrr_i686.c Log Message: con

CVS commit: src/sys/arch/aarch64/include

2020-01-28 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Tue Jan 28 18:02:30 UTC 2020 Modified Files: src/sys/arch/aarch64/include: armreg.h Log Message: More SCTLR. To generate a diff of this commit: cvs rdiff -u -r1.33 -r1.34 src/sys/arch/aarch64/include/armreg.h Please note that dif

CVS commit: src/sys/arch/aarch64

2020-01-28 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Tue Jan 28 17:47:51 UTC 2020 Modified Files: src/sys/arch/aarch64/aarch64: cpu.c src/sys/arch/aarch64/include: armreg.h Log Message: Fetch ID_AA64MMFR2_EL1. Okayed by Nick the other day. To generate a diff of this commit:

CVS commit: src/usr.sbin/cpuctl/arch

2020-01-28 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Tue Jan 28 17:36:42 UTC 2020 Modified Files: src/usr.sbin/cpuctl/arch: aarch64.c Log Message: More identification. To generate a diff of this commit: cvs rdiff -u -r1.7 -r1.8 src/usr.sbin/cpuctl/arch/aarch64.c Please note that di

CVS commit: src/sys/arch/aarch64

2020-01-28 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Tue Jan 28 17:33:07 UTC 2020 Modified Files: src/sys/arch/aarch64/aarch64: genassym.cf locore.S src/sys/arch/aarch64/include: armreg.h Log Message: Jazelle and T32EE are not part of ARMv8, fix the bits to their real meanings

CVS commit: src/sys/arch/aarch64/include

2020-01-28 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Tue Jan 28 17:23:30 UTC 2020 Modified Files: src/sys/arch/aarch64/include: armreg.h Log Message: More definitions. To generate a diff of this commit: cvs rdiff -u -r1.30 -r1.31 src/sys/arch/aarch64/include/armreg.h Please note th

CVS commit: src/sys/dev/videomode

2020-01-25 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sat Jan 25 15:59:11 UTC 2020 Modified Files: src/sys/dev/videomode: edid.c Log Message: Fix uninitialized variable. There may not be a TYPE_ASCII block. Found by kMSan with nouveau. To generate a diff of this commit: cvs rdiff -u

CVS commit: src/sys/kern

2020-01-25 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sat Jan 25 15:55:33 UTC 2020 Modified Files: src/sys/kern: subr_asan.c subr_msan.c Log Message: Actually, uio_vmspace is never NULL, the check should be against pmap_kernel. To generate a diff of this commit: cvs rdiff -u -r1.16 -

CVS commit: src/sys/dev/nvmm/x86

2020-01-09 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Thu Jan 9 16:27:57 UTC 2020 Modified Files: src/sys/dev/nvmm/x86: nvmm_x86_vmx.c Log Message: Registering the host's CR0 is done outside of the VCPU loop, so it must be cleared because it is also cleared inside the loop. Not clear

CVS commit: src/sys/dev/nvmm/x86

2020-01-09 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Thu Jan 9 16:20:12 UTC 2020 Modified Files: src/sys/dev/nvmm/x86: nvmm_x86_vmx.c Log Message: Mmh, as noted in PR/54847, this should be uint64_t, not uint16_t. Harmless because we use only the two lowest bits anyway. I believe thi

CVS commit: src/sys/dev/usb

2020-01-06 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Tue Jan 7 06:42:26 UTC 2020 Modified Files: src/sys/dev/usb: if_aue.c if_axe.c if_axen.c if_cdce.c if_cue.c if_kue.c if_mos.c if_mue.c if_smsc.c if_udav.c if_upl.c if_ure.c if_url.c if_urndis.c u3g.c uark.c u

CVS commit: src/sys/netsmb

2020-01-06 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Tue Jan 7 06:14:43 UTC 2020 Modified Files: src/sys/netsmb: smb_smb.c Log Message: Set 'ntencpass' to NULL as part of 'again', to prevent use-after-free. To generate a diff of this commit: cvs rdiff -u -r1.34 -r1.35 src/sys/netsm

CVS commit: src/sys/dev/ic

2020-01-06 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Tue Jan 7 06:12:09 UTC 2020 Modified Files: src/sys/dev/ic: mfi.c Log Message: Set 'ld_sync' to NULL as part of 'again', to prevent use-after-free. To generate a diff of this commit: cvs rdiff -u -r1.62 -r1.63 src/sys/dev/ic/mfi.

CVS commit: src/sys/dev/raidframe

2020-01-06 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Tue Jan 7 06:10:19 UTC 2020 Modified Files: src/sys/dev/raidframe: rf_compat32.c Log Message: Fix big bugs. To generate a diff of this commit: cvs rdiff -u -r1.7 -r1.8 src/sys/dev/raidframe/rf_compat32.c Please note that diffs a

CVS commit: src/sys/netinet6

2020-01-03 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Fri Jan 3 08:53:14 UTC 2020 Modified Files: src/sys/netinet6: ip6_mroute.c Log Message: Don't forget to initialize 'sin6_len'. With kASan, from time to time the value will be bigger than the size of the source, and we get a read ov

CVS commit: src/sys/dev/usb

2020-01-02 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Thu Jan 2 08:08:30 UTC 2020 Modified Files: src/sys/dev/usb: umidi.c Log Message: Remove the call to KERNEL_UNLOCK_ONE(), it was forgotten when the biglock was dropped in rev1.63. Found via vHCI. To generate a diff of this commit

CVS commit: src/sys/compat

2020-01-01 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Wed Jan 1 14:52:38 UTC 2020 Modified Files: src/sys/compat/common: kern_sig_43.c src/sys/compat/netbsd32: netbsd32_compat_20.c netbsd32_compat_50.c Log Message: Fix three stack info leaks, found by kMSan when just invoking

CVS commit: src/sys/dev/hid

2020-01-01 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Wed Jan 1 09:40:17 UTC 2020 Modified Files: src/sys/dev/hid: hid.c Log Message: Fix small read overflows when parsing HID tables. Noticed by kASan the other day while I was playing with vHCI. To generate a diff of this commit: cv

CVS commit: src/sys/compat/netbsd32

2020-01-01 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Wed Jan 1 09:17:45 UTC 2020 Modified Files: src/sys/compat/netbsd32: netbsd32_compat_43.c Log Message: Fix sizeof mismatch in copyin. This leads to a user-triggerable stack overflow. On my test build at least, by luck, the compiler

CVS commit: src/sys/dev/usb

2020-01-01 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Wed Jan 1 09:08:28 UTC 2020 Modified Files: src/sys/dev/usb: ucycom.c Log Message: Fix buffer overflows: validate the lengths at attach time, given that they are apparently not supposed to be variable. Drop sc_ilen since it is unus

CVS commit: src/sys/dev/usb

2020-01-01 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Wed Jan 1 09:05:03 UTC 2020 Modified Files: src/sys/dev/usb: uhid.c Log Message: Fix buffer overflows. Also add missing mutex_exit. To generate a diff of this commit: cvs rdiff -u -r1.110 -r1.111 src/sys/dev/usb/uhid.c Please no

CVS commit: src/sys/dev/usb

2020-01-01 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Wed Jan 1 09:03:00 UTC 2020 Modified Files: src/sys/dev/usb: uthum.c Log Message: Fix buffer overflows. sc_{o,f}len are controlled by the USB device. By crafting the former the device can leak stack data. By crafting the latter the

CVS commit: src/sys/kern

2019-12-27 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Fri Dec 27 15:49:20 UTC 2019 Modified Files: src/sys/kern: subr_pool.c Log Message: Switch to panic, and make the message more useful. To generate a diff of this commit: cvs rdiff -u -r1.263 -r1.264 src/sys/kern/subr_pool.c Pleas

CVS commit: src

2019-12-22 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Mon Dec 23 06:45:38 UTC 2019 Modified Files: src/distrib/sets/lists/base: mi src/distrib/sets/lists/comp: mi src/distrib/sets/lists/man: mi src/etc: MAKEDEV.tmpl src/etc/mtree: NetBSD.dist.base

CVS commit: src/usr.bin/make

2019-12-18 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Thu Dec 19 07:14:07 UTC 2019 Modified Files: src/usr.bin/make: Makefile compat.c make.1 meta.c Log Message: Revert the filemon removal in bmake, as pointed out by maya we do care about not introducing divergence with FreeBSD, and th

CVS commit: src

2019-12-17 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Wed Dec 18 07:37:19 UTC 2019 Modified Files: src/distrib/sets/lists/base: mi src/distrib/sets/lists/comp: mi src/distrib/sets/lists/man: mi src/etc: MAKEDEV.tmpl src/etc/mtree: NetBSD.dist.base

CVS commit: src/sys/arch/amd64/conf

2019-12-13 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sat Dec 14 07:45:20 UTC 2019 Modified Files: src/sys/arch/amd64/conf: GENERIC Log Message: Disable multiboot for now, too much breakage. To generate a diff of this commit: cvs rdiff -u -r1.550 -r1.551 src/sys/arch/amd64/conf/GENER

CVS commit: src/sys/net

2019-12-13 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Fri Dec 13 14:13:55 UTC 2019 Modified Files: src/sys/net: if_tun.c Log Message: Read the len before pushing the packet, otherwise possible use-after-free. Found by a custom query on LGTM. To generate a diff of this commit: cvs rdi

CVS commit: src/sys/dev/usb

2019-12-13 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Fri Dec 13 14:10:32 UTC 2019 Modified Files: src/sys/dev/usb: if_urtwn.c Log Message: Fix gross use-after-free. Found by a custom query on LGTM. To generate a diff of this commit: cvs rdiff -u -r1.77 -r1.78 src/sys/dev/usb/if_urtw

CVS commit: src/sys/arch/x86/x86

2019-12-12 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Thu Dec 12 16:49:20 UTC 2019 Modified Files: src/sys/arch/x86/x86: spectre.c Log Message: Check CPUID.IBRS in addition to ARCH_CAP.IBRS_ALL. For clarity, and also because VirtualBox clears the former but forgets to clear the latter

CVS commit: src/sys

2019-12-08 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sun Dec 8 11:53:54 UTC 2019 Modified Files: src/sys/arch/amd64/include: cpu.h src/sys/kern: subr_msan.c Log Message: Use the inlines; it is actually fine, since the compiler drops the inlines if the caller is kmsan-instrume

CVS commit: src/sys/sys

2019-12-08 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sun Dec 8 11:48:15 UTC 2019 Modified Files: src/sys/sys: cdefs.h Log Message: Fix __nomsan: missing opt_kmsan.h, and the attribute should be kernel-memory. To generate a diff of this commit: cvs rdiff -u -r1.149 -r1.150 src/sys/s

CVS commit: src/sys/arch/amd64/amd64

2019-12-07 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sat Dec 7 10:19:35 UTC 2019 Modified Files: src/sys/arch/amd64/amd64: amd64_trap.S Log Message: Panic instead of printf, same as syscall. To generate a diff of this commit: cvs rdiff -u -r1.50 -r1.51 src/sys/arch/amd64/amd64/amd6

CVS commit: src/sys/kern

2019-12-06 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Fri Dec 6 16:54:47 UTC 2019 Modified Files: src/sys/kern: subr_msan.c Log Message: cast to proper type To generate a diff of this commit: cvs rdiff -u -r1.3 -r1.4 src/sys/kern/subr_msan.c Please note that diffs are not public do

CVS commit: src/sys

2019-12-06 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Fri Dec 6 08:35:21 UTC 2019 Modified Files: src/sys/arch/amd64/amd64: machdep.c src/sys/compat/common: compat_sysctl_09_43.c src/sys/kern: tty_subr.c Log Message: Fix a bunch of unimportant "Local variable hides glo

CVS commit: src/sys

2019-12-05 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Fri Dec 6 07:27:07 UTC 2019 Modified Files: src/sys/dev/acpi: acpi_pci_link.c src/sys/dev/pci: auich.c src/sys/kern: uipc_mbuf.c Log Message: Minor changes, reported by the LGTM bot. To generate a diff of this com

CVS commit: src/sys/dev

2019-12-05 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Fri Dec 6 07:12:39 UTC 2019 Modified Files: src/sys/dev/gpio: gpioow.c src/sys/dev/ic: smc91cxx.c smc91cxxvar.h src/sys/dev/pci: if_txp.c src/sys/dev/pcmcia: if_cnw.c src/sys/dev/usb: uhidev.c uirda.c

CVS commit: src/sys/dev

2019-12-01 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sun Dec 1 12:47:10 UTC 2019 Modified Files: src/sys/dev/pci: if_msk.c src/sys/dev/usb: if_atu.c uhid.c ustir.c Log Message: minor adjustments, to avoid warnings on debug builds To generate a diff of this commit: cvs rdiff

CVS commit: src/sys/dev/usb

2019-12-01 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sun Dec 1 08:27:54 UTC 2019 Modified Files: src/sys/dev/usb: if_ural.c uaudio.c uberry.c ubt.c ucycom.c udsbr.c uep.c ugen.c uhid.c uhso.c ulpt.c umidi.c ums.c urio.c usscanner.c ustir.c uthum.c utoppy.c uvid

CVS commit: src/sys/arch/x86

2019-12-01 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sun Dec 1 08:23:09 UTC 2019 Modified Files: src/sys/arch/x86/include: i82489var.h src/sys/arch/x86/x86: lapic.c Log Message: localify To generate a diff of this commit: cvs rdiff -u -r1.19 -r1.20 src/sys/arch/x86/include/

CVS commit: src/sys/uvm

2019-12-01 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sun Dec 1 08:19:09 UTC 2019 Modified Files: src/sys/uvm: uvm_fault.c Log Message: Use atomic_{load,store}_relaxed() on global counters. To generate a diff of this commit: cvs rdiff -u -r1.208 -r1.209 src/sys/uvm/uvm_fault.c Plea

CVS commit: src/sys

2019-12-01 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sun Dec 1 08:15:58 UTC 2019 Modified Files: src/sys/kern: subr_csan.c src/sys/sys: atomic.h Log Message: Add KCSAN instrumentation for atomic_{load,store}_*. To generate a diff of this commit: cvs rdiff -u -r1.5 -r1.6 src

CVS commit: src/sys/arch/x86/x86

2019-05-10 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Fri May 10 18:21:01 UTC 2019 Modified Files: src/sys/arch/x86/x86: cpu_ucode_intel.c Log Message: Clean up, and add sanity checks on the microcode lengths. To generate a diff of this commit: cvs rdiff -u -r1.16 -r1.17 src/sys/arch

CVS commit: src/sys/arch/x86/x86

2019-05-09 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Thu May 9 18:53:14 UTC 2019 Modified Files: src/sys/arch/x86/x86: cpu_ucode_intel.c Log Message: Invalidate the cache before updating the microcode. Some platforms require this. Seen in Illumos and FreeBSD. To generate a diff of

CVS commit: src/sys/kern

2019-05-04 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sat May 4 17:19:10 UTC 2019 Modified Files: src/sys/kern: subr_asan.c Log Message: Rewrite kasan_mark() to fix a still existing race in pool_cache_get_paddr() that could cause false positives. Now a buffer initially valid remains v

CVS commit: src/sys

2019-05-04 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sat May 4 10:07:11 UTC 2019 Modified Files: src/sys/kern: subr_asan.c src/sys/sys: systm.h Log Message: Add KASAN instrumentation for kcopy and copystr. To generate a diff of this commit: cvs rdiff -u -r1.7 -r1.8 src/sys/

CVS commit: src/sys/arch

2019-05-04 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sat May 4 08:50:39 UTC 2019 Modified Files: src/sys/arch/amd64/amd64: copy.S src/sys/arch/i386/i386: copy.S Log Message: Hum. Fix a potentially catastrophic bug: kcopy() sets DF=1 if the areas overlap, but doesn't clear it

CVS commit: src/sys/arch

2019-05-04 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sat May 4 07:20:22 UTC 2019 Modified Files: src/sys/arch/amd64/amd64: cpufunc.S src/sys/arch/i386/i386: cpufunc.S i386func.S src/sys/arch/x86/include: cpufunc.h src/sys/arch/xen/x86: xenfunc.c Log Message: M

CVS commit: src/sys/arch

2019-05-01 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Wed May 1 15:17:49 UTC 2019 Modified Files: src/sys/arch/amd64/amd64: cpufunc.S src/sys/arch/i386/i386: cpufunc.S src/sys/arch/x86/include: cpufunc.h Log Message: Start converting the x86 CPU functions to inlined AS

CVS commit: src/sys/arch

2019-05-01 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Wed May 1 14:29:15 UTC 2019 Modified Files: src/sys/arch/amd64/amd64: cpufunc.S src/sys/arch/i386/i386: cpufunc.S src/sys/arch/x86/include: cpufunc.h Log Message: Remove unused functions and reorder a little. To g

CVS commit: src

2019-05-01 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Wed May 1 09:20:21 UTC 2019 Modified Files: src/lib/libnvmm: libnvmm.c src/sys/dev/nvmm: nvmm.c nvmm.h nvmm_internal.h nvmm_ioctl.h src/sys/dev/nvmm/x86: nvmm_x86.h nvmm_x86_svm.c nvmm_x86_vmx.c Log Message: Use the

CVS commit: src/lib/libnvmm

2019-04-29 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Mon Apr 29 19:03:17 UTC 2019 Modified Files: src/lib/libnvmm: libnvmm.3 Log Message: sync with reality To generate a diff of this commit: cvs rdiff -u -r1.15 -r1.16 src/lib/libnvmm/libnvmm.3 Please note that diffs are not public

CVS commit: src

2019-04-29 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Mon Apr 29 18:54:26 UTC 2019 Modified Files: src/doc: TODO.nvmm src/lib/libnvmm: libnvmm.3 src/sys/dev/nvmm/x86: nvmm_x86_svm.c nvmm_x86_vmx.c Log Message: Stop taking care of the INT/NMI windows in the kernel, the e

CVS commit: src/lib/libnvmm

2019-04-29 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Mon Apr 29 17:27:57 UTC 2019 Modified Files: src/lib/libnvmm: libnvmm.c Log Message: Remove useless calls to nvmm_init(). To generate a diff of this commit: cvs rdiff -u -r1.10 -r1.11 src/lib/libnvmm/libnvmm.c Please note that di

CVS commit: src

2019-04-28 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sun Apr 28 14:22:14 UTC 2019 Modified Files: src/lib/libnvmm: Makefile libnvmm.c libnvmm_x86.c nvmm.h src/sys/dev/nvmm: nvmm.c nvmm.h nvmm_internal.h nvmm_ioctl.h src/sys/dev/nvmm/x86: nvmm_x86.h nvmm_x86_svm.c nvmm_x

CVS commit: src/sys/dev/nvmm

2019-04-27 Thread Maxime Villard
Module Name:src Committed By: maxv Date: Sat Apr 27 17:30:38 UTC 2019 Modified Files: src/sys/dev/nvmm: nvmm.c Log Message: Mmh, fix nvmm_vcpu_create(), the cpuid is given, and must not be chosen from the free map. Looks like I forgot this after all my design rounds. While

<    1   2   3   4   5   6   7   8   9   10   >