CVS commit: src/sys/dev/scsipi

2024-02-24 Thread Michael van Elst
Module Name:src Committed By: mlelstv Date: Sat Feb 24 22:06:50 UTC 2024 Modified Files: src/sys/dev/scsipi: sd.c Log Message: Don't try to discover wedges when the unit isn't online. To generate a diff of this commit: cvs rdiff -u -r1.335 -r1.336

CVS commit: src/sys/dev/scsipi

2024-02-24 Thread Michael van Elst
Module Name:src Committed By: mlelstv Date: Sat Feb 24 22:06:50 UTC 2024 Modified Files: src/sys/dev/scsipi: sd.c Log Message: Don't try to discover wedges when the unit isn't online. To generate a diff of this commit: cvs rdiff -u -r1.335 -r1.336

CVS commit: src/sys/dev/scsipi

2024-01-01 Thread David H. Gutteridge
Module Name:src Committed By: gutteridge Date: Mon Jan 1 22:29:49 UTC 2024 Modified Files: src/sys/dev/scsipi: if_dse.c Log Message: if_dse.c: s/addredses/addresses/ in comment To generate a diff of this commit: cvs rdiff -u -r1.4 -r1.5 src/sys/dev/scsipi/if_dse.c

CVS commit: src/sys/dev/scsipi

2024-01-01 Thread David H. Gutteridge
Module Name:src Committed By: gutteridge Date: Mon Jan 1 22:29:49 UTC 2024 Modified Files: src/sys/dev/scsipi: if_dse.c Log Message: if_dse.c: s/addredses/addresses/ in comment To generate a diff of this commit: cvs rdiff -u -r1.4 -r1.5 src/sys/dev/scsipi/if_dse.c

CVS commit: src/sys/dev/scsipi

2023-12-06 Thread Andrius Varanavicius
Module Name:src Committed By: andvar Date: Thu Dec 7 07:04:13 UTC 2023 Modified Files: src/sys/dev/scsipi: scsi_disk.h Log Message: s/multiplcation/multiplication/ in comment. To generate a diff of this commit: cvs rdiff -u -r1.34 -r1.35 src/sys/dev/scsipi/scsi_disk.h

CVS commit: src/sys/dev/scsipi

2023-12-06 Thread Andrius Varanavicius
Module Name:src Committed By: andvar Date: Thu Dec 7 07:04:13 UTC 2023 Modified Files: src/sys/dev/scsipi: scsi_disk.h Log Message: s/multiplcation/multiplication/ in comment. To generate a diff of this commit: cvs rdiff -u -r1.34 -r1.35 src/sys/dev/scsipi/scsi_disk.h

CVS commit: src/sys/dev/scsipi

2022-12-22 Thread Nathanial Sloss
Module Name:src Committed By: nat Date: Thu Dec 22 23:06:11 UTC 2022 Modified Files: src/sys/dev/scsipi: if_dse.c Log Message: Fix condition for ending the pacet read loop. len is unsigned 16 bit so testing for less than zero is not valid. To generate a diff of this

CVS commit: src/sys/dev/scsipi

2022-12-22 Thread Nathanial Sloss
Module Name:src Committed By: nat Date: Thu Dec 22 23:06:11 UTC 2022 Modified Files: src/sys/dev/scsipi: if_dse.c Log Message: Fix condition for ending the pacet read loop. len is unsigned 16 bit so testing for less than zero is not valid. To generate a diff of this

CVS commit: src/sys/dev/scsipi

2022-12-22 Thread Nathanial Sloss
Module Name:src Committed By: nat Date: Thu Dec 22 22:39:20 UTC 2022 Modified Files: src/sys/dev/scsipi: if_dse.c Log Message: Remove unused commented out code. Remove unintentional stray debug printfs. Fix DSE_DEBUG build. To generate a diff of this commit: cvs rdiff

CVS commit: src/sys/dev/scsipi

2022-12-22 Thread Nathanial Sloss
Module Name:src Committed By: nat Date: Thu Dec 22 22:39:20 UTC 2022 Modified Files: src/sys/dev/scsipi: if_dse.c Log Message: Remove unused commented out code. Remove unintentional stray debug printfs. Fix DSE_DEBUG build. To generate a diff of this commit: cvs rdiff

CVS commit: src/sys/dev/scsipi

2022-10-15 Thread Jared D. McNeill
Module Name:src Committed By: jmcneill Date: Sat Oct 15 18:42:49 UTC 2022 Modified Files: src/sys/dev/scsipi: scsiconf.c Log Message: Add PQUIRK_ONLYBIG for Oracle OCI BlockVolumes. Oracle cloud BlockVolumes do not appear to support SCSI READ6 or WRITE6 commands, so set

CVS commit: src/sys/dev/scsipi

2022-10-15 Thread Jared D. McNeill
Module Name:src Committed By: jmcneill Date: Sat Oct 15 18:42:49 UTC 2022 Modified Files: src/sys/dev/scsipi: scsiconf.c Log Message: Add PQUIRK_ONLYBIG for Oracle OCI BlockVolumes. Oracle cloud BlockVolumes do not appear to support SCSI READ6 or WRITE6 commands, so set

CVS commit: src/sys/dev/scsipi

2022-08-29 Thread Nick Hudson
Module Name:src Committed By: skrll Date: Mon Aug 29 07:32:46 UTC 2022 Modified Files: src/sys/dev/scsipi: if_se.c Log Message: Make this build again. Sorry about that. To generate a diff of this commit: cvs rdiff -u -r1.117 -r1.118 src/sys/dev/scsipi/if_se.c Please

CVS commit: src/sys/dev/scsipi

2022-08-29 Thread Nick Hudson
Module Name:src Committed By: skrll Date: Mon Aug 29 07:32:46 UTC 2022 Modified Files: src/sys/dev/scsipi: if_se.c Log Message: Make this build again. Sorry about that. To generate a diff of this commit: cvs rdiff -u -r1.117 -r1.118 src/sys/dev/scsipi/if_se.c Please

CVS commit: src/sys/dev/scsipi

2022-08-28 Thread Michael van Elst
Module Name:src Committed By: mlelstv Date: Sun Aug 28 10:26:37 UTC 2022 Modified Files: src/sys/dev/scsipi: sd.c sdvar.h Log Message: Don't fetch data beyond end of inquiry buffer, which, here, is not NUL-terminated. Reduce target buffer to needed size (product name +

CVS commit: src/sys/dev/scsipi

2022-08-28 Thread Michael van Elst
Module Name:src Committed By: mlelstv Date: Sun Aug 28 10:26:37 UTC 2022 Modified Files: src/sys/dev/scsipi: sd.c sdvar.h Log Message: Don't fetch data beyond end of inquiry buffer, which, here, is not NUL-terminated. Reduce target buffer to needed size (product name +

CVS commit: src/sys/dev/scsipi

2022-08-28 Thread Nick Hudson
Module Name:src Committed By: skrll Date: Sun Aug 28 09:48:12 UTC 2022 Modified Files: src/sys/dev/scsipi: if_se.c Log Message: se(4): don't set if_watchdog as it's not used. if_timer is never set in this driver and so if_watchdog will never be called. To generate a

CVS commit: src/sys/dev/scsipi

2022-08-28 Thread Nick Hudson
Module Name:src Committed By: skrll Date: Sun Aug 28 09:48:12 UTC 2022 Modified Files: src/sys/dev/scsipi: if_se.c Log Message: se(4): don't set if_watchdog as it's not used. if_timer is never set in this driver and so if_watchdog will never be called. To generate a

CVS commit: src/sys/dev/scsipi

2022-07-07 Thread Nick Hudson
Module Name:src Committed By: skrll Date: Thu Jul 7 06:11:28 UTC 2022 Modified Files: src/sys/dev/scsipi: if_se.c Log Message: Trailing whitespace To generate a diff of this commit: cvs rdiff -u -r1.115 -r1.116 src/sys/dev/scsipi/if_se.c Please note that diffs are not

CVS commit: src/sys/dev/scsipi

2022-07-07 Thread Nick Hudson
Module Name:src Committed By: skrll Date: Thu Jul 7 06:11:28 UTC 2022 Modified Files: src/sys/dev/scsipi: if_se.c Log Message: Trailing whitespace To generate a diff of this commit: cvs rdiff -u -r1.115 -r1.116 src/sys/dev/scsipi/if_se.c Please note that diffs are not

CVS commit: src/sys/dev/scsipi

2022-06-26 Thread Andrius Varanavicius
Module Name:src Committed By: andvar Date: Sun Jun 26 21:00:28 UTC 2022 Modified Files: src/sys/dev/scsipi: cd.c Log Message: s/Ramdom/Random/ in comments. To generate a diff of this commit: cvs rdiff -u -r1.353 -r1.354 src/sys/dev/scsipi/cd.c Please note that diffs

CVS commit: src/sys/dev/scsipi

2022-06-26 Thread Andrius Varanavicius
Module Name:src Committed By: andvar Date: Sun Jun 26 21:00:28 UTC 2022 Modified Files: src/sys/dev/scsipi: cd.c Log Message: s/Ramdom/Random/ in comments. To generate a diff of this commit: cvs rdiff -u -r1.353 -r1.354 src/sys/dev/scsipi/cd.c Please note that diffs

CVS commit: src/sys/dev/scsipi

2022-03-28 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Mon Mar 28 12:39:47 UTC 2022 Modified Files: src/sys/dev/scsipi: sd.c Log Message: sd(4): Use d_cfdriver/devtounit to avoid open/detach races. To generate a diff of this commit: cvs rdiff -u -r1.333 -r1.334

CVS commit: src/sys/dev/scsipi

2022-03-28 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Mon Mar 28 12:39:47 UTC 2022 Modified Files: src/sys/dev/scsipi: sd.c Log Message: sd(4): Use d_cfdriver/devtounit to avoid open/detach races. To generate a diff of this commit: cvs rdiff -u -r1.333 -r1.334

CVS commit: src/sys/dev/scsipi

2022-03-12 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sat Mar 12 16:57:16 UTC 2022 Modified Files: src/sys/dev/scsipi: scsiconf.c Log Message: scsi(9): Handle bogus number of LUNs in SCSI_REPORT_LUNS. Reported-by: syzbot+76ef9084533d4bcce...@syzkaller.appspotmail.com To

CVS commit: src/sys/dev/scsipi

2022-03-12 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sat Mar 12 16:57:16 UTC 2022 Modified Files: src/sys/dev/scsipi: scsiconf.c Log Message: scsi(9): Handle bogus number of LUNs in SCSI_REPORT_LUNS. Reported-by: syzbot+76ef9084533d4bcce...@syzkaller.appspotmail.com To

CVS commit: src/sys/dev/scsipi

2022-02-05 Thread Juergen Hannken-Illjes
Module Name:src Committed By: hannken Date: Sat Feb 5 17:32:59 UTC 2022 Modified Files: src/sys/dev/scsipi: scsiconf.c Log Message: Initialize "replun" -- found with KMSAN. To generate a diff of this commit: cvs rdiff -u -r1.297 -r1.298 src/sys/dev/scsipi/scsiconf.c

CVS commit: src/sys/dev/scsipi

2022-02-05 Thread Juergen Hannken-Illjes
Module Name:src Committed By: hannken Date: Sat Feb 5 17:32:59 UTC 2022 Modified Files: src/sys/dev/scsipi: scsiconf.c Log Message: Initialize "replun" -- found with KMSAN. To generate a diff of this commit: cvs rdiff -u -r1.297 -r1.298 src/sys/dev/scsipi/scsiconf.c

CVS commit: src/sys/dev/scsipi

2022-01-29 Thread Martin Husemann
Module Name:src Committed By: martin Date: Sat Jan 29 11:20:30 UTC 2022 Modified Files: src/sys/dev/scsipi: scsiconf.c Log Message: In some cases the gcc optimizer is not smart enough to figure out why the luns and nluns variables are never actually used when they are not

CVS commit: src/sys/dev/scsipi

2022-01-29 Thread Martin Husemann
Module Name:src Committed By: martin Date: Sat Jan 29 11:20:30 UTC 2022 Modified Files: src/sys/dev/scsipi: scsiconf.c Log Message: In some cases the gcc optimizer is not smart enough to figure out why the luns and nluns variables are never actually used when they are not

CVS commit: src/sys/dev/scsipi

2022-01-28 Thread Christos Zoulas
Module Name:src Committed By: christos Date: Fri Jan 28 18:23:28 UTC 2022 Modified Files: src/sys/dev/scsipi: scsiconf.c Log Message: Factor out the lun detection code to simplify control flow. To generate a diff of this commit: cvs rdiff -u -r1.295 -r1.296

CVS commit: src/sys/dev/scsipi

2022-01-28 Thread Christos Zoulas
Module Name:src Committed By: christos Date: Fri Jan 28 18:23:28 UTC 2022 Modified Files: src/sys/dev/scsipi: scsiconf.c Log Message: Factor out the lun detection code to simplify control flow. To generate a diff of this commit: cvs rdiff -u -r1.295 -r1.296

CVS commit: src/sys/dev/scsipi

2022-01-28 Thread Jonathan A. Kollasch
Module Name:src Committed By: jakllsch Date: Fri Jan 28 14:02:45 UTC 2022 Modified Files: src/sys/dev/scsipi: scsiconf.c Log Message: shut up GCC about possibly-uninit; some KNF To generate a diff of this commit: cvs rdiff -u -r1.294 -r1.295

CVS commit: src/sys/dev/scsipi

2022-01-28 Thread Jonathan A. Kollasch
Module Name:src Committed By: jakllsch Date: Fri Jan 28 14:02:45 UTC 2022 Modified Files: src/sys/dev/scsipi: scsiconf.c Log Message: shut up GCC about possibly-uninit; some KNF To generate a diff of this commit: cvs rdiff -u -r1.294 -r1.295

CVS commit: src/sys/dev/scsipi

2022-01-27 Thread Jonathan A. Kollasch
Module Name:src Committed By: jakllsch Date: Thu Jan 27 18:44:49 UTC 2022 Modified Files: src/sys/dev/scsipi: sd.c Log Message: use powerof2() in sd_validate_blksize() To generate a diff of this commit: cvs rdiff -u -r1.332 -r1.333 src/sys/dev/scsipi/sd.c Please note

CVS commit: src/sys/dev/scsipi

2022-01-27 Thread Jonathan A. Kollasch
Module Name:src Committed By: jakllsch Date: Thu Jan 27 18:44:49 UTC 2022 Modified Files: src/sys/dev/scsipi: sd.c Log Message: use powerof2() in sd_validate_blksize() To generate a diff of this commit: cvs rdiff -u -r1.332 -r1.333 src/sys/dev/scsipi/sd.c Please note

CVS commit: src/sys/dev/scsipi

2022-01-27 Thread Jonathan A. Kollasch
Module Name:src Committed By: jakllsch Date: Thu Jan 27 18:37:02 UTC 2022 Modified Files: src/sys/dev/scsipi: scsi_spc.h scsiconf.c Log Message: Try REPORT LUNS command to enumerate logical units. To generate a diff of this commit: cvs rdiff -u -r1.6 -r1.7

CVS commit: src/sys/dev/scsipi

2022-01-27 Thread Jonathan A. Kollasch
Module Name:src Committed By: jakllsch Date: Thu Jan 27 18:37:02 UTC 2022 Modified Files: src/sys/dev/scsipi: scsi_spc.h scsiconf.c Log Message: Try REPORT LUNS command to enumerate logical units. To generate a diff of this commit: cvs rdiff -u -r1.6 -r1.7

CVS commit: src/sys/dev/scsipi

2021-12-21 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Tue Dec 21 22:53:21 UTC 2021 Modified Files: src/sys/dev/scsipi: scsiconf.c Log Message: scsi(4): Take kernel lock around entry into autoconf. This code paths is entered by kthreads marked MP-safe, not just from autoconf.

CVS commit: src/sys/dev/scsipi

2021-12-21 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Tue Dec 21 22:53:21 UTC 2021 Modified Files: src/sys/dev/scsipi: scsiconf.c Log Message: scsi(4): Take kernel lock around entry into autoconf. This code paths is entered by kthreads marked MP-safe, not just from autoconf.

CVS commit: src/sys/dev/scsipi

2021-09-26 Thread Jason R Thorpe
Module Name:src Committed By: thorpej Date: Sun Sep 26 14:57:19 UTC 2021 Modified Files: src/sys/dev/scsipi: ch.c Log Message: Use seltrue_filtops rather than rolling our own with filt_seltrue. To generate a diff of this commit: cvs rdiff -u -r1.94 -r1.95

CVS commit: src/sys/dev/scsipi

2021-09-26 Thread Jason R Thorpe
Module Name:src Committed By: thorpej Date: Sun Sep 26 14:57:19 UTC 2021 Modified Files: src/sys/dev/scsipi: ch.c Log Message: Use seltrue_filtops rather than rolling our own with filt_seltrue. To generate a diff of this commit: cvs rdiff -u -r1.94 -r1.95

CVS commit: src/sys/dev/scsipi

2021-06-13 Thread Michael van Elst
Module Name:src Committed By: mlelstv Date: Sun Jun 13 10:07:56 UTC 2021 Modified Files: src/sys/dev/scsipi: st.c Log Message: Restore EOM handling. To generate a diff of this commit: cvs rdiff -u -r1.240 -r1.241 src/sys/dev/scsipi/st.c Please note that diffs are not

CVS commit: src/sys/dev/scsipi

2021-06-13 Thread Michael van Elst
Module Name:src Committed By: mlelstv Date: Sun Jun 13 10:07:56 UTC 2021 Modified Files: src/sys/dev/scsipi: st.c Log Message: Restore EOM handling. To generate a diff of this commit: cvs rdiff -u -r1.240 -r1.241 src/sys/dev/scsipi/st.c Please note that diffs are not

CVS commit: src/sys/dev/scsipi

2021-05-30 Thread David A. Holland
Module Name:src Committed By: dholland Date: Sun May 30 06:46:46 UTC 2021 Modified Files: src/sys/dev/scsipi: sd.c Log Message: typo in comment To generate a diff of this commit: cvs rdiff -u -r1.331 -r1.332 src/sys/dev/scsipi/sd.c Please note that diffs are not public

CVS commit: src/sys/dev/scsipi

2021-05-30 Thread David A. Holland
Module Name:src Committed By: dholland Date: Sun May 30 06:46:46 UTC 2021 Modified Files: src/sys/dev/scsipi: sd.c Log Message: typo in comment To generate a diff of this commit: cvs rdiff -u -r1.331 -r1.332 src/sys/dev/scsipi/sd.c Please note that diffs are not public

CVS commit: src/sys/dev/scsipi

2021-04-16 Thread Reinoud Zandijk
Module Name:src Committed By: reinoud Date: Fri Apr 16 12:58:54 UTC 2021 Modified Files: src/sys/dev/scsipi: cd.c Log Message: Limit buffer size for device capabilities requests as a work-around for PR kern/56109. To generate a diff of this commit: cvs rdiff -u -r1.350

CVS commit: src/sys/dev/scsipi

2021-04-16 Thread Reinoud Zandijk
Module Name:src Committed By: reinoud Date: Fri Apr 16 12:58:54 UTC 2021 Modified Files: src/sys/dev/scsipi: cd.c Log Message: Limit buffer size for device capabilities requests as a work-around for PR kern/56109. To generate a diff of this commit: cvs rdiff -u -r1.350

CVS commit: src/sys/dev/scsipi

2021-02-10 Thread Christos Zoulas
Module Name:src Committed By: christos Date: Wed Feb 10 16:30:01 UTC 2021 Modified Files: src/sys/dev/scsipi: cd.c sd.c Log Message: PR/55986: Ryo Onodera: DK_BUSY must have mask as second argument. Make cd.c consistent by also using __BIT() To generate a diff of this

CVS commit: src/sys/dev/scsipi

2021-02-10 Thread Christos Zoulas
Module Name:src Committed By: christos Date: Wed Feb 10 16:30:01 UTC 2021 Modified Files: src/sys/dev/scsipi: cd.c sd.c Log Message: PR/55986: Ryo Onodera: DK_BUSY must have mask as second argument. Make cd.c consistent by also using __BIT() To generate a diff of this

CVS commit: src/sys/dev/scsipi

2020-12-17 Thread Jason R Thorpe
Module Name:src Committed By: thorpej Date: Fri Dec 18 01:55:22 UTC 2020 Modified Files: src/sys/dev/scsipi: ch.c Log Message: Use sel{record,remove}_knote(). To generate a diff of this commit: cvs rdiff -u -r1.92 -r1.93 src/sys/dev/scsipi/ch.c Please note that diffs

CVS commit: src/sys/dev/scsipi

2020-12-17 Thread Jason R Thorpe
Module Name:src Committed By: thorpej Date: Fri Dec 18 01:55:22 UTC 2020 Modified Files: src/sys/dev/scsipi: ch.c Log Message: Use sel{record,remove}_knote(). To generate a diff of this commit: cvs rdiff -u -r1.92 -r1.93 src/sys/dev/scsipi/ch.c Please note that diffs

CVS commit: src/sys/dev/scsipi

2020-10-26 Thread Michael van Elst
Module Name:src Committed By: mlelstv Date: Mon Oct 26 11:39:48 UTC 2020 Modified Files: src/sys/dev/scsipi: cd.c Log Message: Avoid buffer overflow when copying from bounce buffer. Fixes PR 54810 Don't use uninitialized pointer in split bounce buffer case and free a

CVS commit: src/sys/dev/scsipi

2020-10-26 Thread Michael van Elst
Module Name:src Committed By: mlelstv Date: Mon Oct 26 11:39:48 UTC 2020 Modified Files: src/sys/dev/scsipi: cd.c Log Message: Avoid buffer overflow when copying from bounce buffer. Fixes PR 54810 Don't use uninitialized pointer in split bounce buffer case and free a

CVS commit: src/sys/dev/scsipi

2020-09-28 Thread SAITOH Masanobu
Module Name:src Committed By: msaitoh Date: Tue Sep 29 03:04:03 UTC 2020 Modified Files: src/sys/dev/scsipi: cd.c Log Message: s/settng/setting/ To generate a diff of this commit: cvs rdiff -u -r1.347 -r1.348 src/sys/dev/scsipi/cd.c Please note that diffs are not

CVS commit: src/sys/dev/scsipi

2020-09-28 Thread SAITOH Masanobu
Module Name:src Committed By: msaitoh Date: Tue Sep 29 03:04:03 UTC 2020 Modified Files: src/sys/dev/scsipi: cd.c Log Message: s/settng/setting/ To generate a diff of this commit: cvs rdiff -u -r1.347 -r1.348 src/sys/dev/scsipi/cd.c Please note that diffs are not

CVS commit: src/sys/dev/scsipi

2020-09-25 Thread Jonathan A. Kollasch
Module Name:src Committed By: jakllsch Date: Fri Sep 25 13:08:00 UTC 2020 Modified Files: src/sys/dev/scsipi: sd.c Log Message: spelling fixes in sd.c comments To generate a diff of this commit: cvs rdiff -u -r1.329 -r1.330 src/sys/dev/scsipi/sd.c Please note that

CVS commit: src/sys/dev/scsipi

2020-09-25 Thread Jonathan A. Kollasch
Module Name:src Committed By: jakllsch Date: Fri Sep 25 13:08:00 UTC 2020 Modified Files: src/sys/dev/scsipi: sd.c Log Message: spelling fixes in sd.c comments To generate a diff of this commit: cvs rdiff -u -r1.329 -r1.330 src/sys/dev/scsipi/sd.c Please note that

Re: CVS commit: src/sys/dev/scsipi

2020-09-19 Thread Kimmo Suominen
I don't think this should be reverted, because LUN 0 must exist, but if there is no device on it, it will report "NOT PRESENT". We do not want the scan to stop in this case, but it should continue with other LUNs (such as those found through REPORT LUNS in the future). Kind regards, + Kimmo On

CVS commit: src/sys/dev/scsipi

2020-09-18 Thread Jonathan A. Kollasch
Module Name:src Committed By: jakllsch Date: Fri Sep 18 15:04:25 UTC 2020 Modified Files: src/sys/dev/scsipi: scsiconf.c Log Message: Revert scsiconf.c 1.288, it only worked for LUN 1. vioscsi(4) now sets PQUIRK_FORCELUNS, which fixes the original issue for all LUNs.

CVS commit: src/sys/dev/scsipi

2020-09-18 Thread Jonathan A. Kollasch
Module Name:src Committed By: jakllsch Date: Fri Sep 18 15:04:25 UTC 2020 Modified Files: src/sys/dev/scsipi: scsiconf.c Log Message: Revert scsiconf.c 1.288, it only worked for LUN 1. vioscsi(4) now sets PQUIRK_FORCELUNS, which fixes the original issue for all LUNs.

CVS commit: src/sys/dev/scsipi

2020-09-16 Thread Jonathan A. Kollasch
Module Name:src Committed By: jakllsch Date: Thu Sep 17 01:19:41 UTC 2020 Modified Files: src/sys/dev/scsipi: scsiconf.c scsipi_base.c Log Message: Some misspelling-in-comments fixes for scsipi To generate a diff of this commit: cvs rdiff -u -r1.288 -r1.289

CVS commit: src/sys/dev/scsipi

2020-09-16 Thread Jonathan A. Kollasch
Module Name:src Committed By: jakllsch Date: Thu Sep 17 01:19:41 UTC 2020 Modified Files: src/sys/dev/scsipi: scsiconf.c scsipi_base.c Log Message: Some misspelling-in-comments fixes for scsipi To generate a diff of this commit: cvs rdiff -u -r1.288 -r1.289

CVS commit: src/sys/dev/scsipi

2020-07-27 Thread Julian Coleman
Module Name:src Committed By: jdc Date: Mon Jul 27 15:41:03 UTC 2020 Modified Files: src/sys/dev/scsipi: if_se.c Log Message: Improve the workqueue and callout handling. Prompted by riastradh@. To generate a diff of this commit: cvs rdiff -u -r1.110 -r1.111

CVS commit: src/sys/dev/scsipi

2020-07-27 Thread Julian Coleman
Module Name:src Committed By: jdc Date: Mon Jul 27 15:41:03 UTC 2020 Modified Files: src/sys/dev/scsipi: if_se.c Log Message: Improve the workqueue and callout handling. Prompted by riastradh@. To generate a diff of this commit: cvs rdiff -u -r1.110 -r1.111

Re: CVS commit: src/sys/dev/scsipi

2020-07-11 Thread Kimmo Suominen
On Sun, Jul 12, 2020 at 12:05:37AM +0700, Robert Elz wrote: > Just to make things clear here, the LUN you're talking about is not > the scsi unit number (which is what I think Martin was referring to) > but a sub-device number within a single scsi ID. Right? Correct. I should have written "SCSI

Re: CVS commit: src/sys/dev/scsipi

2020-07-11 Thread Robert Elz
Date:Sat, 11 Jul 2020 18:24:51 +0300 From:Kimmo Suominen Message-ID: <20200711152451.ga1...@homeworld.netbsd.org> | On Sat, Jul 11, 2020 at 05:00:02PM +0200, Martin Husemann wrote: | > I don't understand the change. When was this broken? This has always worked

Re: CVS commit: src/sys/dev/scsipi

2020-07-11 Thread Martin Husemann
On Sat, Jul 11, 2020 at 06:24:51PM +0300, Kimmo Suominen wrote: > I think all real SCSI hardware I've had has always just only had LUN 0, > and each disk has been on its own SCSI ID (target). Yes, I confused ID and LUN here - just ignore me. Martin

Re: CVS commit: src/sys/dev/scsipi

2020-07-11 Thread Kimmo Suominen
On Sat, Jul 11, 2020 at 05:00:02PM +0200, Martin Husemann wrote: > I don't understand the change. When was this broken? This has always worked > for me e.g. with the sd0 at LUN 3 and the controller at 6 or 7. I think all real SCSI hardware I've had has always just only had LUN 0, and each disk

Re: CVS commit: src/sys/dev/scsipi

2020-07-11 Thread Martin Husemann
On Sat, Jul 11, 2020 at 05:57:46PM +0300, Kimmo Suominen wrote: > On Sat, Jul 11, 2020 at 05:47:34PM +0300, Jukka Ruohonen wrote: > > I'd reckon a pullup to NetBSD 9 would be in order? > > Yes, I was just waiting to be able to link to mail-index. I had > already checked that the patch applies

Re: CVS commit: src/sys/dev/scsipi

2020-07-11 Thread Kimmo Suominen
On Sat, Jul 11, 2020 at 05:47:34PM +0300, Jukka Ruohonen wrote: > I'd reckon a pullup to NetBSD 9 would be in order? Yes, I was just waiting to be able to link to mail-index. I had already checked that the patch applies cleanly to both netbsd-9 and netbsd-8.

Re: CVS commit: src/sys/dev/scsipi

2020-07-11 Thread Jukka Ruohonen
On Sat, Jul 11, 2020 at 02:31:46PM +, Kimmo Suominen wrote: > Use case 2: A Linode boot profile with multiple disks results in > the first disk ("sda") on LUN 1, while the second disk ("sdb") is > on LUN 0, each on their own bus. As Linode is quite popular, and supposedly uses a rather

CVS commit: src/sys/dev/scsipi

2020-07-11 Thread Kimmo Suominen
Module Name:src Committed By: kim Date: Sat Jul 11 14:31:46 UTC 2020 Modified Files: src/sys/dev/scsipi: scsiconf.c Log Message: Continue scanning a SCSI bus when a LUN is reported not present This fixes disk attachment under Qemu when there is no disk on LUN 0 on a SCSI

CVS commit: src/sys/dev/scsipi

2020-07-11 Thread Kimmo Suominen
Module Name:src Committed By: kim Date: Sat Jul 11 14:31:46 UTC 2020 Modified Files: src/sys/dev/scsipi: scsiconf.c Log Message: Continue scanning a SCSI bus when a LUN is reported not present This fixes disk attachment under Qemu when there is no disk on LUN 0 on a SCSI

CVS commit: src/sys/dev/scsipi

2020-06-22 Thread Julian Coleman
Module Name:src Committed By: jdc Date: Mon Jun 22 17:38:27 UTC 2020 Modified Files: src/sys/dev/scsipi: if_se.c Log Message: Add sedetach() and also use it to remove duplicate code from seattach(). Correct a comment about sedone(). To generate a diff of this commit:

CVS commit: src/sys/dev/scsipi

2020-06-22 Thread Julian Coleman
Module Name:src Committed By: jdc Date: Mon Jun 22 17:38:27 UTC 2020 Modified Files: src/sys/dev/scsipi: if_se.c Log Message: Add sedetach() and also use it to remove duplicate code from seattach(). Correct a comment about sedone(). To generate a diff of this commit:

CVS commit: src/sys/dev/scsipi

2020-06-22 Thread Julian Coleman
Module Name:src Committed By: jdc Date: Mon Jun 22 16:05:20 UTC 2020 Modified Files: src/sys/dev/scsipi: if_se.c Log Message: Use workqueues so that we don't call into the scsipi subsystem via a softint from the network stack. Don't recurse through scsipi_command() when

CVS commit: src/sys/dev/scsipi

2020-06-22 Thread Julian Coleman
Module Name:src Committed By: jdc Date: Mon Jun 22 16:05:20 UTC 2020 Modified Files: src/sys/dev/scsipi: if_se.c Log Message: Use workqueues so that we don't call into the scsipi subsystem via a softint from the network stack. Don't recurse through scsipi_command() when

CVS commit: src/sys/dev/scsipi

2020-06-19 Thread Julian Coleman
Module Name:src Committed By: jdc Date: Fri Jun 19 10:30:27 UTC 2020 Modified Files: src/sys/dev/scsipi: if_se.c Log Message: First pass at making this work again. Remove spl and add some locking around network access (needs more work). Make sure that we consistently use

CVS commit: src/sys/dev/scsipi

2020-06-19 Thread Julian Coleman
Module Name:src Committed By: jdc Date: Fri Jun 19 10:30:27 UTC 2020 Modified Files: src/sys/dev/scsipi: if_se.c Log Message: First pass at making this work again. Remove spl and add some locking around network access (needs more work). Make sure that we consistently use

CVS commit: src/sys/dev/scsipi

2020-05-02 Thread Julian Coleman
Module Name:src Committed By: jdc Date: Sat May 2 06:45:53 UTC 2020 Modified Files: src/sys/dev/scsipi: scsiconf.c Log Message: Don't attempt to read opcodes and their timeouts at attach time for old devices. The MAINTENANCE IN command was introduced with SCSI-3 and

CVS commit: src/sys/dev/scsipi

2020-05-02 Thread Julian Coleman
Module Name:src Committed By: jdc Date: Sat May 2 06:45:53 UTC 2020 Modified Files: src/sys/dev/scsipi: scsiconf.c Log Message: Don't attempt to read opcodes and their timeouts at attach time for old devices. The MAINTENANCE IN command was introduced with SCSI-3 and

CVS commit: src/sys/dev/scsipi

2020-03-27 Thread Michael van Elst
Module Name:src Committed By: mlelstv Date: Fri Mar 27 11:15:33 UTC 2020 Modified Files: src/sys/dev/scsipi: cd.c Log Message: Allow open of RAWPART even when no medium is loaded. Keep errors silent if no medium is loaded. Fixes PR kern/55104 To generate a diff of this

CVS commit: src/sys/dev/scsipi

2020-03-27 Thread Michael van Elst
Module Name:src Committed By: mlelstv Date: Fri Mar 27 11:15:33 UTC 2020 Modified Files: src/sys/dev/scsipi: cd.c Log Message: Allow open of RAWPART even when no medium is loaded. Keep errors silent if no medium is loaded. Fixes PR kern/55104 To generate a diff of this

CVS commit: src/sys/dev/scsipi

2020-02-19 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Wed Feb 19 16:05:41 UTC 2020 Modified Files: src/sys/dev/scsipi: scsipi_base.c Added Files: src/sys/dev/scsipi: scsi_sdt.h Log Message: Sprinkle some dtrace probes into scsi(4). To generate a diff of this commit: cvs

CVS commit: src/sys/dev/scsipi

2020-02-19 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Wed Feb 19 16:05:41 UTC 2020 Modified Files: src/sys/dev/scsipi: scsipi_base.c Added Files: src/sys/dev/scsipi: scsi_sdt.h Log Message: Sprinkle some dtrace probes into scsi(4). To generate a diff of this commit: cvs

CVS commit: src/sys/dev/scsipi

2020-02-11 Thread Chuck Silvers
Module Name:src Committed By: chs Date: Wed Feb 12 00:19:07 UTC 2020 Modified Files: src/sys/dev/scsipi: atapi_wdc.c Log Message: the number of possible ATAPI devices on an ATA bus is not always 2, it is however many devices the underlying ATA bus can have (eg. 1 for

CVS commit: src/sys/dev/scsipi

2020-02-11 Thread Chuck Silvers
Module Name:src Committed By: chs Date: Wed Feb 12 00:19:07 UTC 2020 Modified Files: src/sys/dev/scsipi: atapi_wdc.c Log Message: the number of possible ATAPI devices on an ATA bus is not always 2, it is however many devices the underlying ATA bus can have (eg. 1 for

CVS commit: src/sys/dev/scsipi

2020-01-28 Thread Jason R Thorpe
Module Name:src Committed By: thorpej Date: Wed Jan 29 05:59:50 UTC 2020 Modified Files: src/sys/dev/scsipi: if_se.c Log Message: Adopt . To generate a diff of this commit: cvs rdiff -u -r1.103 -r1.104 src/sys/dev/scsipi/if_se.c Please note that diffs are not public

CVS commit: src/sys/dev/scsipi

2020-01-28 Thread Jason R Thorpe
Module Name:src Committed By: thorpej Date: Wed Jan 29 05:59:50 UTC 2020 Modified Files: src/sys/dev/scsipi: if_se.c Log Message: Adopt . To generate a diff of this commit: cvs rdiff -u -r1.103 -r1.104 src/sys/dev/scsipi/if_se.c Please note that diffs are not public

CVS commit: src/sys/dev/scsipi

2019-09-18 Thread SAITOH Masanobu
Module Name:src Committed By: msaitoh Date: Thu Sep 19 03:37:31 UTC 2019 Modified Files: src/sys/dev/scsipi: scsipi_base.c Log Message: Use unsigned to avoid undefined behavior in scsipi_{get,put}_tag(). Found by kUBSan. To generate a diff of this commit: cvs rdiff -u

CVS commit: src/sys/dev/scsipi

2019-09-18 Thread SAITOH Masanobu
Module Name:src Committed By: msaitoh Date: Thu Sep 19 03:37:31 UTC 2019 Modified Files: src/sys/dev/scsipi: scsipi_base.c Log Message: Use unsigned to avoid undefined behavior in scsipi_{get,put}_tag(). Found by kUBSan. To generate a diff of this commit: cvs rdiff -u

CVS commit: src/sys/dev/scsipi

2019-05-30 Thread Michael van Elst
Module Name:src Committed By: mlelstv Date: Thu May 30 16:57:39 UTC 2019 Modified Files: src/sys/dev/scsipi: scsipi_ioctl.c Log Message: use correct size when copying outgoing sense data. To generate a diff of this commit: cvs rdiff -u -r1.71 -r1.72

CVS commit: src/sys/dev/scsipi

2019-05-30 Thread Michael van Elst
Module Name:src Committed By: mlelstv Date: Thu May 30 16:57:39 UTC 2019 Modified Files: src/sys/dev/scsipi: scsipi_ioctl.c Log Message: use correct size when copying outgoing sense data. To generate a diff of this commit: cvs rdiff -u -r1.71 -r1.72

CVS commit: src/sys/dev/scsipi

2019-05-26 Thread Michael van Elst
Module Name:src Committed By: mlelstv Date: Sun May 26 08:12:41 UTC 2019 Modified Files: src/sys/dev/scsipi: scsipi_ioctl.c Log Message: Add sanity checks to SCIOCCOMMAND, adapter drivers might be confused or trigger assertions (e.g. umass). To generate a diff of this

CVS commit: src/sys/dev/scsipi

2019-05-26 Thread Michael van Elst
Module Name:src Committed By: mlelstv Date: Sun May 26 08:12:41 UTC 2019 Modified Files: src/sys/dev/scsipi: scsipi_ioctl.c Log Message: Add sanity checks to SCIOCCOMMAND, adapter drivers might be confused or trigger assertions (e.g. umass). To generate a diff of this

CVS commit: src/sys/dev/scsipi

2019-05-19 Thread Frank Kardel
Module Name:src Committed By: kardel Date: Sun May 19 19:06:53 UTC 2019 Modified Files: src/sys/dev/scsipi: st.c Log Message: Add simple position recovery when positioning to EOM by reading the position with READ_POSITION. this allows for mt eom mt st to

CVS commit: src/sys/dev/scsipi

2019-05-03 Thread Michael van Elst
Module Name:src Committed By: mlelstv Date: Fri May 3 16:06:56 UTC 2019 Modified Files: src/sys/dev/scsipi: scsi_base.c Log Message: Avoid null pointer deref in printing xfer mode when no target driver is attached. Fixes kern/54157. To generate a diff of this commit:

CVS commit: src/sys/dev/scsipi

2019-05-03 Thread Michael van Elst
Module Name:src Committed By: mlelstv Date: Fri May 3 16:06:56 UTC 2019 Modified Files: src/sys/dev/scsipi: scsi_base.c Log Message: Avoid null pointer deref in printing xfer mode when no target driver is attached. Fixes kern/54157. To generate a diff of this commit:

CVS commit: src/sys/dev/scsipi

2019-03-19 Thread Michael van Elst
Module Name:src Committed By: mlelstv Date: Tue Mar 19 06:59:40 UTC 2019 Modified Files: src/sys/dev/scsipi: sd.c sdvar.h Log Message: Set disk product name as disk type. The information can be queried through drvctl(4). To generate a diff of this commit: cvs rdiff -u

  1   2   3   4   >