Re: CVS commit: src/sys

2010-03-13 Thread Darran Hunt
I've made it conditional on options KDTRACE_HOOKS, so it will only build when DTrace support is enabled. Regards, Darran. On 13/03/2010, at 7:58 PM, matthew green wrote: Added Files: src/sys/kern: kern_ctf.c thils file is linked into everyone's kernel now, and is only used by

Re: CVS commit: src/sbin/atactl

2010-03-13 Thread David Holland
On Sat, Mar 13, 2010 at 07:49:50PM +, matthew green wrote: Log Message: add SMART code 187: Reported uncorrect. from smartmontools. Is that supposed to be read as uncorrected or incorrect? (And can we edit it or does it need to stay verbatim?) -- David A. Holland dholl...@netbsd.org

Re: CVS commit: src/sys

2010-03-13 Thread Darran Hunt
I've tested with an i386 kernel. I'd rather not make those changes conditional so I'll see if I can work out why the Atari kernel would have problems. If no CTF section is found then ksyms should behave exactly as it did before the change, just with an empty CTF section. On 14/03/2010,

Re: CVS commit: src/sys

2010-03-13 Thread Izumi Tsutsui
I've tested with an i386 kernel. I'd rather not make those changes conditional so I'll see if I can work out why the Atari kernel would have problems. If no CTF section is found then ksyms should behave exactly as it did before the change, just with an empty CTF section. Ok, I'll

Re: CVS commit: src/sys

2010-03-13 Thread Simon Burge
Darran Hunt wrote: Added Files: src/sys/sys: kern_ctf.h The convention for include files in sys/sys doesn't include a kern_ prefix in the name - would it make sense to add this as sys/ctf.h instead? Cheers, Simon.

Re: CVS commit: src/sys

2010-03-13 Thread Darran Hunt
I wanted to differentiate it from the sys/ctf.h header that's part of the external/cddl/osnet tree. Sorry to rock the convention. Perhaps kctf.h? Regards, Darran. On 14/03/2010, at 5:02 PM, Simon Burge wrote: Darran Hunt wrote: Added Files: src/sys/sys: kern_ctf.h The

Re: CVS commit: src/sys

2010-03-13 Thread Matt Thomas
On Mar 13, 2010, at 8:11 PM, Darran Hunt wrote: I wanted to differentiate it from the sys/ctf.h header that's part of the external/cddl/osnet tree. Sorry to rock the convention. Perhaps kctf.h? Regards, Darran. Why pollute sys at all. why not put these in sys/dtrace/ since dtrace