Re: CVS commit: src/sys/dev

2010-11-24 Thread Juergen Hannken-Illjes
On Wed, Nov 24, 2010 at 02:40:45AM +, Mindaugas Rasiukevicius wrote: Hello, Juergen Hannken-Illjes hann...@netbsd.org wrote: Module Name:src Committed By: hannken Date: Tue Nov 23 09:30:43 UTC 2010 Modified Files: src/sys/dev: md.c Log

Re: CVS commit: src/bin/dd

2010-11-24 Thread Jim Wise
David Holland dholland-sourcechan...@netbsd.org writes: Adding weird special case remote access hacks to dd (of all random tools) is also poor design. Why not for the next round add support for dd ifurl=http://www.netbsd.org/index.html of=mycopy or dd ifurl=http://www.netbsd.org/

Re: CVS commit: src/sys/dev

2010-11-24 Thread David Holland
On Wed, Nov 24, 2010 at 12:15:59PM +0100, Juergen Hannken-Illjes wrote: +kmutex_t sc_lock; /* Protect self. */ +kcondvar_t sc_cv; /* Signal work. */ I think Signal work is missleading. :) No. It DOES signal work to the umem server. But it's not for

Re: CVS commit: src/usr.bin/stat

2010-11-24 Thread Christos Zoulas
In article 20101124225754.6201e17...@cvs.netbsd.org, David A. Holland source-changes-d@NetBSD.org wrote: - (void)snprintf(tmp, sizeof(tmp), %dd, prec 9 ? 9 : prec); + (void)snprintf(tmp, sizeof(tmp), %dld, prec 9 ? 9 : prec); perhaps %dlld?

Re: CVS commit: src/usr.bin/stat

2010-11-24 Thread David Holland
On Wed, Nov 24, 2010 at 11:11:36PM +, Christos Zoulas wrote: - (void)snprintf(tmp, sizeof(tmp), %dd, prec 9 ? 9 : prec); + (void)snprintf(tmp, sizeof(tmp), %dld, prec 9 ? 9 : prec); perhaps %dlld? Nope, that's the nsecs, which are long. I'm sort of inclined to

Re: NetBSD source-changes Digest V2 #1781

2010-11-24 Thread Paul Goyette
On Wed, 24 Nov 2010, NetBSD source-changes Digest wrote: NetBSD source-changes Digest Wednesday, November 24 2010 Volume 02 : Number 1781 ... Hmmm, did something change recently? I used to be subscribed only to source-changes but for the last couple of days I've also been getting the

Re: CVS commit: src/sys/kern

2010-11-24 Thread YAMAMOTO Takashi
hi, Hello, Sorry for late reply. y...@mwd.biglobe.ne.jp (YAMAMOTO Takashi) wrote: how about the attached patch? Consider offset = (INT64_MAX - PAGE_SIZE) and len = PAGE_SIZE. That would still panic.. heh, right. then, how about: if (round_page(offset)

Re: CVS commit: src/usr.bin/stat

2010-11-24 Thread Christos Zoulas
On Nov 24, 11:49pm, dholland-sourcechan...@netbsd.org (David Holland) wrote: -- Subject: Re: CVS commit: src/usr.bin/stat | On Wed, Nov 24, 2010 at 11:11:36PM +, Christos Zoulas wrote: | - (void)snprintf(tmp, sizeof(tmp), %dd, prec 9 ? 9 : prec); | + (void)snprintf(tmp,

Re: CVS commit: src/sys/uvm

2010-11-24 Thread YAMAMOTO Takashi
hi, - what's VM_PHYSSEG_OP_PG? - why *offp calculation is done in _p functions, rather than the caller? YAMAMOTO Takashi Module Name: src Committed By: uebayasi Date: Sun Nov 14 15:06:34 UTC 2010 Modified Files: src/sys/uvm: uvm_page.c uvm_page.h uvm_pglist.c Log

Re: CVS commit: src/sys/uvm

2010-11-24 Thread Masao Uebayashi
Hi, thanks for review. On Thu, Nov 25, 2010 at 01:58:04AM +, YAMAMOTO Takashi wrote: hi, - what's VM_PHYSSEG_OP_PG? It's to lookup vm_physseg by struct vm_page *, relying on that struct vm_page *[] is allocated linearly. It'll be used to remove vm_page::phys_addr as we talked some time

Re: CVS commit: src/sys/uvm

2010-11-24 Thread YAMAMOTO Takashi
hi, Hi, thanks for review. On Thu, Nov 25, 2010 at 01:58:04AM +, YAMAMOTO Takashi wrote: hi, - what's VM_PHYSSEG_OP_PG? It's to lookup vm_physseg by struct vm_page *, relying on that struct vm_page *[] is allocated linearly. It'll be used to remove vm_page::phys_addr as we

Re: CVS commit: src/sys/uvm

2010-11-24 Thread Masao Uebayashi
On Thu, Nov 25, 2010 at 04:18:25AM +, YAMAMOTO Takashi wrote: hi, Hi, thanks for review. On Thu, Nov 25, 2010 at 01:58:04AM +, YAMAMOTO Takashi wrote: hi, - what's VM_PHYSSEG_OP_PG? It's to lookup vm_physseg by struct vm_page *, relying on that struct vm_page *[] is

Re: CVS commit: src/sys/uvm

2010-11-24 Thread YAMAMOTO Takashi
hi, On Thu, Nov 25, 2010 at 04:18:25AM +, YAMAMOTO Takashi wrote: hi, Hi, thanks for review. On Thu, Nov 25, 2010 at 01:58:04AM +, YAMAMOTO Takashi wrote: hi, - what's VM_PHYSSEG_OP_PG? It's to lookup vm_physseg by struct vm_page *, relying on that struct vm_page

Re: CVS commit: src/sys/uvm

2010-11-24 Thread Masao Uebayashi
On Thu, Nov 25, 2010 at 05:44:21AM +, YAMAMOTO Takashi wrote: hi, On Thu, Nov 25, 2010 at 04:18:25AM +, YAMAMOTO Takashi wrote: hi, Hi, thanks for review. On Thu, Nov 25, 2010 at 01:58:04AM +, YAMAMOTO Takashi wrote: hi, - what's VM_PHYSSEG_OP_PG?

Re: CVS commit: src/sys/uvm

2010-11-24 Thread Matt Thomas
On Nov 24, 2010, at 10:47 PM, Masao Uebayashi wrote: On Thu, Nov 25, 2010 at 05:44:21AM +, YAMAMOTO Takashi wrote: hi, On Thu, Nov 25, 2010 at 04:18:25AM +, YAMAMOTO Takashi wrote: hi, Hi, thanks for review. On Thu, Nov 25, 2010 at 01:58:04AM +, YAMAMOTO Takashi wrote: