Re: CVS commit: src/lib/libc/stdio

2012-03-21 Thread Takehiko NOZAKI
Hi, It seems that lint(1) is not cross build safe, it doesn't handle MD char default type of sign/unsignd. See src/usr.bin/xlint/lint1/tree.c::cvtcon(). They use host MD CHAR_MAX directry ;) So, if cross building ppc/arm on other arch cause false alarm , "out of range " warnng. very truly yours.

Re: CVS commit: src/lib/libc/stdio

2012-03-21 Thread Valeriy E. Ushakov
On Thu, Mar 22, 2012 at 02:36:03 +, Christos Zoulas wrote: > In article <20120322013932.ga24...@britannica.bec.de>, > Joerg Sonnenberger wrote: > >> > >> What's is wrong with it? > > > >It should be unnecessary. CHAR_MAX is certainly required to fit into > >both char and unsigned char. > >

Re: CVS commit: src/lib/libc/stdio

2012-03-21 Thread Christos Zoulas
In article <20120322013932.ga24...@britannica.bec.de>, Joerg Sonnenberger wrote: >> >> What's is wrong with it? > >It should be unnecessary. CHAR_MAX is certainly required to fit into >both char and unsigned char. Yes, the issue here being that lint is saying that if char is signed the constant

Re: CVS commit: src/lib/libc/stdio

2012-03-21 Thread Joerg Sonnenberger
On Thu, Mar 22, 2012 at 01:31:41AM +, Christos Zoulas wrote: > In article <20120322003141.gb1...@britannica.bec.de>, > Joerg Sonnenberger wrote: > >On Wed, Mar 21, 2012 at 10:20:47AM -0400, Christos Zoulas wrote: > >> Module Name: src > >> Committed By: christos > >> Date:

Re: CVS commit: src/lib/libc/stdio

2012-03-21 Thread Christos Zoulas
In article <20120322003141.gb1...@britannica.bec.de>, Joerg Sonnenberger wrote: >On Wed, Mar 21, 2012 at 10:20:47AM -0400, Christos Zoulas wrote: >> Module Name: src >> Committed By:christos >> Date:Wed Mar 21 14:20:47 UTC 2012 >> >> Modified Files: >> src/lib/libc/s

Re: CVS commit: src/lib/libc/stdio

2012-03-21 Thread Joerg Sonnenberger
On Wed, Mar 21, 2012 at 10:20:47AM -0400, Christos Zoulas wrote: > Module Name: src > Committed By: christos > Date: Wed Mar 21 14:20:47 UTC 2012 > > Modified Files: > src/lib/libc/stdio: vfwprintf.c > > Log Message: > unsigned char portability casts This looks wrong. What's the p

Re: CVS commit: src/lib/libc/arch/alpha/gen

2012-03-21 Thread Nicolas Joly
On Wed, Mar 21, 2012 at 10:42:58PM +0200, Alan Barrett wrote: > On Wed, 21 Mar 2012, Havard Eidnes wrote: > >Modified Files: > > src/lib/libc/arch/alpha/gen: fpgetround.c fpsetround.c > > > >Log Message: > >Add some casts to get rid of "bitwise op on signed value is non-portable" > >warning fro

Re: CVS commit: src/lib/libc/arch/alpha/gen

2012-03-21 Thread Alan Barrett
On Wed, 21 Mar 2012, Havard Eidnes wrote: Modified Files: src/lib/libc/arch/alpha/gen: fpgetround.c fpsetround.c Log Message: Add some casts to get rid of "bitwise op on signed value is non-portable" warning from lint. I see no bitwise ops on signed values here. - return ((fpcr

Re: CVS commit: src/lib/libc/gen

2012-03-21 Thread David Laight
On Wed, Mar 21, 2012 at 10:28:32AM -0400, Christos Zoulas wrote: > Module Name: src > Committed By: christos > Date: Wed Mar 21 14:28:32 UTC 2012 > > Modified Files: > src/lib/libc/gen: setmode.c > > Log Message: > fix argument order. Matt should have used my sed script ...

Re: CVS commit: src/lib/libc/arch/arm/gen

2012-03-21 Thread Mindaugas Rasiukevicius
David Young wrote: > On Wed, Mar 21, 2012 at 10:44:35AM +0100, Joerg Sonnenberger wrote: > > On Wed, Mar 21, 2012 at 09:05:36AM +, Hiroyuki Bessho wrote: > > > Module Name: src > > > Committed By: bsh > > > Date: Wed Mar 21 09:05:36 UTC 2012 > > > > > > Modified Files: >

Re: CVS commit: src/lib/libc/arch/arm/gen

2012-03-21 Thread David Young
On Wed, Mar 21, 2012 at 10:44:35AM +0100, Joerg Sonnenberger wrote: > On Wed, Mar 21, 2012 at 09:05:36AM +, Hiroyuki Bessho wrote: > > Module Name:src > > Committed By: bsh > > Date: Wed Mar 21 09:05:36 UTC 2012 > > > > Modified Files: > > src/lib/libc/arch/arm/

Re: CVS commit: src/lib/libc/stdlib

2012-03-21 Thread Alan Barrett
On Tue, 20 Mar 2012, Christos Zoulas wrote: Modified Files: src/lib/libc/stdlib: jemalloc.c -static char*umax2s(uintmax_t x, char *s); +static char*umax2s(size_t x, char *s); If you change the argument type, then please also change the function name. Right now, the name conta

Re: CVS commit: src/lib/libc/arch/arm/gen

2012-03-21 Thread Joerg Sonnenberger
On Wed, Mar 21, 2012 at 09:05:36AM +, Hiroyuki Bessho wrote: > Module Name: src > Committed By: bsh > Date: Wed Mar 21 09:05:36 UTC 2012 > > Modified Files: > src/lib/libc/arch/arm/gen: _lwp.c > > Log Message: > shut up lint(1) So the question is still -- how much do we want t