Pre-branch commits

2019-01-11 Thread Robert Elz
| Anyway, what was the urgency? Were you somehow under | the impression that the branch was taking place last weekend | and you had to rush these This message is not a comment (in any way) on the substance of the issue being discussed in the quote above, or about the code involved, or

Re: CVS commit: src/sys/kern

2019-01-11 Thread Christoph Badura
On Fri, Jan 11, 2019 at 12:41:36AM +0100, Michael van Elst wrote: > On Thu, Jan 10, 2019 at 05:50:30PM +0100, Christoph Badura wrote: > > > > If you hadn't reversed the order of > > > > tftproot_dhcpboot() > > if (md_is_root) ... > > rootspec = bootspec > > > > that would wouldn't have need

Re: CVS commit: src/lib/libwrap

2019-01-11 Thread Andreas Gustafsson
Christos, I think libwrap/diag.c 1.15 will read random memory if either the tag or tcpd_context.file contains "%s". It's similar to 1.9 but lacks the code in 1.9 to escape the percent signs (using fixed-length buffers...). Kludgy as it was, 1.13 seems like the least bad version so far. --

Re: CVS commit: src/lib/libwrap

2019-01-11 Thread Valery Ushakov
On Fri, Jan 11, 2019 at 07:39:58 +0700, Robert Elz wrote: > farily easy to add, if only gcc didn't go and do printf format string > analysis and complain when it sees something it does not understand. gcc has plugin API that lets you add support for custom format languages. We use it at work