Re: CVS commit: src/sys

2021-02-13 Thread David Young
On Tue, Feb 09, 2021 at 07:02:32AM +, Roy Marples wrote: > Hi David > > On 03/02/2021 21:45, David Young wrote: > > > > This change looks a little hasty to me. > > > > It looks to me like some of these structs were __packed so that > > they could be read/written directly from/to any offset in

Re: CVS commit: src

2021-02-13 Thread Roland Illig
On 13.02.2021 17:20, Valery Ushakov wrote: Thanks for working on this, but a couple of nitpicks: On Sat, Feb 13, 2021 at 14:30:37 +, Roland Illig wrote: In sysinst, the installation screen is indented with tabs. Sysinst uses msgc, which brings its own text layout engine. This engine

Re: CVS commit: src

2021-02-13 Thread Roland Illig
On 13.02.2021 20:00, Valery Ushakov wrote: On Sat, Feb 13, 2021 at 14:30:37 +, Roland Illig wrote: Libcurses can be built in 2 modes: with wide character support or without (-DDISABLE_WCHAR). The test suite only covers the variant with wide characters. The single-byte variant has to be

Re: CVS commit: src

2021-02-13 Thread Valery Ushakov
On Sat, Feb 13, 2021 at 14:30:37 +, Roland Illig wrote: > Libcurses can be built in 2 modes: with wide character support or > without (-DDISABLE_WCHAR). The test suite only covers the variant with > wide characters. The single-byte variant has to be tested manually. > Running sysinst with

Re: CVS commit: src

2021-02-13 Thread Valery Ushakov
Thanks for working on this, but a couple of nitpicks: On Sat, Feb 13, 2021 at 14:30:37 +, Roland Illig wrote: > In sysinst, the installation screen is indented with tabs. Sysinst uses > msgc, which brings its own text layout engine. This engine does not use > addbytes but addch. [...] >

Re: CVS commit: src/sys/net

2021-02-13 Thread Jonathan A. Kollasch
On Sat, Feb 13, 2021 at 07:28:05AM +, Roy Marples wrote: > Module Name: src > Committed By: roy > Date: Sat Feb 13 07:28:05 UTC 2021 > > Modified Files: > src/sys/net: if_ether.h if_ethersubr.c > > Log Message: > if_ether: Ensure that ether_header is aligned > > > To