> On May 16, 2021, at 1:06 PM, matthew green wrote:
>
>> Modified Files:
>> src/sys/dev/i2c [thorpej-i2c-spi-conf]: spdmem_i2c.c
>>
>> Log Message:
>> The last change had an unfortunate side-effect on empty DIMM slots, so
>> roll that back. Instead, if we used direct config, then probe
> Modified Files:
> src/sys/dev/i2c [thorpej-i2c-spi-conf]: spdmem_i2c.c
>
> Log Message:
> The last change had an unfortunate side-effect on empty DIMM slots, so
> roll that back. Instead, if we used direct config, then probe for the
> module in the attach routine and report if the module
16.05.2021 10:29:48 Robert Elz :
> Actually, it isn't. Consistency is good,
> but correctness is better. Both is better
> still. It is possible that unsigned long
> is 32 bits, and size_t is 64, in which case
> casting to unsigned long risks truncating
> the value. That might not be possible
Date:Sun, 16 May 2021 16:32:55 +1000
From:Simon Burge
Message-ID: <20210516063255.13f704e...@thoreau.thistledown.com.au>
| Roland Illig wrote:
| > therefore I did it this way, for consistency.
|
| Good reason :)
Actually, it isn't. Consistency is good,
but
Roland Illig wrote:
>
> 16.05.2021 04:30:06 Simon Burge :
>
> > Hi Roland,
> >
> > Would using "%zu" and reverting the cast be a better fix here?
>
> I had considered this as well but found another instance in the same
> file where a size_t was fed to printf by casting it to unsigned long,
>
