y easily accommodate future tests for rmdir(2) without the need to
create a test program -- and adding a single test case is trivial, but
adding a test program currently is not.
--
Julio Merino
;
> func() {}
>
> ATF_TC_FSAPPLY(func, "description")
> ATF_TP_ADD_TCS(tp)
> {
> ATF_TP_FSAPPLY(func);
> return atf_no_error();
> }
>
> Which may be more convenient to add further testcases.
Sure, but you could change the one-liner with the more verbose version
when you want to add a second test case.
--
Julio Merino
her growth. Such approach
provides no cohesion of test cases and it makes things harder to
maintain (for all the reasons pooka mentioned regarding the addition
of new test programs to the tree).
--
Julio Merino
same effect. Until atf can
> do parallel test execution, tests which spend 99.% of their
> execution sleeping are not nice.
Thanks. Tests that do any sleep() at all are horrible regardless of
whether atf supports parallel execution or not. (Yeah, you can blame
me for this one, but I was
On Aug 26, 2010, at 4:43 PM, Paul Goyette wrote:
On Thu, 26 Aug 2010, Julio Merino wrote:
Module Name:src
Committed By: jmmv
Date: Thu Aug 26 15:28:31 UTC 2010
Modified Files:
src/external/bsd/atf/dist/atf-c++: io.cpp io.hpp io_test.cpp
src/external/bsd/atf
On 12/3/10 1:29 AM, Christos Zoulas wrote:
Module Name:src
Committed By: christos
Date: Fri Dec 3 01:29:55 UTC 2010
Modified Files:
src/tests/util/make: Makefile t_make.sh
Added Files:
src/tests/util/make: d_unmatchedvarparen.mk d_unmatchedvarparen.out
Log Messa
d /var/lock/lvm subdir for LVM it can be created automagically but I think
> that it's better to have it created before.
This broke the build:
http://www.gson.org/netbsd/bugs/build/build/2011.01.01.20.43.01/build.log.tail
--
Julio Merino
ordinary.in
> startend.in subexp.in subtle.in word_bound.in
>
> Log Message:
> Atf-ify the regex test
I think there is a missing Makefile in this change in
src/tests/lib/libc/regex/. I get complains in the checkflist stage
about missing files in destdir, but surprisingly not during the build.
--
Julio Merino
On 5/14/11 12:27 PM, Julio Merino wrote:
Module Name:src
Committed By: jmmv
Date: Sat May 14 16:27:50 UTC 2011
Modified Files:
src/sys/crypto/rijndael: rijndael-api-fst.c
Log Message:
Declare for-loop control variable outside of the for statement to prevent
a warning
On 5/14/11 12:31 PM, Christos Zoulas wrote:
On May 14, 12:29pm, j...@julipedia.org (Julio Merino) wrote:
-- Subject: Re: CVS commit: src/sys/crypto/rijndael
|> Declare for-loop control variable outside of the for statement to prevent
|> a warning and therefore fix the build.
|
| Ah!
On 5/16/11 1:03 AM, Christos Zoulas wrote:
Module Name:src
Committed By: christos
Date: Mon May 16 00:03:36 UTC 2011
Modified Files:
src/tests/lib/libposix: t_rename.c
Log Message:
h_macros need strlcat and random ugh, please someone remove this header.
define _NETBSD_SO
On 5/18/11 4:15 AM, Christos Zoulas wrote:
Module Name:src
Committed By: christos
Date: Wed May 18 03:15:12 UTC 2011
Modified Files:
src/tests/syscall: t_pselect.c
Log Message:
Don't depend on the atf timeout stuff, do it ourselves.
Why? Could atf do something better
eople will lose any
local changes they do when they extract xserver.tgz.
(I see other platforms installing xorg.conf-something from xserver.tgz,
but I presume those are to be treated as examples.)
--
Julio Merino / @jmmv
test if GCC is present and disable other compiler.
Tests should always run and report 'skipped' when they can't for
whatever reason. This test should have a #ifdef around the code and
fall back to a simple "atf_tc_skip".
--
Julio Merino / @jmmv
On Wed, May 18, 2011 at 12:30:24PM +, Christos Zoulas wrote:
> In article <4dd39547.9010...@julipedia.org>,
> Julio Merino wrote:
> >On 5/18/11 4:15 AM, Christos Zoulas wrote:
> >> Module Name: src
> >> Committed By: christos
> >> Da
les when they unpack
xserver.tgz ;-)
--
Julio Merino / @jmmv
On 5/21/11 3:19 PM, Christos Zoulas wrote:
In article<20110521083602.ga24...@netbsd.org>,
Julio Merino wrote:
1. It did not work. What units is the timeout anyway? I waited 2 seconds
and 2 minutes and it did not fire.
It's in seconds. The default is 300.
I think the unit
On 5/21/11 5:25 PM, David Laight wrote:
On Sat, May 21, 2011 at 05:14:07PM +0200, Manuel Bouyer wrote:
On Sat, May 21, 2011 at 03:34:22PM +0100, Julio Merino wrote:
Yes, the timeout thing is broken. It should really be a
specification of the test case size (e.g. 'small', 'la
On 05/21/11 15:44, Christos Zoulas wrote:
> On May 21, 3:34pm, j...@netbsd.org (Julio Merino) wrote:
> -- Subject: Re: CVS commit: src/tests/syscall
>
> | On 5/21/11 3:19 PM, Christos Zoulas wrote:
> | > Revert the latest revision in the test and boot a kernel before the
>
On 05/21/11 21:58, Christos Zoulas wrote:
> On May 21, 9:26pm, j...@julipedia.org (Julio Merino) wrote:
> -- Subject: Re: CVS commit: src/tests/syscall
>
> | Just to make sure we are talking about the same: you were running the
> | test program with atf-run; correct? If yes, wh
On 5/22/11 12:18 AM, Christos Zoulas wrote:
On May 21, 10:31pm, j...@julipedia.org (Julio Merino) wrote:
-- Subject: Re: CVS commit: src/tests/syscall
| Sounds like a good idea. Note that there is *many* more things that
| will not work. The test case will dump garbage in the current
On 5/22/11 12:48 AM, Christos Zoulas wrote:
On May 22, 12:28am, j...@julipedia.org (Julio Merino) wrote:
-- Subject: Re: CVS commit: src/tests/syscall
| That's what was done. But in order to enforce the timeouts et. al. this
| library had to fork() on every test case. This was really, r
On 5/26/11 5:25 AM, Masao Uebayashi wrote:
Module Name:src
Committed By: uebayasi
Date: Thu May 26 04:25:28 UTC 2011
Modified Files:
src/share/man/man5: boot.cfg.5
src/share/man/man8/man8.i386: boot.8
src/sys/arch/i386/stand/boot: boot2.c
src/sys/a
On 5/26/11 5:10 PM, Lars Heidieker wrote:
Hi,
with those changes I can't compile a kernel without USERCONF option set.
The changes in x86_machdep.c should be with in if defs on that options
Ok to commit the attached patch?
@@ -178,6 +182,7 @@ module_init_md(void)
}
#endif/* MODULAR
fully soon). One thing is reorganizing the tests to match the
tree structure, but the other is to move the tests right next to the
source (like we did with manpages).
--
Julio Merino / @jmmv
o, just replace assert by one of:
- ATF_REQUIRE(boolean_expression)
- ATF_REQUIRE_EQ(expected_value, actual_value)
like:
ATF_REQUIRE(pipe(fds) != 0);
ATF_REQUIRE_EQ(1, write(fds[1], "", 1));
--
Julio Merino / @jmmv
g the last
ATF_REQUIRE_EQ_MSG call in the program to ATF_REQUIRE_MSG but it did not
fail. And I tried adding an explicitly-failing ATF_REQUIRE_MSG and did
not see a crash either...
Could you provide some more details and/or a stack trace please?
--
Julio Merino / @jmmv
On 5/31/11 7:06 PM, Jukka Ruohonen wrote:
On Sat, May 28, 2011 at 04:53:21PM +0100, Julio Merino wrote:
One thing is reorganizing the tests to match the tree structure, but the
other is to move the tests right next to the source
I don't quite understand the latter part. Why is this
I'm not sure how the curses tests work, but based on what you show above
they seem complex. In general, just doing the "t_foo bar" dance is
enough for debugging.
--
Julio Merino / @jmmv
presume you found this with clang, right? I only hit the issue in OS
X and didn't bother to pull it up to NetBSD because gcc did not
encounter the problem.
Thanks!
--
Julio Merino / @jmmv
support "foreign" tests. The most basic form of this would be
programs that just return 0 on success or 1 on failure, but maybe it'd
be extended to also support autotest programs, etc.
Sure, their functionality would be limited within the framework (as
compared to "native atf tes
he way to go. Even if you
> dislike some parts of the API, already the consistency is a big win.
Yep, I had the same question here. I don't know what the original
comment meant.
> On Wed, Jun 29, 2011 at 10:50:22AM +0100, Julio Merino wrote:
>> One of the ideas floating around
On 7/20/11 10:35 PM, David Holland wrote:
On Wed, Jul 20, 2011 at 12:49:34PM +0300, Jukka Ruohonen wrote:
> A lot of empty talk here.
>
> What is exactly your problem?
You asked, I tried to explain, you describe it as "empty talk". What
are you expecting, a gigantic patch?
Anyway, I gue
On 7/21/11 4:49 AM, Martin Husemann wrote:
On Thu, Jul 21, 2011 at 07:11:56AM +0100, Iain Hibbert wrote:
I thought that I agreed with Jukka, it seemed to be a complaint with no
specific content except that you were uncomfortable (unfamilar?) with
atf.
I'm mostly with Iain here, though I have a
On 7/21/11 2:11 AM, Iain Hibbert wrote:
PS the "predictable consequence" that you cannot fold in external test
programs did not come true, see tests/lib/libevent/t_event.sh for example,
though I note that the number of libevent tests are misrepresented in the
atf-total since the test program prin
On 9/30/11 2:17 PM, Christos Zoulas wrote:
On Sep 30, 5:37pm, jruoho...@iki.fi (Jukka Ruohonen) wrote:
-- Subject: Re: CVS commit: src/tests/net/net
| This fails, probably because it does not follow the atf(7) API:
|
| tps-count: 1
| tp-start: t_unix, 2
| tc-start: sockaddr_un_len_exceed
| tc-e
On 11/6/11 1:18 PM, Christos Zoulas wrote:
Module Name:src
Committed By: christos
Date: Sun Nov 6 18:18:16 UTC 2011
Modified Files:
src/external/bsd/atf/dist/atf-c: tc.c
Log Message:
don't truncate error messages to 1K.
The use of dprintf cannot be merged back upstrea
/fprintf instead of open coding it.
>>
>>From reading the patch, there are three different brances, right?
>> Why don't you use writev for this with up to 6 elements in the vector?
>
> Done.
Did you even run any tests after doing this?
This is broken. The assertion you added triggers immediately.
--
Julio Merino / @jmmv
have broken much earlier everywhere.
--
Julio Merino / @jmmv
On 11/9/11 9:42 AM, Christos Zoulas wrote:
Module Name:src
Committed By: christos
Date: Wed Nov 9 14:42:43 UTC 2011
Modified Files:
src/external/bsd/atf/dist/atf-c: tc.c
Log Message:
need || instead of&&
To generate a diff of this commit:
cvs rdiff -u -r1.10 -r1.11 sr
On 11/14/11 3:23 PM, Christos Zoulas wrote:
Module Name:src
Committed By: christos
Date: Mon Nov 14 20:23:29 UTC 2011
Modified Files:
src/tests/util/sh: Makefile
Added Files:
src/tests/util/sh: t_evaltested.sh
Log Message:
Add a test for PR/45613 (eval failing in
On 11/16/11 12:46 PM, Christos Zoulas wrote:
Module Name:src
Committed By: christos
Date: Wed Nov 16 17:46:16 UTC 2011
Modified Files:
src/external/bsd/atf/dist/atf-c++/detail: text.cpp text.hpp
src/external/bsd/atf/dist/atf-run: requirements.cpp test-program.cpp
On 11/16/11 1:51 PM, Christos Zoulas wrote:
In article<4ec3f8f7.8020...@netbsd.org>,
Julio Merino wrote:
On 11/16/11 12:46 PM, Christos Zoulas wrote:
Module Name:src
Committed By: christos
Date: Wed Nov 16 17:46:16 UTC 2011
Modified Files:
src/external/bsd/at
On 11/16/11 3:11 PM, Christos Zoulas wrote:
In article<4ec40d98.4070...@netbsd.org>,
Julio Merino wrote:
I know there is no portable way, but at least we can default to "do
nothing" if this is not supported. It's better than "not building" :-P
Oh, I can
UPDATING. If people have their own
kernel configuration files, they need to know to remove 'rnd' from them
in order to be able to build kernels. I just encountered this scenario
and had to dig down to see if removing the entry from the file was the
right thing to do.
--
Julio Merino / @jmmv
;t use antiquated BSD API's that require global variable, use posix
> timers
> instead.
>
Interesting; didn't know about these.
But what's the point of this change? It breaks OS X at least and does not
fix anything AFAICT.
--
Julio Merino / @jmmv
On Mon, Dec 19, 2011 at 5:58 PM, Christos Zoulas wrote:
> On Dec 19, 5:00pm, j...@netbsd.org (Julio Merino) wrote:
> -- Subject: Re: CVS commit: src/external/bsd/atf/dist/atf-run
>
> | Interesting; didn't know about these.
> |
> | But what's the point of this change?
On Mon, Dec 19, 2011 at 8:32 PM, Christos Zoulas wrote:
> On Dec 19, 6:06pm, j...@netbsd.org (Julio Merino) wrote:
> -- Subject: Re: CVS commit: src/external/bsd/atf/dist/atf-run
>
> | I could only check with Snow Leopard and there is no timer_t there. I
> | don't have a
modern interfaces". Was it really worth it? (I have
not committed these "fixes" to the NetBSD tree because I cannot test
them at the moment.)
--
Julio Merino / @jmmv
On 2/7/12 2:37 PM, Joerg Sonnenberger wrote:
Module Name:src
Committed By: joerg
Date: Tue Feb 7 19:37:14 UTC 2012
Modified Files:
src: UPDATING
src/doc: CHANGES
Log Message:
Add note about new apropos and mandoc for formatting. Document failing
update builds du
On 2/17/12 5:43 PM, Matt Thomas wrote:
On Feb 17, 2012, at 2:36 PM, Julio Merino wrote:
Module Name:src
Committed By: jmmv
Date: Fri Feb 17 22:36:50 UTC 2012
Modified Files:
src/distrib/sets/lists/tests: module.mi
src/tests/modules: Makefile
Added Files
On 2/17/12 5:45 PM, Matt Thomas wrote:
On Feb 17, 2012, at 2:43 PM, Julio Merino wrote:
On 2/17/12 5:43 PM, Matt Thomas wrote:
On Feb 17, 2012, at 2:36 PM, Julio Merino wrote:
Module Name:src
Committed By: jmmv
Date: Fri Feb 17 22:36:50 UTC 2012
Modified Files
On 2/17/12 5:58 PM, Matt Thomas wrote:
On Feb 17, 2012, at 2:54 PM, Julio Merino wrote:
On 2/17/12 5:45 PM, Matt Thomas wrote:
On Feb 17, 2012, at 2:43 PM, Julio Merino wrote:
So the modules are broken on purpose?
Yes.
Interesting. If that's the case, shouldn't we break PAG
On 2/17/12 6:06 PM, Matt Thomas wrote:
On Feb 17, 2012, at 3:02 PM, Julio Merino wrote:
Aha, I see. Does it make sense to keep the test after renaming PAGE_SIZE to
uvmexp.pagesize? It's a public symbol after all and we really should have
tests for these, I think.
Do we need to go ove
On 2/17/12 6:42 PM, Matt Thomas wrote:
On Feb 17, 2012, at 3:11 PM, Julio Merino wrote:
On 2/17/12 6:06 PM, Matt Thomas wrote:
On Feb 17, 2012, at 3:02 PM, Julio Merino wrote:
Aha, I see. Does it make sense to keep the test after renaming PAGE_SIZE to
uvmexp.pagesize? It's a p
On 2/17/12 7:11 PM, Julio Merino wrote:
On 2/17/12 6:42 PM, Matt Thomas wrote:
On Feb 17, 2012, at 3:11 PM, Julio Merino wrote:
On 2/17/12 6:06 PM, Matt Thomas wrote:
On Feb 17, 2012, at 3:02 PM, Julio Merino wrote:
Aha, I see. Does it make sense to keep the test after renaming
PAGE_SIZE
On 2/17/12 6:41 PM, Matt Thomas wrote:
Module Name:src
Committed By: matt
Date: Fri Feb 17 23:41:03 UTC 2012
Modified Files:
src/sys/uvm: uvm_init.c uvm_param.h
Log Message:
Make sure to export uvmexp_* if MODULAR is defined.
Make the uvmexp_page* be a pointer to a const
On 3/18/12 1:53 AM, Jukka Ruohonen wrote:
On Fri, Mar 16, 2012 at 10:25:08PM -0400, Christos Zoulas wrote:
Module Name:src
Committed By: christos
Date: Sat Mar 17 02:25:08 UTC 2012
Modified Files:
src/sbin/ifconfig: af_inetany.c
Log Message:
PR/43141: Tobias Nygren: Pri
On Thu, Jul 12, 2012 at 12:15 PM, Christos Zoulas wrote:
> Module Name:src
> Committed By: christos
> Date: Thu Jul 12 16:15:40 UTC 2012
>
> Modified Files:
> src/external/bsd/atf/lib/libatf-c++: Makefile
>
> Log Message:
> Properly include dependent library, unbreaks objdi
ot use ATF but keep adding your
>> custom test programs?? I recall some kind of resolution about this...
>>
>> (And IMO, even if you dislike ATF, you can not dislike the infrastructure.)
>
> It's just a temporary solution.
What is just a temporary solution?
--
Julio Merino / @jmmv
ee
to reply privately or email the atf-devel list only if you do not want
to share at large for whatever reason.)
> Feel free to convert this to ATF. As for resolution - if you insist,
> I can stop adding the tests.
Have you gone over http://wiki.netbsd.org/tutorials/atf/ ? (I guess
you have, but just in case.)
--
Julio Merino / @jmmv
any more error details.
This is pure curiosity: isn't a fflush(stderr) right before the fork()
enough to make printf() safe in the child? If not, why not?
--
Julio Merino / @jmmv
On Sat, Feb 23, 2013 at 9:18 AM, Julio Merino wrote:
> Module Name:src
> Committed By: jmmv
> Date: Sat Feb 23 14:18:52 UTC 2013
>
> Modified Files:
> src/external/bsd: Makefile
>
> Log Message:
> Makefile
Fixed in the repository to read:
On Mon, Feb 25, 2013 at 1:54 PM, David Holland
wrote:
> On Mon, Feb 25, 2013 at 06:49:51PM +0000, Julio Merino wrote:
> > Log Message:
> > Cherry-pick upstream change d0daf9983f5a0e635f1127dbc827aa114daa90d8:
> >
> > Fix broken variable parsing with NetBSD&#x
On Feb 25, 2013, at 13:54, David Holland
wrote:
> On Mon, Feb 25, 2013 at 06:49:51PM +0000, Julio Merino wrote:
>> Log Message:
>> Cherry-pick upstream change d0daf9983f5a0e635f1127dbc827aa114daa90d8:
>>
>> Fix broken variable parsing with NetBSD's /bin/sh
On Feb 25, 2013, at 15:40, "Valeriy E. Ushakov" wrote:
> On Mon, Feb 25, 2013 at 18:49:51 +, Julio Merino wrote:
>
>> Module Name: src
>> Committed By:jmmv
>> Date:Mon Feb 25 18:49:51 UTC 2013
>>
>> Modified Files:
>
On Feb 25, 2013, at 14:01, Paul Goyette wrote:
> On Mon, 25 Feb 2013, David Holland wrote:
>
>> On Mon, Feb 25, 2013 at 06:49:51PM +, Julio Merino wrote:
>> > Log Message:
>> > Cherry-pick upstream change d0daf9983f5a0e635f1127dbc827aa114daa90d8:
>> >
#x27;ifra_mask' has incomplete type
/home/jmmv/os/netbsd/amd64/destdir/usr/include/netiso/iso_var.h:94:22:
error: field 'ifr_Addr' has incomplete type
--
Julio Merino / @jmmv
On Sat, Oct 19, 2013 at 7:32 AM, Marc Balmer wrote:
> Am 19.10.13 01:40, schrieb Julio Merino:
>> Module Name: src
>> Committed By: jmmv
>> Date: Fri Oct 18 23:40:48 UTC 2013
>>
>> Update of /cvsroot/src/external/bsd/kyua-cli/dist
>> In director
ents running tests in parallel. You just need
to maintain one work directory for every test body/cleanup pair and
delete the directory only after cleanup... and you cannot share work
directories among tests anyway so you have to do that one way or
another.
--
Julio Merino / @jmmv
nt "frameworks" (including "no
framework"). We'd investigate using other unit-testing libraries at
that point that have more traditional fixture definitions, and even
use different approaches for sh and C, all within the same NetBSD test
suite. I'll be posting an update to the plan in this area soon.
--
Julio Merino / @jmmv
71 matches
Mail list logo
