CVS commit: src

2024-08-04 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Mon Aug 5 06:03:54 UTC 2024 Modified Files: src/bin/pax: pax.c src/tests/bin/pax: t_pax.sh Log Message: pax(1): Only require getcwd if we're reading without --insecure. No other paths use the result of getcwd. PR bin

CVS commit: src/tests/bin/pax

2024-08-04 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Mon Aug 5 06:03:33 UTC 2024 Modified Files: src/tests/bin/pax: t_pax.sh Log Message: tests/bin/pax: Add some more cwd-related test cases. PR bin/44498: tar(1) unnecessarily demands that getcwd() work To generate a diff of t

CVS commit: src/tests/bin/pax

2024-08-04 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Mon Aug 5 06:03:33 UTC 2024 Modified Files: src/tests/bin/pax: t_pax.sh Log Message: tests/bin/pax: Add some more cwd-related test cases. PR bin/44498: tar(1) unnecessarily demands that getcwd() work To generate a diff of t

CVS commit: src/tests/bin/pax

2024-08-04 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Mon Aug 5 04:05:59 UTC 2024 Modified Files: src/tests/bin/pax: t_pax.sh Log Message: tests/bin/pax: Test pax(1) succeeds with empty file list on stdin. PR bin/41736: pax reports an error when copying zero files To generate

CVS commit: src/tests/bin/pax

2024-08-04 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Mon Aug 5 04:05:59 UTC 2024 Modified Files: src/tests/bin/pax: t_pax.sh Log Message: tests/bin/pax: Test pax(1) succeeds with empty file list on stdin. PR bin/41736: pax reports an error when copying zero files To generate

CVS commit: src

2024-08-04 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Mon Aug 5 04:05:51 UTC 2024 Modified Files: src/bin/pax: pax.c src/tests/bin/pax: t_pax.sh Log Message: pax(1): Don't require open(".") or getcwd to work for list operation. PR 44498: tar(1) unnecessarily demands that

CVS commit: src

2024-08-04 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Mon Aug 5 04:05:51 UTC 2024 Modified Files: src/bin/pax: pax.c src/tests/bin/pax: t_pax.sh Log Message: pax(1): Don't require open(".") or getcwd to work for list operation. PR 44498: tar(1) unnecessarily demands that

CVS commit: src/tests/bin/pax

2024-08-04 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Mon Aug 5 03:55:04 UTC 2024 Modified Files: src/tests/bin/pax: t_pax.sh Log Message: tests/bin/pax: Add test for pax list in an ungettable cwd. The list operation has no need to touch the file system, so it should have no nee

CVS commit: src/tests/bin/pax

2024-08-04 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Mon Aug 5 03:55:04 UTC 2024 Modified Files: src/tests/bin/pax: t_pax.sh Log Message: tests/bin/pax: Add test for pax list in an ungettable cwd. The list operation has no need to touch the file system, so it should have no nee

CVS commit: src/libexec/ld.elf_so

2024-08-03 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sat Aug 3 21:59:59 UTC 2024 Modified Files: src/libexec/ld.elf_so: debug.h headers.c map_object.c src/libexec/ld.elf_so/arch/alpha: alpha_reloc.c src/libexec/ld.elf_so/arch/arm: mdreloc.c src/libexec/ld.

CVS commit: src/libexec/ld.elf_so

2024-08-03 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sat Aug 3 21:59:59 UTC 2024 Modified Files: src/libexec/ld.elf_so: debug.h headers.c map_object.c src/libexec/ld.elf_so/arch/alpha: alpha_reloc.c src/libexec/ld.elf_so/arch/arm: mdreloc.c src/libexec/ld.

CVS commit: src/sys/arch/x86/x86

2024-08-01 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Thu Aug 1 11:18:54 UTC 2024 Modified Files: src/sys/arch/x86/x86: cpu_rng.c Log Message: x86/cpu_rng.c: Archive more links. Why do major hardware manufacturers consistently seem to think links should just stop working after a

CVS commit: src/sys/arch/x86/x86

2024-08-01 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Thu Aug 1 11:18:54 UTC 2024 Modified Files: src/sys/arch/x86/x86: cpu_rng.c Log Message: x86/cpu_rng.c: Archive more links. Why do major hardware manufacturers consistently seem to think links should just stop working after a

CVS commit: src/sys/arch/x86/x86

2024-07-31 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Wed Jul 31 22:44:49 UTC 2024 Modified Files: src/sys/arch/x86/x86: cpu_rng.c Log Message: x86/cpu_rng.c: Add reference for Intel's hardware design. Not normative, unverifiable, possibly outdated -- but still a useful descripti

CVS commit: src/sys/arch/x86/x86

2024-07-31 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Wed Jul 31 22:44:49 UTC 2024 Modified Files: src/sys/arch/x86/x86: cpu_rng.c Log Message: x86/cpu_rng.c: Add reference for Intel's hardware design. Not normative, unverifiable, possibly outdated -- but still a useful descripti

CVS commit: src/sys/arch/hppa/dev

2024-07-31 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Wed Jul 31 16:38:00 UTC 2024 Modified Files: src/sys/arch/hppa/dev: hyperfb.c Log Message: hyperfb(4): Nix trailing whitespace, sprinkle KNF. No functional change intended -- just whitespace (and comments). To generate a dif

CVS commit: src/sys/arch/hppa/dev

2024-07-31 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Wed Jul 31 16:38:00 UTC 2024 Modified Files: src/sys/arch/hppa/dev: hyperfb.c Log Message: hyperfb(4): Nix trailing whitespace, sprinkle KNF. No functional change intended -- just whitespace (and comments). To generate a dif

CVS commit: src/sys/net

2024-07-30 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Wed Jul 31 00:26:02 UTC 2024 Modified Files: src/sys/net: if_wg.c Log Message: wg(4): Add Internet Archive links for the versions cited. No functional change. To generate a diff of this commit: cvs rdiff -u -r1.130 -r1.131 s

CVS commit: src/sys/net

2024-07-30 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Wed Jul 31 00:26:02 UTC 2024 Modified Files: src/sys/net: if_wg.c Log Message: wg(4): Add Internet Archive links for the versions cited. No functional change. To generate a diff of this commit: cvs rdiff -u -r1.130 -r1.131 s

CVS commit: src/sys/net

2024-07-30 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Wed Jul 31 00:25:47 UTC 2024 Modified Files: src/sys/net: if_wg.c Log Message: wg(4): Make a rule for who wins when both peers send INIT at once. The rule is that the peer with the numerically smaller public key hash, in littl

CVS commit: src/sys/net

2024-07-30 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Wed Jul 31 00:25:47 UTC 2024 Modified Files: src/sys/net: if_wg.c Log Message: wg(4): Make a rule for who wins when both peers send INIT at once. The rule is that the peer with the numerically smaller public key hash, in littl

CVS commit: src/sys/net

2024-07-29 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Mon Jul 29 19:47:13 UTC 2024 Modified Files: src/sys/net: if_wg.c Log Message: wg(4): Sprinkle volatile on variables requiring atomic access. No functional change intended, since the relevant access is always done with atomic_

CVS commit: src/sys/net

2024-07-29 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Mon Jul 29 19:47:13 UTC 2024 Modified Files: src/sys/net: if_wg.c Log Message: wg(4): Sprinkle volatile on variables requiring atomic access. No functional change intended, since the relevant access is always done with atomic_

CVS commit: src/sys/net

2024-07-29 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Mon Jul 29 19:47:00 UTC 2024 Modified Files: src/sys/net: if_wg.c Log Message: wg(4): When a session is established, send first packet directly. Like we would do with the keepalive packet, if we had to send that instead -- no

CVS commit: src/sys/net

2024-07-29 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Mon Jul 29 19:47:00 UTC 2024 Modified Files: src/sys/net: if_wg.c Log Message: wg(4): When a session is established, send first packet directly. Like we would do with the keepalive packet, if we had to send that instead -- no

CVS commit: src/sys/net

2024-07-29 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Mon Jul 29 19:46:25 UTC 2024 Modified Files: src/sys/net: if_wg.c Log Message: wg(4): Queue packet for post-handshake retransmit if limits are hit. PR kern/58521: experimental wg(4) may drop packet after minutes of quiet To

CVS commit: src/sys/net

2024-07-29 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Mon Jul 29 19:46:25 UTC 2024 Modified Files: src/sys/net: if_wg.c Log Message: wg(4): Queue packet for post-handshake retransmit if limits are hit. PR kern/58521: experimental wg(4) may drop packet after minutes of quiet To

CVS commit: src/sys/net

2024-07-29 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Mon Jul 29 19:45:56 UTC 2024 Modified Files: src/sys/net: if_wg.c Log Message: wg(4): Trigger session initiation in wgintr, not in wg_output. We have to look up the session in wgintr anyway, for wg_send_data_msg. By triggerin

CVS commit: src/sys/net

2024-07-29 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Mon Jul 29 19:45:56 UTC 2024 Modified Files: src/sys/net: if_wg.c Log Message: wg(4): Trigger session initiation in wgintr, not in wg_output. We have to look up the session in wgintr anyway, for wg_send_data_msg. By triggerin

CVS commit: src/sys/net

2024-07-29 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Mon Jul 29 19:44:23 UTC 2024 Modified Files: src/sys/net: if_wg.c Log Message: wg(4): Add missing barriers around wgp_pending access. PR kern/58520: experimental wg(4) lacks barriers around access to packet pending initiation

CVS commit: src/sys/net

2024-07-29 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Mon Jul 29 19:44:23 UTC 2024 Modified Files: src/sys/net: if_wg.c Log Message: wg(4): Add missing barriers around wgp_pending access. PR kern/58520: experimental wg(4) lacks barriers around access to packet pending initiation

CVS commit: src/sys/net

2024-07-29 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Mon Jul 29 19:43:56 UTC 2024 Modified Files: src/sys/net: if_wg.c Log Message: wg(4): Force rekey on tx if session is older than reject-after-time. One more corner case for: PR kern/55729: net/if_wg/t_misc:wg_rekey test case

CVS commit: src/sys/net

2024-07-29 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Mon Jul 29 19:43:56 UTC 2024 Modified Files: src/sys/net: if_wg.c Log Message: wg(4): Force rekey on tx if session is older than reject-after-time. One more corner case for: PR kern/55729: net/if_wg/t_misc:wg_rekey test case

CVS commit: src/sys/net

2024-07-29 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Mon Jul 29 18:43:11 UTC 2024 Modified Files: src/sys/net: if_wg.c Log Message: wg(4): Read wgs_state atomically in wg_get_stable_session. As noted in the comment above, it may concurrently transition from ESTABLISHED to DESTRO

CVS commit: src/sys/net

2024-07-29 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Mon Jul 29 18:43:11 UTC 2024 Modified Files: src/sys/net: if_wg.c Log Message: wg(4): Read wgs_state atomically in wg_get_stable_session. As noted in the comment above, it may concurrently transition from ESTABLISHED to DESTRO

CVS commit: src/sys/net

2024-07-29 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Mon Jul 29 16:02:05 UTC 2024 Modified Files: src/sys/net: if_wg.c Log Message: wg(4): Deduplicate session establishment actions. The actions to (a) record the last handshake time, (b) clear some handshake state, (c) transmit

CVS commit: src/sys/net

2024-07-29 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Mon Jul 29 16:02:05 UTC 2024 Modified Files: src/sys/net: if_wg.c Log Message: wg(4): Deduplicate session establishment actions. The actions to (a) record the last handshake time, (b) clear some handshake state, (c) transmit

CVS commit: src/sys/net

2024-07-29 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Mon Jul 29 16:01:32 UTC 2024 Modified Files: src/sys/net: if_wg.c Log Message: wg(4): Sprinkle comments on internal sliding window API. Post-fix tidying for: PR kern/58480: experimental wg(4) sliding window logic has oopsie

CVS commit: src/sys/net

2024-07-29 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Mon Jul 29 16:01:32 UTC 2024 Modified Files: src/sys/net: if_wg.c Log Message: wg(4): Sprinkle comments on internal sliding window API. Post-fix tidying for: PR kern/58480: experimental wg(4) sliding window logic has oopsie

CVS commit: src/sys/net

2024-07-29 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Mon Jul 29 16:01:13 UTC 2024 Modified Files: src/sys/net: if_wg.c Log Message: wg(4): Omit needless atomic_load. wgs_local_index is only ever written to while only one thread has access to it and it is not in the thmap -- befo

CVS commit: src/sys/net

2024-07-29 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Mon Jul 29 16:01:13 UTC 2024 Modified Files: src/sys/net: if_wg.c Log Message: wg(4): Omit needless atomic_load. wgs_local_index is only ever written to while only one thread has access to it and it is not in the thmap -- befo

CVS commit: src/sys/net

2024-07-29 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Mon Jul 29 16:00:41 UTC 2024 Modified Files: src/sys/net: if_wg.c Log Message: wg(4): Fix typo in comment recently added. Comment added in the service of: PR kern/55729: net/if_wg/t_misc:wg_rekey test case fails PR kern/56252

CVS commit: src/sys/net

2024-07-29 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Mon Jul 29 16:00:41 UTC 2024 Modified Files: src/sys/net: if_wg.c Log Message: wg(4): Fix typo in comment recently added. Comment added in the service of: PR kern/55729: net/if_wg/t_misc:wg_rekey test case fails PR kern/56252

CVS commit: src/sys/net

2024-07-28 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Mon Jul 29 02:34:27 UTC 2024 Modified Files: src/sys/net: if_wg.c Log Message: wg(4): Fix memory ordering in detach. PR kern/58510: experimental wg(4) lacks memory ordering between wg_count_dec and module unload To generate

CVS commit: src/sys/net

2024-07-28 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Mon Jul 29 02:34:27 UTC 2024 Modified Files: src/sys/net: if_wg.c Log Message: wg(4): Fix memory ordering in detach. PR kern/58510: experimental wg(4) lacks memory ordering between wg_count_dec and module unload To generate

CVS commit: src/sys/net

2024-07-28 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Mon Jul 29 02:33:58 UTC 2024 Modified Files: src/sys/net: if_wg.c Log Message: wg(4): No need for atomic access to wgs_time_established in tx/rx. This is stable while the session is visible to the tx/rx paths -- it is initiali

CVS commit: src/sys/net

2024-07-28 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Mon Jul 29 02:33:58 UTC 2024 Modified Files: src/sys/net: if_wg.c Log Message: wg(4): No need for atomic access to wgs_time_established in tx/rx. This is stable while the session is visible to the tx/rx paths -- it is initiali

CVS commit: src/sys/net

2024-07-28 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Mon Jul 29 02:33:44 UTC 2024 Modified Files: src/sys/net: if_wg.c Log Message: wg(4): Sprinkle comments into wg_swap_sessions. No functional change intended. Prompted by: PR kern/55729: net/if_wg/t_misc:wg_rekey test case fa

CVS commit: src/sys/net

2024-07-28 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Mon Jul 29 02:33:44 UTC 2024 Modified Files: src/sys/net: if_wg.c Log Message: wg(4): Sprinkle comments into wg_swap_sessions. No functional change intended. Prompted by: PR kern/55729: net/if_wg/t_misc:wg_rekey test case fa

CVS commit: src/sys/net

2024-07-28 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Mon Jul 29 02:33:27 UTC 2024 Modified Files: src/sys/net: if_wg.c Log Message: wg(4): Queue pending packet in FIFO order, not LIFO order. Sometimes the session takes a seconds to establish, for whatever reason. It is better i

CVS commit: src/sys/net

2024-07-28 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Mon Jul 29 02:33:27 UTC 2024 Modified Files: src/sys/net: if_wg.c Log Message: wg(4): Queue pending packet in FIFO order, not LIFO order. Sometimes the session takes a seconds to establish, for whatever reason. It is better i

CVS commit: src/sys/net

2024-07-28 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Mon Jul 29 02:29:12 UTC 2024 Modified Files: src/sys/net: if_wg.c Log Message: wg(4): Sprinkle static on fixed-size array parameters. Let's make the static size declarations useful. No functional change intended. To generat

CVS commit: src/sys/net

2024-07-28 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Mon Jul 29 02:29:12 UTC 2024 Modified Files: src/sys/net: if_wg.c Log Message: wg(4): Sprinkle static on fixed-size array parameters. Let's make the static size declarations useful. No functional change intended. To generat

CVS commit: src/sys/net

2024-07-28 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Mon Jul 29 02:28:58 UTC 2024 Modified Files: src/sys/net: if_wg.c Log Message: wg(4): Put force_rekey state in the session, not the peer. That way, there is a time when one thread has exclusive access to the state, in wg_destr

CVS commit: src/sys/net

2024-07-28 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Mon Jul 29 02:28:58 UTC 2024 Modified Files: src/sys/net: if_wg.c Log Message: wg(4): Put force_rekey state in the session, not the peer. That way, there is a time when one thread has exclusive access to the state, in wg_destr

CVS commit: src/sys/net

2024-07-28 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Jul 28 14:55:30 UTC 2024 Modified Files: src/sys/net: if_wg.c Log Message: wg(4): Explain why gethexdump/puthexdump is there, and tidy. This way I will not be tempted to replace it by in-line calls to libkern hexdump. PR

CVS commit: src/sys/net

2024-07-28 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Jul 28 14:55:30 UTC 2024 Modified Files: src/sys/net: if_wg.c Log Message: wg(4): Explain why gethexdump/puthexdump is there, and tidy. This way I will not be tempted to replace it by in-line calls to libkern hexdump. PR

CVS commit: src/sys/net

2024-07-28 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Jul 28 14:50:31 UTC 2024 Modified Files: src/sys/net: if_wg.c Log Message: wg(4): Delete temporary hacks to dump keys and packets. No longer useful for: PR kern/55729: net/if_wg/t_misc:wg_rekey test case fails PR kern/562

CVS commit: src/sys/net

2024-07-28 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Jul 28 14:50:31 UTC 2024 Modified Files: src/sys/net: if_wg.c Log Message: wg(4): Delete temporary hacks to dump keys and packets. No longer useful for: PR kern/55729: net/if_wg/t_misc:wg_rekey test case fails PR kern/562

CVS commit: src/sys/net

2024-07-28 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Jul 28 14:50:05 UTC 2024 Modified Files: src/sys/net: if_wg.c Log Message: wg(4): Parenthesize macro expansions properly. PR kern/58480: experimental wg(4) sliding window logic has oopsie To generate a diff of this commi

CVS commit: src/sys/net

2024-07-28 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Jul 28 14:50:05 UTC 2024 Modified Files: src/sys/net: if_wg.c Log Message: wg(4): Parenthesize macro expansions properly. PR kern/58480: experimental wg(4) sliding window logic has oopsie To generate a diff of this commi

CVS commit: src/sys/net

2024-07-28 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Jul 28 14:49:49 UTC 2024 Modified Files: src/sys/net: if_wg.c Log Message: wg(4): Be more consistent about #ifdef INET/INET6. PR kern/58478: experimental wg(4) probably doesn't build with INET6-only To generate a diff of

CVS commit: src/sys/net

2024-07-28 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Jul 28 14:49:49 UTC 2024 Modified Files: src/sys/net: if_wg.c Log Message: wg(4): Be more consistent about #ifdef INET/INET6. PR kern/58478: experimental wg(4) probably doesn't build with INET6-only To generate a diff of

CVS commit: src/sys/net

2024-07-28 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Jul 28 14:49:31 UTC 2024 Modified Files: src/sys/net: if_wg.c Log Message: wg(4): Tidy up error branches. No functional change intended, except to add some log messages in failure cases. Cleanup after: PR kern/55729: net

CVS commit: src/sys/net

2024-07-28 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Jul 28 14:49:31 UTC 2024 Modified Files: src/sys/net: if_wg.c Log Message: wg(4): Tidy up error branches. No functional change intended, except to add some log messages in failure cases. Cleanup after: PR kern/55729: net

CVS commit: src/sys/net

2024-07-28 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Jul 28 14:48:47 UTC 2024 Modified Files: src/sys/net: if_wg.c Log Message: wg(4): Process all altq'd packets when deleting peer. Can't just drop them because we can only go through all packets on an interface at a time, fo

CVS commit: src/sys/net

2024-07-28 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Jul 28 14:48:47 UTC 2024 Modified Files: src/sys/net: if_wg.c Log Message: wg(4): Process all altq'd packets when deleting peer. Can't just drop them because we can only go through all packets on an interface at a time, fo

CVS commit: src/sys/net

2024-07-28 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Jul 28 14:48:13 UTC 2024 Modified Files: src/sys/net: if_wg.c Log Message: wg(4): Fix quotation in comment. Prompted by: PR kern/55729: net/if_wg/t_misc:wg_rekey test case fails PR kern/56252: wg(4) state machine has race

CVS commit: src/sys/net

2024-07-28 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Jul 28 14:48:13 UTC 2024 Modified Files: src/sys/net: if_wg.c Log Message: wg(4): Fix quotation in comment. Prompted by: PR kern/55729: net/if_wg/t_misc:wg_rekey test case fails PR kern/56252: wg(4) state machine has race

CVS commit: src/sys/net

2024-07-28 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Jul 28 14:47:58 UTC 2024 Modified Files: src/sys/net: if_wg.c Log Message: wg(4): Make time_uptime32 work in netbsd<=10. This is the low 32 bits of time_uptime. Will simplify pullups to 10 for: PR kern/55729: net/if_wg/t

CVS commit: src/sys/net

2024-07-28 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Jul 28 14:47:58 UTC 2024 Modified Files: src/sys/net: if_wg.c Log Message: wg(4): Make time_uptime32 work in netbsd<=10. This is the low 32 bits of time_uptime. Will simplify pullups to 10 for: PR kern/55729: net/if_wg/t

CVS commit: src/sys/net

2024-07-28 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Jul 28 14:47:37 UTC 2024 Modified Files: src/sys/net: if_wg.c Log Message: wg(4): Use 32-bit for times handled in rx/tx paths. The rx and tx paths require unlocked access to wgs_time_established (to decide whether it's tim

CVS commit: src/sys/net

2024-07-28 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Jul 28 14:47:37 UTC 2024 Modified Files: src/sys/net: if_wg.c Log Message: wg(4): Use 32-bit for times handled in rx/tx paths. The rx and tx paths require unlocked access to wgs_time_established (to decide whether it's tim

CVS commit: src/tests/net/if_wg

2024-07-28 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Jul 28 14:47:06 UTC 2024 Modified Files: src/tests/net/if_wg: t_misc.sh Log Message: wg(4): Tests should pass now. PR kern/55729: net/if_wg/t_misc:wg_rekey test case fails PR kern/56252: wg(4) state machine has race condit

CVS commit: src/tests/net/if_wg

2024-07-28 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Jul 28 14:47:06 UTC 2024 Modified Files: src/tests/net/if_wg: t_misc.sh Log Message: wg(4): Tests should pass now. PR kern/55729: net/if_wg/t_misc:wg_rekey test case fails PR kern/56252: wg(4) state machine has race condit

CVS commit: src/tests/net/if_wg

2024-07-28 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Jul 28 14:46:44 UTC 2024 Modified Files: src/tests/net/if_wg: t_misc.sh Log Message: tests/net/if_wg/t_misc: Elaborate in wg_rekey debug messages. Helpful for following the test log when things go wrong. PR kern/55729: ne

CVS commit: src/tests/net/if_wg

2024-07-28 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Jul 28 14:46:44 UTC 2024 Modified Files: src/tests/net/if_wg: t_misc.sh Log Message: tests/net/if_wg/t_misc: Elaborate in wg_rekey debug messages. Helpful for following the test log when things go wrong. PR kern/55729: ne

CVS commit: src/tests/net/if_wg

2024-07-28 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Jul 28 14:46:33 UTC 2024 Modified Files: src/tests/net/if_wg: t_misc.sh Log Message: tests/net/if_wg/t_misc: Tweak timeouts in wg_handshake_timeout. Most of the timers in wg(4) have only 1sec resolution, which might be rou

CVS commit: src/tests/net/if_wg

2024-07-28 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Jul 28 14:46:33 UTC 2024 Modified Files: src/tests/net/if_wg: t_misc.sh Log Message: tests/net/if_wg/t_misc: Tweak timeouts in wg_handshake_timeout. Most of the timers in wg(4) have only 1sec resolution, which might be rou

CVS commit: src/sys/net

2024-07-28 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Jul 28 14:46:16 UTC 2024 Modified Files: src/sys/net: if_wg.c Log Message: wg(4): Make sure to update endpoint on keepalive packets too. Prompted by: PR kern/55729: net/if_wg/t_misc:wg_rekey test case fails PR kern/56252:

CVS commit: src/sys/net

2024-07-28 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Jul 28 14:46:16 UTC 2024 Modified Files: src/sys/net: if_wg.c Log Message: wg(4): Make sure to update endpoint on keepalive packets too. Prompted by: PR kern/55729: net/if_wg/t_misc:wg_rekey test case fails PR kern/56252:

CVS commit: src/sys/net

2024-07-28 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Jul 28 14:45:51 UTC 2024 Modified Files: src/sys/net: if_wg.c Log Message: wg(4): On rx of valid ciphertext, make sure to update state machine. Previously, we also required the plaintext to be a plausible-looking IP packet

CVS commit: src/sys/net

2024-07-28 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Jul 28 14:45:51 UTC 2024 Modified Files: src/sys/net: if_wg.c Log Message: wg(4): On rx of valid ciphertext, make sure to update state machine. Previously, we also required the plaintext to be a plausible-looking IP packet

CVS commit: src/sys/net

2024-07-28 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Jul 28 14:45:33 UTC 2024 Modified Files: src/sys/net: if_wg.c Log Message: wg(4): Reject rx on sessions older than reject-after-time sec. Prompted by (but won't fix anything in): PR kern/55729: net/if_wg/t_misc:wg_rekey t

CVS commit: src/sys/net

2024-07-28 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Jul 28 14:45:33 UTC 2024 Modified Files: src/sys/net: if_wg.c Log Message: wg(4): Reject rx on sessions older than reject-after-time sec. Prompted by (but won't fix anything in): PR kern/55729: net/if_wg/t_misc:wg_rekey t

CVS commit: src/sys/net

2024-07-28 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Jul 28 14:40:02 UTC 2024 Modified Files: src/sys/net: if_wg.c Log Message: wg(4): Fix session destruction. Schedule destruction as soon as the session is created, to ensure key erasure within 2*reject-after-time seconds.

CVS commit: src/sys/net

2024-07-28 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Jul 28 14:40:02 UTC 2024 Modified Files: src/sys/net: if_wg.c Log Message: wg(4): Fix session destruction. Schedule destruction as soon as the session is created, to ensure key erasure within 2*reject-after-time seconds.

CVS commit: src/sys/net

2024-07-28 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Jul 28 14:39:36 UTC 2024 Modified Files: src/sys/net: if_wg.c Log Message: wg(4): Mark wgp_pending volatile to reflect its usage. Prompted by (but won't fix any part of): PR kern/55729: net/if_wg/t_misc:wg_rekey test case

CVS commit: src/sys/net

2024-07-28 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Jul 28 14:39:36 UTC 2024 Modified Files: src/sys/net: if_wg.c Log Message: wg(4): Mark wgp_pending volatile to reflect its usage. Prompted by (but won't fix any part of): PR kern/55729: net/if_wg/t_misc:wg_rekey test case

CVS commit: src/sys/net

2024-07-28 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Jul 28 14:39:19 UTC 2024 Modified Files: src/sys/net: if_wg.c Log Message: wg(4): Expand cookie secret to 32 bytes. This is only relevant for denial of service mitigation, so it's not that big a deal, and the spec doesn't

CVS commit: src/sys/net

2024-07-28 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Jul 28 14:39:19 UTC 2024 Modified Files: src/sys/net: if_wg.c Log Message: wg(4): Expand cookie secret to 32 bytes. This is only relevant for denial of service mitigation, so it's not that big a deal, and the spec doesn't

CVS commit: src/sys/net

2024-07-28 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Jul 28 14:39:00 UTC 2024 Modified Files: src/sys/net: if_wg.c Log Message: wg(4): Omit needless pserialize_perform on transition to DESTROYING. A session can still be used when it is in the DESTROYING state, so there's no

CVS commit: src/sys/net

2024-07-28 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Jul 28 14:39:00 UTC 2024 Modified Files: src/sys/net: if_wg.c Log Message: wg(4): Omit needless pserialize_perform on transition to DESTROYING. A session can still be used when it is in the DESTROYING state, so there's no

CVS commit: src/sys/net

2024-07-28 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Jul 28 14:38:42 UTC 2024 Modified Files: src/sys/net: if_wg.c Log Message: wg(4): Use callout_halt, not callout_stop. It's possible that callout_stop might work here, but let's simplify reasoning about it -- the timers in

CVS commit: src/sys/net

2024-07-28 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Jul 28 14:38:42 UTC 2024 Modified Files: src/sys/net: if_wg.c Log Message: wg(4): Use callout_halt, not callout_stop. It's possible that callout_stop might work here, but let's simplify reasoning about it -- the timers in

CVS commit: src/sys/net

2024-07-28 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Jul 28 14:38:19 UTC 2024 Modified Files: src/sys/net: if_wg.c Log Message: wg(4): Fix logic to ensure session initiation is underway. Previously, wg_task_send_init_message would call wg_send_handshake_msg_init if either:

CVS commit: src/sys/net

2024-07-28 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Jul 28 14:38:19 UTC 2024 Modified Files: src/sys/net: if_wg.c Log Message: wg(4): Fix logic to ensure session initiation is underway. Previously, wg_task_send_init_message would call wg_send_handshake_msg_init if either:

CVS commit: src/sys/net

2024-07-28 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Jul 28 14:37:59 UTC 2024 Modified Files: src/sys/net: if_wg.c Log Message: wg(4): Rework some details of internal session state machine. This way: - There is a clear transition between when a session is being set up, an

CVS commit: src/sys/net

2024-07-28 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Sun Jul 28 14:37:59 UTC 2024 Modified Files: src/sys/net: if_wg.c Log Message: wg(4): Rework some details of internal session state machine. This way: - There is a clear transition between when a session is being set up, an

CVS commit: src/sys/net

2024-07-26 Thread Taylor R Campbell
Module Name:src Committed By: riastradh Date: Fri Jul 26 18:34:35 UTC 2024 Modified Files: src/sys/net: if_wg.c Log Message: wg(4): Allow modunload before any interface creation. The workqueue and pktq are both lazily created, for annoying module initialization order reas

<    1   2   3   4   5   6   7   8   9   10   >