CVS commit: src/bin/cp

2024-01-15 Thread Christos Zoulas
Module Name:src Committed By: christos Date: Mon Jan 15 17:41:06 UTC 2024 Modified Files: src/bin/cp: utils.c Log Message: PR/57857: Ricardo Branco: Always copy regular files, even if they appear to be zero-sized. To generate a diff of this commit: cvs rdiff -u -r1.49 -r

CVS commit: src/bin/cp

2024-01-15 Thread Christos Zoulas
Module Name:src Committed By: christos Date: Mon Jan 15 17:41:06 UTC 2024 Modified Files: src/bin/cp: utils.c Log Message: PR/57857: Ricardo Branco: Always copy regular files, even if they appear to be zero-sized. To generate a diff of this commit: cvs rdiff -u -r1.49 -r

CVS commit: src/bin/cp

2024-06-07 Thread Andrius Varanavicius
Module Name:src Committed By: andvar Date: Fri Jun 7 21:01:00 UTC 2024 Modified Files: src/bin/cp: cp.c Log Message: s/concatentation/concatenation/ in comment. To generate a diff of this commit: cvs rdiff -u -r1.62 -r1.63 src/bin/cp/cp.c Please note that diffs are not

CVS commit: src/bin/cp

2024-06-07 Thread Andrius Varanavicius
Module Name:src Committed By: andvar Date: Fri Jun 7 21:01:00 UTC 2024 Modified Files: src/bin/cp: cp.c Log Message: s/concatentation/concatenation/ in comment. To generate a diff of this commit: cvs rdiff -u -r1.62 -r1.63 src/bin/cp/cp.c Please note that diffs are not

CVS commit: src/bin/cp

2019-09-23 Thread Christos Zoulas
Module Name:src Committed By: christos Date: Mon Sep 23 18:01:09 UTC 2019 Modified Files: src/bin/cp: utils.c Log Message: PR/54564: Jan Schaumann: cp of a fifo yields an empty file Don't short-circuit 0 sized stat entries if they don't belong to regular files. Also don't

CVS commit: src/bin/cp

2019-09-23 Thread Christos Zoulas
Module Name:src Committed By: christos Date: Mon Sep 23 18:01:09 UTC 2019 Modified Files: src/bin/cp: utils.c Log Message: PR/54564: Jan Schaumann: cp of a fifo yields an empty file Don't short-circuit 0 sized stat entries if they don't belong to regular files. Also don't

Re: CVS commit: src/bin/cp

2010-10-23 Thread David Holland
On Fri, Oct 22, 2010 at 05:56:06PM +, Antti Kantee wrote: > Disable mmap path. With the current vnode locking scheme it has > a very annoying property: if the source media is slow (like a slow > network), the target file will be locked for the duration of the > entire max 8MB write and cau

Re: CVS commit: src/bin/cp

2010-10-24 Thread David Laight
On Sun, Oct 24, 2010 at 05:21:06AM +, David Holland wrote: > > Because individual write() calls are supposed to be atomic, I don't > think there is such a thing as a locking improvement that'll help with > this behavior. :-/ I think write() only needs to lock the the file enough to ensure tha

Re: CVS commit: src/bin/cp

2010-10-24 Thread David Holland
(adding tech-kern because this seems likely to become lengthy; if following up please drop source-changes-d) On Sun, Oct 24, 2010 at 11:30:43AM +0100, David Laight wrote: > > > [mmap mode disabled in cp due to long vnode lock waits] > > > > Because individual write() calls are supposed to be at

Re: CVS commit: src/bin/cp

2010-10-25 Thread Matthias Scheler
On Sun, Oct 24, 2010 at 10:56:40PM +, David Holland wrote: > Anyway, ISTM that writing from the mmap buffer in say 64K chunks would > retain nearly all the advantages and get rid of the latency problem. The way the code is currently written it only uses mmap(2) for files smaller than 8MB anywa

Re: CVS commit: src/bin/cp

2010-10-25 Thread Matthias Scheler
On Mon, Oct 25, 2010 at 08:52:43AM +0100, Matthias Scheler wrote: > On Sun, Oct 24, 2010 at 10:56:40PM +, David Holland wrote: > > Anyway, ISTM that writing from the mmap buffer in say 64K chunks would > > retain nearly all the advantages and get rid of the latency problem. > > The way the cod

Re: CVS commit: src/bin/cp

2010-10-25 Thread Juergen Hannken-Illjes
On Sun, Oct 24, 2010 at 05:21:06AM +, David Holland wrote: > On Fri, Oct 22, 2010 at 05:56:06PM +, Antti Kantee wrote: > > Disable mmap path. With the current vnode locking scheme it has > > a very annoying property: if the source media is slow (like a slow > > network), the target file

Re: CVS commit: src/bin/cp

2010-10-25 Thread Joerg Sonnenberger
On Mon, Oct 25, 2010 at 11:17:22AM +0200, Juergen Hannken-Illjes wrote: > On Sun, Oct 24, 2010 at 05:21:06AM +, David Holland wrote: > > On Fri, Oct 22, 2010 at 05:56:06PM +, Antti Kantee wrote: > > > Disable mmap path. With the current vnode locking scheme it has > > > a very annoying p

Re: CVS commit: src/bin/cp

2010-10-25 Thread Juergen Hannken-Illjes
On Mon, Oct 25, 2010 at 06:30:54PM +0200, Joerg Sonnenberger wrote: > On Mon, Oct 25, 2010 at 11:17:22AM +0200, Juergen Hannken-Illjes wrote: > > On Sun, Oct 24, 2010 at 05:21:06AM +, David Holland wrote: > > > On Fri, Oct 22, 2010 at 05:56:06PM +, Antti Kantee wrote: > > > > Disable mmap

Re: CVS commit: src/bin/cp

2010-10-25 Thread David Laight
On Mon, Oct 25, 2010 at 11:17:22AM +0200, Juergen Hannken-Illjes wrote: > On Sun, Oct 24, 2010 at 05:21:06AM +, David Holland wrote: > > On Fri, Oct 22, 2010 at 05:56:06PM +, Antti Kantee wrote: > > > Disable mmap path. With the current vnode locking scheme it has > > > a very annoying p

Re: CVS commit: src/bin/cp

2010-10-25 Thread David Laight
On Sun, Oct 24, 2010 at 10:56:40PM +, David Holland wrote: > > > > I think write() only needs to lock the the file enough to ensure that > > the file offset is correct. > > No, since in general the file is also being extended (certainly in > this case it is) it also has to lock the file si

Re: CVS commit: src/bin/cp

2010-10-25 Thread Joerg Sonnenberger
On Mon, Oct 25, 2010 at 06:41:11PM +0200, Juergen Hannken-Illjes wrote: > > Do we implement MADV_WILLNEED? > > According to the man page "This WILL NOT fault pages in from backing store". The version of the man page I have says "It might or might not fault pages in from backing store". Joerg

re: CVS commit: src/bin/cp

2010-10-25 Thread matthew green
> On Mon, Oct 25, 2010 at 08:52:43AM +0100, Matthias Scheler wrote: > > On Sun, Oct 24, 2010 at 10:56:40PM +, David Holland wrote: > > > Anyway, ISTM that writing from the mmap buffer in say 64K chunks would > > > retain nearly all the advantages and get rid of the latency problem. > > > > Th

Re: CVS commit: src/bin/cp

2010-10-25 Thread Juergen Hannken-Illjes
On Mon, Oct 25, 2010 at 06:46:36PM +0200, Joerg Sonnenberger wrote: > On Mon, Oct 25, 2010 at 06:41:11PM +0200, Juergen Hannken-Illjes wrote: > > > Do we implement MADV_WILLNEED? > > > > According to the man page "This WILL NOT fault pages in from backing store". > > The version of the man page I

Re: CVS commit: src/bin/cp

2010-10-25 Thread Matthias Scheler
On Tue, Oct 26, 2010 at 05:05:28AM +1100, matthew green wrote: > > > On Mon, Oct 25, 2010 at 08:52:43AM +0100, Matthias Scheler wrote: > > > On Sun, Oct 24, 2010 at 10:56:40PM +, David Holland wrote: > > > > Anyway, ISTM that writing from the mmap buffer in say 64K chunks would > > > > retain

Re: CVS commit: src/bin/cp

2010-10-26 Thread David Holland
On Mon, Oct 25, 2010 at 05:49:11PM +0100, David Laight wrote: > > No, since in general the file is also being extended (certainly in > > this case it is) it also has to lock the file size, and that's going > > to deny stat() until it's done. > > A stat request during a write can safely return

Re: CVS commit: src/bin/cp

2010-12-21 Thread Alan Barrett
On Tue, 21 Dec 2010, Christos Zoulas wrote: > Modified Files: > src/bin/cp: cp.1 cp.c utils.c > > Log Message: > Add -a archive flag. from Aleksey Cheusov Please add a note under STANDARDS in the man page saying that "-a" is non-standard. --apb (Alan Barrett)