CVS commit: src/sbin/ping

2022-12-01 Thread Christos Zoulas
Module Name:src Committed By: christos Date: Thu Dec 1 14:42:12 UTC 2022 Modified Files: src/sbin/ping: ping.c Log Message: fix sign. To generate a diff of this commit: cvs rdiff -u -r1.121 -r1.122 src/sbin/ping/ping.c Please note that diffs are not public domain;

CVS commit: src/sbin/ping

2022-12-01 Thread Christos Zoulas
Module Name:src Committed By: christos Date: Thu Dec 1 14:42:12 UTC 2022 Modified Files: src/sbin/ping: ping.c Log Message: fix sign. To generate a diff of this commit: cvs rdiff -u -r1.121 -r1.122 src/sbin/ping/ping.c Please note that diffs are not public domain;

CVS commit: src/sbin/ping

2022-12-01 Thread Christos Zoulas
Module Name:src Committed By: christos Date: Thu Dec 1 14:40:53 UTC 2022 Modified Files: src/sbin/ping: ping.c Log Message: Add a sanity check for the ip header length (from FreeBSD) To generate a diff of this commit: cvs rdiff -u -r1.120 -r1.121 src/sbin/ping/ping.c

CVS commit: src/sbin/ping

2022-12-01 Thread Christos Zoulas
Module Name:src Committed By: christos Date: Thu Dec 1 14:40:53 UTC 2022 Modified Files: src/sbin/ping: ping.c Log Message: Add a sanity check for the ip header length (from FreeBSD) To generate a diff of this commit: cvs rdiff -u -r1.120 -r1.121 src/sbin/ping/ping.c

Re: CVS commit: src/sbin/ping

2017-03-22 Thread Frank Kardel
The bug seems to also exist in NetBSD-7.1 - maybe a pull-up would be helpful. Best regards, Frank Kardel On 03/17/17 07:52, Ryo Shimizu wrote: Module Name:src Committed By: ryo Date: Fri Mar 17 06:52:59 UTC 2017 Modified Files: src/sbin/ping: ping.c Log Message: Fix

Re: CVS commit: src/sbin/ping

2013-01-02 Thread Greg Troxel
chris...@zoulas.com (Christos Zoulas) writes: ping -s 1 localhost linux: PING localhost (127.0.0.1) 1(29) bytes of data. 9 bytes from localhost (127.0.0.1): icmp_seq=1 ttl=64 so linux sends n bytes more than the header. macosx PING localhost (127.0.0.1): 1 data bytes 9 bytes from

Re: CVS commit: src/sbin/ping

2013-01-02 Thread Christos Zoulas
On Jan 2, 10:55am, g...@ir.bbn.com (Greg Troxel) wrote: -- Subject: Re: CVS commit: src/sbin/ping | chris...@zoulas.com (Christos Zoulas) writes: | | ping -s 1 localhost | | linux: | PING localhost (127.0.0.1) 1(29) bytes of data. | 9 bytes from localhost (127.0.0.1): icmp_seq=1 ttl=64

Re: CVS commit: src/sbin/ping

2013-01-02 Thread Greg Troxel
I am not understanding why '-s argument is the number of data bytes beyond the standard 8-byte icmp header' is complicated. People who use -s are trying to control packet size, and the rule of 8 header + data seems to be longstanding. Looking at -current: the size of the timespec should be

Re: CVS commit: src/sbin/ping

2013-01-02 Thread Christos Zoulas
In article rmik3rv4kwp@fnord.ir.bbn.com, Greg Troxel g...@ir.bbn.com wrote: -=-=-=-=-=- I am not understanding why '-s argument is the number of data bytes beyond the standard 8-byte icmp header' is complicated. People who use -s are trying to control packet size, and the rule of 8 header

Re: CVS commit: src/sbin/ping

2012-12-30 Thread Greg Troxel
3. Always send ICMP_MINLEN packets; this is what everyone else does. Makes ping -s n where n 8 work. Shouldn't that be an error? Otherwise people will think that something is happening when it isn't. pgpsqNepA4SMC.pgp Description: PGP signature

Re: CVS commit: src/sbin/ping

2012-12-30 Thread Christos Zoulas
On Dec 30, 7:53am, g...@ir.bbn.com (Greg Troxel) wrote: -- Subject: Re: CVS commit: src/sbin/ping | 3. Always send ICMP_MINLEN packets; this is what everyone else does. Makes | ping -s n where n 8 work. | | Shouldn't that be an error? Otherwise people will think that something

Re: CVS commit: src/sbin/ping

2012-12-30 Thread dieter roelants
On Sun, 30 Dec 2012 10:50:07 -0500 chris...@zoulas.com (Christos Zoulas) wrote: netbsd-old PING localhost (127.0.0.1): 1 data bytes [no response] Not that old, though; it has worked in the past: box2$ uname -r 5.1_STABLE box2$ ping -c 1 -s 1 localhost PING localhost (127.0.0.1):

Re: CVS commit: src/sbin/ping

2012-12-30 Thread Christos Zoulas
In article 20121230173516.ab058f88b94567154810b...@pandora.be, dieter roelants dieter.net...@pandora.be wrote: On Sun, 30 Dec 2012 10:50:07 -0500 chris...@zoulas.com (Christos Zoulas) wrote: netbsd-old PING localhost (127.0.0.1): 1 data bytes [no response] Not that old, though; it has worked