Module Name:src
Committed By: maxv
Date: Sat Nov 16 10:05:44 UTC 2019
Modified Files:
src/sys/kern: vfs_subr.c
Log Message:
Add a NULL check on the structure (same logic as my previous change in this
file). For clarity, and to appease kUBSan.
To generate a diff of this
Module Name:src
Committed By: maxv
Date: Sat Nov 16 10:05:44 UTC 2019
Modified Files:
src/sys/kern: vfs_subr.c
Log Message:
Add a NULL check on the structure (same logic as my previous change in this
file). For clarity, and to appease kUBSan.
To generate a diff of this
Module Name:src
Committed By: pgoyette
Date: Sat Nov 16 03:26:19 UTC 2019
Modified Files:
src/sys/kern: compat_stub.c
Log Message:
Remove some XXX'd comments that were remnants of when I was working
on the [pgoyette-compat] code.
NFC
To generate a diff of this commit:
Module Name:src
Committed By: pgoyette
Date: Sat Nov 16 03:26:19 UTC 2019
Modified Files:
src/sys/kern: compat_stub.c
Log Message:
Remove some XXX'd comments that were remnants of when I was working
on the [pgoyette-compat] code.
NFC
To generate a diff of this commit:
Module Name:src
Committed By: maxv
Date: Fri Nov 15 15:51:57 UTC 2019
Modified Files:
src/sys/kern: vfs_subr.c
Log Message:
NULL-check the structure pointer, not the address of its first field. This
is clearer and also appeases syzbot.
Reported-by:
Module Name:src
Committed By: maxv
Date: Fri Nov 15 15:51:57 UTC 2019
Modified Files:
src/sys/kern: vfs_subr.c
Log Message:
NULL-check the structure pointer, not the address of its first field. This
is clearer and also appeases syzbot.
Reported-by:
Module Name:src
Committed By: maxv
Date: Thu Nov 14 16:56:13 UTC 2019
Modified Files:
src/sys/kern: subr_csan.c
Log Message:
Don't include "opt_kcsan.h" since there's already included.
To generate a diff of this commit:
cvs rdiff -u -r1.3 -r1.4 src/sys/kern/subr_csan.c
Module Name:src
Committed By: maxv
Date: Thu Nov 14 16:56:13 UTC 2019
Modified Files:
src/sys/kern: subr_csan.c
Log Message:
Don't include "opt_kcsan.h" since there's already included.
To generate a diff of this commit:
cvs rdiff -u -r1.3 -r1.4 src/sys/kern/subr_csan.c
Module Name:src
Committed By: pgoyette
Date: Wed Nov 13 15:48:36 UTC 2019
Modified Files:
src/sys/kern: sys_ptrace_common.c
Log Message:
Return success if no coredump module is loaded/hooked.
To generate a diff of this commit:
cvs rdiff -u -r1.70 -r1.71
Module Name:src
Committed By: pgoyette
Date: Wed Nov 13 15:48:36 UTC 2019
Modified Files:
src/sys/kern: sys_ptrace_common.c
Log Message:
Return success if no coredump module is loaded/hooked.
To generate a diff of this commit:
cvs rdiff -u -r1.70 -r1.71
Module Name:src
Committed By: mrg
Date: Wed Nov 13 01:31:47 UTC 2019
Modified Files:
src/sys/kern: kern_cpu.c
Log Message:
put the ucode not found message under #ifdef DEBUG. use printf()
instead of aprint_error().
there's an error returned to userland and displayed by
Module Name:src
Committed By: mrg
Date: Wed Nov 13 01:31:47 UTC 2019
Modified Files:
src/sys/kern: kern_cpu.c
Log Message:
put the ucode not found message under #ifdef DEBUG. use printf()
instead of aprint_error().
there's an error returned to userland and displayed by
Module Name:src
Committed By: maxv
Date: Mon Nov 11 09:50:11 UTC 2019
Modified Files:
src/sys/kern: subr_xcall.c
Log Message:
Remove lockless reads of 'xc_donep'. This is an uint64_t, and we cannot
expect the accesses to be MP-safe on 32bit arches.
Found by KCSAN.
To
Module Name:src
Committed By: maxv
Date: Mon Nov 11 09:50:11 UTC 2019
Modified Files:
src/sys/kern: subr_xcall.c
Log Message:
Remove lockless reads of 'xc_donep'. This is an uint64_t, and we cannot
expect the accesses to be MP-safe on 32bit arches.
Found by KCSAN.
To
Module Name:src
Committed By: joerg
Date: Sun Nov 10 23:39:03 UTC 2019
Modified Files:
src/sys/kern: kern_lwp.c
Log Message:
Ensure that the second LWP of a new process uses a free LWP ID.
Document overflow behavior.
To generate a diff of this commit:
cvs rdiff -u
Module Name:src
Committed By: joerg
Date: Sun Nov 10 23:39:03 UTC 2019
Modified Files:
src/sys/kern: kern_lwp.c
Log Message:
Ensure that the second LWP of a new process uses a free LWP ID.
Document overflow behavior.
To generate a diff of this commit:
cvs rdiff -u
Module Name:src
Committed By: pgoyette
Date: Sat Nov 9 23:34:13 UTC 2019
Modified Files:
src/sys/kern: sys_sig.c
Log Message:
If we need to handle old-version signals, load the version-specific
"compat_16" module. There is no longer a monolithic "compat" module!
XXX
Module Name:src
Committed By: pgoyette
Date: Sat Nov 9 23:34:13 UTC 2019
Modified Files:
src/sys/kern: sys_sig.c
Log Message:
If we need to handle old-version signals, load the version-specific
"compat_16" module. There is no longer a monolithic "compat" module!
XXX
Module Name:src
Committed By: jdolecek
Date: Sat Nov 9 22:05:50 UTC 2019
Modified Files:
src/sys/kern: makesyscalls.sh
Log Message:
do not try to rm sysautoload when it's not actually used for given compat;
script tried to rm /dev/null which failed
To generate a diff
Module Name:src
Committed By: jdolecek
Date: Sat Nov 9 22:05:50 UTC 2019
Modified Files:
src/sys/kern: makesyscalls.sh
Log Message:
do not try to rm sysautoload when it's not actually used for given compat;
script tried to rm /dev/null which failed
To generate a diff
Module Name:src
Committed By: kamil
Date: Thu Nov 7 20:34:29 UTC 2019
Modified Files:
src/sys/kern: subr_disk_mbr.c
Log Message:
Revert subr_disk_mbr.c r.1.54
Requested by as there can be a better way to fix the original
problem with alignment.
To generate a diff of
Module Name:src
Committed By: kamil
Date: Thu Nov 7 20:34:29 UTC 2019
Modified Files:
src/sys/kern: subr_disk_mbr.c
Log Message:
Revert subr_disk_mbr.c r.1.54
Requested by as there can be a better way to fix the original
problem with alignment.
To generate a diff of
Module Name:src
Committed By: kamil
Date: Thu Nov 7 20:30:49 UTC 2019
Modified Files:
src/sys/kern: subr_disk_mbr.c
Log Message:
Decorate check_label_magic() with __noubsan
Requested by
To generate a diff of this commit:
cvs rdiff -u -r1.54 -r1.55
Module Name:src
Committed By: kamil
Date: Thu Nov 7 20:30:49 UTC 2019
Modified Files:
src/sys/kern: subr_disk_mbr.c
Log Message:
Decorate check_label_magic() with __noubsan
Requested by
To generate a diff of this commit:
cvs rdiff -u -r1.54 -r1.55
Module Name:src
Committed By: joerg
Date: Thu Nov 7 19:45:18 UTC 2019
Modified Files:
src/sys/kern: kern_lwp.c
Log Message:
Preserve the LWP ID of the calling thread on (v)fork. This ensures that
_lwp_self() remains invariant as necessary for the locking in the
dynamic
Module Name:src
Committed By: joerg
Date: Thu Nov 7 19:45:18 UTC 2019
Modified Files:
src/sys/kern: kern_lwp.c
Log Message:
Preserve the LWP ID of the calling thread on (v)fork. This ensures that
_lwp_self() remains invariant as necessary for the locking in the
dynamic
On Nov 7, 6:08pm, n...@gmx.com (Kamil Rytarowski) wrote:
-- Subject: Re: CVS commit: src/sys/kern
| Please review:
|
| http://netbsd.org/~kamil/patch-00194-disklabel-alignment.txt
|
| This patch works for me.
|
| Patch inspired by:
|
| Avoid misaligned access in disklabel(8) in find_label
On Thu, Nov 07, 2019 at 19:06:29 +0100, Martin Husemann wrote:
> OK, why is it 8 byte aligned? Checking
>
> > revision 1.108
> > date: 2011-01-18 20:52:24 +0100; author: matt; state: Exp; lines: +2 -1;
> > Make struct disklabel 8 byte aligned. This increases its size by 4 bytes
> > on
On 07.11.2019 19:32, Valery Ushakov wrote:
> On Thu, Nov 07, 2019 at 18:08:40 +0100, Kamil Rytarowski wrote:
>
>> On 07.11.2019 16:45, Kamil Rytarowski wrote:
>>> On 07.11.2019 16:26, Martin Husemann wrote:
On Thu, Nov 07, 2019 at 02:53:08PM +0100, Kamil Rytarowski wrote:
> On 07.11.2019
Module Name:src
Committed By: kamil
Date: Thu Nov 7 18:35:41 UTC 2019
Modified Files:
src/sys/kern: subr_disk_mbr.c
Log Message:
Revert src/sys/kern/subr_disk_mbr.c r.1.52
Addressed in a better way in r. 1.53.
To generate a diff of this commit:
cvs rdiff -u -r1.53
Module Name:src
Committed By: kamil
Date: Thu Nov 7 18:35:41 UTC 2019
Modified Files:
src/sys/kern: subr_disk_mbr.c
Log Message:
Revert src/sys/kern/subr_disk_mbr.c r.1.52
Addressed in a better way in r. 1.53.
To generate a diff of this commit:
cvs rdiff -u -r1.53
On Thu, Nov 07, 2019 at 18:08:40 +0100, Kamil Rytarowski wrote:
> On 07.11.2019 16:45, Kamil Rytarowski wrote:
> > On 07.11.2019 16:26, Martin Husemann wrote:
> >> On Thu, Nov 07, 2019 at 02:53:08PM +0100, Kamil Rytarowski wrote:
> >>> On 07.11.2019 14:25, Valery Ushakov wrote:
> If the
Module Name:src
Committed By: kamil
Date: Thu Nov 7 18:30:27 UTC 2019
Modified Files:
src/sys/kern: subr_disk_mbr.c
Log Message:
Ensure in validate_label() that struct disklabel pointer is 8-byte aligned
The label is searched each 4 bytes and can be detected in an
Module Name:src
Committed By: kamil
Date: Thu Nov 7 18:30:27 UTC 2019
Modified Files:
src/sys/kern: subr_disk_mbr.c
Log Message:
Ensure in validate_label() that struct disklabel pointer is 8-byte aligned
The label is searched each 4 bytes and can be detected in an
On Thu, Nov 07, 2019 at 06:46:48PM +0100, Kamil Rytarowski wrote:
> member access within misaligned address 0x942d3de8c03c for type
> 'const struct disklabel' which requires 8 byte alignment
OK, why is it 8 byte aligned? Checking
> revision 1.108
> date: 2011-01-18 20:52:24 +0100;
On 07.11.2019 18:20, Martin Husemann wrote:
> On Thu, Nov 07, 2019 at 06:08:40PM +0100, Kamil Rytarowski wrote:
>> Please review:
>>
>> http://netbsd.org/~kamil/patch-00194-disklabel-alignment.txt
>>
>> This patch works for me.
>
> Yes, I believe that it does - but why is it needed?
>
syzbot
On Thu, Nov 07, 2019 at 06:08:40PM +0100, Kamil Rytarowski wrote:
> Please review:
>
> http://netbsd.org/~kamil/patch-00194-disklabel-alignment.txt
>
> This patch works for me.
Yes, I believe that it does - but why is it needed?
dlp = (void *)a->bp->b_data;
Here we can assume that
On 07.11.2019 16:45, Kamil Rytarowski wrote:
> On 07.11.2019 16:26, Martin Husemann wrote:
>> On Thu, Nov 07, 2019 at 02:53:08PM +0100, Kamil Rytarowski wrote:
>>> On 07.11.2019 14:25, Valery Ushakov wrote:
If the sanitizer does complain about other uses, there is little point
in fixing
David Young wrote in <20191107155806.gl1...@pobox.com>:
|On Thu, Nov 07, 2019 at 04:26:51PM +0100, Martin Husemann wrote:
|> On Thu, Nov 07, 2019 at 02:53:08PM +0100, Kamil Rytarowski wrote:
|>> On 07.11.2019 14:25, Valery Ushakov wrote:
..
|I think the problem is that if you have the series
On 07.11.2019 17:20, Kamil Rytarowski wrote:
> On 07.11.2019 17:08, Martin Husemann wrote:
>> On Thu, Nov 07, 2019 at 04:56:16PM +0100, Kamil Rytarowski wrote:
>>> 6.3.2.1 C11
>>>
>>> 'An lvalue is an expression (with an object type other than void) that
>>> potentially designates an object'
>>>
On Thu, Nov 07, 2019 at 09:58:06 -0600, David Young wrote:
> On Thu, Nov 07, 2019 at 04:26:51PM +0100, Martin Husemann wrote:
> > On Thu, Nov 07, 2019 at 02:53:08PM +0100, Kamil Rytarowski wrote:
> > > On 07.11.2019 14:25, Valery Ushakov wrote:
> > > > If the sanitizer does complain about other
On 07.11.2019 17:09, Martin Husemann wrote:
> On Thu, Nov 07, 2019 at 09:58:06AM -0600, David Young wrote:
>> I think the problem is that if you have the series of statements,
>>
>> element_t *e = >element;
>>
>> if (s == NULL)
>> return;
>
> Note that this example
On 07.11.2019 17:08, Martin Husemann wrote:
> On Thu, Nov 07, 2019 at 04:56:16PM +0100, Kamil Rytarowski wrote:
>> 6.3.2.1 C11
>>
>> 'An lvalue is an expression (with an object type other than void) that
>> potentially designates an object'
>>
>> This means that real dereference is not needed,
On Thu, Nov 07, 2019 at 09:58:06AM -0600, David Young wrote:
> I think the problem is that if you have the series of statements,
>
> element_t *e = >element;
>
> if (s == NULL)
> return;
Note that this example has *nothing* in common with Kamil's code change.
He
On Thu, Nov 07, 2019 at 04:56:16PM +0100, Kamil Rytarowski wrote:
> 6.3.2.1 C11
>
> 'An lvalue is an expression (with an object type other than void) that
> potentially designates an object'
>
> This means that real dereference is not needed, only a potential. And
> there are special cases of
On Thu, Nov 07, 2019 at 04:26:51PM +0100, Martin Husemann wrote:
> On Thu, Nov 07, 2019 at 02:53:08PM +0100, Kamil Rytarowski wrote:
> > On 07.11.2019 14:25, Valery Ushakov wrote:
> > > If the sanitizer does complain about other uses, there is little point
> > > in fixing one instance and not the
On 07.11.2019 16:49, Martin Husemann wrote:
> On Thu, Nov 07, 2019 at 04:45:31PM +0100, Kamil Rytarowski wrote:
>> Unfortunately the C committee went into the opposite direction here and
>> specified a potential dereference.
>
> Where?
>
> Martin
>
6.3.2.1 C99
"An lvalue is an expression with
On Thu, Nov 07, 2019 at 04:45:31PM +0100, Kamil Rytarowski wrote:
> Unfortunately the C committee went into the opposite direction here and
> specified a potential dereference.
Where?
Martin
On 07.11.2019 16:26, Martin Husemann wrote:
> On Thu, Nov 07, 2019 at 02:53:08PM +0100, Kamil Rytarowski wrote:
>> On 07.11.2019 14:25, Valery Ushakov wrote:
>>> If the sanitizer does complain about other uses, there is little point
>>> in fixing one instance and not the others.
>>
>> We already
On Thu, Nov 07, 2019 at 02:53:08PM +0100, Kamil Rytarowski wrote:
> On 07.11.2019 14:25, Valery Ushakov wrote:
> > If the sanitizer does complain about other uses, there is little point
> > in fixing one instance and not the others.
>
> We already agreed with Christos that this is appeasing of
On 07.11.2019 14:25, Valery Ushakov wrote:
> If the sanitizer does complain about other uses, there is little point
> in fixing one instance and not the others.
We already agreed with Christos that this is appeasing of GCC. If you
want to scan the whole kernel (or whole C) file for more
On Thu, Nov 07, 2019 at 15:48:55 +0300, Valery Ushakov wrote:
> On Thu, Nov 07, 2019 at 13:37:21 +0100, Kamil Rytarowski wrote:
>
> > On 07.11.2019 13:17, Valery Ushakov wrote:
> > > On Thu, Nov 07, 2019 at 06:02:39 +0100, Kamil Rytarowski wrote:
> > >
> > >> I have checked received the
On Thu, Nov 07, 2019 at 13:59:37 +0100, Kamil Rytarowski wrote:
> On 07.11.2019 13:48, Valery Ushakov wrote:
> > On Thu, Nov 07, 2019 at 13:37:21 +0100, Kamil Rytarowski wrote:
> >
> >> On 07.11.2019 13:17, Valery Ushakov wrote:
> >>> On Thu, Nov 07, 2019 at 06:02:39 +0100, Kamil Rytarowski
On 07.11.2019 13:48, Valery Ushakov wrote:
> On Thu, Nov 07, 2019 at 13:37:21 +0100, Kamil Rytarowski wrote:
>
>> On 07.11.2019 13:17, Valery Ushakov wrote:
>>> On Thu, Nov 07, 2019 at 06:02:39 +0100, Kamil Rytarowski wrote:
>>> As a side note - the C99 standard contains "derefer" exactly once,
On Thu, Nov 07, 2019 at 13:37:21 +0100, Kamil Rytarowski wrote:
> On 07.11.2019 13:17, Valery Ushakov wrote:
> > On Thu, Nov 07, 2019 at 06:02:39 +0100, Kamil Rytarowski wrote:
> >
> >> I have checked received the following patch and received a feedback from
> >> a LLVM developer.
> >>
> >> On
On 07.11.2019 13:17, Valery Ushakov wrote:
> On Thu, Nov 07, 2019 at 06:02:39 +0100, Kamil Rytarowski wrote:
>
>> I have checked received the following patch and received a feedback from
>> a LLVM developer.
>>
>> On 07.11.2019 05:47, 'Dmitry Vyukov' via syzkaller-netbsd-bugs wrote:
>>> I've
On Thu, Nov 07, 2019 at 06:02:39 +0100, Kamil Rytarowski wrote:
> I have checked received the following patch and received a feedback from
> a LLVM developer.
>
> On 07.11.2019 05:47, 'Dmitry Vyukov' via syzkaller-netbsd-bugs wrote:
> > I've consulted with some people and _presumably_ (to the
On 07.11.2019 11:53, Martin Husemann wrote:
> On Thu, Nov 07, 2019 at 11:46:47AM +0100, Kamil Rytarowski wrote:
>> Please see my newer mail with rationale and another one with a
>> confirmation that this was real UB.
>
> Confirmation? The dereference in this case happens in memcmp()
> only, so
On Thu, Nov 07, 2019 at 11:46:47AM +0100, Kamil Rytarowski wrote:
> Please see my newer mail with rationale and another one with a
> confirmation that this was real UB.
Confirmation? The dereference in this case happens in memcmp()
only, so what misalignment could there be?
Martin
On 07.11.2019 07:25, Martin Husemann wrote:
> On Wed, Nov 06, 2019 at 11:17:23PM +0100, Kamil Rytarowski wrote:
>> Technically, I think that this is a real UB.
>>
>> 6.3.2.3/7
>> A pointer to an object type may be converted to a pointer to a
>> different object type. If the resulting pointer is
On Wed, Nov 06, 2019 at 11:17:23PM +0100, Kamil Rytarowski wrote:
> Technically, I think that this is a real UB.
>
> 6.3.2.3/7
> A pointer to an object type may be converted to a pointer to a
> different object type. If the resulting pointer is not correctly
> aligned for the referenced type, the
sys/kern/vfs_subr.c:793:14,
member access within null pointer of type 'struct vnode_impl'
On 07.11.2019 00:03, Kamil Rytarowski wrote:
> On 06.11.2019 23:38, Christos Zoulas wrote:
>> On Nov 6, 11:17pm, n...@gmx.com (Kamil Rytarowski) wrote:
>> -- Subject: Re: CVS commit: src/sys/kern
On 06.11.2019 23:38, Christos Zoulas wrote:
> On Nov 6, 11:17pm, n...@gmx.com (Kamil Rytarowski) wrote:
> -- Subject: Re: CVS commit: src/sys/kern
>
> | Technically, I think that this is a real UB.
> |
> | 6.3.2.3/7
> | A pointer to an object type may be converted to a point
On Nov 6, 11:17pm, n...@gmx.com (Kamil Rytarowski) wrote:
-- Subject: Re: CVS commit: src/sys/kern
| Technically, I think that this is a real UB.
|
| 6.3.2.3/7
| A pointer to an object type may be converted to a pointer to a
| different object type. If the resulting pointer is not correctly
On 06.11.2019 22:43, Christos Zoulas wrote:
> In article <20191106130732.c6c5af...@cvs.netbsd.org>,
> Kamil Rytarowski wrote:
>> -=-=-=-=-=-
>>
>> Module Name: src
>> Committed By:kamil
>> Date:Wed Nov 6 13:07:32 UTC 2019
>>
>> Modified Files:
>> src/sys/kern:
In article <20191106130732.c6c5af...@cvs.netbsd.org>,
Kamil Rytarowski wrote:
>-=-=-=-=-=-
>
>Module Name: src
>Committed By: kamil
>Date: Wed Nov 6 13:07:32 UTC 2019
>
>Modified Files:
> src/sys/kern: subr_disk_mbr.c
>
>Log Message:
>Avoid unaligned pointer arithmetic in
Module Name:src
Committed By: kamil
Date: Wed Nov 6 13:07:32 UTC 2019
Modified Files:
src/sys/kern: subr_disk_mbr.c
Log Message:
Avoid unaligned pointer arithmetic in check_label_magic()
Replace the logic of calculating the address with with base + offset.
Reported by
Module Name:src
Committed By: kamil
Date: Wed Nov 6 13:07:32 UTC 2019
Modified Files:
src/sys/kern: subr_disk_mbr.c
Log Message:
Avoid unaligned pointer arithmetic in check_label_magic()
Replace the logic of calculating the address with with base + offset.
Reported by
Module Name:src
Committed By: christos
Date: Mon Oct 21 14:23:53 UTC 2019
Modified Files:
src/sys/kern: init_sysent.c
Log Message:
regen
To generate a diff of this commit:
cvs rdiff -u -r1.325 -r1.326 src/sys/kern/init_sysent.c
Please note that diffs are not public
Module Name:src
Committed By: christos
Date: Mon Oct 21 14:23:53 UTC 2019
Modified Files:
src/sys/kern: init_sysent.c
Log Message:
regen
To generate a diff of this commit:
cvs rdiff -u -r1.325 -r1.326 src/sys/kern/init_sysent.c
Please note that diffs are not public
Module Name:src
Committed By: tnn
Date: Sat Oct 19 06:36:47 UTC 2019
Modified Files:
src/sys/kern: uipc_mbuf.c
Log Message:
mcl_cache: align items to COHERENCY_UNIT
Because we do cache incoherent DMA to/from mbufs we cannot safely share
share cache lines with adjacent
Module Name:src
Committed By: tnn
Date: Sat Oct 19 06:36:47 UTC 2019
Modified Files:
src/sys/kern: uipc_mbuf.c
Log Message:
mcl_cache: align items to COHERENCY_UNIT
Because we do cache incoherent DMA to/from mbufs we cannot safely share
share cache lines with adjacent
Module Name:src
Committed By: christos
Date: Fri Oct 18 19:43:49 UTC 2019
Modified Files:
src/sys/kern: kern_event.c
Log Message:
print which process asked for an unsupported event so we can fix it.
To generate a diff of this commit:
cvs rdiff -u -r1.104 -r1.105
Module Name:src
Committed By: christos
Date: Fri Oct 18 19:43:49 UTC 2019
Modified Files:
src/sys/kern: kern_event.c
Log Message:
print which process asked for an unsupported event so we can fix it.
To generate a diff of this commit:
cvs rdiff -u -r1.104 -r1.105
Module Name:src
Committed By: kamil
Date: Tue Oct 15 13:59:57 UTC 2019
Modified Files:
src/sys/kern: kern_sig.c
Log Message:
Remove the short-circuit lwp_exit() path from sigswitch()
sigswitch() can be called from exit1() through:
ttywait()->ttysleep()->
Module Name:src
Committed By: kamil
Date: Tue Oct 15 13:59:57 UTC 2019
Modified Files:
src/sys/kern: kern_sig.c
Log Message:
Remove the short-circuit lwp_exit() path from sigswitch()
sigswitch() can be called from exit1() through:
ttywait()->ttysleep()->
On Mon, Oct 14, 2019 at 04:27:04PM +, Maxime Villard wrote:
> Module Name: src
> Committed By: maxv
> Date: Mon Oct 14 16:27:04 UTC 2019
>
> Modified Files:
> src/sys/kern: uipc_socket.c
>
> Log Message:
> Add a check before the memcpy. memcpy is defined to never take NULL as
Module Name:src
Committed By: maxv
Date: Mon Oct 14 16:27:04 UTC 2019
Modified Files:
src/sys/kern: uipc_socket.c
Log Message:
Add a check before the memcpy. memcpy is defined to never take NULL as
second argument, and the compiler is free to perform optimizations knowing
Module Name:src
Committed By: maxv
Date: Mon Oct 14 16:27:04 UTC 2019
Modified Files:
src/sys/kern: uipc_socket.c
Log Message:
Add a check before the memcpy. memcpy is defined to never take NULL as
second argument, and the compiler is free to perform optimizations knowing
Module Name:src
Committed By: christos
Date: Sun Oct 13 22:31:19 UTC 2019
Modified Files:
src/sys/kern: makesyscalls.sh
Log Message:
cast nullop though void *
To generate a diff of this commit:
cvs rdiff -u -r1.174 -r1.175 src/sys/kern/makesyscalls.sh
Please note that
Module Name:src
Committed By: christos
Date: Sun Oct 13 22:31:19 UTC 2019
Modified Files:
src/sys/kern: makesyscalls.sh
Log Message:
cast nullop though void *
To generate a diff of this commit:
cvs rdiff -u -r1.174 -r1.175 src/sys/kern/makesyscalls.sh
Please note that
Module Name:src
Committed By: kamil
Date: Sun Oct 13 03:50:26 UTC 2019
Modified Files:
src/sys/kern: kern_sig.c
Log Message:
Avoid double lwp_exit() in eventswitch()
For the PTRACE_LWP_EXIT event, the eventswitch() call is triggered from
lwp_exit(). In the case of
Module Name:src
Committed By: kamil
Date: Sun Oct 13 03:50:26 UTC 2019
Modified Files:
src/sys/kern: kern_sig.c
Log Message:
Avoid double lwp_exit() in eventswitch()
For the PTRACE_LWP_EXIT event, the eventswitch() call is triggered from
lwp_exit(). In the case of
Module Name:src
Committed By: kamil
Date: Sun Oct 13 03:19:57 UTC 2019
Modified Files:
src/sys/kern: kern_sig.c
Log Message:
Fix one the the root causes of unreliability of the ptrace(2)ed threads
In case of sigswitchin away in issignal() and continuing the execution on
Module Name:src
Committed By: kamil
Date: Sun Oct 13 03:19:57 UTC 2019
Modified Files:
src/sys/kern: kern_sig.c
Log Message:
Fix one the the root causes of unreliability of the ptrace(2)ed threads
In case of sigswitchin away in issignal() and continuing the execution on
Module Name:src
Committed By: kamil
Date: Sun Oct 13 03:10:22 UTC 2019
Modified Files:
src/sys/kern: kern_sig.c
Log Message:
Add sigswitch_unlock_and_switch_away(), extracted from sigswitch()
Use sigswitch_unlock_and_switch_away() whenever there is no need for
Module Name:src
Committed By: kamil
Date: Sun Oct 13 03:10:22 UTC 2019
Modified Files:
src/sys/kern: kern_sig.c
Log Message:
Add sigswitch_unlock_and_switch_away(), extracted from sigswitch()
Use sigswitch_unlock_and_switch_away() whenever there is no need for
Module Name:src
Committed By: kamil
Date: Sat Oct 12 12:04:37 UTC 2019
Modified Files:
src/sys/kern: sys_ptrace_common.c
Log Message:
Avoid signed integer overflow for -lwp where lwp is INT_MIN
Reported-by: syzbot+68b80b44b898e66da...@syzkaller.appspotmail.com
To
Module Name:src
Committed By: kamil
Date: Sat Oct 12 12:04:37 UTC 2019
Modified Files:
src/sys/kern: sys_ptrace_common.c
Log Message:
Avoid signed integer overflow for -lwp where lwp is INT_MIN
Reported-by: syzbot+68b80b44b898e66da...@syzkaller.appspotmail.com
To
Module Name:src
Committed By: kamil
Date: Sat Oct 12 10:55:23 UTC 2019
Modified Files:
src/sys/kern: kern_exec.c kern_fork.c kern_proc.c kern_sig.c
Log Message:
Remove p_oppid from struct proc
This field is not needed as it duplicated p_opptr that is alread safe to
use,
Module Name:src
Committed By: kamil
Date: Sat Oct 12 10:55:23 UTC 2019
Modified Files:
src/sys/kern: kern_exec.c kern_fork.c kern_proc.c kern_sig.c
Log Message:
Remove p_oppid from struct proc
This field is not needed as it duplicated p_opptr that is alread safe to
use,
Module Name:src
Committed By: hannken
Date: Fri Oct 11 08:05:19 UTC 2019
Modified Files:
src/sys/kern: vnode_if.c
Log Message:
Regen.
To generate a diff of this commit:
cvs rdiff -u -r1.107 -r1.108 src/sys/kern/vnode_if.c
Please note that diffs are not public domain;
Module Name:src
Committed By: hannken
Date: Fri Oct 11 08:05:19 UTC 2019
Modified Files:
src/sys/kern: vnode_if.c
Log Message:
Regen.
To generate a diff of this commit:
cvs rdiff -u -r1.107 -r1.108 src/sys/kern/vnode_if.c
Please note that diffs are not public domain;
Module Name:src
Committed By: hannken
Date: Fri Oct 11 08:04:52 UTC 2019
Modified Files:
src/sys/kern: vnode_if.sh vnode_if.src
Log Message:
As VOP_STRATEGY() usually calls itself on the file system holding "/dev"
it may deadlock on suspension of this file system.
Add
Module Name:src
Committed By: hannken
Date: Fri Oct 11 08:04:52 UTC 2019
Modified Files:
src/sys/kern: vnode_if.sh vnode_if.src
Log Message:
As VOP_STRATEGY() usually calls itself on the file system holding "/dev"
it may deadlock on suspension of this file system.
Add
Le 30/09/2019 à 20:51, Nick Hudson a écrit :
On 30 Sep 2019, at 18:06, Tobias Nygren wrote:
On Mon, 23 Sep 2019 05:39:59 +
Nick Hudson wrote:
Modified Files:
src/sys/kern: subr_pool.c
Log Message:
Enable POOL_REDZONE with DIAGNOSTIC.
The bug in the arm pmap was fixed long ago.
Module Name:src
Committed By: chs
Date: Wed Oct 9 17:47:13 UTC 2019
Modified Files:
src/sys/kern: sysv_shm.c
Log Message:
simpler fix for the race between shmat() and shmdt():
change shmat() to hold shm_lock until it is completely done.
To generate a diff of this
Module Name:src
Committed By: chs
Date: Wed Oct 9 17:47:13 UTC 2019
Modified Files:
src/sys/kern: sysv_shm.c
Log Message:
simpler fix for the race between shmat() and shmdt():
change shmat() to hold shm_lock until it is completely done.
To generate a diff of this
Module Name:src
Committed By: chs
Date: Wed Oct 9 17:44:45 UTC 2019
Modified Files:
src/sys/kern: sysv_shm.c
Log Message:
revert rev 1.139 (fixing a race between shmat() and shmdt())
that approach turned out to be too complicated.
To generate a diff of this commit:
cvs
Module Name:src
Committed By: chs
Date: Wed Oct 9 17:44:45 UTC 2019
Modified Files:
src/sys/kern: sysv_shm.c
Log Message:
revert rev 1.139 (fixing a race between shmat() and shmdt())
that approach turned out to be too complicated.
To generate a diff of this commit:
cvs
1101 - 1200 of 1962 matches
Mail list logo
