Re: CVS commit: src/sys/netinet6

On Fri, Apr 24, 2020 at 05:36:55PM +, Jonathan A. Kollasch wrote: > Module Name: src > Committed By: jakllsch > Date: Fri Apr 24 17:36:55 UTC 2020 > > Modified Files: > src/sys/netinet6: in6_proto.c > > Log Message: > Fill in .pr_usrreqs for SOCK_SEQPACKET and SOCK_STREAM

Re: CVS commit: src/sys/netinet6

On 22/04/2020 20:32, Roy Marples wrote: Module Name:src Committed By: roy Date: Wed Apr 22 19:32:11 UTC 2020 Modified Files: src/sys/netinet6: nd6_nbr.c Log Message: inet6: nd6_na_input() now considers ln_state <= ND6_LLINFO_INCOMPLETE Otherwise if ln_state !=

Re: CVS commit: src/sys/netinet6

Now that's a simpler fix than I imagined it would be... kre

Re: CVS commit: src/sys/netinet6

On Wed, 28 Aug 2019, Roy Marples wrote: On 27/08/2019 22:17, Hisashi T Fujinaka wrote: Is this necessary for -9 too? Pretty much every BSD with IPv6. I'll submit a PR for -9 in day or so. I need to work this and a few other recent changes for -8 and maybe -7 also. Cool. Thanks for all the

Re: CVS commit: src/sys/netinet6

On 27/08/2019 22:17, Hisashi T Fujinaka wrote: Is this necessary for -9 too? Pretty much every BSD with IPv6. I'll submit a PR for -9 in day or so. I need to work this and a few other recent changes for -8 and maybe -7 also. Roy

Re: CVS commit: src/sys/netinet6

Is this necessary for -9 too? On Tue, 27 Aug 2019, Roy Marples wrote: Module Name:src Committed By: roy Date: Tue Aug 27 21:11:26 UTC 2019 Modified Files: src/sys/netinet6: nd6.c Log Message: inet6: nd6_free assumes all routers are processed by kernel RA This hasn't

Re: CVS commit: src/sys/netinet6

On Tue, May 29, 2018 at 6:10 PM Patrick Welche wrote: > Module Name:src > Committed By: prlw1 > Date: Tue May 29 09:10:39 UTC 2018 > Modified Files: > src/sys/netinet6: in6.c > Log Message: > Mark in6m as used for non-DIAGNOSTIC builds. Oops! Thank you for the fix.

Re: CVS commit: src/sys/netinet6

m...@netbsd.org wrote: >Module Name:src >Committed By: maxv >Date: Tue Jan 30 15:54:03 UTC 2018 > >Modified Files: >src/sys/netinet6: in6.h ip6_input.c ip6_var.h > >Log Message: >Style, localify, remove dead code, and fix typos. No functional change. Please could we make

Re: CVS commit: src/sys/netinet6

On Thu, Jan 11, 2018 at 2:07 PM, Ryota Ozaki wrote: > Hi, > > I'm going to change to use callout_stop because it seems using it > is almost harmless in practical. See the below explanation (tl;dr). Eventually we found a possible way to use callout_stop for (MP-)safe

Re: CVS commit: src/sys/netinet6

Hi, I'm going to change to use callout_stop because it seems using it is almost harmless in practical. See the below explanation (tl;dr). I investigated how using callout_stop affects and figured out it can be problematic but the probability is quite low. (That's why NetBSD 7 and earlier using

Re: CVS commit: src/sys/netinet6

On 27/12/2017 09:08, Ryota Ozaki wrote: There are other paths. nd6_dad_stop is called from in6_purgeaddr, in6_if_link_down and nd6_ioctl. nd6_dad_duplicated is called nd6_dad_timer, nd6_dad_ns_input and nd6_dad_na_input. I added the below assertion in my local repository and found

Re: CVS commit: src/sys/netinet6

On Wed, Dec 27, 2017 at 10:40 AM, Ryota Ozaki wrote: > On Wed, Dec 27, 2017 at 10:36 AM, Taylor R Campbell > wrote: >>> Date: Wed, 27 Dec 2017 10:31:25 +0900 >>> From: Ryota Ozaki >>> >>> On Wed, Dec 27, 2017

Re: CVS commit: src/sys/netinet6

On Wed, Dec 27, 2017 at 10:36 AM, Taylor R Campbell wrote: >> Date: Wed, 27 Dec 2017 10:31:25 +0900 >> From: Ryota Ozaki >> >> On Wed, Dec 27, 2017 at 10:27 AM, Taylor R Campbell >>

Re: CVS commit: src/sys/netinet6

> Date: Wed, 27 Dec 2017 10:31:25 +0900 > From: Ryota Ozaki > > On Wed, Dec 27, 2017 at 10:27 AM, Taylor R Campbell > wrote: > > Can you add this to the collection? > > > > #ifdef NET_MPSAFE > > #define

Re: CVS commit: src/sys/netinet6

On Wed, Dec 27, 2017 at 10:27 AM, Taylor R Campbell wrote: >> Date: Wed, 27 Dec 2017 10:24:26 +0900 >> From: Ryota Ozaki >> >> On Wed, Dec 27, 2017 at 12:50 AM, Taylor R Campbell >>

Re: CVS commit: src/sys/netinet6

> Date: Wed, 27 Dec 2017 10:24:26 +0900 > From: Ryota Ozaki > > On Wed, Dec 27, 2017 at 12:50 AM, Taylor R Campbell > wrote: > > Can you just pass the interlock -- softnet_lock or NULL, depending on > > NET_MPSAFE -- as an

Re: CVS commit: src/sys/netinet6

On Wed, Dec 27, 2017 at 12:50 AM, Taylor R Campbell wrote: >> Date: Tue, 26 Dec 2017 18:42:14 +0900 >> From: Ryota Ozaki >> >> On Tue, Dec 26, 2017 at 6:30 PM, Paul Goyette wrote: >> > I'd really like to see

Re: CVS commit: src/sys/netinet6

> Date: Tue, 26 Dec 2017 18:42:14 +0900 > From: Ryota Ozaki > > On Tue, Dec 26, 2017 at 6:30 PM, Paul Goyette wrote: > > I'd really like to see other peoples' opinions on this matter before > > making a final decision. (And I'm rather surprised that

Re: CVS commit: src/sys/netinet6

On Tue, Dec 26, 2017 at 6:30 PM, Paul Goyette wrote: > On Tue, 26 Dec 2017, Ryota Ozaki wrote: > >> On Tue, Dec 26, 2017 at 4:30 PM, Paul Goyette wrote: >>> >>> On Tue, 26 Dec 2017, Ryota Ozaki wrote: >>> > Well, since the lock _might_ be released (and

Re: CVS commit: src/sys/netinet6

On Tue, 26 Dec 2017, Ryota Ozaki wrote: On Tue, Dec 26, 2017 at 4:30 PM, Paul Goyette wrote: On Tue, 26 Dec 2017, Ryota Ozaki wrote: Well, since the lock _might_ be released (and subsequently reacquired) by callout_halt(), it might be easiest to modify all the callers to

Re: CVS commit: src/sys/netinet6

On Tue, Dec 26, 2017 at 4:30 PM, Paul Goyette wrote: > On Tue, 26 Dec 2017, Ryota Ozaki wrote: > >>> Well, since the lock _might_ be released (and subsequently reacquired) >>> by callout_halt(), it might be easiest to modify all the callers to >>> just unlock it before calling

Re: CVS commit: src/sys/netinet6

On Tue, 26 Dec 2017, Ryota Ozaki wrote: Well, since the lock _might_ be released (and subsequently reacquired) by callout_halt(), it might be easiest to modify all the callers to just unlock it before calling nd6_dad_stoptimer(), and reacquire the mutex after it returns (as well as

Re: CVS commit: src/sys/netinet6

On Tue, Dec 26, 2017 at 12:37 PM, Paul Goyette wrote: > On Tue, 26 Dec 2017, Ryota Ozaki wrote: > >> On Tue, Dec 26, 2017 at 11:35 AM, Paul Goyette wrote: >>> >>> To generate a diff of this commit: >>> >>> >>> >>> # cvs rdiff -u -r1.139 -r1.140

Re: CVS commit: src/sys/netinet6

On Tue, 26 Dec 2017, Ryota Ozaki wrote: On Tue, Dec 26, 2017 at 11:35 AM, Paul Goyette wrote: To generate a diff of this commit: # cvs rdiff -u -r1.139 -r1.140 src/sys/netinet6/nd6_nbr.c @@ -1097,7 +1097,11 @@ nd6_dad_stoptimer(struct dadq *dp) #ifdef NET_MPSAFE

Re: CVS commit: src/sys/netinet6

On Tue, Dec 26, 2017 at 11:35 AM, Paul Goyette wrote: > >> To generate a diff of this commit: > > > # cvs rdiff -u -r1.139 -r1.140 src/sys/netinet6/nd6_nbr.c > @@ -1097,7 +1097,11 @@ nd6_dad_stoptimer(struct dadq *dp) > #ifdef NET_MPSAFE > callout_halt(>dad_timer_ch,

Re: CVS commit: src/sys/netinet6

To generate a diff of this commit: # cvs rdiff -u -r1.139 -r1.140 src/sys/netinet6/nd6_nbr.c @@ -1097,7 +1097,11 @@ nd6_dad_stoptimer(struct dadq *dp) #ifdef NET_MPSAFE callout_halt(>dad_timer_ch, NULL); #else - callout_halt(>dad_timer_ch, softnet_lock); + /* XXX still

Re: CVS commit: src/sys/netinet6

comment fixed (CVS lines removed). Sorry for the noise Frank On 05/13/17 22:13, Frank Kardel wrote: Module Name:src Committed By: kardel Date: Sat May 13 20:13:27 UTC 2017 Modified Files: src/sys/netinet6: mld6.c Log Message: avoid a double ifa_release() and thus a

Re: CVS commit: src/sys/netinet6

On Mon, Mar 18, 2013 at 07:31:39PM +, Greg Troxel wrote: Module Name: src Committed By: gdt Date: Mon Mar 18 19:31:39 UTC 2013 Modified Files: src/sys/netinet6: ip6_output.c Log Message: Initialize variable used as (conditional) result parameter. ip6_insertfraghdr

Re: CVS commit: src/sys/netinet6

David Laight da...@l8s.co.uk writes: On Mon, Mar 18, 2013 at 07:31:39PM +, Greg Troxel wrote: Module Name: src Committed By:gdt Date:Mon Mar 18 19:31:39 UTC 2013 Modified Files: src/sys/netinet6: ip6_output.c Log Message: Initialize variable used as

Re: CVS commit: src/sys/netinet6

On Sat, Jul 25, 2009 at 11:12:09PM +, Tonnerre Lombard wrote: Module Name: src Committed By: tonnerre Date: Sat Jul 25 23:12:09 UTC 2009 Modified Files: src/sys/netinet6: nd6.c nd6_rtr.c Log Message: Instead of using the net.inet6.ip6.accept_rtadv sysctl for all

re: CVS commit: src/sys/netinet6

That said, where we now return EPERM is where in the future we'll return the error value returned by kauth(9), like many many other places in the kernel. Other parts of the networking stacks (say, opening a raw socket) now return EPERM instead of EACCES ip(4) and ip6(4)

Re: CVS commit: src/sys/netinet6

On Sun, May 10, 2009 at 8:44 AM, YAMAMOTO Takashi y...@mwd.biglobe.ne.jp wrote: have you checked callers and ensure that the change from EACCES to EPERM won't be a problem? Only ipsec_set_policy() returns EPERM instead of EACCES now, and I don't think it should be a problem. don't think?  

Re: CVS commit: src/sys/netinet6

hi, On Sun, May 10, 2009 at 8:44 AM, YAMAMOTO Takashi y...@mwd.biglobe.ne.jp wrote: have you checked callers and ensure that the change from EACCES to EPERM won't be a problem? Only ipsec_set_policy() returns EPERM instead of EACCES now, and I don't think it should be a problem. don't

Re: CVS commit: src/sys/netinet6

On Sun, May 10, 2009 at 1:12 PM, YAMAMOTO Takashi y...@mwd.biglobe.ne.jp wrote: That said, where we now return EPERM is where in the future we'll return the error value returned by kauth(9), like many many other places in the kernel. Other parts of the networking stacks (say, opening a raw

Re: CVS commit: src/sys/netinet6

hi, On Fri, May 8, 2009 at 2:18 AM, YAMAMOTO Takashi y...@mwd.biglobe.ne.jp wrote: hi, have you checked callers and ensure that the change from EACCES to EPERM won't be a problem? Only ipsec_set_policy() returns EPERM instead of EACCES now, and I don't think it should be a problem.