Re: CVS commit: src/usr.bin/make

2013-07-16 Thread Christos Zoulas
On Jul 16, 11:20pm, ryo...@yk.rim.or.jp (Ryo ONODERA) wrote: -- Subject: Re: CVS commit: src/usr.bin/make | With this change, I have gotten following errors. | I think -lutil is needed. No, I fixed it... I was supposed to use bmake_foo() not efoo(). christos

Re: CVS commit: src/usr.bin/make

2013-07-16 Thread Ryo ONODERA
From: chris...@zoulas.com (Christos Zoulas), Date: Tue, 16 Jul 2013 10:23:04 -0400 On Jul 16, 11:20pm, ryo...@yk.rim.or.jp (Ryo ONODERA) wrote: -- Subject: Re: CVS commit: src/usr.bin/make | With this change, I have gotten following errors. | I think -lutil is needed. No, I fixed

Re: CVS commit: src/usr.bin/make

2013-07-16 Thread David Holland
On Tue, Jul 16, 2013 at 08:00:56PM +, Simon J. Gerraty wrote: Modified Files: src/usr.bin/make: var.c Log Message: When a var is set in the CMD context, it prevents the same name being set in GLOBAL context. We should also delete any such variable in GLOBAL context, else

Re: CVS commit: src/usr.bin/make

2013-07-10 Thread Christos Zoulas
In article krbu04$2j1$1...@ger.gmane.org, Christos Zoulas chris...@astron.com wrote: Module Name: src Committed By: sjg Date: Sat Jul 6 18:19:17 UTC 2013 Modified Files: src/usr.bin/make: main.c var.c Log Message: If using gmake's MAKELEVEL; use it the same way Now you put it

Re: CVS commit: src/usr.bin/make

2013-07-10 Thread Ryo ONODERA
From: chris...@astron.com (Christos Zoulas), Date: Wed, 10 Jul 2013 13:08:49 + (UTC) In article krbu04$2j1$1...@ger.gmane.org, Christos Zoulas chris...@astron.com wrote: Module Name: src Committed By:sjg Date:Sat Jul 6 18:19:17 UTC 2013 Modified Files:

Re: CVS commit: src/usr.bin/make

2013-07-10 Thread Christos Zoulas
In article 20130710.232445.202823964487691297.ryo...@yk.rim.or.jp, Ryo ONODERA ryo...@yk.rim.or.jp wrote: From: chris...@astron.com (Christos Zoulas), Date: Wed, 10 Jul 2013 13:08:49 + (UTC) In article krbu04$2j1$1...@ger.gmane.org, Christos Zoulas chris...@astron.com wrote: Module Name:

Re: CVS commit: src/usr.bin/make

2013-07-10 Thread Ryo ONODERA
From: chris...@astron.com (Christos Zoulas), Date: Wed, 10 Jul 2013 15:08:39 + (UTC) In article 20130710.232445.202823964487691297.ryo...@yk.rim.or.jp, Ryo ONODERA ryo...@yk.rim.or.jp wrote: From: chris...@astron.com (Christos Zoulas), Date: Wed, 10 Jul 2013 13:08:49 + (UTC) In

Re: CVS commit: src/usr.bin/make

2013-07-07 Thread Christos Zoulas
Module Name: src Committed By: sjg Date: Sat Jul 6 18:19:17 UTC 2013 Modified Files: src/usr.bin/make: main.c var.c Log Message: If using gmake's MAKELEVEL; use it the same way Now you put it back the way it was before which is wrong. Gmake does not behave this way. Before

Re: CVS commit: src/usr.bin/make

2013-06-18 Thread Christos Zoulas
In article 20130618200609.a234...@cvs.netbsd.org, Simon J. Gerraty source-changes-d@NetBSD.org wrote: -=-=-=-=-=- Module Name: src Committed By: sjg Date: Tue Jun 18 20:06:09 UTC 2013 Modified Files: src/usr.bin/make: main.c make.h var.c Log Message: Use a #define for the

Re: CVS commit: src/usr.bin/make

2013-03-08 Thread Christos Zoulas
On Mar 8, 5:21pm, lu...@netbsd.org (Luke Mewburn) wrote: -- Subject: Re: CVS commit: src/usr.bin/make | Removing the source files would be an epic, | if brutal, method of fixing the problem. :-) I think it is still possible to do this with the code I added :-) christos

Re: CVS commit: src/usr.bin/make

2013-03-07 Thread Luke Mewburn
On Tue, Mar 05, 2013 at 08:35:42PM +, Christos Zoulas wrote: | In article CADbF7eeV2AcmiVZJzuxsN8gvwQHfMLYVN63gRdXpv8-jV=x...@mail.gmail.com, | Masao Uebayashi uebay...@gmail.com wrote: | -=-=-=-=-=- | | I like make(1) to exit when stale depend is found. | | I was thinking of

Re: CVS commit: src/usr.bin/make

2013-03-06 Thread Christos Zoulas
In article 20130306073342.gg4...@apb-laptoy.apb.alt.za, Alan Barrett a...@cequrux.com wrote: On Tue, 05 Mar 2013, Christos Zoulas wrote: Modified Files: src/usr.bin/make: dir.c job.c job.h make.1 parse.c Log Message: Add a .STALE special target that gets invoked when dependency files

Re: CVS commit: src/usr.bin/make

2013-03-05 Thread Masao Uebayashi
I like make(1) to exit when stale depend is found. On Tue, Mar 5, 2013 at 11:04 AM, Christos Zoulas chris...@netbsd.orgwrote: Module Name:src Committed By: christos Date: Tue Mar 5 02:04:11 UTC 2013 Modified Files: src/usr.bin/make: dir.c job.c parse.c Log

Re: CVS commit: src/usr.bin/make

2013-03-05 Thread Christos Zoulas
In article CADbF7eeV2AcmiVZJzuxsN8gvwQHfMLYVN63gRdXpv8-jV=x...@mail.gmail.com, Masao Uebayashi uebay...@gmail.com wrote: -=-=-=-=-=- I like make(1) to exit when stale depend is found. I was thinking of adding a .STALE target, so you can do what you like, for example: .STALE: rm -f

Re: CVS commit: src/usr.bin/make

2013-03-05 Thread Alan Barrett
On Tue, 05 Mar 2013, Christos Zoulas wrote: Modified Files: src/usr.bin/make: dir.c job.c job.h make.1 parse.c Log Message: Add a .STALE special target that gets invoked when dependency files contain stail entries. Please discuss this sort of thing first. There may be a way to solve

Re: CVS commit: src/usr.bin/make

2013-01-26 Thread David Laight
On Sat, Jan 26, 2013 at 10:53:00AM -0500, Christos Zoulas wrote: Module Name: src Committed By: christos Date: Sat Jan 26 15:53:00 UTC 2013 Modified Files: src/usr.bin/make: job.c main.c Log Message: Check read and write errors to avoid warnings from linux. XXX: Should

Re: CVS commit: src/usr.bin/make

2013-01-26 Thread Christos Zoulas
In article 20130126205325.gd28...@snowdrop.l8s.co.uk, David Laight da...@l8s.co.uk wrote: I'd have been tempted to do: int stupid_glibc_wont_let_us_ignore_the_result_of_write(int fd, const void *buf, size_t len) { return write(fd, buf, len); } It is the linux headers :-) I'm not sure,

re: CVS commit: src/usr.bin/make

2013-01-26 Thread matthew green
Not much point writing an error is you'vejust failed to write to stderr! i disagree -- ktrace sees it and thus it is not entirely lost :)

Re: CVS commit: src/usr.bin/make

2012-11-03 Thread David Laight
On Sat, Nov 03, 2012 at 02:25:14AM +, Simon J. Gerraty wrote: Module Name: src Committed By: sjg Date: Sat Nov 3 02:25:13 UTC 2012 Modified Files: src/usr.bin/make: cond.c Log Message: Allow cond_state[] to grow. The need is rare, but real. 128 nested conditional

Re: CVS commit: src/usr.bin/make

2011-06-10 Thread Matt Thomas
On Jun 10, 2011, at 4:57 PM, Simon J. Gerraty wrote: Module Name: src Committed By: sjg Date: Fri Jun 10 23:57:39 UTC 2011 Modified Files: src/usr.bin/make: meta.c Log Message: size_t on amd64 doesn't like %u, use a cast. why not use %zu?

Re: CVS commit: src/usr.bin/make

2011-06-10 Thread Jukka Ruohonen
On Fri, Jun 10, 2011 at 11:57:39PM +, Simon J. Gerraty wrote: Module Name: src Committed By: sjg Date: Fri Jun 10 23:57:39 UTC 2011 Modified Files: src/usr.bin/make: meta.c Log Message: size_t on amd64 doesn't like %u, use a cast. %zu? - Jukka.

re: CVS commit: src/usr.bin/make

2011-06-10 Thread matthew green
On Fri, Jun 10, 2011 at 11:57:39PM +, Simon J. Gerraty wrote: Module Name:src Committed By: sjg Date: Fri Jun 10 23:57:39 UTC 2011 Modified Files: src/usr.bin/make: meta.c Log Message: size_t on amd64 doesn't like %u, use a cast. %zu?

Re: CVS commit: src/usr.bin/make

2011-05-18 Thread David Laight
On Wed, May 18, 2011 at 02:43:03AM +, David Holland wrote: On Tue, May 17, 2011 at 09:56:52PM +, David Laight wrote: cvs rdiff -u -r1.51 -r1.52 src/usr.bin/make/Makefile uh, did you mean to commit that? No - I've changed it back. David -- David Laight: da...@l8s.co.uk

Re: CVS commit: src/usr.bin/make

2011-05-17 Thread David Holland
On Tue, May 17, 2011 at 09:56:52PM +, David Laight wrote: cvs rdiff -u -r1.51 -r1.52 src/usr.bin/make/Makefile uh, did you mean to commit that? -- David A. Holland dholl...@netbsd.org

Re: CVS commit: src/usr.bin/make

2011-04-06 Thread Joerg Sonnenberger
On Thu, Apr 07, 2011 at 02:49:31AM +0100, Mindaugas Rasiukevicius wrote: Joerg Sonnenberger jo...@netbsd.org wrote: Module Name:src Committed By: joerg Date: Thu Apr 7 01:40:02 UTC 2011 Modified Files: src/usr.bin/make: make.1 var.c

Re: CVS commit: src/usr.bin/make

2010-11-26 Thread Martin Husemann
On Thu, Nov 25, 2010 at 04:31:10PM -0500, Christos Zoulas wrote: Module Name: src Committed By: christos Date: Thu Nov 25 21:31:09 UTC 2010 Modified Files: src/usr.bin/make: arch.c compat.c make.c make.h targ.c Log Message: Instead of keeping around the mtime of the

Re: CVS commit: src/usr.bin/make

2010-11-26 Thread Christos Zoulas
In article 20101126105706.ga18...@homeworld.netbsd.org, Martin Husemann mar...@homeworld.netbsd.org wrote: On Thu, Nov 25, 2010 at 04:31:10PM -0500, Christos Zoulas wrote: Module Name: src Committed By:christos Date:Thu Nov 25 21:31:09 UTC 2010 Modified Files:

Re: CVS commit: src/usr.bin/make

2010-11-26 Thread Christoph Egger
Original-Nachricht Datum: Fri, 26 Nov 2010 13:56:22 + (UTC) Von: chris...@astron.com An: source-changes-d@NetBSD.org Betreff: Re: CVS commit: src/usr.bin/make In article 20101126105706.ga18...@homeworld.netbsd.org, Martin Husemann mar...@homeworld.netbsd.org wrote

Re: CVS commit: src/usr.bin/make

2010-11-26 Thread Christos Zoulas
On Nov 26, 3:34pm, christoph_eg...@gmx.de (Christoph Egger) wrote: -- Subject: Re: CVS commit: src/usr.bin/make | BTW: It works on a clean build. | | I must have forgotten to test for cmgn NULL somewhere; where | does gdb say that it dies? | | Core was generated by `nbmake'. | Program

Re: CVS commit: src/usr.bin/make

2010-11-26 Thread Christoph Egger
On Nov 26, 3:34pm, christoph_eg...@gmx.de (Christoph Egger) wrote: -- Subject: Re: CVS commit: src/usr.bin/make | BTW: It works on a clean build. | | I must have forgotten to test for cmgn NULL somewhere; where | does gdb say that it dies? | | Core was generated by `nbmake

Re: CVS commit: src/usr.bin/make

2010-06-09 Thread Joerg Sonnenberger
On Wed, Jun 09, 2010 at 12:58:23PM -0400, Christos Zoulas wrote: Log Message: Explain variable expansion better. Requested by Aleksey Cheusov This is wrong. Loop variables are not exapnded on each loop iteration. Each loop iteration effectively creates a new variable. The rest of his confusion

Re: CVS commit: src/usr.bin/make

2010-06-09 Thread Christos Zoulas
In article 20100609171621.ga23...@britannica.bec.de, Joerg Sonnenberger jo...@britannica.bec.de wrote: On Wed, Jun 09, 2010 at 12:58:23PM -0400, Christos Zoulas wrote: Log Message: Explain variable expansion better. Requested by Aleksey Cheusov This is wrong. Loop variables are not exapnded on

Re: CVS commit: src/usr.bin/make

2010-06-09 Thread M. Warner Losh
In message: huonge$v4...@dough.gmane.org chris...@astron.com (Christos Zoulas) writes: : In article 20100609171621.ga23...@britannica.bec.de, : Joerg Sonnenberger jo...@britannica.bec.de wrote: : On Wed, Jun 09, 2010 at 12:58:23PM -0400, Christos Zoulas wrote: : Log Message: :

Re: CVS commit: src/usr.bin/make

2010-06-09 Thread David Laight
On Wed, Jun 09, 2010 at 06:45:35PM +, Christos Zoulas wrote: This is wrong. Loop variables are not exapnded on each loop iteration. Each loop iteration effectively creates a new variable. The rest of his confusion comes from two simple facts: (1) += is lazy in bmake. This is different

Re: CVS commit: src/usr.bin/make

2010-06-09 Thread David Laight
On Wed, Jun 09, 2010 at 01:19:29PM -0600, M. Warner Losh wrote: It looks like it is lazy to me for all non-loop variables in FreeBSD: ... % cat M FOO=1 BAR=2 .for j in a b c FOO+= ${BAR} ${j} .endfor BAR=3 all: @echo ${FOO} @echo ${BAR} % make -f M 1 3 a 3 b 3 c

Re: CVS commit: src/usr.bin/make

2010-05-17 Thread Christos Zoulas
In article 20100514052935.gg26...@netbsd.org, David Holland dholland-sourcechan...@netbsd.org wrote: On Wed, May 05, 2010 at 10:10:39AM -0400, Christos Zoulas wrote: Revert bogus patch that attempted to canonicalize a non absolute argv[0] using realpath(3). Consider: touch Makefile; mkdir

Re: CVS commit: src/usr.bin/make

2010-05-17 Thread David Holland
On Mon, May 17, 2010 at 01:01:17PM -0400, Christos Zoulas wrote: Log Message: put back canonicalization, but avoid doing it for files that don't contain / From dholland ...in the sense that I did none of the work? Thanks though :-) -- David A. Holland dholl...@netbsd.org

Re: CVS commit: src/usr.bin/make

2010-04-29 Thread Joerg Sonnenberger
On Thu, Apr 29, 2010 at 11:12:21PM +, Simon J. Gerraty wrote: Module Name: src Committed By: sjg Date: Thu Apr 29 23:12:21 UTC 2010 Modified Files: src/usr.bin/make: main.c parse.c Log Message: fflush stdout, before writing to stderr. In which situation does it

Re: CVS commit: src/usr.bin/make

2010-04-29 Thread Phil Nelson
On Thursday 29 April 2010 17:02:50 Joerg Sonnenberger wrote: On Thu, Apr 29, 2010 at 11:12:21PM +, Simon J. Gerraty wrote: Module Name:  src Committed By: sjg Date: Thu Apr 29 23:12:21 UTC 2010 Modified Files:   src/usr.bin/make: main.c parse.c Log Message:

Re: CVS commit: src/usr.bin/make

2010-04-22 Thread Tom Spindler
Modified Files: src/usr.bin/make: job.c main.c make.h Log Message: Just because $TMPDIR is set does not mean it is valid. Add a central function for creating temp files so we have one place to audit. This breaks build.sh when bootstrapping nbmake on linux: cc -O -o nbmake *.o

Re: CVS commit: src/usr.bin/make

2010-04-22 Thread Simon J. Gerraty
On Thu, 22 Apr 2010 19:51:07 +, Tom Spindler writes: Modified Files: src/usr.bin/make: job.c main.c make.h Log Message: Just because $TMPDIR is set does not mean it is valid. Add a central function for creating temp files so we have one place to audit. This breaks build.sh when

Re: CVS commit: src/usr.bin/make

2010-04-22 Thread Simon J. Gerraty
Dh already commited the exact same change I just tried to. On Thu, 22 Apr 2010 19:51:07 +, Tom Spindler writes: Modified Files: src/usr.bin/make: job.c main.c make.h Log Message: Just because $TMPDIR is set does not mean it is valid. Add a central function for creating temp files

Re: CVS commit: src/usr.bin/make

2010-04-22 Thread David Holland
On Thu, Apr 22, 2010 at 02:11:31PM -0700, Simon J. Gerraty wrote: Dh already commited the exact same change I just tried to. sorry, didn't look here first. :-/ -- David A. Holland dholl...@netbsd.org

Re: CVS commit: src/usr.bin/make

2010-04-22 Thread Simon J. Gerraty
Thanks for fixing that. On Thu, 22 Apr 2010 22:00:26 +, David Holland writes: On Thu, Apr 22, 2010 at 02:11:31PM -0700, Simon J. Gerraty wrote: Dh already commited the exact same change I just tried to. sorry, didn't look here first. :-/

Re: CVS commit: src/usr.bin/make

2010-04-15 Thread Christos Zoulas
In article 20100415034839.eaf0c17...@cvs.netbsd.org, Simon J. Gerraty source-changes-d@NetBSD.org wrote: -=-=-=-=-=- Module Name: src Committed By: sjg Date: Thu Apr 15 03:48:39 UTC 2010 Modified Files: src/usr.bin/make: make.1 var.c Log Message: Add :tA to attempt to resolve

Re: CVS commit: src/usr.bin/make

2009-11-22 Thread Bernd Ernesti
On Thu, Nov 19, 2009 at 12:30:25AM +, Simon J. Gerraty wrote: Module Name: src Committed By: sjg Date: Thu Nov 19 00:30:25 UTC 2009 Modified Files: src/usr.bin/make: make.1 nonints.h parse.c var.c src/usr.bin/make/unit-tests: Makefile test.exp Added Files:

Re: CVS commit: src/usr.bin/make

2009-11-22 Thread Simon J. Gerraty
Yes, cvs log has been fixed. Log Message: PR: make.unexport Reviewed by: Hmm, this is a little unusual commit message. Bernd

Re: CVS commit: src/usr.bin/make

2009-03-29 Thread Perry E. Metzger
Alistair Crooks a...@pkgsrc.org writes: This is veering off topic, I fear, but a datapoint: We used a mmdd-based time value for version numbering of the pkg_install tools, derived from embedded RCS Ids, for years (to check tools had sufficient features for what they were going to be

Re: CVS commit: src/usr.bin/make

2009-03-26 Thread David Holland
On Tue, Mar 24, 2009 at 11:41:11AM -0400, Perry E. Metzger wrote: Consider building NetBSD 0.9 today. As it was, MAKE_VERSION would seem quite modern, but the make would really be quite old. Using the last rcsid time would at least fix that... Not really, because branches

<    1   2