Re: CVS commit: src/sys/compat/linux/common

2023-08-25 Thread Theodore Preduta
On 2023-08-25 13:30, Taylor R Campbell wrote: > Since VOP_READDIR requires vp to be locked, I can infer that the > handle_write caller must already hold vp locked. But that means that > we have ifd_lock -> vnode lock in one path, and vnode lock -> ifd_lock > in another path, which is forbidden

Re: CVS commit: src/sys/compat/linux/common

2023-08-25 Thread Taylor R Campbell
> Date: Fri, 25 Aug 2023 13:38:02 -0400 > From: Theodore Preduta > > On 2023-08-25 13:13, Taylor R Campbell wrote: > > This can't be right, and it's a little unsettling that the problem > > isn't caught by any automatic tests. > > > > As I understand it, the `ie_name' member is supposed to

Re: CVS commit: src/sys/compat/linux/common

2023-08-25 Thread Theodore Preduta
On 2023-08-25 13:13, Taylor R Campbell wrote: >> Module Name:src >> Committed By: christos >> Date: Wed Aug 23 19:17:59 UTC 2023 >> >> Modified Files: >> src/sys/compat/linux/common: linux_inotify.c >> >> Log Message: >> put variable length structure at the end, so that

Re: CVS commit: src/sys/compat/linux/common

2023-08-25 Thread Taylor R Campbell
> Module Name:src > Committed By: christos > Date: Thu Aug 24 19:51:24 UTC 2023 > > Modified Files: > src/sys/compat/linux/common: linux_inotify.c > > Log Message: > fix a locking bug (Theodore Preduta) > > if (needs_lock) > vn_lock(vp, LK_SHARED

Re: CVS commit: src/sys/compat/linux/common

2023-08-25 Thread Taylor R Campbell
> Module Name:src > Committed By: christos > Date: Wed Aug 23 19:17:59 UTC 2023 > > Modified Files: > src/sys/compat/linux/common: linux_inotify.c > > Log Message: > put variable length structure at the end, so that clang does not complain. > > struct inotify_entry { >

re: CVS commit: src/sys/compat/linux/common

2018-01-08 Thread Christos Zoulas
On Jan 9, 12:33pm, m...@eterna.com.au (matthew green) wrote: -- Subject: re: CVS commit: src/sys/compat/linux/common | Christos Zoulas writes: | > On Jan 9, 12:44am, m...@netbsd.org (m...@netbsd.org) wrote: | > -- Subject: Re: CVS commit: src/sys/compat/linux/common | > | > |

re: CVS commit: src/sys/compat/linux/common

2018-01-08 Thread matthew green
Christos Zoulas writes: > On Jan 9, 12:44am, m...@netbsd.org (m...@netbsd.org) wrote: > -- Subject: Re: CVS commit: src/sys/compat/linux/common > > | Why not add a signal? > > It is complicated to do so. It will even change the sigmask size. it will? don't we have support fo