Re: CVS commit: src/usr.bin/gzip

2024-06-01 Thread Izumi Tsutsui
> Your diff is backwards and I guess that is the cause for the confusion. Ah, I checked a wrong tree. Sorry for the noise. --- Izumi Tsutsui

Re: CVS commit: src/usr.bin/gzip

2024-06-01 Thread Martin Husemann
On Sat, Jun 01, 2024 at 11:17:11PM +0900, Izumi Tsutsui wrote: > > Log Message: > > Fix typo in previous > > --- > @@ -1126,7 +1126,7 @@ copymodes(int fd, const struct stat *sbp > if (fchmod(fd, sb.st_mode) < 0) > maybe_warn("couldn't fchmod: %s", file); > > -#if !HAVE_NBTOOL

Re: CVS commit: src/usr.bin/gzip

2024-06-01 Thread Izumi Tsutsui
martin@ wrote: > Module Name: src > Committed By: martin > Date: Sat Jun 1 10:17:12 UTC 2024 > > Modified Files: > src/usr.bin/gzip: gzip.c > > Log Message: > Fix typo in previous --- @@ -1126,7 +1126,7 @@ copymodes(int fd, const struct stat *sbp if (fchmod(fd, sb.st_mod

Re: CVS commit: src/usr.bin/gzip

2018-06-13 Thread Kamil Rytarowski
On 13.06.2018 00:54, Robert Elz wrote: > Date:Tue, 12 Jun 2018 19:52:43 +0200 > From:Kamil Rytarowski > Message-ID: <90519caf-289c-b4d3-7ebc-d14d4efc9...@gmx.com> > > | I will try to meet the expectations in commit messages for *San fixes. > > That would be good (a

Re: CVS commit: src/usr.bin/gzip

2018-06-12 Thread Robert Elz
Date:Tue, 12 Jun 2018 19:52:43 +0200 From:Kamil Rytarowski Message-ID: <90519caf-289c-b4d3-7ebc-d14d4efc9...@gmx.com> | I will try to meet the expectations in commit messages for *San fixes. That would be good (and not just those, unless the board required it, whi

Re: CVS commit: src/usr.bin/gzip

2018-06-12 Thread Kamil Rytarowski
On 12.06.2018 15:52, Joerg Sonnenberger wrote: > On Tue, Jun 12, 2018 at 02:35:40PM +0200, Kamil Rytarowski wrote: >> On 12.06.2018 14:24, Joerg Sonnenberger wrote: >>> That's missing the point. A short description of why the specific >>> undefined behavior is seen is useful. Pasting random program

Re: CVS commit: src/usr.bin/gzip

2018-06-12 Thread Joerg Sonnenberger
On Tue, Jun 12, 2018 at 02:35:40PM +0200, Kamil Rytarowski wrote: > On 12.06.2018 14:24, Joerg Sonnenberger wrote: > > That's missing the point. A short description of why the specific > > undefined behavior is seen is useful. Pasting random program output is > > not. > > > > Joerg > > > > Rando

Re: CVS commit: src/usr.bin/gzip

2018-06-12 Thread Kamil Rytarowski
On 12.06.2018 14:24, Joerg Sonnenberger wrote: > On Tue, Jun 12, 2018 at 12:00:01PM +0200, Kamil Rytarowski wrote: >> On 12.06.2018 11:51, matthew green wrote: On 12.06.2018 10:28, Kamil Rytarowski wrote: > On 12.06.2018 09:04, Martin Husemann wrote: >> On Tue, Jun 12, 2018 at 05:47:35

Re: CVS commit: src/usr.bin/gzip

2018-06-12 Thread Joerg Sonnenberger
On Tue, Jun 12, 2018 at 12:00:01PM +0200, Kamil Rytarowski wrote: > On 12.06.2018 11:51, matthew green wrote: > >> On 12.06.2018 10:28, Kamil Rytarowski wrote: > >>> On 12.06.2018 09:04, Martin Husemann wrote: > On Tue, Jun 12, 2018 at 05:47:35AM +0300, Valery Ushakov wrote: > > To sum it

Re: CVS commit: src/usr.bin/gzip

2018-06-12 Thread Kamil Rytarowski
On 12.06.2018 11:51, matthew green wrote: >> On 12.06.2018 10:28, Kamil Rytarowski wrote: >>> On 12.06.2018 09:04, Martin Husemann wrote: On Tue, Jun 12, 2018 at 05:47:35AM +0300, Valery Ushakov wrote: > To sum it up, out of 30+ lines of the commit message, the relevant > information i

re: CVS commit: src/usr.bin/gzip

2018-06-12 Thread matthew green
>On 12.06.2018 10:28, Kamil Rytarowski wrote: >> On 12.06.2018 09:04, Martin Husemann wrote: >>> On Tue, Jun 12, 2018 at 05:47:35AM +0300, Valery Ushakov wrote: To sum it up, out of 30+ lines of the commit message, the relevant information is contained only in (part of) one line. >>> >>>

Re: CVS commit: src/usr.bin/gzip

2018-06-12 Thread Kamil Rytarowski
On 12.06.2018 10:28, Kamil Rytarowski wrote: > On 12.06.2018 09:04, Martin Husemann wrote: >> On Tue, Jun 12, 2018 at 05:47:35AM +0300, Valery Ushakov wrote: >>> To sum it up, out of 30+ lines of the commit message, the relevant >>> information is contained only in (part of) one line. >> >> FWIW, I

Re: CVS commit: src/usr.bin/gzip

2018-06-12 Thread Kamil Rytarowski
On 12.06.2018 09:04, Martin Husemann wrote: > On Tue, Jun 12, 2018 at 05:47:35AM +0300, Valery Ushakov wrote: >> To sum it up, out of 30+ lines of the commit message, the relevant >> information is contained only in (part of) one line. > > FWIW, I fully agree with uwe here. > > Martin > I find

Re: CVS commit: src/usr.bin/gzip

2018-06-12 Thread Martin Husemann
On Tue, Jun 12, 2018 at 05:47:35AM +0300, Valery Ushakov wrote: > To sum it up, out of 30+ lines of the commit message, the relevant > information is contained only in (part of) one line. FWIW, I fully agree with uwe here. Martin

Re: CVS commit: src/usr.bin/gzip

2018-06-11 Thread Valery Ushakov
On Mon, Jun 11, 2018 at 21:59:19 -0400, John Hawkinson wrote: > Valery Ushakov wrote on Tue, 12 Jun 2018 > at 04:50:36 +0300 in <20180612015036.ge15...@pony.stderr.spb.ru>: > > > Please, can you keep your commit messages to the point? > > > > "Fix unportable left shift" > > > > is probably a

Re: CVS commit: src/usr.bin/gzip

2018-06-11 Thread John Hawkinson
Valery Ushakov wrote on Tue, 12 Jun 2018 at 04:50:36 +0300 in <20180612015036.ge15...@pony.stderr.spb.ru>: > Please, can you keep your commit messages to the point? > > "Fix unportable left shift" > > is probably a good enough summary. You don't have to paste the test > suite results and the

Re: CVS commit: src/usr.bin/gzip

2018-06-11 Thread Valery Ushakov
Please, can you keep your commit messages to the point? "Fix unportable left shift" is probably a good enough summary. You don't have to paste the test suite results and the actual diffs in free form as well. On Tue, Jun 12, 2018 at 00:42:17 +, Kamil Rytarowski wrote: > Log Message: > Co

re: CVS commit: src/usr.bin/gzip

2017-08-23 Thread matthew green
"Christos Zoulas" writes: > Module Name: src > Committed By: christos > Date: Wed Aug 23 13:04:17 UTC 2017 > > Modified Files: > src/usr.bin/gzip: gzip.c > > Log Message: > now that we are processing SIGINFO write can be interrupted and return > partial results (well, it could befo