CVS commit: src/sys/kern

2019-10-07 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Mon Oct 7 21:32:51 UTC 2019 Modified Files: src/sys/kern: sys_ptrace_common.c Log Message: Fix typo in a comment To generate a diff of this commit: cvs rdiff -u -r1.63 -r1.64 src/sys/kern/sys_ptrace_common.c Please note that

CVS commit: src/sys/kern

2019-10-08 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Tue Oct 8 18:02:46 UTC 2019 Modified Files: src/sys/kern: kern_sig.c Log Message: Enhance reliability of ptrace(2) in a debuggee with multiple LWPs Stop competing between threads which one emits event signal quicker and

CVS commit: src/sys/kern

2019-10-08 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Tue Oct 8 18:02:46 UTC 2019 Modified Files: src/sys/kern: kern_sig.c Log Message: Enhance reliability of ptrace(2) in a debuggee with multiple LWPs Stop competing between threads which one emits event signal quicker and

CVS commit: src/lib/libc/sys

2019-10-09 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Wed Oct 9 13:42:37 UTC 2019 Modified Files: src/lib/libc/sys: ptrace.2 Log Message: Document PT_STOP, update PT_KILL in the ptrace(2) man-page Formatting by To generate a diff of this commit: cvs rdiff -u -r1.80 -r1.81

CVS commit: src/lib/libc/sys

2019-10-09 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Wed Oct 9 13:42:37 UTC 2019 Modified Files: src/lib/libc/sys: ptrace.2 Log Message: Document PT_STOP, update PT_KILL in the ptrace(2) man-page Formatting by To generate a diff of this commit: cvs rdiff -u -r1.80 -r1.81

CVS commit: src/sys

2019-10-09 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Wed Oct 9 13:19:43 UTC 2019 Modified Files: src/sys/kern: sys_ptrace_common.c src/sys/sys: ptrace.h Log Message: Introduce new ptrace(2) operation PT_STOP It works like: - kill(SIGSTOP) for unstopped tracee -

CVS commit: src/sys

2019-10-09 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Wed Oct 9 13:19:43 UTC 2019 Modified Files: src/sys/kern: sys_ptrace_common.c src/sys/sys: ptrace.h Log Message: Introduce new ptrace(2) operation PT_STOP It works like: - kill(SIGSTOP) for unstopped tracee -

CVS commit: src/sys/kern

2019-10-08 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Tue Oct 8 12:29:57 UTC 2019 Modified Files: src/sys/kern: sys_ptrace_common.c Log Message: Correct the same expression on both sides of | PR sw-bug/54610 by David Binderman To generate a diff of this commit: cvs rdiff -u

CVS commit: src/sys/kern

2019-10-08 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Tue Oct 8 12:29:57 UTC 2019 Modified Files: src/sys/kern: sys_ptrace_common.c Log Message: Correct the same expression on both sides of | PR sw-bug/54610 by David Binderman To generate a diff of this commit: cvs rdiff -u

CVS commit: src/sys/sys

2019-10-03 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Thu Oct 3 22:26:43 UTC 2019 Modified Files: src/sys/sys: lwp.h Log Message: Define LW_DBGSUSPEND in sys/lwp.h This flag specifies the suspended by debugger property, as used by PT_SUSPEND in ptrace(2). To generate a diff of

CVS commit: src/sys/sys

2019-10-03 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Thu Oct 3 22:26:43 UTC 2019 Modified Files: src/sys/sys: lwp.h Log Message: Define LW_DBGSUSPEND in sys/lwp.h This flag specifies the suspended by debugger property, as used by PT_SUSPEND in ptrace(2). To generate a diff of

CVS commit: src/sys/kern

2019-10-03 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Thu Oct 3 22:48:44 UTC 2019 Modified Files: src/sys/kern: kern_exit.c kern_lwp.c kern_sig.c kern_synch.c sys_ptrace_common.c Log Message: Separate flag for suspended by _lwp_suspend and suspended by a debugger Once a

CVS commit: src/sys/kern

2019-10-03 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Thu Oct 3 22:48:44 UTC 2019 Modified Files: src/sys/kern: kern_exit.c kern_lwp.c kern_sig.c kern_synch.c sys_ptrace_common.c Log Message: Separate flag for suspended by _lwp_suspend and suspended by a debugger Once a

CVS commit: src/sys/kern

2019-10-03 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Thu Oct 3 22:29:17 UTC 2019 Modified Files: src/sys/kern: init_main.c Log Message: Remove compile-time asserts checking whether intptr_t and void* are compat The checks were requested by core@ as a prerequisite for kevent::udata

CVS commit: src/sys/kern

2019-10-03 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Thu Oct 3 22:29:17 UTC 2019 Modified Files: src/sys/kern: init_main.c Log Message: Remove compile-time asserts checking whether intptr_t and void* are compat The checks were requested by core@ as a prerequisite for kevent::udata

CVS commit: src

2019-10-03 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Thu Oct 3 22:16:53 UTC 2019 Modified Files: src/external/bsd/libevent/dist: kqueue.c src/sys/compat/linux/common: linux_sched.c src/sys/compat/netbsd32: netbsd32.h netbsd32_conv.h src/sys/sys: event.h Log

CVS commit: src

2019-10-03 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Thu Oct 3 22:16:53 UTC 2019 Modified Files: src/external/bsd/libevent/dist: kqueue.c src/sys/compat/linux/common: linux_sched.c src/sys/compat/netbsd32: netbsd32.h netbsd32_conv.h src/sys/sys: event.h Log

CVS commit: src/sys/kern

2019-10-03 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Thu Oct 3 23:11:11 UTC 2019 Modified Files: src/sys/kern: sys_ptrace_common.c Log Message: Add two KASSERTS in the ptrace(2) kernel code Verify that we will never return empty ptrace_state for CHILD/LWP event. To generate a

CVS commit: src/sys/kern

2019-10-03 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Thu Oct 3 23:11:11 UTC 2019 Modified Files: src/sys/kern: sys_ptrace_common.c Log Message: Add two KASSERTS in the ptrace(2) kernel code Verify that we will never return empty ptrace_state for CHILD/LWP event. To generate a

Re: CVS commit: src/sys/arch/acorn32/acorn32

2019-10-03 Thread Kamil Rytarowski
At least in certain domains of engineering 0 is a special case as it does not need unit (km, lumen, kg, ...) neither base (hex, dec, ..). It is natural (correct, expected) to print %#x for 0 as 0, without 0x. On 04.10.2019 04:09, Christos Zoulas wrote: > Thanks, and zero is special for 0#.

Re: CVS commit: src/external/gpl3/gcc

2019-10-05 Thread Kamil Rytarowski
On 04.10.2019 10:51, matthew green wrote: > Module Name: src > Committed By: mrg > Date: Fri Oct 4 08:51:33 UTC 2019 > > Modified Files: > src/external/gpl3/gcc: README.gcc8 > src/external/gpl3/gcc/dist/gcc/config/aarch64: aarch64-netbsd.h >

CVS commit: src/sys/kern

2019-10-05 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Sat Oct 5 12:57:40 UTC 2019 Modified Files: src/sys/kern: kern_time.c Log Message: Check for valid timespec in clock_settime1() An alternative approach would be to check the valie in settime1(), but it would result in multiple

CVS commit: src/sys/kern

2019-10-05 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Sat Oct 5 12:57:40 UTC 2019 Modified Files: src/sys/kern: kern_time.c Log Message: Check for valid timespec in clock_settime1() An alternative approach would be to check the valie in settime1(), but it would result in multiple

CVS commit: src/sys/compat/netbsd32

2019-10-05 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Sat Oct 5 14:19:53 UTC 2019 Modified Files: src/sys/compat/netbsd32: netbsd32_compat_50.c netbsd32_time.c Log Message: Validate input before converting timeval::tv_usec in compat/netbsd32 To generate a diff of this commit: cvs

CVS commit: src/sys/compat/netbsd32

2019-10-05 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Sat Oct 5 14:19:53 UTC 2019 Modified Files: src/sys/compat/netbsd32: netbsd32_compat_50.c netbsd32_time.c Log Message: Validate input before converting timeval::tv_usec in compat/netbsd32 To generate a diff of this commit: cvs

CVS commit: src/sys/uvm

2019-10-04 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Fri Oct 4 22:48:46 UTC 2019 Modified Files: src/sys/uvm: uvm_mmap.c Log Message: Avoid left shift changing the signedness flag Reviewed by Reported-by: syzbot+25ac03024cedf27f3...@syzkaller.appspotmail.com To generate a diff

CVS commit: src/sys/uvm

2019-10-04 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Fri Oct 4 22:48:46 UTC 2019 Modified Files: src/sys/uvm: uvm_mmap.c Log Message: Avoid left shift changing the signedness flag Reviewed by Reported-by: syzbot+25ac03024cedf27f3...@syzkaller.appspotmail.com To generate a diff

CVS commit: src/sys/kern

2019-10-04 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Fri Oct 4 23:20:22 UTC 2019 Modified Files: src/sys/kern: sysv_msg.c Log Message: Avoid -LONG_MIN msgtyp in msgrcv(2) and treat it as LONG_MAX This logic (found in Linux) avoids undefined behavior. Reported-by:

CVS commit: src/sys/kern

2019-10-04 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Fri Oct 4 23:20:22 UTC 2019 Modified Files: src/sys/kern: sysv_msg.c Log Message: Avoid -LONG_MIN msgtyp in msgrcv(2) and treat it as LONG_MAX This logic (found in Linux) avoids undefined behavior. Reported-by:

CVS commit: src/sys/kern

2019-10-04 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Fri Oct 4 14:17:08 UTC 2019 Modified Files: src/sys/kern: subr_time.c Log Message: Avoid signed integer overflow in ts2timo() for ts->tv_nsec The condition would be rechecked later again after subtracting start time and most

CVS commit: src/sys/kern

2019-10-04 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Fri Oct 4 14:17:08 UTC 2019 Modified Files: src/sys/kern: subr_time.c Log Message: Avoid signed integer overflow in ts2timo() for ts->tv_nsec The condition would be rechecked later again after subtracting start time and most

CVS commit: src/sys/kern

2019-10-12 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Sat Oct 12 12:04:37 UTC 2019 Modified Files: src/sys/kern: sys_ptrace_common.c Log Message: Avoid signed integer overflow for -lwp where lwp is INT_MIN Reported-by: syzbot+68b80b44b898e66da...@syzkaller.appspotmail.com To

CVS commit: src/sys/kern

2019-10-12 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Sat Oct 12 12:04:37 UTC 2019 Modified Files: src/sys/kern: sys_ptrace_common.c Log Message: Avoid signed integer overflow for -lwp where lwp is INT_MIN Reported-by: syzbot+68b80b44b898e66da...@syzkaller.appspotmail.com To

CVS commit: src/sys/kern

2019-10-12 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Sat Oct 12 10:55:23 UTC 2019 Modified Files: src/sys/kern: kern_exec.c kern_fork.c kern_proc.c kern_sig.c Log Message: Remove p_oppid from struct proc This field is not needed as it duplicated p_opptr that is alread safe to use,

CVS commit: src/sys/kern

2019-10-12 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Sat Oct 12 10:55:23 UTC 2019 Modified Files: src/sys/kern: kern_exec.c kern_fork.c kern_proc.c kern_sig.c Log Message: Remove p_oppid from struct proc This field is not needed as it duplicated p_opptr that is alread safe to use,

CVS commit: src/sys

2019-10-12 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Sat Oct 12 19:57:09 UTC 2019 Modified Files: src/sys/kern: kern_sig.c src/sys/sys: signalvar.h Log Message: Refactor sigswitch() Make the function static as it is now local to kern_sig.c. Rename the 'relock' argument to

CVS commit: src/sys/sys

2019-10-12 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Sat Oct 12 19:38:57 UTC 2019 Modified Files: src/sys/sys: proc.h Log Message: Remove now unused p_oppid from struct proc To generate a diff of this commit: cvs rdiff -u -r1.356 -r1.357 src/sys/sys/proc.h Please note that diffs

CVS commit: src/sys/sys

2019-10-12 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Sat Oct 12 19:38:57 UTC 2019 Modified Files: src/sys/sys: proc.h Log Message: Remove now unused p_oppid from struct proc To generate a diff of this commit: cvs rdiff -u -r1.356 -r1.357 src/sys/sys/proc.h Please note that diffs

CVS commit: src/sys

2019-10-12 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Sat Oct 12 19:57:09 UTC 2019 Modified Files: src/sys/kern: kern_sig.c src/sys/sys: signalvar.h Log Message: Refactor sigswitch() Make the function static as it is now local to kern_sig.c. Rename the 'relock' argument to

CVS commit: src/sys/sys

2019-10-12 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Sat Oct 12 19:59:57 UTC 2019 Modified Files: src/sys/sys: param.h Log Message: Welcome to 9.99.17! struct proc change sigswitch() removed from public API To generate a diff of this commit: cvs rdiff -u -r1.617 -r1.618

CVS commit: src/sys/sys

2019-10-12 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Sat Oct 12 19:59:57 UTC 2019 Modified Files: src/sys/sys: param.h Log Message: Welcome to 9.99.17! struct proc change sigswitch() removed from public API To generate a diff of this commit: cvs rdiff -u -r1.617 -r1.618

CVS commit: src/sys/kern

2019-10-12 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Sun Oct 13 03:10:22 UTC 2019 Modified Files: src/sys/kern: kern_sig.c Log Message: Add sigswitch_unlock_and_switch_away(), extracted from sigswitch() Use sigswitch_unlock_and_switch_away() whenever there is no need for

CVS commit: src/sys/kern

2019-10-12 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Sun Oct 13 03:10:22 UTC 2019 Modified Files: src/sys/kern: kern_sig.c Log Message: Add sigswitch_unlock_and_switch_away(), extracted from sigswitch() Use sigswitch_unlock_and_switch_away() whenever there is no need for

CVS commit: src/sys/kern

2019-10-12 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Sun Oct 13 03:19:57 UTC 2019 Modified Files: src/sys/kern: kern_sig.c Log Message: Fix one the the root causes of unreliability of the ptrace(2)ed threads In case of sigswitchin away in issignal() and continuing the execution on

CVS commit: src/sys/kern

2019-10-12 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Sun Oct 13 03:19:57 UTC 2019 Modified Files: src/sys/kern: kern_sig.c Log Message: Fix one the the root causes of unreliability of the ptrace(2)ed threads In case of sigswitchin away in issignal() and continuing the execution on

CVS commit: src/sys/kern

2019-10-12 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Sun Oct 13 03:50:26 UTC 2019 Modified Files: src/sys/kern: kern_sig.c Log Message: Avoid double lwp_exit() in eventswitch() For the PTRACE_LWP_EXIT event, the eventswitch() call is triggered from lwp_exit(). In the case of

CVS commit: src/sys/kern

2019-10-12 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Sun Oct 13 03:50:26 UTC 2019 Modified Files: src/sys/kern: kern_sig.c Log Message: Avoid double lwp_exit() in eventswitch() For the PTRACE_LWP_EXIT event, the eventswitch() call is triggered from lwp_exit(). In the case of

CVS commit: src/tests/lib/libc/sys

2019-10-12 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Sun Oct 13 04:00:12 UTC 2019 Modified Files: src/tests/lib/libc/sys: t_ptrace_wait.c Log Message: Bump the number of threads in LWP t_ptrace_wait*() tests from to 100 This is a torture, but on purpose to catch LWP_CREATED and

CVS commit: src/tests/lib/libc/sys

2019-10-12 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Sun Oct 13 04:00:12 UTC 2019 Modified Files: src/tests/lib/libc/sys: t_ptrace_wait.c Log Message: Bump the number of threads in LWP t_ptrace_wait*() tests from to 100 This is a torture, but on purpose to catch LWP_CREATED and

CVS commit: src/tests/lib/libc/sys

2019-10-12 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Sun Oct 13 04:05:39 UTC 2019 Modified Files: src/tests/lib/libc/sys: t_ptrace_wait.c Log Message: Enable TEST_LWP_ENABLED in t_ptrace_wait* The LWP events (created, exited) are now reliable in my local tests. PR kern/51420 PR

CVS commit: src/tests/lib/libc/sys

2019-10-12 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Sun Oct 13 04:05:39 UTC 2019 Modified Files: src/tests/lib/libc/sys: t_ptrace_wait.c Log Message: Enable TEST_LWP_ENABLED in t_ptrace_wait* The LWP events (created, exited) are now reliable in my local tests. PR kern/51420 PR

CVS commit: src/tests/lib/libc/sys

2019-10-13 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Sun Oct 13 09:42:15 UTC 2019 Modified Files: src/tests/lib/libc/sys: t_ptrace_wait.c Log Message: Fix race in t_ptrace_wait* LWP tests Increment the done variable under a mutex. This variable was updated non-atomically and

CVS commit: src/tests/lib/libc/sys

2019-10-13 Thread Kamil Rytarowski
Module Name:src Committed By: kamil Date: Sun Oct 13 09:42:15 UTC 2019 Modified Files: src/tests/lib/libc/sys: t_ptrace_wait.c Log Message: Fix race in t_ptrace_wait* LWP tests Increment the done variable under a mutex. This variable was updated non-atomically and

Re: CVS commit: src/tests/usr.bin

2019-10-14 Thread Kamil Rytarowski
On 14.10.2019 05:47, Jason High wrote: Module Name:src Committed By: jhigh Date: Mon Oct 14 03:47:20 UTC 2019 Modified Files: src/tests/usr.bin: Makefile Added Files: src/tests/usr.bin/argon2: Atffile Makefile t_argon2.sh Log Message: adding argon2 tests

Re: CVS commit: src/sys/sys

2019-12-22 Thread Kamil Rytarowski
On 22.12.2019 23:27, Andrew Doran wrote: > On Sat, Dec 21, 2019 at 05:23:23PM +, Alexander Nasonov wrote: > >> Andrew Doran wrote: >>> Log Message: >>> NetBSD 9.99.28 - cpu_data & UVM changes. >> >> Wow, you bump versions faster than I compile new releases. At this >> pace, we'll get to

Re: CVS commit: src/sys/sys

2019-12-22 Thread Kamil Rytarowski
On 23.12.2019 01:54, Roy Marples wrote: > On 22/12/2019 22:24, Andrew Doran wrote: >> NetBSD 9.99.29 - struct mount changed. > > Just curious - does our build software cope with 3 digit for the last > number? > > Roy At least from the __NetBSD_Version__ point of view there are 4 digits unused,

Re: CVS commit: src/sys/sys

2019-12-23 Thread Kamil Rytarowski
On 23.12.2019 16:57, Martin Husemann wrote: > On Mon, Dec 23, 2019 at 09:02:50AM -0500, Greg Troxel wrote: >> Well, we are coming up on a year since netbsd-9 was branched, or at >> least will arrive there before this discussion resolves. So cutting >> -10 before we hit 100 works for me :-) > >

Re: CVS commit: src/external/bsd/dhcpcd/dist/src

2020-02-13 Thread Kamil Rytarowski
On 13.02.2020 14:50, Valery Ushakov wrote: > On Thu, Feb 13, 2020 at 14:18:43 +0100, Kamil Rytarowski wrote: > >> > Can you show the original problem that you are trying to fix here? > When and how did you get warning? > GCC has a property (as called by Joerg bug) t

Re: CVS commit: src/external/bsd/dhcpcd/dist/src

2020-02-13 Thread Kamil Rytarowski
On 13.02.2020 00:58, Joerg Sonnenberger wrote: > On Mon, Feb 10, 2020 at 04:45:35PM +, Roy Marples wrote: >> On 09/02/2020 19:21, Joerg Sonnenberger wrote: >>> On Sat, Feb 08, 2020 at 12:17:16PM +, Santhosh Raju wrote: Module Name: src Committed By: fox Date:

Re: CVS commit: src/external/bsd/dhcpcd/dist/src

2020-02-13 Thread Kamil Rytarowski
On 13.02.2020 14:13, Joerg Sonnenberger wrote: > On Thu, Feb 13, 2020 at 02:05:12PM +0100, Kamil Rytarowski wrote: >> On 13.02.2020 00:58, Joerg Sonnenberger wrote: >>> On Mon, Feb 10, 2020 at 04:45:35PM +, Roy Marples wrote: >>>> On 09/02/2020 19:21, Joerg So

Re: CVS commit: src/lib/libpthread

2020-02-12 Thread Kamil Rytarowski
/mono6: > The invalid thread pointer is not 0x. > pthread_equal t1: 0x7b066d4d7800 > pthread_equal t2: 0x60f5f000 > > Of course, it is desirable to fix every misuses and bugs in pkgsrc. > However it is impossible for now (at least for me). > > "Kamil Rytarowski"

Re: CVS commit: src/lib/libpthread

2020-02-13 Thread Kamil Rytarowski
On 12.02.2020 15:01, Ryo ONODERA wrote: > Hi, > > Kamil Rytarowski writes: > >> Hello, >> >> I will have a look at them. > > Thank you. > Real fix is welcome. > > And multimedia/handbrake has workaround already. > I have workaround pa

Re: CVS commit: src/external/bsd/dhcpcd/dist/src

2020-02-13 Thread Kamil Rytarowski
On 13.02.2020 18:00, Valery Ushakov wrote: > Arguably, if the tool you use is broken, you shouln't be mutilating > the source code just to shut that tool up. The introduced changes were good, even if GCC would be silent. It is far from mutilating. As an alternative option we can disable warnings

Re: CVS commit: src/lib/libpthread

2020-02-12 Thread Kamil Rytarowski
Hello, I will have a look at them. On 12.02.2020 14:02, Ryo ONODERA wrote: > Hi, > > Kamil Rytarowski writes: > >> Please apple workaround (same like in NSPR) for now if fixing is difficult. >> >> Such bugs can have security implications. > > Adding w

Re: CVS commit: src/tests/lib/libc/gen

2020-02-24 Thread Kamil Rytarowski
On 24.02.2020 20:29, Christos Zoulas wrote: > In article <20200222191457.87687f...@cvs.netbsd.org>, > Kamil Rytarowski wrote: >> -=-=-=-=-=- >> >> Module Name: src >> Committed By:kamil >> Date:Sat Feb 22 19:14:57 UTC 2020 >&g

Re: CVS commit: src/tests/lib/libc/gen

2020-02-24 Thread Kamil Rytarowski
On 24.02.2020 20:32, Christos Zoulas wrote: > In article <20200221222550.325a6f...@cvs.netbsd.org>, > Kamil Rytarowski wrote: >> -=-=-=-=-=- >> >> Module Name: src >> Committed By:kamil >> Date:Fri Feb 21 22:25:50 UTC 2020 >&g

Re: CVS commit: src/external/bsd/libarchive/dist/libarchive

2020-02-25 Thread Kamil Rytarowski
On 25.02.2020 16:24, Andreas Gustafsson wrote: > Kamil Rytarowski wrote: >> To generate a diff of this commit: >> cvs rdiff -u -r1.1.1.4 -r1.2 \ >> src/external/bsd/libarchive/dist/libarchive/archive_read.c > > What kind of sorcery is this? Why is the diff not r

Re: CVS commit: src/doc

2020-02-29 Thread Kamil Rytarowski
On 29.02.2020 19:00, Taylor R Campbell wrote: >> Module Name:src >> Committed By: kamil >> Date: Sat Feb 29 04:27:01 UTC 2020 >> >> Modified Files: >> src/doc: CHANGES >> >> Log Message: >> ld.elf_so(1): Implement DT_GNU_HASH > > Was this discussed anywhere? In the

Re: CVS commit: src/doc

2020-02-29 Thread Kamil Rytarowski
On 29.02.2020 19:29, Martin Husemann wrote: > On Sat, Feb 29, 2020 at 06:00:29PM +, Taylor R Campbell wrote: >>> Module Name:src >>> Committed By: kamil >>> Date: Sat Feb 29 04:27:01 UTC 2020 >>> >>> Modified Files: >>> src/doc: CHANGES >>> >>> Log Message: >>>

Re: CVS commit: src/doc

2020-02-29 Thread Kamil Rytarowski
On 29.02.2020 22:29, Kamil Rytarowski wrote: > On 29.02.2020 21:58, Joerg Sonnenberger wrote: >> On Sat, Feb 29, 2020 at 07:36:00PM +0100, Kamil Rytarowski wrote: >>> On 29.02.2020 19:00, Taylor R Campbell wrote: >>>>> Module Name:src >>>>> Com

Re: CVS commit: src/doc

2020-02-29 Thread Kamil Rytarowski
On 29.02.2020 21:58, Joerg Sonnenberger wrote: > On Sat, Feb 29, 2020 at 07:36:00PM +0100, Kamil Rytarowski wrote: >> On 29.02.2020 19:00, Taylor R Campbell wrote: >>>> Module Name:src >>>> Committed By: kamil >>>> Date: Sat Feb

Re: CVS commit: src/doc

2020-03-01 Thread Kamil Rytarowski
On 29.02.2020 23:31, Joerg Sonnenberger wrote: > On Sat, Feb 29, 2020 at 10:29:02PM +0100, Kamil Rytarowski wrote: >> On 29.02.2020 21:58, Joerg Sonnenberger wrote: >>> On Sat, Feb 29, 2020 at 07:36:00PM +0100, Kamil Rytarowski wrote: >>>> On 29.02.2020

Re: CVS commit: src/include

2020-03-01 Thread Kamil Rytarowski
On 01.03.2020 19:31, Joerg Sonnenberger wrote: > On Sun, Mar 01, 2020 at 03:08:16PM +0000, Kamil Rytarowski wrote: >> Module Name: src >> Committed By:kamil >> Date:Sun Mar 1 15:08:16 UTC 2020 >> >> Modified Files: >> src/include

Re: CVS commit: src/include

2020-03-01 Thread Kamil Rytarowski
On 01.03.2020 22:54, Joerg Sonnenberger wrote: > On Sun, Mar 01, 2020 at 10:26:08PM +0100, Kamil Rytarowski wrote: >> On 01.03.2020 19:31, Joerg Sonnenberger wrote: >>> On Sun, Mar 01, 2020 at 03:08:16PM +, Kamil Rytarowski wrote: >>>> Module Name: src

Re: CVS commit: src/doc

2020-03-01 Thread Kamil Rytarowski
On 01.03.2020 22:36, Joerg Sonnenberger wrote: > On Sun, Mar 01, 2020 at 10:20:44PM +0100, Kamil Rytarowski wrote: >> If that will nor realize, I will request to enable GNU_HASH for NetBSD-11. > > You have so far demonstrated no justification at all beyond handwaving >

Re: CVS commit: src/include

2020-03-01 Thread Kamil Rytarowski
On 02.03.2020 03:58, matthew green wrote: >>> On Sun, Mar 01, 2020 at 03:08:16PM +0000, Kamil Rytarowski wrote: >>>> Module Name: src >>>> Committed By: kamil >>>> Date: Sun Mar 1 15:08:16 UTC 2020 >>>> >>

Re: CVS commit: src/sys/kern

2020-02-25 Thread Kamil Rytarowski
On 24.02.2020 21:47, Jaromir Dolecek wrote: > Module Name: src > Committed By: jdolecek > Date: Mon Feb 24 20:47:47 UTC 2020 > > Modified Files: > src/sys/kern: init_main.c > > Log Message: > move config_init_mi() call before vfsinit(), which can trigger loading > of VFS modules >

Re: CVS commit: src/external/bsd/tcpdump/dist

2020-02-24 Thread Kamil Rytarowski
On 24.02.2020 17:44, Valery Ushakov wrote: > On Mon, Feb 24, 2020 at 16:19:35 +0000, Kamil Rytarowski wrote: > >> Module Name: src >> Committed By:kamil >> Date:Mon Feb 24 16:19:35 UTC 2020 >> >> Modified Files: >> src/exte

Re: CVS commit: src/lib/libpthread

2020-01-30 Thread Kamil Rytarowski
On 05.03.2019 23:49, Christos Zoulas wrote: > Module Name: src > Committed By: christos > Date: Tue Mar 5 22:49:38 UTC 2019 > > Modified Files: > src/lib/libpthread: pthread_mutex.c > > Log Message: > Jemalloc initializes mutexes before we become threaded and expects to use >

Re: CVS commit: src/lib/libpthread

2020-02-01 Thread Kamil Rytarowski
@@ > { > char buf[1024]; > size_t len; > - > + > if (pthread__diagassert == 0) > return; > > > > "Kamil Rytarowski" writes: > >> Module Name: src >> Committed By:kamil >> Date:

Re: CVS commit: src/lib/libpthread

2020-02-01 Thread Kamil Rytarowski
Actually it happened that modifiying pthread_atfork() to stop malloc()ing is enough to address the problem. I have landed the changes and removed '#if 0' kludge. Thanks! On 01.02.2020 13:59, Kamil Rytarowski wrote: > On 31.01.2020 22:10, Andrew Doran wrote: >> On Fri, Jan 31, 2020 at 0

Re: CVS commit: src/lib/libpthread

2020-02-01 Thread Kamil Rytarowski
read", >> t1->pt_magic == PT_MAGIC); >> >> pthread__error(EINVAL, "Invalid thread", >> t2->pt_magic == PT_MAGIC); >> +#endif >> >> /* Nothing special here. */ >> return (t1 == t2); >> @@ -1108,7

Re: CVS commit: src/lib/libpthread

2020-01-31 Thread Kamil Rytarowski
On 31.01.2020 03:38, Christos Zoulas wrote: > And it is fixed now. > > christos > OK. I am going to submit a bug report upstream and get some feedback what is the way forward here, delaying initialization. signature.asc Description: OpenPGP digital signature

Re: CVS commit: src/lib/libpthread

2020-01-31 Thread Kamil Rytarowski
On 31.01.2020 19:55, Christos Zoulas wrote: > In article <724af477-010b-9ddf-6ece-e23d7cf59...@gmx.com>, > Kamil Rytarowski wrote: >> -=-=-=-=-=- >> -=-=-=-=-=- >> >> On 31.01.2020 03:38, Christos Zoulas wrote: >>> And it is fixed now. >>>

Re: CVS commit: src/lib/libpthread

2020-02-03 Thread Kamil Rytarowski
Please check this workaround: http://netbsd.org/~kamil/patch-00224-firefox-pthread_equal.txt It has to be applied on firefox's package. The problem has to be reported upstream as a real bug. On 03.02.2020 16:01, Ryo ONODERA wrote: > Hi, > > Ryo ONODERA writes: > >> Hi, >> >> I had tested

Re: CVS commit: src/lib/libpthread

2020-02-03 Thread Kamil Rytarowski
On 03.02.2020 17:10, Ryo ONODERA wrote: > Hi, > > Kamil Rytarowski writes: > >> Please check this workaround: >> >> http://netbsd.org/~kamil/patch-00224-firefox-pthread_equal.txt >> >> It has to be applied on firefox's package. > > Thank you

Re: CVS commit: src/lib/libc/gen

2020-02-03 Thread Kamil Rytarowski
On 03.02.2020 17:21, Joerg Sonnenberger wrote: > On Sat, Feb 01, 2020 at 03:38:46PM +0000, Kamil Rytarowski wrote: >> Module Name: src >> Committed By:kamil >> Date:Sat Feb 1 15:38:46 UTC 2020 >> >> Modified Files: >> src/l

Re: CVS commit: src/lib/libc/gen

2020-02-03 Thread Kamil Rytarowski
On 03.02.2020 17:24, Kamil Rytarowski wrote: > On 03.02.2020 17:21, Joerg Sonnenberger wrote: >> On Sat, Feb 01, 2020 at 03:38:46PM +0000, Kamil Rytarowski wrote: >>> Module Name:src >>> Committed By: kamil >>> Date: Sat Feb 1 15:3

Re: CVS commit: src/lib/libpthread

2020-02-02 Thread Kamil Rytarowski
(5) file. On 01.02.2020 22:20, Kamil Rytarowski wrote: > Good idea. It could be checked quicker... however I presume that > t1->pt_magic + t1->pt_magic already crash on invalid t1/t2 pointers as > the argument with condition is evaluated. > > Ryo, you might check: > $ expo

Re: CVS commit: src/sys/net

2020-01-28 Thread Kamil Rytarowski
On 29.01.2020 07:40, Jason Thorpe wrote: > >> On Jan 28, 2020, at 10:25 PM, Kamil Rytarowski wrote: >> >> The distribution build breaks for me with: > > Should be fixed with: > > /cvsroot/src/sys/rump/net/lib/libnet/Makefile,v <-- Makefile > new

Re: CVS commit: src/sys/net

2020-01-28 Thread Kamil Rytarowski
On 29.01.2020 04:16, Jason R Thorpe wrote: > Module Name: src > Committed By: thorpej > Date: Wed Jan 29 03:16:28 UTC 2020 > > Modified Files: > src/sys/net: Makefile files.net if.c if.h > Added Files: > src/sys/net: if_stats.c if_stats.h > > Log Message: > Add support for

Re: CVS commit: src/lib/libpthread

2020-02-01 Thread Kamil Rytarowski
On 31.01.2020 22:10, Andrew Doran wrote: > On Fri, Jan 31, 2020 at 06:55:00PM -, Christos Zoulas wrote: > >> In article <724af477-010b-9ddf-6ece-e23d7cf59...@gmx.com>, >> Kamil Rytarowski wrote: >>> -=-=-=-=-=- >>> -=-=-=-=-=- >>

Re: CVS commit: src/tests/lib/libc/sys

2020-02-18 Thread Kamil Rytarowski
On 18.02.2020 16:57, Christos Zoulas wrote: > In article <20200213152742.081a9f...@cvs.netbsd.org>, > MichaŠGórny wrote: >> -=-=-=-=-=- >> >> Module Name: src >> Committed By:mgorny >> Date:Thu Feb 13 15:27:41 UTC 2020 >> >> Modified Files: >>

Re: CVS commit: src/doc

2020-02-19 Thread Kamil Rytarowski
On 19.02.2020 16:32, Kamil Rytarowski wrote: > On 18.02.2020 22:14, Christos Zoulas wrote: >> Module Name: src >> Committed By:christos >> Date:Tue Feb 18 21:14:16 UTC 2020 >> >> Modified Files: >> src/doc: 3RDPART

Re: CVS commit: src/lib/libpthread

2020-02-19 Thread Kamil Rytarowski
On 13.02.2020 20:03, Ryo ONODERA wrote: > Hi, > > Kamil Rytarowski writes: > >> On 12.02.2020 15:01, Ryo ONODERA wrote: >>> Hi, >>> >>> Kamil Rytarowski writes: >>> >>>> Hello, >>>> >>>> I will have a

Re: CVS commit: src/external/apache2/llvm/config/llvm/Config

2020-02-19 Thread Kamil Rytarowski
On 19.02.2020 14:32, Joerg Sonnenberger wrote: > Module Name: src > Committed By: joerg > Date: Wed Feb 19 13:32:40 UTC 2020 > > Modified Files: > src/external/apache2/llvm/config/llvm/Config: config.h.in > > Log Message: > Revert last. It was objected to pre-commit, there is no

Re: CVS commit: src/doc

2020-02-19 Thread Kamil Rytarowski
On 18.02.2020 22:14, Christos Zoulas wrote: > Module Name: src > Committed By: christos > Date: Tue Feb 18 21:14:16 UTC 2020 > > Modified Files: > src/doc: 3RDPARTY CHANGES > > Log Message: > new awk > > > To generate a diff of this commit: > cvs rdiff -u -r1.1690 -r1.1691

Re: CVS commit: src/external/apache2/llvm/config/llvm/Config

2020-02-20 Thread Kamil Rytarowski
On 21.02.2020 01:17, Christos Zoulas wrote: > In article <5f8df6c1-bb25-f24a-27fc-b3a752a6d...@gmx.com>, > Kamil Rytarowski wrote: > >> We don't have any direct reproducer (we tried) and we must figure it out >>from syzkaller bot. We don't have access to the mach

Re: CVS commit: src/external/apache2/llvm/config/llvm/Config

2020-02-20 Thread Kamil Rytarowski
On 21.02.2020 02:47, Christos Zoulas wrote: > So host needs to install terminfo-dev. How is that different from the host > environment needing to provide other pieces of the development environment? > For example if another tool needed openssl-dev, would we disable crypto? Or > if it needed

Re: CVS commit: src/external/apache2/llvm/config/llvm/Config

2020-02-21 Thread Kamil Rytarowski
On 21.02.2020 09:17, Leonardo Taccari wrote: > Kamil Rytarowski writes: >> [...] >> ./build.sh tools for LLVM is broken when host ships with no terminfo >> devel libraries. I tried to disable this superfluous feature for tools >> (for colors in a terminal), but it got r

<    2   3   4   5   6   7   8   9   >