[SoX-devel] [ANNOUNCE] SoX 14.4.2rc2 Released

2014-12-22 Thread Chris Bagwell
A new release candidate has been released with following incremental changes. In addition, the windows executables distributed in rc1 were invalid and should be fixed in rc2. git tag: sox-14.4.2rc2 Chris Bagwell (6): Check for minimum size sphere headers More checks for invalid MS AD

Re: [SoX-devel] Review patch for average power spectrum

2014-12-22 Thread Cedric Roux
On 12/22/2014 11:14 PM, Eric Wong wrote: > ...otherwise, free may be called on an uninitialized value: > >> + if (re_average) { >> +free(re_average); >> + } Just for you information, if a pointer is null free(p) is fine and does nothing. The "if" is not required. --

Re: [SoX-devel] Review patch for average power spectrum

2014-12-22 Thread Pander
On 12/22/2014 11:14 PM, Eric Wong wrote: > Pander wrote: >> Please review the attached patch for outputting the average power spectrum. > > I am not knowledgable in the math behind this, but I noticed one > memory management error: > >> @@ -134,6 +138,15 @@ static int sox_stat_flow(sox_effect_t

Re: [SoX-devel] Review patch for average power spectrum

2014-12-22 Thread Eric Wong
Pander wrote: > Please review the attached patch for outputting the average power spectrum. I am not knowledgable in the math behind this, but I noticed one memory management error: > @@ -134,6 +138,15 @@ static int sox_stat_flow(sox_effect_t * effp, const > sox_sample_t *ibuf, sox_samp >pr

[SoX-devel] Review patch for average power spectrum

2014-12-22 Thread Pander
Hi all, Please review the attached patch for outputting the average power spectrum. For many applications I need to calculate this with additional tools. This patch will make SoX do it directly. Regards, Pander >From 261b4fb8cc9f8f98e0044e973a81e7a367349339 Mon Sep 17 00:00:00 2001 From: Pander