Re: [SoX-devel] [PATCH RESEND 7/9] spectrogram: remove arbitrary limit on height of spectrogram

2020-08-13 Thread Pander via SoX-devel
On 8/13/20 18:20, Måns Rullgård wrote: > Martin Guy writes: > >> On 31/07/2020, Måns Rullgård wrote: - if (end) memset(p->window, 0, sizeof(p->window)); + if (end) memset(p->window, 0, sizeof(*(p->window)) * p->dft_size); >>> This memset is short by one element. >> It is. Many thanks

Re: [SoX-devel] [PATCH RESEND 9/9] Added average power spectrum for stat -freq -a

2020-08-13 Thread Pander via SoX-devel
On 8/2/20 12:52, Måns Rullgård wrote: > Måns Rullgård writes: > >>> + if (stat->fft_average) { >>> + for (i = 0; i < samples / 2; i++) /* FIXME: should be <= samples >>> / 2 */ >>> + fprintf(stderr, " %f %f\n", ffa * i, re_average[i] / len); >>> + } >> I don't un