Re: [SoX-devel] sox spectrogram patches

2015-12-29 Thread Eric Wong
Måns Rullgård wrote: > I'd be willing to co-maintain it, should it come to that. Thank you, much appreciated! -- ___ SoX-devel mailing list SoX-devel@lists.sourceforge.net http

Re: [SoX-devel] sox spectrogram patches

2015-12-28 Thread Måns Rullgård
Eric Wong writes: >> Thanks again for stepping in to work on this. I was about to leave sox >> to die, given that its fathers have abandoned it. If we can get a last >> twitch of life out of them, it would be best they appoint you as its >> official maintainer. > > No problem. I hope they come b

Re: [SoX-devel] sox spectrogram patches

2015-12-26 Thread Eric Wong
Martin Guy wrote: > On 26/12/2015, Eric Wong wrote: > > --- a/src/spectrogram.c > > +++ b/src/spectrogram.c > > @@ -70,7 +70,11 @@ typedef struct { > >sox_bool using_stdout; /* output image to stdout */ > > > >/* Shared work area */ > > +#if HAVE_FFTW > > + fftw_plan fftw_plan;

Re: [SoX-devel] sox spectrogram patches

2015-12-26 Thread Martin Guy
On 26/12/2015, Eric Wong wrote: > --- a/src/spectrogram.c > +++ b/src/spectrogram.c > @@ -70,7 +70,11 @@ typedef struct { >sox_bool using_stdout; /* output image to stdout */ > >/* Shared work area */ > +#if HAVE_FFTW > + fftw_plan fftw_plan; /* Used if FFT_type == FFT_fft

Re: [SoX-devel] sox spectrogram patches

2015-12-26 Thread Eric Wong
Martin Guy wrote: > > "cmp" tells me that the PNG files are identical with/without FFTW Thanks. I'll note that if I get around to making a test suite. > Yes, I've done relatively little configure.ac hacking and was hoping > someone who knows better might improve things. Thanks for the heads-up

Re: [SoX-devel] sox spectrogram patches

2015-12-26 Thread Martin Guy
On 26/12/2015, Eric Wong wrote: > Martin Guy wrote: >> - remove arbitrary limit on spectrogram output height (was 1200) > > Seems alright, did you check for possible integer overflow issues > from raising the limit? Only by inspection and testing a range of heights/widths. >> - add FFTW3 suppor

Re: [SoX-devel] sox spectrogram patches

2015-12-26 Thread Eric Wong
Martin Guy wrote: > On 26/12/2015, Eric Wong wrote: > > I've started maintaining a branch of things in their absence. > > Thanks Eric. I have three commits, all regarding "sox spectrogram": > - remove arbitrary limit on spectrogram output height (was 1200) Seems alright, did you check for possi

[SoX-devel] sox spectrogram patches

2015-12-25 Thread Martin Guy
On 26/12/2015, Eric Wong wrote: > I've started maintaining a branch of things in their absence. Thanks Eric. I have three commits, all regarding "sox spectrogram": - remove arbitrary limit on spectrogram output height (was 1200) - add "spectrogram -n" flag to normalize the image brightness regard