Re: [Spacewalk-devel] httpd.conf?

2008-12-11 Thread Jan Pazdziora
On Wed, Dec 10, 2008 at 11:02:06PM -0500, Jesus M. Rodriguez wrote: > Mike, > > I thought we were getting rid of satellite-httpd in favor of > /etc/httpd/conf.d? > > http://git.fedorahosted.org/git/?p=spacewalk.git;a=commitdiff;h=056892dfcd5dcabc49bb7b487033227ed5268f13 Well, some people pointe

Re: [Spacewalk-devel] httpd.conf?

2008-12-11 Thread Mike McCune
Jan Pazdziora wrote: On Wed, Dec 10, 2008 at 11:02:06PM -0500, Jesus M. Rodriguez wrote: Mike, I thought we were getting rid of satellite-httpd in favor of /etc/httpd/conf.d? http://git.fedorahosted.org/git/?p=spacewalk.git;a=commitdiff;h=056892dfcd5dcabc49bb7b487033227ed5268f13 Well, some p

[Spacewalk-devel] kickstartTreeHandler

2008-12-11 Thread Jesus M. Rodriguez
Partha, EXCELLENT! I like this type of rename. Kudos! http://git.fedorahosted.org/git/?p=spacewalk.git;a=commitdiff;h=e6cb94844dac061193aff1d5d0c3e0cd287dd0db jesus ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mai

[Spacewalk-devel] instead of new Long().toString() try String.valueOf()

2008-12-11 Thread Jesus M. Rodriguez
Shannon, Instead of new Long(daysUntilExpiration).toString(), I think String.valueOf(daysUntilExpiration) looks better. I'm just being picky, because what you have works, though like I said I think it looks better with String.valueOf() http://git.fedorahosted.org/git/?p=spacewalk.git;a=commitdiff

[Spacewalk-devel] symlink of sqlplus

2008-12-11 Thread Jesus M. Rodriguez
Michael, Excellent, thanks for doing this. http://git.fedorahosted.org/git/?p=spacewalk.git;a=commitdiff;h=7c1c8cd0faa52a34db383e7477567bd20971806c jesus ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listin

Re: [Spacewalk-devel] kickstartTreeHandler

2008-12-11 Thread Partha Aji
Thanks zeus :) .. I had the right intentions but I wonder if I was being a bit naive here.. Hopefully qa automation tests that were written for this are easy enough to change ,... If thats too much to change feel free to revert Partha Jesus M. Rodriguez wrote: Partha, EXCELLENT! I like this

Re: [Spacewalk-devel] kickstartTreeHandler

2008-12-11 Thread Jesus M. Rodriguez
It's the right thing to do. /me hates having wordy method names when the namespaces should be enough. Good job. On Thu, Dec 11, 2008 at 10:33 PM, Partha Aji wrote: > Thanks zeus :) .. I had the right intentions but I wonder if I was being a > bit naive here.. Hopefully qa automation tests that we