It avoids the creation of the debug string, over time this can get
costly. We had a huge problem
with this at my last job and we improved performance quite a bit by
simply wrapping our
debug logs in an if statement. the JIT pretty much compiles out the
block at runtime.
We are NOT that good at rem
jmrodri wrote:
> Please wrap the log.debug() with if (log.isDebugEnabled()) {...
> log.debug(); }
>
> jesus
Out of curiosity what is the benefit of this ? Speedier execution ?
-Justin
>
>
>
>
>
> Sent to you by jmrodri via Google Reader:
>
>
>
>
>
> making log statment
Looking at your commit:
http://git.fedoraproject.org/git/?p=spacewalk.git;a=commitdiff;h=c587ddb52000ea2ec2635bccf6729cdf7f6dc0a2
You're missing the fact that even with CFG.ISS_PARENT set, we can still
talk to RHN with my commandline url options. Which means you'll be
raising an iss error even
I've got a number of issues with this commit.
Config.java
* what problem are we solving that we need the list of page sizes
in the config file?
* please remove the getPageSizes() and getDefaultPageSize() methods
from Config. Based on the javadoc comment they are used by
PageSiz
Please wrap the log.debug() with if (log.isDebugEnabled()) {...
log.debug(); }
jesus
Sent to you by jmrodri via Google Reader: making log statment debug as
it was intended to be via Fedora Hosted Git Repositories -
spacewalk.git/rss log by Justin Sherrill on
3/16/09 making log statment debug as
